corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
600,850 Commits 1 Branch 0 Tags
d79059cc816be54a94cfcc7010e55adbcc21fde4
Commit Graph

54 Commits

Author SHA1 Message Date
Kershaw Chang
d79059cc81 Bug 1555322 - Make sure WebSocketImpl is deleted on the right thread r=smaug 
I think the root cause of the crash is that WebSocketImpl is not deleted on the target thread. When this happens, there is a race between setting WebSocket::mImpl to nullptr and accessubg mImpl.
If WebSocketImpl is always deleted on the target thread, WebSocketImpl::Disconnect should be called in ~WebSocketImpl when mDisconnectingOrDisconnected is false.
So, this patch checks the ref counter in WebSocketImpl::Release and make sure to delete WebSocketImpl on the right thread.

Differential Revision: https://phabricator.services.mozilla.com/D34320
 2019-06-19 17:24:23 +00:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike 
Differential Revision: https://phabricator.services.mozilla.com/D34196
 2019-06-11 15:51:51 +00:00
Sylvestre Ledru
69746836db Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883
 2019-05-25 17:46:15 +00:00
arthur.iakab
699b884244 Backed out changeset a296439a25ff (bug 1519636) for frequent Windows cppunit failures CLOSED TREE 2019-05-24 14:26:01 +03:00
Sylvestre Ledru
10a773a4ca Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883
 2019-05-24 09:59:17 +00:00
Brian Hackett
4b7ce69bdf Bug 1546736 Part 4 - Only capture web socket stacks for net monitor when the docshell/worker is being watched by the devtools, r=bzbarsky. 2019-05-19 12:53:45 -10:00
Brian Hackett
05c9465554 Bug 1392411 Part 1 - Report stacks to net monitor when creating web sockets, r=bzbarsky. 2019-05-19 12:44:37 -10:00
Andrea Marchesini
d9998f98c8 Bug 1542170 - Expose http channel Id to WebSocketEvent listeners, r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D28865
 2019-05-03 17:25:44 +00:00
Andrea Marchesini
92e17e61eb Bug 1541339 - WebSocket channel should use the correct CookieSettings in workers, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D28949
 2019-04-26 22:51:42 +00:00
Cosmin Sabou
a9f5827e67 Backed out changeset daeba572395d (bug 1541339) for xpcshell failures on test_dns_proxy_bypass. 2019-04-26 21:26:21 +03:00
Andrea Marchesini
5e4079ec50 Bug 1541339 - WebSocket channel should use the correct CookieSettings in workers, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D28949
 2019-04-26 17:44:59 +00:00
Eden Chuang
805df63f08 Bug 1442778 - Add "chromeContext" parameter to console API and console service messages. r=smaug 
1. Adding a new attribute chromeContext in ConsoleEvent
2. Adding a new boolean attribute isFromChromeContext in nsIConsoleMessage
3. Sending IsFromChromeContext to the parent process

Differential Revision: https://phabricator.services.mozilla.com/D23330
 2019-04-01 22:42:34 +00:00
Andrea Marchesini
ed30c84049 Bug 1455020 - Extend CheckInnerWindowCorrectness() to check the state of the worker, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D25486
 2019-04-01 16:46:46 +00:00
Andrea Marchesini
d9d03b7c85 Bug 1539528 - WebSocket must bind itself to valid nsIGlobalObject in workers, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D25088
 2019-03-29 14:14:53 +00:00
Dorel Luca
3bd7556eea Backed out changeset b81febb43f21 (bug 1539528) for Mochitest failues in dom/websocket/tests/test_webSocket_sharedWorker.html. CLOSED TREE 2019-03-29 12:27:27 +02:00
Andrea Marchesini
59c0cb041f Bug 1539528 - WebSocket must bind itself to valid nsIGlobalObject in workers, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D25088
 2019-03-29 09:32:21 +00:00
Daniel Varga
caf7790a5e Backed out changeset 29c306545aa5 (bug 1539528) for mochitest failure at /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp:69. On a CLOSED TREE 2019-03-29 11:18:33 +02:00
Andrea Marchesini
bec384eff5 Bug 1539528 - WebSocket must bind itself to valid nsIGlobalObject in workers, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D25088
 2019-03-28 22:09:21 +00:00
Cosmin Sabou
de6f748a09 Backed out changeset 7fa7d6e6dedc (bug 1442778) for devtools failures on browser_webconsole_check_stubs_console_api.js CLOSED TREE 2019-03-26 20:27:55 +02:00
Eden Chuang
4427a101b6 Bug 1442778 - Add "chromeContext" parameter to console API and console service messages. r=smaug 
1. Adding a new attribute chromeContext in ConsoleEvent
2. Adding a new boolean attribute isFromChromeContext in nsIConsoleMessage
3. Sending IsFromChromeContext to the parent process

Differential Revision: https://phabricator.services.mozilla.com/D23330
 2019-03-26 15:18:20 +00:00
Michal Novotny
44608ec784 Bug 1525527 - Crash in OOM | large | NS_ABORT_OOM | mozilla::dom::WebSocket::CreateAndDispatchMessageEvent, r=michal 2019-02-19 08:22:00 +02:00
Jonathan Kingston
58708e007c Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin 
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885
 2019-02-12 16:08:25 +00:00
Emilio Cobos Álvarez
dc336a73ba Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug 
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
 2019-01-03 17:48:33 +01:00
Sylvestre Ledru
e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 
# ignore-this-changeset
 2018-11-30 11:46:48 +01:00
Henri Sivonen
5f8eae48db Bug 1489098 - Remove useless use of PromiseFlatString. r=peterv 
MozReview-Commit-ID: 10JE4PRp8i0

Differential Revision: https://phabricator.services.mozilla.com/D5237
 2018-09-11 17:17:05 +00:00
Boris Zbarsky
df3b83f98c Bug 1450167. Stop using atom-or-string for event names in the listener manager. r=smaug 
Now that we support atoms off the the main thread, we can just use atoms.
 2018-07-24 18:15:19 -04:00
Christoph Kerschbaumer
6584c7601a Bug 1304645: Pass individual CSP errors as categories to web console error messages. r=baku 2018-07-20 19:57:21 +02:00
Andreea Pavel
9e3c21fbdf Backed out 3 changesets (bug 1475073, bug 1304645, bug 1474537) for failing wpt and mochitest on a CLOSED TREE 
Backed out changeset 4fbeea69b10d (bug 1475073)
Backed out changeset d3ac68d9ead9 (bug 1304645)
Backed out changeset 113b601a3b59 (bug 1474537)
 2018-07-20 14:00:09 +03:00
Christoph Kerschbaumer
da3b449455 Bug 1304645: Pass individual CSP errors as categories to web console error messages. r=baku 2018-07-20 10:42:46 +02:00
Andrea Marchesini
656b292d56 Bug 1471189 - Removing 'Terminating' state in workers, r=mrbkap 2018-07-12 19:33:41 +02:00
Andi-Bogdan Postelnicu
63320a1ffe Bug 1453795 - DOM - Initialize member fields in classes/ structures. r=peterv 2018-06-16 17:21:46 +03:00
Michal Novotny
f7d56c7e95 Bug 756165 - Return close code 1015 to JS when TLS setup fails, r=baku, r=valentin 
We cannot simply pass the status code using nsIWebSocketListener::OnServerClose because it's called only when the connection is established. Instead, I'm passing TLS failure from http channel to nsIWebSocketListener::OnStop where the correct status code is set.
 2018-06-28 07:54:00 +03:00
Andreea Pavel
f1ddf7dbee Backed out changeset 5d8c20358cac (bug 756165) for [@ MOZ_CrashOOL] crashes on a CLOSED TREE 2018-06-28 03:00:49 +03:00
Michal Novotny
d411e9bebc Bug 756165 - Return close code 1015 to JS when TLS setup fails, r=baku, r=valentin 
We cannot simply pass the status code using nsIWebSocketListener::OnServerClose because it's called only when the connection is established. Instead, I'm passing TLS failure from http channel to nsIWebSocketListener::OnStop where the correct status code is set.
 2018-06-27 06:50:00 +03:00
Jeff Gilbert
70a22b2878 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot 
MozReview-Commit-ID: JtTcLL5OPF0
 2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez
0348c342b8 Bug 1470930: Use enums for passing arguments for event dispatch. r=smaug 
MozReview-Commit-ID: DsNuF7GAflJ
 2018-06-26 18:22:06 +02:00
Emilio Cobos Álvarez
4b8b5e1717 Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
 2018-06-01 10:45:27 +02:00
Boris Zbarsky
a793b360eb Bug 1455676 part 5. Remove nsIDOMNode usage from netwerk/. r=qdot 2018-05-29 22:58:48 -04:00
Andrea Marchesini
d20a7bf20d Bug 1450644 - WorkerRef should make APIs able to work until the worker is completely terminated - part 3 - WebSocket, r=asuth 2018-04-17 20:51:03 +02:00
Tiberius Oros
a1c2a7891a Backed out 7 changesets (bug 1450644, bug 1454633) for for failing browser_storage_permission.js on a CLOSED TREE 
Backed out changeset f4989e0da221 (bug 1454633)
Backed out changeset 08239799d43e (bug 1450644)
Backed out changeset cbe3ad4833b6 (bug 1450644)
Backed out changeset 0d2088370d0c (bug 1450644)
Backed out changeset 246fb3ee14cd (bug 1450644)
Backed out changeset 629e499c0f75 (bug 1450644)
Backed out changeset ed93e3547096 (bug 1450644)
 2018-04-18 01:10:26 +03:00
Andrea Marchesini
f2d4c79ef0 Bug 1450644 - WorkerRef should make APIs able to work until the worker is completely terminated - part 3 - WebSocket, r=asuth 2018-04-17 20:51:03 +02:00
Ben Kelly
a26853807c Bug 1451913 P2 Update websocket state on the inner window when rebinding. r=smaug 2018-04-16 06:08:52 -07:00
Sebastian Hengst
d91e9954eb Backed out 4 changesets (bug 525063) on request from Andi. a=backout 
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
 2018-04-13 16:01:28 +03:00
Tristan Bourvon
6095241db8 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Boris Zbarsky
d54406240d Bug 1449631 part 6. Remove nsIDOMEventTarget::DispatchEvent. r=smaug 
MozReview-Commit-ID: 8YMgmMwZkAL
 2018-04-05 13:42:41 -04:00
Christoph Kerschbaumer
56529d1f61 Bug 1439713 - Change nsIContentPolicy shouldLoad to take an <uri, loadInfo> pair instead of the various args. r=bz 2018-03-29 12:16:23 +02:00
Andrea Marchesini
250636f2ad Bug 1446366 - Correct readyState in WebSocket when worker goes away, r=smaug 2018-03-18 23:13:01 +01:00
Andrea Marchesini
b52a964d52 Bug 1436784 - Use WorkerRef in WebSocket, r=smaug 2018-03-13 21:16:59 +01:00
Andrea Marchesini
cdb15164d7 Bug 1443079 - nsScriptError.isFromPrivateWindow must match the correct value also in e10s mode, r=smaug 2018-03-13 06:40:38 +01:00
Andrea Marchesini
ddb4518ad1 Bug 1435174 - Remove the renaming 'using namespace workers', r=bkelly 2018-02-05 19:55:07 +01:00