corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
896,034 Commits 1 Branch 0 Tags
d7633e63e50582cc4ff450fdd5dba6a5a40fbc85
Commit Graph

54 Commits

Author SHA1 Message Date
Tom Schuster
de7961b047 Bug 1936573 - Remove inline event handlers from permission-popup. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D231961
 2024-12-13 09:39:12 +00:00
Jan-Ivar Bruaroey
1ae52f7a91 Bug 1609427 - Hide persisted "Always Ask ✖" permissions in the UX over risk of confusion over what happens when they're cleared'. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D183439
 2024-08-06 13:53:21 +00:00
Jan-Ivar Bruaroey
66caa367ed Bug 1609427 - Persist SitePermissions.PROMPT for cam/mic when ☐ Remember this decision is unchecked. r=pbz,mt 
Differential Revision: https://phabricator.services.mozilla.com/D183066
 2024-08-06 13:53:20 +00:00
Hanna Jones
21849b1def Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D207445
 2024-04-24 19:16:46 +00:00
Stanca Serban
29d6ee2faf Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE 2024-04-24 03:14:45 +03:00
Hanna Jones
9413513b0d Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D207445
 2024-04-23 19:28:47 +00:00
Aron Cseh
08943f7f60 Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
cf0399a238 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D207445
 2024-04-23 13:52:27 +00:00
Dave Townsend
ab57b0fdc1 Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao 
Differential Revision: https://phabricator.services.mozilla.com/D202949
 2024-03-19 14:59:20 +00:00
Benjamin VanderSloot
e35d811bd3 Bug 1836792, part 3 - Adopt permissions UI to just show the same old prompt for 3rdPartyFrameAccess requests, r=anti-tracking-reviewers,timhuang,pbz 
Differential Revision: https://phabricator.services.mozilla.com/D180217
 2023-06-23 12:14:18 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-12 17:16:35 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-05-18 17:19:45 +00:00
Abhishek Madan
aa971cac82 Bug 1831363 - Converted SitePermissions.jsm to ES modules and all of its corresponding references. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D177380
 2023-05-17 14:45:26 +00:00
Emilio Cobos Álvarez
5d7aa08c51 Bug 1826072 - Don't flex permission state label. r=pbz 
Err, so the original patch is necessary but not sufficient, and I
clearly goofed my testing (I had removed this attribute in a separate
commit).

The issue is that this button ends up with a markup like:

  <button class="permission-popup-permission-remove-button">
    <label flex="1" class="permission-popup-permission-state-label">Allowed Temporarily</label>
    <hbox class="box-inherit button-box" align="center" pack="center" flex="1" anonid="button-box">
      <image class="button-icon"/>
      <label class="button-text"/>
    </hbox>
  </button>

So the label and hbox divide the available space in half. Removing any
of the flex="1" attributes would cause the desired rendering.

I don't think the hbox needs to be flexible tbh, but ok, that's a
riskier change. I'm pretty sure the label in this case doesn't need to
be flexible at all though, specially since we don't want these buttons
to take any minimum amount of space.

An alternative would be to use `flex: 1 auto` or so for the label (via
CSS). That'd match the pre-regression behavior more exactly, but again I
don't think flexing the label is needed at all.

Depends on D174706

Differential Revision: https://phabricator.services.mozilla.com/D174707
 2023-04-05 12:04:03 +00:00
ganna
3e0eae322f Bug 1814270 - Use moz-support-link for permission-popup-storage-access-permission-learn-more label. r=tgiles 
Differential Revision: https://phabricator.services.mozilla.com/D173748
 2023-03-30 17:59:46 +00:00
Mark Banner
34d6fb8d94 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D165068
 2022-12-27 10:08:58 +00:00
Karl Tomlinson
563e32cccf Bug 1712892 use _createWebRTCPermissionItem() for speaker selection permissions r=pbz 
so as to add support for double-keyed per device permissions, which can then
all be cleared from a single item/button.

Differential Revision: https://phabricator.services.mozilla.com/D162233
 2022-12-13 09:37:34 +00:00
Emilio Cobos Álvarez
8eb4bd796d Bug 1795944 - Remove descriptionheightworkaround. r=Gijs 
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
 2022-10-19 11:55:29 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak 
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
 2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak 
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
 2022-09-02 11:18:54 +00:00
Mike Conley
d900f6df78 Bug 1783918 - Part 3: Make it possible for the permission panel anchor and position to be overridden. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D154129
 2022-08-10 15:05:32 +00:00
Mike Conley
7045ff2c74 Bug 1783918 - Part 2: Make gPermissionPanel._openPopup public. r=pbz 
This also moves the fullscreen fix for bug 1557041 to the top of openPopup so that
direct callers of openPopup don't bypass the fix.

Differential Revision: https://phabricator.services.mozilla.com/D154128
 2022-08-10 15:05:32 +00:00
Dão Gottwald
430a5f2bcb Bug 1706534 - Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D114475
 2021-10-13 16:37:56 +00:00
Cristian Tuns
11ed5baad6 Backed out changeset 3132e2d5dc45 (bug 1706534) for causing mochitest failures on browser_creditCard_doorhanger.js. CLOSED TREE 2021-10-13 10:48:47 -04:00
Dão Gottwald
e2f8616427 Bug 1706534 - Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D114475
 2021-10-13 12:39:06 +00:00
Bernard Igiri
078cec04ff Bug 1706192 - Get rid of popup-subitem r=mconley 
Removed occurences of popup-subitem.

Differential Revision: https://phabricator.services.mozilla.com/D117330
 2021-06-17 15:30:28 +00:00
Csoregi Natalia
8cae44475f Backed out changeset 9c2ba085b136 (bug 1703609) for failures on browser_devices_get_user_media_queue_request.js. CLOSED TREE 2021-06-15 02:55:35 +03:00
Molly Howell
bd5ee6f3fc Bug 1703609 - Hide doorhangers while site permissions panel is showing. r=emalysz 
Differential Revision: https://phabricator.services.mozilla.com/D117700
 2021-06-14 20:49:38 +00:00
Ramya Praneetha
2f39899876 Bug 1676067 - Renamed "Show blocked pop-up" to "Open blocked pop-up" in site info menu. r=prathiksha,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D112016
 2021-04-15 16:23:11 +00:00
Tim Huang
c33f6b2a43 Bug 1676074 - Part 1: Add a learn more link into the "Cross-site cookies" permission header description. r=johannh,fluent-reviewers,desktop-theme-reviewers,harry 
Differential Revision: https://phabricator.services.mozilla.com/D112044
 2021-04-15 09:27:26 +00:00
Dão Gottwald
ba52a5524d Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D110817
 2021-04-14 13:57:34 +00:00
Jan-Ivar Bruaroey
d663085059 Bug 1697487 - Show gray cam/mic indicator during permission grace periods. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D111000
 2021-04-14 11:20:15 +00:00
Emma Malysz
dd71b38d47 Bug 1703476, update site permission panel formatting r=mconley,pbz 
Changes includde padding/margin changes and button structure

Differential Revision: https://phabricator.services.mozilla.com/D111479
 2021-04-12 16:28:01 +00:00
smolnar
9772ac8235 Backed out changeset 034a69e0a73e (bug 1701306) for causing browser-chrome failures in browser_page_action_menu. CLOSED TREE 2021-04-08 17:16:21 +03:00
Dão Gottwald
7c29048b6e Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D110817
 2021-04-08 12:53:08 +00:00
Alexandru Michis
77c2ff629e Backed out changeset 8d8aa8575c1d (bug 1701306) for causing multiple bc failures. 
CLOSED TREE
 2021-04-06 19:45:27 +03:00
Dão Gottwald
4a29705c86 Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D110817
 2021-04-06 13:22:50 +00:00
Paul Zuehlcke
09e816bda6 Bug 1695615 - Updated permission panel for double-keyed WebRTC permissions. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D107071
 2021-03-12 10:06:16 +00:00
Paul Zuehlcke
927176d829 Bug 1695615 - Removed obsolete per-frame permission tracking for geolocation and WebRTC permissions. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D107070
 2021-03-12 10:06:16 +00:00
Paul Zuehlcke
c8a3bd27b8 Bug 1695356 - Show permission indicator for any non-default site-permissions. r=johannh 
Before decoupling the permission panel in Bug 1596897, the permission indicator was
not shown if we had a blocked permission icon to show instead. With the decoupled
permissions panel it needs to be shown whenever we have permissions listed in the
panel. The granted permissions icon is now the anchor for the panel.

Differential Revision: https://phabricator.services.mozilla.com/D106771
 2021-03-04 12:18:06 +00:00
Marco Bonardo
6bf8ff6f3c Bug 1693338 - Remove obsolete WebRTC icon blink synchronization code. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D106277
 2021-02-24 23:11:44 +00:00
james
c8a67215e0 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D104552
 2021-02-13 23:33:51 +00:00
Narcis Beleuzu
d5390af0ba Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
1c970f6297 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D104552
 2021-02-13 18:11:18 +00:00
Paul Zuehlcke
a1d23766c7 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh 
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
 2021-02-05 13:40:35 +00:00