Commit Graph

9 Commits

Author SHA1 Message Date
DimiL
5bfeea65b2 Bug 1329366 - Avoid the reuse of the same chunk numbers in classifierHelper.js. r=francois
This patch includes following fix in classifierHelper.js:
1. Avoid the reuse of same chunk numbers
2. Remove unused removeUrlFromDB function

MozReview-Commit-ID: XK1oHBa8gf
2017-06-12 17:04:59 +08:00
DimiL
da8ff508ef Bug 1365877 - resetDatabase in SafeBrowsing test case should also reset cache. r=francois
resetDatabase() is used to clear out the Safe Browsing database and cache in tests.
Since bug 1333328 however we can no longer rely on updates clearing the cache.

There are two solutions to address this issue:
1. resetDatabase() calls another test-only function: reloadDatabase(). Since the cache
   is in memory, reloading the URL classifier will automatically clear the cache.
2. During an update, remove cache entries which are not in the database.

I prefer taking the first one because if we implement the second
approach, an update will take longer since we need to check if each prefix
in the cache can also be found in the database. I think this is not necessary
because prefixes not in the database will eventually be removed when they
are expired.

MozReview-Commit-ID: BjsDKDMr205
2017-05-18 17:21:00 +08:00
dimi
ac0dea5510 Bug 1254766 - Stop caching Safe Browsing completions to disk. r=gcp
MozReview-Commit-ID: 8Qnc8yymgDL
2016-08-11 08:17:39 +08:00
dimi
8f13e1c1d1 Bug 1272239 - Part 3: Testcase, test gethash. r=francois
MozReview-Commit-ID: 3IkrdJgZNP1
2016-07-21 15:40:03 +08:00
Carsten "Tomcat" Book
1d2e8550ed Backed out changeset 5042da9fc11c (bug 1272239) 2016-06-15 22:16:52 +01:00
dlee
66155fbd55 Bug 1272239 - P3. Testcase, test gethash. r=francois 2016-06-14 14:48:28 +01:00
Dimi Lee
d2b3a51b5d Bug 1274105 - Refactor classifierHelper.js. r=gcp
MozReview-Commit-ID: ljq4KPzUqu
2016-05-25 20:20:42 +08:00
dimi
ff7cea2e35 Bug 1264169 - P2. Refine classifierHelper chunk format. r=francois
MozReview-Commit-ID: WBexu4sO8R
2016-04-25 10:13:15 +08:00
dimi
05c258a574 Bug 1264169 - P1. test_classifier.html doesn't remove url added to malware database when finish. r=francois
MozReview-Commit-ID: 5iuMuVk5f8d
2016-04-22 17:25:40 +08:00