This is needed before we can upgrade to flake8 3.3.0, as that version starts flagging these errors.
These files were modified by running:
autopep8 --select E305 --in-place -r <dir>
on the affected directories. I did it one dir at a time and verified the result after each.
MozReview-Commit-ID: FmlsfiKIbtr
Unfortunately it means using FLAG histograms because I need to test that their
"we have a hidden default value" behaviour is appropriately silenced as well.
MozReview-Commit-ID: J8xGXwCTRIg
The probes needing to record in gpu were determined by listing the probes that
submitted data for those measures on Nightly on April 18.
MozReview-Commit-ID: 85nQA8rCH1p
The probes needing to record in gpu were determined by listing the probes that
submitted data for those measures on Nightly on April 18.
MozReview-Commit-ID: 85nQA8rCH1p
This patch enables flake8 rule E128:
"continuation line under-indented for visual indent" in toolkit/components/telemetry
by removing the relative E128 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E128 error was reported.
Precisely 10 errors violating E128 rule were found and solved.
MozReview-Commit-ID: 4sNXIxGFJQN
This patch enables flake8 rule E713:
"test for membership should be 'not in'" in toolkit/components/telemetry
by removing the relative E713 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E713 error was reported.
Precisely 6 errors violating E713 rule were found and solved.
MozReview-Commit-ID: 2AaYGgVkxbU
This patch enables flake8 rule E111: "indentation is not a multiple of four"
in toolkit/components/telemetry by removing the relative E111 entry from
toolkit/components/telemetry/.flake8 and fixing the files for which the E111
error was reported.
MozReview-Commit-ID: EOVcsllJNJK
alert_emails tell us who is interested in a particular histogram. If there's
no one interested, then the histogram shouldn't exist.
MozReview-Commit-ID: 90Yqof3dbsd
bug_numbers is now mandatory, because we really want to have some explanation
about where the probe came from.
We have a lot of non-bug-numbered probes (including non-Histograms.json-
resident probes like the use counters) that are being "grandfathered in" via
a whitelist in whitelists.json.
MozReview-Commit-ID: 62dN96sEOUf
- Convert string values to integer and boolean values for Histograms
- Add compile time type checks on Histograms.json
- Remove string to int/bool coercion for the Histogram keys:
- n_buckets
- n_values
- low
- high
- keyed
- Remove check_numeric (redundant with check_expression_types)
