Commit Graph

65 Commits

Author SHA1 Message Date
Marco Castelluccio
743dd2e0c8 Bug 1357517 - Remove Preferences.jsm usage from some Telemetry files. r=Dexter 2017-07-31 01:32:31 +02:00
Kate Ustiuzhanina
3af03ea956 Bug 1318297 - Support initial implementation for Health ping. r=gfritzsche
Health ping is supposed to be a small ping for monitoring failures.
Current implementation tracks discarded for size and
send failures.
2017-07-25 16:19:31 +01:00
Carsten "Tomcat" Book
5089ce5b5c Backed out changeset 2ceb8a5a3e40 (bug 1318297) for xpcshell failures in test_TelemetryHealthPing.js 2017-07-24 16:16:40 +02:00
Kate Ustiuzhanina
17ad6746e6 Bug 1318297 - Support initial implementation for Health ping. r=gfritzsche
Health ping is supposed to be a small ping for monitoring failures.
Current implementation tracks discarded for size and
send failures.
2017-07-13 13:39:09 +01:00
Alejandro Rodriguez Salamanca
1d9a0b4bf3 Bug 1381843 - Use the prefs defined in TelemetryUtils.jsm in TelemetrySend.jsm. r=dexter 2017-07-19 02:12:00 +02:00
Vanessa Gutierrez
43f421e92a Bug 1376629 - Discard changes to npm-shrinkwrap.json and package.json. r=gfritzsche 2017-06-28 15:12:00 -04:00
Kate Ustiuzhanina
d9a5f7bf27 Bug 1367094 - Measure the size of successful and failed pings. r=gfritzsche
MozReview-Commit-ID: KSt07czm7Kt
2017-06-06 16:52:41 +01:00
Chris H-C
ed074fb3ef bug 1367110 - Collect Telemetry for different TelemetrySend failures r=bsmedberg,Dexter data-r=bsmedberg
Expires in 61 for now until we can show its usefulness.

MozReview-Commit-ID: IpfEnmnuKgr
2017-05-24 10:14:41 -04:00
Sebastian Hengst
1d7c0f09b9 Backed out changeset 244e7cfea731 (bug 1367110) 2017-05-31 21:02:07 +02:00
Chris H-C
1ba026146e bug 1367110 - Collect Telemetry for different TelemetrySend failures r=bsmedberg,Dexter data-r=bsmedberg
Expires in 61 for now until we can show its usefulness.

MozReview-Commit-ID: IpfEnmnuKgr
2017-05-24 10:14:41 -04:00
Gabriele Svelto
967217803e Bug 1364673 - Hide the mouse throbber when running the pingsender on Windows; r=Dexter
This patch uses the functionality introduced in bug 1366711 to launch the
pingsender without showing its console window nor a mouse throbber. This also
reverts the pingsender into a console application.

MozReview-Commit-ID: BTcqAkR9UKB
2017-05-29 15:28:36 +02:00
Chris H-C
4e05065abf Bug 1319026 - Remove logging for failed Telemetry send requests. r=gfritzsche
We have the data we need.

MozReview-Commit-ID: 8L24RSiu7Xd
2017-05-19 09:05:00 -04:00
Alessio Placitelli
4de8c1c162 Bug 1363345 - Don't use the pingsender when the OS is shutting down. r=bsmedberg,gfritzsche,data-review=bsmedberg
MozReview-Commit-ID: 9d8paU8M1T7
2017-05-12 12:23:07 +02:00
Sebastian Hengst
c36f0caacd Backed out changeset 30179c555174 (bug 1363345) for eslint failing at test_TelemetrySession.js:1421. r=backout 2017-05-22 20:07:13 +02:00
Alessio Placitelli
fd57e647e7 Bug 1363345 - Don't use the pingsender when the OS is shutting down. r=bsmedberg,gfritzsche,data-review=bsmedberg
MozReview-Commit-ID: 9d8paU8M1T7
2017-05-12 12:23:07 +02:00
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Alessio Placitelli
6bc6b11ec3 Bug 1120370 - Implement the new-profile ping. r=bsmedberg,chutten, data-r=bsmedberg
It schedules the ping to be sent on new profiles after 30 minutes
from the Firefox startup. The ping is eventually sent at shutdown
if the scheduled time wasn't reached.
To reliably prevent sending the ping more than once, the "session-state.json"
file is used to keep track of the "sent" state.

The "new-profile" ping is protected behind a pref, disabled by default
in this patch.

MozReview-Commit-ID: 4g4lPRXe9q6
2017-04-27 09:36:01 +02:00
Chris H-C
4b2149dbff bug 1319026 - Log failed Telemetry send requests. r=gfritzsche
Roughly one in three telemetry sends fail according to telemetry.mozilla.org.
Unfortunately, we have little idea about why.

This patch logs the failure paths in an effort to identify the worst offenders.

This is a temporary measure not meant to survive for long.
The data it gathers will be used to write appropriate longer-term error probes.

MozReview-Commit-ID: 9IMrLNH2AD
2017-04-06 15:10:15 -04:00
Gabriele Svelto
b9cab3fec0 Bug 1356673 - Run the pingsender executable in a way that avoids shutdown races with mozalloc; r=Dexter
When sending the shutdown ping we launched the pingsender executable via
PR_CreateProcessDetached() which on both Linux and MacOS X would fork()
gecko's main process and then exec() the pingsender executable. On MacOS X
this seemed to trigger a race with the mozalloc shutdown procedure within the
forked process. This patch changes the telemetry logic to use nsIProcess
instead which relies on posix_spawnp() to launch the new executable making it
immune to issues related to mozalloc's shutdown.

Since we don't need C++ code anymore to run the pingsender the runPingSender()
method is also moved to TelemtrySend.

MozReview-Commit-ID: C7fZw1ZpVBO
2017-04-25 01:07:36 +02:00
Alessio Placitelli
89df58ce52 Bug 1356673 - Fix a crash in RunPingSender at shutdown. r=gfritzsche
This patch makes sure to wait on the pingsender process to spawn
before shutting down Firefox.

MozReview-Commit-ID: CYYcGAy5H2s
2017-04-19 17:00:21 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Alessio Placitelli
70c97fb2f2 Bug 1354482 - Turn on sending the "shutdown" ping using the pingsender from the second Firefox session. r=chutten,gfritzsche
MozReview-Commit-ID: IEYfziF86mF
2017-04-10 12:51:45 +02:00
Alessio Placitelli
d0dc520ab5 Bug 1336360 - Use the PingSender for sending pings when the browser shuts down. r=chutten,gsvelto
MozReview-Commit-ID: 6bNQs87UQ9m
2017-02-23 14:58:02 +01:00
Gabriele Svelto
4ff26d2d74 Bug 1341349 - Enable sending the crash ping from the crashreporter client only when the overall configuration would allow pings to be sent r=Dexter,gfritzsche
The crashreporter client will send a crash ping autonomously only when it
finds a valid TelemetryServerUrl annotation. This patch makes this annotation
conditional on all the preferences that regulate sending pings (including
official telemetry flags) and prevents it from sending pings before the user
has been notified of the privacy policy.

This is achieved by adding a new _annotateCrashReport() method to the
TelemetrySend obejct which can be called before we've initialized the rest of
the components. It is invoked manually early in the startup process so that
startup crashes are properly annotated, then it's invoked again when the user
is informed of the privacy policy as well as when one of the relevant
preferences is altered. This ensures that the annotations are stripped if the
user disables uploading pings without having to restart Firefox.

MozReview-Commit-ID: 2DKnoWGT1Bp
2017-03-08 15:00:26 +01:00
Deepa
8e003ca34a Bug 1344741 - Update TelemetrySend.jsm to async function & await. r=gfritzsche 2017-03-17 22:26:25 +05:30
Alessio Placitelli
bdc93b7e31 Bug 1329978 - Add pref to override TelemetrySend official check in sendingEnabled. r=gfritzsche 2017-01-26 05:43:00 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Robert Helmer
49646a2b03 Bug 1325501 - move Telemetry from XHR to ServiceRequest r=gfritzsche
MozReview-Commit-ID: 6ZyLQknPVFx
2016-12-22 20:38:58 -08:00
Wes Kocher
c0b7d27da7 Backed out 3 changesets (bug 1325501) for xpcshell failures a=backout
Backed out changeset b6e50911ef79 (bug 1325501)
Backed out changeset c0493757d21e (bug 1325501)
Backed out changeset 880decff07b3 (bug 1325501)
2016-12-24 00:38:09 -08:00
Robert Helmer
38f72ef7b7 Bug 1325501 - move Telemetry from XHR to ServiceRequest r=gfritzsche
MozReview-Commit-ID: 6ZyLQknPVFx
2016-12-22 20:38:58 -08:00
Alessio Placitelli
ca9f461380 Bug 1323628 - Fix test_TelemetrySend.js failing and enable it again. r=chutten
MozReview-Commit-ID: AGRh5GCuHEK
2016-12-15 07:49:00 +01:00
Georg Fritzsche
6ecf96c260 Bug 1318284 - Improve probes measuring Telemetry send times. r=dexter 2016-11-21 17:48:42 +01:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Thomas Nguyen
95466008ee Bug 1296802 - remove LOAD_CLASSIFY_URI flag to prevent telemetry pings from running through the URL Classifier. r=francois
MozReview-Commit-ID: 3xHBa7NnhgQ
2016-10-27 18:16:26 +08:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
ebf1ccbe46 Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh
2016-08-03 18:54:59 -04:00
Alessio Placitelli
381601829e Bug 1156361 - Telemetry redesign: Consolidate date & string utility functions in TelemetryUtils.jsm. r=gfritzsche 2016-05-06 09:36:00 +02:00
Georg Fritzsche
b8fc1356a7 Bug 1144778 - Send an HTTP Date request header with telemetry pings. r=dexter 2016-04-29 15:16:22 +02:00
Dave Townsend
66459b47af Bug 1229519: Fix toolkit/components/telemetry to pass eslint checks. r=gfritzsche 2015-12-03 10:02:02 -08:00
Alessio Placitelli
75b5952485 Bug 1221958 - Make TelemetryController.enableTelemetryRecording pref checks more robust. r=gfritzsche 2015-11-17 07:42:00 +01:00
Alessio Placitelli
51748d69e3 Bug 1174674 - Clear out all pending pings when FHR is deactived. r=gfritzsche 2015-10-02 05:50:00 +02:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Alessio Placitelli
ff56ff5bca Bug 1191336 - Part 1 - Don't show the datachoices infobar when sending deletion pings. r=gfritzsche 2015-08-06 09:00:00 +02:00
Alessio Placitelli
2ac22d8e0e Bug 1186955 - Telemetry should discard pings that are too big. r=gfritzsche 2015-07-29 11:08:00 +02:00
Alessio Placitelli
cd37e2af35 Bug 1186492 - Add a probe to track client-side ping eviction due to server errors. r=gfritzsche 2015-07-30 06:48:00 +02:00