Before this patch, test_logins_decrypt_failure.js would essentially call
PK11_ResetToken and then PK11_ChangePW (via nsIPK11Token.reset and
nsIPK11Token.changePassword, respectively). This was never correct (after
PK11_ResetToken, the token has no password, so it can't be changed), and after
bug 1379273 this actually fails. The correct thing to do is PK11_ResetToken and
then PK11_InitPin (nsIPK11Token.initPassword).
In bug 1266836 we fixed this code to properly work in e10s,
but made the mistake of using gBrowser in toolkit code, breaking
XUL apps that don't have a gBrowser. This solution implements
a different code-path for non-e10s and returns a chrome
window for consumers that don't offer a browser.
MozReview-Commit-ID: 929ahDenzu5
Bug 1376893's approach is wrong in various ways:
- It shows the reload button as enabled for about:blank
- The disabled state styling is implemented in browser/themes/shared/toolbarbuttons.inc.css, and could be implemented differently. browser/base/content/browser.css should not depend on theme specifics.
- :not(:-moz-window-inactive) only begins to make sense on Mac, and obviously prevents the fix from taking effect in inactive windows
MozReview-Commit-ID: Dfh6VbirwPe
Bug 1376893's approach is wrong in various ways:
- It shows the reload button as enabled for about:blank
- The disabled state styling is implemented in browser/themes/shared/toolbarbuttons.inc.css, and could be implemented differently. browser/base/content/browser.css should not depend on theme specifics.
- :not(:-moz-window-inactive) only begins to make sense on Mac, and obviously prevents the fix from taking effect in inactive windows
MozReview-Commit-ID: CaBLYFKwPgh
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.
MozReview-Commit-ID: 1buqgX1EP4P
The login manager searching logins for autofill may trap the user
in an infinite loop of master password prompts until the user enters
the correct master password. To prevent that, we're adding a timeout
to showing the master password prompt for autofill after it was last
cancelled.
MozReview-Commit-ID: JcmTDU6CKKA
Added a call to
'treeBoxObject.ensureRowIsVisible(signonsTree.view.selection.currentIndex)' in
'signonReloadDisplay()' to make sure the selection is visible regardless of the
operation which caused a call to signonReloadDisplay().
MozReview-Commit-ID: EztJ4sZcofi
InsecurePasswordUtils.jsm used to rely on a devtools util to get the innerWindowId
of window objects. As devtools are moving out of mozilla-central, this code needs
to be extracted and the dependency should be removed.
MozReview-Commit-ID: 8rI3Lxu16h5
We can lower the eslint cyclomatic complexity threshold in some directories without adding eslint suppression comments in any .js source files. We need to specify the complexity rule in accessible/.eslintrc because it doesn't inherit the mozilla/recommended rules. eslint's default complexity threshold is 20.
Also bump the eslint-plugin-mozilla version because we modified the mozilla/recommended rules.
MozReview-Commit-ID: 57T4gAjPH7z
