Commit Graph

620 Commits

Author SHA1 Message Date
Josh Matthews
ace11d2112 servo: Merge #13562 - Move mako out of wptrunner required packages (from servo:jdm-patch-5); r=jgraham
There was a review comment about this in https://github.com/servo/servo/pull/13382#issuecomment-249453104 that was never addressed.

Source-Repo: https://github.com/servo/servo
Source-Revision: c10de40e4ea4430037ac9156cc2b5d31f92a7cd4
2016-10-03 15:09:23 -05:00
Gregory
69d4a79f76 servo: Merge #13447 - Have tidy ensure that the there are no extra files in the webidls folder #13427 (from gterzian:check_webidls_folder_files); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->
 Have tidy ensure that the there are no extra files in the webidls folder #13427

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13427 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 3a5fd8b49a45b4647e9823d3e10243d9f4b2277b
2016-10-02 12:00:36 -05:00
Matt Schmoyer
d08183becc servo: Merge #13538 - Avoid unecessary loop evaluation on empty lines for tidy check_license (from mschmo:master); r=Wafflespeanut
Refactored file line loop in `check_license()` to skip when a blank line is encountered. Only difference should be a very very small performance boost.

Also changed the name of a test from the mispelling `test_licence()` to `test_license()`

---
- [ ] `./mach build -d` does not report any errors (I'm not able to download the rust compiler on my laptop due to me probably just needing to update openssl: `Error downloading Rust compiler: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590). The failing URL was: https://static-rust-lang-org.s3.amazonaws.com/dist/2016-09-21/rustc-nightly-x86_64-apple-darwin.tar.gz`)
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are no added tests for this since `test_license()`, `test_shebang_license()` and  `test_apache2_incomplete()` should suffice in this case. Though I'd be more than happy to add a test if requested.

Source-Repo: https://github.com/servo/servo
Source-Revision: a83ef43be0773a52a5e40d05127fbc8814d6caa5
2016-10-01 16:17:00 -05:00
Guillaume Gomez
6707af18b4 servo: Merge #13537 - Ensure cargo is up to date before running update crate command (from GuillaumeGomez:mach_update); r=Wafflespeanut
Fixes #13526

Source-Repo: https://github.com/servo/servo
Source-Revision: 45cc847a005e1722b888ba2ea20f4ab80b70af9f
2016-10-01 14:13:05 -05:00
Kevin Liu
c913f2ecb5 servo: Merge #13513 - Return the error codes instead of implicitly returning None (from nivekuil:master); r=Wafflespeanut
See https://github.com/servo/servo/issues/13344

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13344 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring without logic changes, 0 is falsey as None

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 0e950c0ba5ba96ab629a21e8bdeba0795e320316
2016-09-30 23:02:37 -05:00
Patrick Trottier
ee87215754 servo: Merge #12850 - New folder linux (from Coder206:newFolderLinux); r=aneeshusa
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11983 (github issue number if applicable).

- [x] There are tests for these changes (./mach package)

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 7fbd35efab8d7c999846d4953515d02e6e9f0872
2016-09-30 18:29:56 -05:00
Vladimir Vukicevic
e03996fdcc servo: Merge #13488 - Use default console subsystem on Windows for dev builds (from vvuk:master); r=larsbergstrom
<!-- Please describe your changes on the following line: -->
If we keep the windows subsystem, we don't get any kind of log output.  We should keep the normal console subsystem for dev builds.

Source-Repo: https://github.com/servo/servo
Source-Revision: 31415588a384427392324ba03b6c65206ff09620
2016-09-30 16:33:53 -05:00
UK992
aab04c4142 servo: Merge #13486 - Fix msvc packages download dir for custom .servo location (from UK992:mach-bootstrap-2); r=larsbergstrom
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Source-Repo: https://github.com/servo/servo
Source-Revision: 9acd7f390a1abe8bd91c0dbeb2c3d7862d4cc2d8
2016-09-30 15:39:40 -05:00
Simon Sapin
b2ca8e3f02 servo: Merge #13502 - Fix OS-Mesa discovery in debug mode (from servo:osmesa-debug); r=Ms2ger
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: ce6d7a735f8b59a219bb20c9ffe930c52d527dbd
2016-09-29 10:01:01 -05:00
Manish Goregaokar
25eb14391a servo: Merge #13415 - Run style unit tests in testing mode, disable some properties in testing mode (from Manishearth:style-testing-disable); r=SimonSapin
Another crack at making it possible to test geckolib properties.

In the previous PR I added support for a testing mode but neglected to use it in the style unit tests.

Using it brought out some bugs with properties that exist in both gecko and servo but have different names. Added the ability to disable them.

Hopefully this isn't too unweildy.

r? @emilio

Source-Repo: https://github.com/servo/servo
Source-Revision: 13c4393516df0d3415ed28d107f3744d56b59623
2016-09-28 16:39:49 -05:00
Glenn Watson
4e705fd391 servo: Merge #13474 - Switch default renderer to webrender, and update webrender (from glennw:wr-default); r=Ms2ger
Source-Repo: https://github.com/servo/servo
Source-Revision: a082501173918d6a5808881f84556cb78391b9b2
2016-09-28 13:42:14 -05:00
Glenn Watson
195cf49478 servo: Merge #13382 - Add OSMesa headless mode, run WPT against Webrender (from glennw:headless); r=larsbergstrom
Add OSMesa headless mode, run WPT against Webrender.

Source-Repo: https://github.com/servo/servo
Source-Revision: c7e1a575a5225ccfb00a38fb50e052d986c0a78d
2016-09-27 21:46:13 -05:00
CHANG FU CHIAO
302d44ea5a servo: Merge #13091 - Create ./mach test-perf command (from zack1030:issue-12792); r=shinglyu
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [X] These changes fix #12792 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is low-risk

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

in **testing_commands.py**, I linked the new command to **test_perf.sh**
in **test_perf.sh**, it prepares tp5n.zip and virtual environment
then runs **test_all.sh**

Source-Repo: https://github.com/servo/servo
Source-Revision: 99435663f8e986d1851e4aec683dbbad7d53c0a7
2016-09-26 04:36:04 -05:00
Vignesh Sarma K (വിഘ്നേഷ് ശ൪മ കെ)
9da0e8fdda servo: Merge #13416 - Replace instances of old ServiceWorker specification URL with new one (from vigneshsarma:issue-13408); r=jdm
<!-- Please describe your changes on the following line: -->

The old specification URL is
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/, which has
been replaced by the new one at https://w3c.github.io/ServiceWorker/.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13408 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because all the changes are in commented parts of the code.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

The old specification URL is
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/ has
been replaced by the new one at https://w3c.github.io/ServiceWorker/.

Source-Repo: https://github.com/servo/servo
Source-Revision: d00639c55f9a342765483d347a3c29d4647f7411
2016-09-25 10:12:30 -05:00
Manish Goregaokar
6a1ef325c8 servo: Merge #13386 - Run style tests with all properties included (from Manishearth:style-testing); r=emilio
This turns on all properties (including stylo-only ones) when the style unit tests are compiled. This lets us test the parsing of gecko-only properties.

These tests can't go in tests/stylo since this introduces dependencies on `Gecko_*` symbols. This method lets us test parsing and serialization of geckolib properties compiled in Servo mode (e.g. using Servo atoms, Servo URLs)

r? @emilio

Source-Repo: https://github.com/servo/servo
Source-Revision: 28bce69d248995cc6ec83a2b4ada9cf17a888bb5
2016-09-24 00:36:28 -05:00
Hugo Thiessard
5a99187fb2 servo: Merge #13361 - Report tidy error for space after ( (from Mylainos:issue-13350); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->
Add report in tidy for code which have a space after the `(` like `some_function( argument)`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13350 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 2ba804e6db52637fbe23fbecfd0e65b4db1a49e2
2016-09-23 22:16:57 -05:00
Manish Goregaokar
9fbefe2b32 servo: Merge #13335 - Add unit test crate for stylo (from Manishearth:stylo-tests); r=emilio
@canaltinova needs this for his mask work -- we need a way to test stylo code (or style code that's conditionally compiled out for gecko)

We can add this to the CI as well.

r? @emilio

Source-Repo: https://github.com/servo/servo
Source-Revision: 66c736194d1a6d3af1303a070aa96fec4534187c
2016-09-20 15:47:27 -05:00
UK992
a6ebcb8483 servo: Merge #13205 - Tidy: Fix ordering use statements with braces (from UK992:tidy-sort); r=Wafflespeanut
This hack fixes https://github.com/servo/servo/issues/7412 and matches behavior with rustfmt.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3117787fd2a8b7748cfde1e9b8c5be3c00f2c599
2016-09-08 22:19:19 -05:00
UK992
f8a899b58c servo: Merge #12916 - Create mach bootstrap based on Mozilla's mozboot bootstrapper (from UK992:msvc-dependencies); r=larsbergstrom,wafflespeanut
Fixes https://github.com/servo/servo/issues/12914
I've made this few weeks ago, its an example how could everything looks like.
It downloads and setup all needed dependencies for MSVC.
It's has version in case if some dependencies need to be updated.
Zip files and folder in zip need to be named ``<dep>-<version>``.
Also if cmake already exist in PATH, it won't download it again.

I want opinion on that, if this is right approaches and how to improve it.

cc @vvuk

Source-Repo: https://github.com/servo/servo
Source-Revision: daa30e60f1a7af87ee88aae4fd6e47e210ee9a76
2016-09-08 13:57:23 -05:00
Attila Dusnoki
94bdea58f9 servo: Merge #12875 - WebBluetooth Android support (from dati91:android); r=larsbergstrom
<!-- Please describe your changes on the following line: -->
Add android support for Webbluetooth.
Also adjust to the changed device api.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because there is no test api yet.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 057bcddd0f63a97b8cd1954310878c423d02e056
2016-09-06 10:44:41 -05:00
Emilio Cobos Álvarez
3ade85a49c servo: Merge #13171 - Revert "Remove mako.zip" (from emilio:mako-is-back); r=SimonSapin
<!-- Please describe your changes on the following line: -->

Stylo doesn't use Servo's virtualenv, so we need to integrate it into Gecko's build before doing this.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

This reverts commit 95e3f8333a116f9bd62fb071d08fcef269697804.

Source-Repo: https://github.com/servo/servo
Source-Revision: fe9d9096ec3e78e2d5d53d32f181dc519512a40a
2016-09-03 23:56:55 -05:00
crypto-universe
d8842c0208 servo: Merge #13097 - Mako task (from crypto-universe:mako_task); r=SimonSapin
<!-- Please describe your changes on the following line: -->
Remove mako zip

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #12958 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @SimonSapin

Source-Repo: https://github.com/servo/servo
Source-Revision: e4362356d29ab5b18cb6316a3a510dfa31f9ba7c
2016-09-01 16:47:10 -05:00
Ravi Shankar
c39bd425cd servo: Merge #13151 - Make sure that mach gets the correct paths of executables in virtualenv (from Wafflespeanut:mach_cleanup); r=Ms2ger
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13141 (github issue number if applicable).

<!-- Either: -->
- [x] These changes do not require tests because it's a cleanup related to `mach`

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: e699d9bfad6ce5e1b0cf31d5a6d06512e267f41a
2016-09-01 06:58:50 -05:00
UK992
182dcf7a3e servo: Merge #13107 - Tidy: Handle empty files (from UK992:tidy); r=Wafflespeanut
Fix index error ``list index out of range``, when file is empty.

r? @Wafflespeanut

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

Source-Repo: https://github.com/servo/servo
Source-Revision: c3ce9f2c909cd75c8f424bcef4036d0e29476546
2016-08-31 07:42:25 -05:00
edunham
ded9feab7c servo: Merge #13113 - bump Tidy version (from edunham:tidy-version); r=emilio
Published a new tidy after config file fixes landed, as requested in https://github.com/servo/servo/issues/10636#issuecomment-210658297. This commit makes the repo match what I published, is all.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because **I changed one character in a string. If this breaks stuff, we're !#@$#@!$'d.**

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: c4f34e9019e8324440d46a51e3df3bd150507199
2016-08-30 18:26:56 -05:00
yoyo930021
5b889b293c servo: Merge #13087 - Need better description for mach subcommands #12402 (from yoyo930021:new); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12402  (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because is description

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d807cc2727130a5e2f4f8a05925f7f0bb2243537
2016-08-28 08:50:17 -05:00
UK992
3cdd47dd6d servo: Merge #13027 - Check for license only in Cargo.toml (from UK992:tidy-toml); r=Wafflespeanut
This fix problem with false reporting about missing license in every toml file, that is not Cargo.toml

r? @Wafflespeanut

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

Source-Repo: https://github.com/servo/servo
Source-Revision: 8a5e1b70b7decb251e691ace114e033419a53764
2016-08-25 10:58:09 -05:00
Ravi Shankar
af54932fcd servo: Merge #12976 - A few minor cleanups in tidy (from Wafflespeanut:tidy_fixes); r=nox
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because it's just a cleanup

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: eec56ca50e2d6624b31f23a870936c02e2674573
2016-08-23 03:29:05 -05:00
tp6vup54
e2d49bd3a5 servo: Merge #12971 - Change the separator used in rust path into os.path.join (from tp6vup54:master); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->
Trying to solve #12961 and following the suggestion in it.
Already run test-unit and no red appeared.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #12961 (github issue number if applicable).

<!-- Either: -->
- [x] These changes do not require tests because it's a cleanup of `mach`

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 581e69f8ba1b949dcb5bfa215241d27e3460ee89
2016-08-23 00:39:55 -05:00
UK992
e81d89f36c servo: Merge #12877 - Tidy config file (from UK992:tidy-toml); r=Wafflespeanut
This is wip workaround for https://github.com/servo/servo/issues/10841
Adds ``servo-tidy.toml`` with configs and ignored dirs, files and packages.
This will allow to set custom configuration per repo.
It's an example how could config file looks like.
I want opinion on that, if this is right approaches and how to improve it.

cc @edunham

Source-Repo: https://github.com/servo/servo
Source-Revision: 1c9650cc90090784c63f5af55628ffe6b57c25ed
2016-08-20 22:27:06 -05:00
Connor Brewster
a53fa82f9a servo: Merge #12250 - Add servo version to mac about servo window (from cbrewster:mac_about_version); r=larsbergstrom
<!-- Please describe your changes on the following line: -->
<img width="396" alt="screen shot 2016-07-04 at 8 43 44 pm" src="https://cloud.githubusercontent.com/assets/9086315/16572663/30a6dd6c-4228-11e6-9098-68c49900b14e.png">

cc @aneeshusa

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes are a temporary solution for #12052 (github issue number if applicable).

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 5a5c16776c738fc31bd93c8c45297b53087f9d20
2016-08-19 19:45:00 -05:00
Xidorn Quan
3b7c814308 servo: Merge #12922 - Check PLATFORM for proper toolchain when use msvc (from upsuper:msvc-platform); r=metajack
<!-- Please describe your changes on the following line: -->
Currently, x86_64 toolchain would always pick the amd64 MSVC linker, which will fail to link when it runs in an environment configured for building x86 program (has `PLATFORM=X86` in environment variable).

This commit picks the proper host triple according to the environment variable when using the MSVC backend.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because build system only

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 28767cdb6725be83dcf50b9682a49de01229a287
2016-08-19 18:38:36 -05:00
Vladimir Vukicevic
f387e2e425 servo: Merge #11756 - MSVC support for Servo, and CMake builds for native code (from vvuk:servo-msvc); r=larsbergstrom
This is the base PR for MSVC builds of servo and dependent crates.  It's got replacements in the Cargo.toml to pull in the right versions, to make sure that crates were properly converted to CMake for all other platforms, not just Windows.  (Servo builds with MSVC 2015 with this PR; also with 2013, though a manual change in rust-mozjs to select a different set of bindings is needed.)

This PR isn't quite ready yet, but I want bors-servo to do builds.

Source-Repo: https://github.com/servo/servo
Source-Revision: ec53136863f20b80caf165d2f15e8a77d614536e
2016-08-17 13:22:52 -05:00
S
3d828c7df7 servo: Merge #12900 - ./mach throws error on poor connectivity (from pathway27:master); r=notriddle
<!-- Please describe your changes on the following line: -->

Imported error from socket using `from` since it's the only thing we need.
The exception is [different ](https://docs.python.org/2/library/socket.html#socket.error) from the other exceptions as it could be a string or a tuple with error number.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12764

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests they execute before the test runner is installed. Can't test the bootstrapping code.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9785e520aec4d8a821659d4811713ee43bfe82af
2016-08-17 02:30:56 -05:00
S
7ebb71cca1 servo: Merge #12870 - ./mach has a formatting error (from pathway27:master); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->

Fix for #12766. Couldn't reproduce the exact error.

I explicitly raised urllib2.URLError to get to the print and then tried using many different variable types for e.reason and src but it still didn't throw a coercion error.

So, as @Wafflespeanut said,
> Instead of appending, we can format the values, which (I'm pretty sure) will fix this error.

which is what i've done.

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12766, hopefully.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests they execute before the test runner is installed. Can't test the bootstraping code.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 75f6cf47c493a916272119cf41b0f16791ec8966
2016-08-15 23:59:07 -05:00
Paul Rouget
9a04466ea0 servo: Merge #12867 - Revert "Enable multiprocess and sandbox" (from paulrouget:noMS); r=emilio
Multiprocess and sandboxing still have some issues:
* https://github.com/servo/servo/issues/12791
* https://github.com/servo/servo/issues/12807

Let's disable these features for now and reenable them later: https://github.com/servo/servo/issues/12868.

Source-Repo: https://github.com/servo/servo
Source-Revision: a617ea353a059486a117e1c04a60e3d13fc5f9cc
2016-08-14 21:25:20 -05:00
Paul Rouget
832d245571 servo: Merge #12688 - brew package (from paulrouget:brew); r=larsbergstrom
Addressed #12600

This is just a WIP PR to see if this approach is right.

The same way night builds are uploaded every day, we'd like to offer a brew binary package as well.

Step 1 is to package a tarball along the dmg. This is done in `package_commands.py`.
Step 2 is to upload the package. Done is `update_brew.sh`.
Step 3 is to update the brew Formula. [servo-bin.rb](https://github.com/paulrouget/homebrew-servo/blob/master/servo-bin.rb.in) is updated in `update_brew.sh`.
Step 4 is to trigger `update_brew.sh` along `update_nightly.sh`. https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/steps.yml

Source-Repo: https://github.com/servo/servo
Source-Revision: a2ce4aa8525c3c83388c5401016a79ffe0444c03
2016-08-14 15:25:25 -05:00
UK992
346aa396f6 servo: Merge #12781 - Improve tidy's license validation logic (from UK992:tidycheck-rebased); r=Wafflespeanut
Rebased and fixed https://github.com/servo/servo/pull/10721, which is inactive for months.
Fixes https://github.com/servo/servo/issues/10716

r? @larsbergstrom or @edunham

Source-Repo: https://github.com/servo/servo
Source-Revision: 8419f96dc0cb79c83922b62166390f6688f2aae0
2016-08-14 09:17:34 -05:00
UK992
ae94be4466 servo: Merge #12821 - Create mach fetch command (from UK992:mach-update); r=aneeshusa
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12775.

r? @larsbergstrom

Source-Repo: https://github.com/servo/servo
Source-Revision: b4695541ae50fec1047476155d14fd40bb551de9
2016-08-12 17:18:43 -05:00
Ms2ger
17bdab21c5 servo: Merge #12816 - Update ordered-float (from servo:always-be-updating); r=Wafflespeanut
Source-Repo: https://github.com/servo/servo
Source-Revision: ef442556c2f420ea8f9011df0a9e1b7a55c8b238
2016-08-11 02:16:17 -05:00
Simon Martin
6a92b958ea servo: Merge #12576 - Issue #12421: tidy should also check .html files (from simartin:issue_12421); r=jdm
./mach test-tidy should also check .html files, to avoid patches containing badly formatted new test cases go unnoticed

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12421
- [X] There are tests for these changes (./mach test-tidy failed without the changes to .hrml files)

Source-Repo: https://github.com/servo/servo
Source-Revision: 93004ce57999947f51067d680c6fde056741331a
2016-08-09 17:20:50 -05:00
Ravi Shankar
344e41a8e2 servo: Merge #12783 - Prefer length and percentage for word spacing (from Wafflespeanut:word_spacing); r=Manishearth
<!-- Please describe your changes on the following line: -->
The goal is to make use of `LengthOrPercentage` for word spacing in `ShapingOptions`, but since it makes use of `f32` which doesn't implement `Hash`, we're going for `NotNan<f32>` from [ordered-float](https://github.com/reem/rust-ordered-float/), which supports hashing. Instead of implementing `Hash` for `LengthOrPercentage` and thereby the inner types like `CSSFloat`, `CalcLengthOrPercentage`, etc., we convert it to `(Au, NotNan<f32>)`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 3b676bc85dc66ed0e80756204f347bf1842b01a0
2016-08-09 10:13:30 -05:00
Aneesh Agrawal
1d490c43f8 servo: Merge #12736 - Add more shell script lints (from aneeshusa:prohibit-backticks-in-shell-scripts); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->

The "$(some_command arg1 arg2)" form is preferred to the
`some_command arg1 arg2` form because it nests unambiguously.
Add a lint for this to tidy.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: aa900b91aa9417b6aa032b4eff878f2916c480f0
2016-08-06 21:57:31 -05:00
tsawada
04f8c6c2e1 servo: Merge #12755 - Fix flag compose in runservo.sh (from tsawada:patch-1); r=ConnorGBrewster
This fixes following error when running runservo.sh:

$ ./runservo.sh
Unrecognized option: '-'.
$

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

s/-S--pref/-S --pref/

Source-Repo: https://github.com/servo/servo
Source-Revision: 82f1970e25dcacb05758abcfc3ef3008c169a1e4
2016-08-06 10:57:14 -05:00
UK992
c10f59522d servo: Merge #12752 - Run git commands only with mach build (from UK992:mach); r=metajack
This should solve problem with slow run on Windows mention in https://github.com/servo/servo/issues/12730, which is cause by slow git.

Source-Repo: https://github.com/servo/servo
Source-Revision: 686ca251392ffd7323693ccbe1defc89b3a36caa
2016-08-05 16:15:09 -05:00
Anton Ovchinnikov
b774eaee66 servo: Merge #12244 - Create .tar.gz package deterministically using Python's "tarfile" (from rev112:package-repro-pure); r=aneeshusa
<!-- Please describe your changes on the following line: -->
A development of #12108, creates a .tar.gz package using the `tarfile` and `gzip` modules, without external dependencies. Fixes #11981.
Also this fixes the issue when the existing `resources/` directory didn't allow to create a new package and failed with "File exists" error.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11981 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because "more general approach to reproducibility testing is needed"

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 1086df67e04ce97fed080ba7c79ed8e1615202eb
2016-08-04 18:15:49 -05:00
Paul Rouget
bdf73d4202 servo: Merge #12708 - Enable multiprocess and sandbox (from paulrouget:multiprocessAndSandboxForBhtml); r=metajack
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12705 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Enable multiprocess and sandbox for Mac and Linux when running
browserhtml.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3dce4c62ca55409dfac9dea6ecc674c0020eab6c
2016-08-04 16:13:45 -05:00
Jim Berlage
11fced50ba servo: Merge #12295 - Add linting for shell scripts (from jimberlage:12158/shell-linting); r=aneeshusa
<!-- Please describe your changes on the following line: -->

This changes tidy to check shell scripts for the proper shebang and
options.  It does not check that variables are formatted correctly.  It
also adds a check for the MPL 2.0 license in shell scripts.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12158 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 4bc629b369242d16675161ab6af8141dab0bb556
2016-08-04 12:31:17 -05:00
Emilio Cobos Álvarez
7d754d2cbf servo: Merge #12645 - stylo: Allow computing change hints during the traversal (from emilio:stylo); r=bholley
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because geckolib :-(

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @bholley
cc @heycam

Source-Repo: https://github.com/servo/servo
Source-Revision: cbf71a2cf39e792f75309e68f7cabe862d4a70eb
2016-08-03 19:02:26 -05:00
Shing Lyu
6c94384a0d servo: Merge #12650 - Add python3 licence check template (from shinglyu:py3-tidy); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->

Add a python3 license template. #11107 uses python3 exclusively so we need this.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because covered by test-tidy self test

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9d795c3a3eeb34ef1f380053954bbffb63e31386
2016-07-29 09:42:00 -05:00