Cosmin Sabou
d6de4f5770
Merge mozilla-central to autoland. a=merge
2018-08-24 00:44:17 +03:00
Cosmin Sabou
793596386b
Merge mozilla-inbound to mozilla-central. a=merge
2018-08-24 00:40:14 +03:00
Emilio Cobos Álvarez
4c34d703b9
Bug 1485430 - Simplify PlaceBelowCurrentFloats. r=dbaron,mats
...
No reason to pass our own member as an argument.
Differential Revision: https://phabricator.services.mozilla.com/D4000
2018-08-22 23:29:22 +00:00
Emilio Cobos Álvarez
d5fa724049
Bug 488725: Don't position floats in a nowrap context until hitting a break opportunity. r=dbaron
...
Differential Revision: https://phabricator.services.mozilla.com/D3900
2018-08-23 16:45:01 +02:00
Gerald Squelart
fc3e3c4010
Bug 1483946 - Fix CSS containment issue with scrollable elements - r=dholbert
...
Scrollable elements already trap all of their contents, nothing should spill
out, so there is no need for special handling of the `contain` CSS property.
Differential Revision: https://phabricator.services.mozilla.com/D3854
2018-08-23 15:55:54 +00:00
Cameron McCormack
e84b70ae83
Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio
...
Summary: Depends On D3283
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision: https://phabricator.services.mozilla.com/D3284
2018-08-15 15:46:39 +10:00
Cameron McCormack
eb1c77b263
Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio
...
Summary: Depends On D3282
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision: https://phabricator.services.mozilla.com/D3283
2018-08-15 15:46:00 +10:00
Narcis Beleuzu
ace8b010f2
Backed out 8 changesets (bug 1483121, bug 1482782) for build bustages on nsDirectoryService.cpp. CLOSED TREE
...
Backed out changeset 0a8334bbcf45 (bug 1483121)
Backed out changeset cb2dcb859071 (bug 1482782)
Backed out changeset c834d4ca2eef (bug 1482782)
Backed out changeset 887de0efbb67 (bug 1482782)
Backed out changeset 018fdb50a6be (bug 1482782)
Backed out changeset 33a8aa8096c9 (bug 1482782)
Backed out changeset e3632354f16e (bug 1482782)
Backed out changeset 46f8319bee82 (bug 1482782)
2018-08-15 09:14:41 +03:00
Cameron McCormack
f242832b4e
Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio
...
Summary: Depends On D3283
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision: https://phabricator.services.mozilla.com/D3284
2018-08-15 15:46:39 +10:00
Cameron McCormack
a3c0cd4850
Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio
...
Summary: Depends On D3282
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision: https://phabricator.services.mozilla.com/D3283
2018-08-15 15:46:00 +10:00
Morgan Rae Reschenberg
b8cfeab0cf
Bug 1472919 - Establish stacking context, containing block, independent formatting context for contain:layout. r=dbaron
...
MozReview-Commit-ID: H36HpePX29C
2018-07-20 10:57:22 -07:00
Morgan Rae Reschenberg
2ae64ffcca
Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert
...
MozReview-Commit-ID: 2gRm0LOUTI6
2018-07-23 11:04:50 -07:00
Cosmin Sabou
edf9d939cc
Backed out changeset b580e5b9f9e4 (bug 1476495) for wpt reftest failures on contain-layout-ink-overflow. CLOSED TREE
2018-08-10 07:17:58 +03:00
Morgan Rae Reschenberg
4652967d9f
Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert
...
MozReview-Commit-ID: 2gRm0LOUTI6
2018-07-23 11:04:50 -07:00
Emilio Cobos Álvarez
ef46e516eb
Bug 1478069: Trivial frame constructor cleanup. r=TYLin
...
Using references helps to see when stuff can and cannot be null.
I removed useless aTag / aNamespaceId arguments which are useless now that XBL
can't override them (bug 1450617), so FindXULData is the only one that keeps
them alive.
Also, I took the liberty of renaming a few fooComputedStyle variables to just
fooStyle, and clarify naming in some pseudo-element-related functions to say
originating element (the spec term) and avoid confusing it with the generated
_moz_generated_content_before / _moz_generated_content_after element.
Note that this is a partial state, more stuff will come in the future.
Differential Revision: https://phabricator.services.mozilla.com/D2326
MozReview-Commit-ID: 39B30doREUH
2018-07-25 11:31:18 +02:00
Gerald Squelart
2619a3dbc8
Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron
...
MozReview-Commit-ID: JPfg9YtBm6M
2018-07-10 15:35:48 +10:00
Gerald Squelart
4563073b1d
Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron
...
Similar to lines (see previous patch), floats from next-in-flow or overflow
frames have probably not been marked dirty (as ReflowInput hasn't dealt with
them when it was constructed), so we need to mark them dirty for proper reflow.
If we don't do that, and they don't fit in the current column, the next column
will only mark its current children dirty, so when pulling back its first
floats from the previous column they will not be reflowed as needed.
MozReview-Commit-ID: KKrwtzeQMrI
2018-07-10 11:36:33 +10:00
Gerald Squelart
2d67b03104
Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron
...
Lines pulled from next-in-flow or overflow frames have probably not been marked
dirty (as ReflowInput hasn't dealt with them when it was constructed), so we
need to mark them dirty for proper reflow.
If we don't do that, and they don't fit in the current column, the next column
will only mark its current children dirty, so when pulling back its first lines
from the previous column they will not be reflowed as needed, which causes this
bug.
MozReview-Commit-ID: 8GFO1ZWuZ1b
2018-07-09 11:42:47 +10:00
Emilio Cobos Álvarez
8397ffc9e5
Bug 1476054: Fixes and cleanups for Servo PR #21156 . r=me
...
Similar to the previous patch, logical clear doesn't appear in computed style
objects.
MozReview-Commit-ID: FbN0hiUGzYa
2018-07-17 10:23:26 +02:00
Emilio Cobos Álvarez
ba82c4b179
Bug 1476054: Fixes and cleanups for Servo PR #21139 . r=me
...
Logical floats don't appear in the computed style objects, so there's no need to
check for them.
MozReview-Commit-ID: 3ocJrRB3jeO
2018-07-17 10:15:46 +02:00
Gurzau Raul
dcbcd177e8
Backed out 6 changesets (bug 1476054) for failing on servo/ports/geckolib/glue.rs on a CLOSED TREE
...
Backed out changeset f4941fe345ad (bug 1476054)
Backed out changeset cc571c618e4c (bug 1476054)
Backed out changeset 0a712d7bcb66 (bug 1476054)
Backed out changeset 62293a989ed2 (bug 1476054)
Backed out changeset ef2a43e3fc6c (bug 1476054)
Backed out changeset a2bb0089cf1d (bug 1476054)
2018-07-16 23:56:23 +03:00
Emilio Cobos Álvarez
07cd478d5b
Bug 1476054: Fixes and cleanups for Servo PR #21156 . r=me
...
Similar to the previous patch, logical clear doesn't appear in computed style
objects.
MozReview-Commit-ID: FbN0hiUGzYa
2018-07-16 21:38:46 +02:00
Emilio Cobos Álvarez
db60e73bd2
Bug 1476054: Fixes and cleanups for Servo PR #21139 . r=me
...
Logical floats don't appear in the computed style objects, so there's no need to
check for them.
MozReview-Commit-ID: 3ocJrRB3jeO
2018-07-16 21:38:44 +02:00
Andreea Pavel
757ec900ba
Backed out 3 changesets (bug 1459937) for failing crashtest with Assertion failure: (IndexInFlow(aOldParent) < IndexInFlow(aNewParent)) on a CLOSED TREE
...
Backed out changeset 2cff5c67d000 (bug 1459937)
Backed out changeset fb3fba19e615 (bug 1459937)
Backed out changeset bd4bd8ac335c (bug 1459937)
2018-07-15 10:06:23 +03:00
Gerald Squelart
e7efa5d1c3
Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron
...
MozReview-Commit-ID: JPfg9YtBm6M
2018-07-10 15:35:48 +10:00
Gerald Squelart
5b9f6cdc21
Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron
...
Similar to lines (see previous patch), floats from next-in-flow or overflow
frames have probably not been marked dirty (as ReflowInput hasn't dealt with
them when it was constructed), so we need to mark them dirty for proper reflow.
If we don't do that, and they don't fit in the current column, the next column
will only mark its current children dirty, so when pulling back its first
floats from the previous column they will not be reflowed as needed.
MozReview-Commit-ID: KKrwtzeQMrI
2018-07-10 11:36:33 +10:00
Gerald Squelart
bca5bf93e1
Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron
...
Lines pulled from next-in-flow or overflow frames have probably not been marked
dirty (as ReflowInput hasn't dealt with them when it was constructed), so we
need to mark them dirty for proper reflow.
If we don't do that, and they don't fit in the current column, the next column
will only mark its current children dirty, so when pulling back its first lines
from the previous column they will not be reflowed as needed, which causes this
bug.
MozReview-Commit-ID: 8GFO1ZWuZ1b
2018-07-09 11:42:47 +10:00
Morgan Rae Reschenberg
03c85f3e41
Bug 1467209 - Implement contain:size for blockFrame. r=dholbert
...
MozReview-Commit-ID: 852mDXLEpOj
2018-06-29 10:30:07 -07:00
Chris Peterson
f7ceeaf5cf
Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
...
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.
MozReview-Commit-ID: 5UQVHElSpCr
2018-06-17 22:43:11 -07:00
Cameron McCormack
05223978e6
Bug 1469738 - Part 2: Replace mentions of "space manager" with "float manager" in comments. r=xidorn
...
MozReview-Commit-ID: 1BxlziyTEOM
2018-06-05 15:33:42 +10:00
Brad Werth
058cd02789
Bug 1466231 Part 1: Change nsBlockFrame::PlaceLine to accept an nsFlowAreaRect and update flags if it shrinks the area due to a float. r=dbaron
...
MozReview-Commit-ID: 4stQQfboUl7
2018-06-06 12:02:36 -07:00
Cosmin Sabou
c528f23db4
Backed out 5 changesets (bug 1466231) for reftest failures on float-retry-push-image.html.
...
Backed out changeset 8141b2848c2c (bug 1466231)
Backed out changeset 2250da9a0dd0 (bug 1466231)
Backed out changeset 012e16dcc677 (bug 1466231)
Backed out changeset 332453c76ec7 (bug 1466231)
Backed out changeset f926e605d5a9 (bug 1466231)
2018-06-16 01:45:26 +03:00
Brad Werth
de631b2586
Bug 1466231 Part 1: Change nsBlockFrame::PlaceLine to accept an nsFlowAreaRect and update flags if it shrinks the area due to a float. r=dbaron
...
MozReview-Commit-ID: 4stQQfboUl7
2018-06-06 12:02:36 -07:00
Brad Werth
23ee4aff21
Bug 1463745 Part 3: Change nsBlockFrame::DoReflowInlineFrames to detect when the float area may widen in the block direction, and push the inline frame down by a pixel at a time to retry until it fits. r=dbaron
...
MozReview-Commit-ID: I4jisE3EYi5
2018-05-30 12:39:58 -07:00
Brad Werth
bd11c1e59d
Bug 1463745 Part 2: Change nsFlowAreaRect to also track whether it may widen in the block direction. r=dbaron
...
MozReview-Commit-ID: FWKQEFDBFgr
2018-05-30 11:07:18 -07:00
Cameron McCormack
c3fde9a6c4
Bug 1464967 - Part 2: Fix nsReflowStatus dumping when REALLY_NOISY_REFLOW is defined. r=gerald
...
MozReview-Commit-ID: JPN7i5z5IeX
2018-05-29 14:08:01 +10:00
Boris Zbarsky
586f4fc92c
Bug 1387143 part 24. Remove nsISelection::ContainsNode. r=mats
2018-05-08 13:52:42 -04:00
Chris Peterson
5d6b16ea3b
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
2018-04-28 12:50:58 -07:00
Emilio Cobos Álvarez
65978b31f3
Bug 1452080: Remove ComputedStyle::PresContext usage from layout and canvas code. r=xidorn
...
Couldn't find an easy way of splitting these up :(
MozReview-Commit-ID: 2kTZ5McREUT
2018-04-09 11:19:49 +02:00
Noemi Erli
b15aabf388
Backed out 3 changesets (bug 1452080) for bustage in /builds/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp on a CLOSED TREE
...
Backed out changeset 7f5104c7a242 (bug 1452080)
Backed out changeset 806a9c95a243 (bug 1452080)
Backed out changeset bffebe8aa254 (bug 1452080)
2018-04-09 11:18:12 +03:00
Emilio Cobos Álvarez
9c4328ca42
Bug 1452080: Remove ComputedStyle::PresContext usage from layout and canvas code. r=xidorn
...
Couldn't find an easy way of splitting these up :(
MozReview-Commit-ID: 2kTZ5McREUT
2018-04-09 09:57:55 +02:00
Emilio Cobos Álvarez
7e1d5887e6
Bug 1447827: Rename the reparenting stuff. r=xidorn
...
MozReview-Commit-ID: H7tl6O8Ju32
2018-04-07 15:51:19 +02:00
Emilio Cobos Álvarez
3284a9dda8
Bug 1447827: Remove ServoRestyleManager. r=xidorn
...
MozReview-Commit-ID: CFafQsb4rQn
2018-04-07 15:50:06 +02:00
Emilio Cobos Álvarez
8e43075fd5
Bug 1447827: Move members from ServoRestyleManager to RestyleManager. r=xidorn
...
This leaves ServoRestyleManager as just a typedef.
MozReview-Commit-ID: 5wfTkiDc2Nr
2018-04-07 15:40:00 +02:00
Matt Woodrow
3a11330208
Bug 1443380 - Don't mark all descendant frames modified for display list building when invalidating a frame subtree since marking just the root is sufficient. r=miko
2018-04-04 16:15:49 +12:00
Xidorn Quan
ea8b8b1e74
Bug 1449400 part 5 - Remove StyleSetHandle. r=emilio
...
This patch basically does:
* remove StyleSetHandle and its corresponding files
* revisit #includes of related header files and change correspondingly
* change nsIPresShell::mStyleSet to be UniquePtr<ServoStyleSet>
* change the creating path of ServoStyleSet to pass UniquePtr
* change other mentions of StyleSetHandle to ServoStyleSet*
* remove AsServo() calls on ServoStyleSet
Some unfortunate bits:
* some methods of (Servo)StyleSet only accepts ServoStyleSheet while
many places call into the methods with StyleSheet, so there are many
->AsServo() added to sheets
MozReview-Commit-ID: K4zYnuhOurA
2018-03-29 22:15:46 +11:00
Emilio Cobos Álvarez
68ee99d4c8
Bug 1448688: Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits. r=xidorn
...
MozReview-Commit-ID: ALiOngGqozN
2018-03-26 09:38:07 +02:00
Emilio Cobos Álvarez
1d4859a89a
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
97286b35c8
Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
...
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.
MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
1f5d8de5cc
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00