Commit Graph

2692 Commits

Author SHA1 Message Date
Ting-Yu Lin
d5c5fac26b Bug 1290276 Part 7 - Restyle element and its descendant after loading XBL bindings. r=heycam
MozReview-Commit-ID: 1WiioW3xxMX
2017-06-05 14:21:32 +08:00
Ting-Yu Lin
6599358fae Bug 1290276 Part 3 - Move nsStyleSet's call to SetBindingManager to PresShell::Init(). r=heycam
Delete the NS_WARNING because it's not needed once this bug is fixed.

MozReview-Commit-ID: Ht3ayjSvYW8
2017-06-05 14:33:30 +08:00
L. David Baron
03d37750a7 Bug 1369260 - Remove use of MOZ_ASSERT_IF in layout. r=heycam
As I've said before, as module owner I prefer that MOZ_ASSERT_IF not be
used in the module because I consider it to be unreadable.  However, a
few uses have crept in, and this patch removes them.

I consider it to be unreadable because the name looks like a name that
uses smalltalk-ish naming conventions, i.e., with a part of the name
corresponding to each parameter, in order.  However, the parameters are
in the order opposite the name.

This was written primarily with the vim commands:
:%s/MOZ_ASSERT_IF(\([^,]*\),/MOZ_ASSERT(!\1 ||/
:wn
followed by manual cleanup for indentation and removal of !!.

MozReview-Commit-ID: G6rLbOn7k8d
2017-06-06 22:27:17 -07:00
Mats Palmgren
3009528973 Bug 1367209 part 3 - Add a generic frame state bit, NS_FRAME_HAS_CSS_COUNTERS, to indicate that a frame maybe has some counter styles and thus be known by nsCounterManager. r=jfkthame
If a frame doesn't have that bit then skip mCounterManager.DestroyNodesFor()
when the frame is destroyed because it's definitely not known by
the CounterManager.

MozReview-Commit-ID: Ky3575QvZME
2017-06-04 16:45:15 +02:00
John Schoenick
56fdf7a699 Bug 558184 - Part 4.3 - Load fake plugin handlers as eType_FakePlugin in nsObjectLoadingContent. r=peterv. 2015-05-20 15:30:05 +02:00
Mats Palmgren
49057b2c0a Bug 1369037 - Make the assertions about NS_FRAME_PART_OF_IBSPLIT stricter and update the associated frame properties in nsContainerFrame::DestroyFrom instead of nsFrame::DestroyFrom. r=jfkthame
MozReview-Commit-ID: G8NQ70xzkQU
2017-05-31 21:29:49 +02:00
Mats Palmgren
f53a6843c6 bug 1368547 part 2 - Remove nsFrameManager/PresShell methods dealing with placeholders and introduce a nsIFrame::GetPlaceholderFrame() convenience method. r=jfkthame
MozReview-Commit-ID: GBUiUBqJxhQ
2017-05-31 21:29:49 +02:00
Jonathan Kew
7b40682ff5 Bug 1368249 - Create nsIFrame::AddProperty API for use when the property is known to not already exist, and use to optimize some call sites. r=mats 2017-05-28 13:16:55 +01:00
Sebastian Hengst
99cc01f206 Backed out changeset 59c0589220ec (bug 1368249) unused function GetNormalPosition at nsIFrame.h:1073. r=backout 2017-05-28 15:38:15 +02:00
Jonathan Kew
3a49043e3f Bug 1368249 - Create nsIFrame::AddProperty API for use when the property is known to not already exist, and use to optimize some call sites. r=mats 2017-05-28 13:16:55 +01:00
Jonathan Kew
4dcf0fe444 Bug 1365982 - Attach frame properties to each frame instead of looking them up in a hashtable on the prescontext. r=mats 2017-05-27 12:36:00 +01:00
Xidorn Quan
9c6c25ce2c Bug 1366735 part 3 - Remove SetCounterStyleDirty. r=heycam
When the counter style in the style struct changes, CalcDifference
would return ReconstructFrame, which should cause corresponding use
node to be reconstructed. That means a use node with retired counter
style should always be destroyed in the next flush, so it makes no
sense to reset them anymore.

However, we would still need to mark counter lists dirty because
otherwise their content may not get update when there are changes to
counter styles which are still valid.

MozReview-Commit-ID: FnBPx81StzG
2017-05-23 10:08:50 +10:00
Xidorn Quan
b47214dcef Bug 1366735 part 1 - Change counter functions to use struct rather than nsCSSValue::Array. r=heycam
MozReview-Commit-ID: 4FiOxCOsjtD
2017-05-22 22:51:20 +10:00
Mats Palmgren
bd90393cc1 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz
MozReview-Commit-ID: IbwWM0FL6HF
2017-05-21 17:15:00 +08:00
Carsten "Tomcat" Book
1aa86b3e0e Backed out changeset bbb688fe1ba3 (bug 1365614) 2017-05-22 15:45:31 +02:00
Iris Hsiao
559b666872 Merge mozilla-central to mozilla-inbound 2017-05-22 11:53:00 +08:00
Mats Palmgren
473a358067 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
Hiroyuki Ikezoe
f68519c81c Bug 1364799 - Add a new TraversalRestyleBehavior that represents the traversal is triggered by CSS rule changes. r=birtles
And propagate the new flag to servo if mRestyleForCSSRuleChanges is set.

MozReview-Commit-ID: HRZ5duYgciF
2017-05-21 08:16:26 +09:00
Bobby Holley
cd110a0991 Bug 1329876 - Don't maintain a TreeMatchContext for Servo. r=bz 2017-05-20 22:00:01 +02:00
Xidorn Quan
9c43c2ec09 Bug 1365602 - Put script blocker to nsCSSFrameConstructor::RecalcQuotesAndCounters for avoiding triggering event from nsQuoteList::RecalcAll. r=bz
MozReview-Commit-ID: JW0vjT0C5iU
2017-05-18 11:25:48 +10:00
Daniel Holbert
5066835c91 Bug 1344398 part 2: React to some CSS 'overflow' changes on body/html by simply calling UpdateViewportScrollbarStylesOverride() instead of reframing. r=bz,tnikkel
MozReview-Commit-ID: Lpr9aNv9hAB
2017-05-10 13:53:27 -07:00
Daniel Holbert
55508e8222 Bug 1344398 part 1: Move presContext variable a little earlier in a nsCSSFrameConstructor method. r=tnikkel
Also, assert that this presContext is non-null (which we already implicitly
assume, when we dereference it without null-checking it).

MozReview-Commit-ID: IIYUqGQTOnb
2017-05-10 13:53:25 -07:00
Wes Kocher
1be726284d Backed out 3 changesets (bug 1344398) for assertion failures at Element.cpp a=backout
Backed out changeset d0e5a5ba01b5 (bug 1344398)
Backed out changeset d70f9de401d1 (bug 1344398)
Backed out changeset 647d0bb3714d (bug 1344398)

MozReview-Commit-ID: DTVWf28NcNb
2017-05-10 17:43:50 -07:00
Daniel Holbert
4fdbcddca9 Bug 1344398 part 2: React to some CSS 'overflow' changes on body/html by simply calling UpdateViewportScrollbarStylesOverride() instead of reframing. r=bz,tnikkel
MozReview-Commit-ID: Lpr9aNv9hAB
2017-05-10 13:53:27 -07:00
Daniel Holbert
99e0a8111c Bug 1344398 part 1: Move presContext variable a little earlier in a nsCSSFrameConstructor method. r=tnikkel
Also, assert that this presContext is non-null (which we already implicitly
assume, when we dereference it without null-checking it).

MozReview-Commit-ID: IIYUqGQTOnb
2017-05-10 13:53:25 -07:00
Emilio Cobos Álvarez
643f3f8618 Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn
This avoids conflicts with mozilla::dom::FrameType.

MozReview-Commit-ID: 7aEMbHRaTFk
2017-05-01 19:32:52 +02:00
Emilio Cobos Álvarez
3731858edf Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
MozReview-Commit-ID: 5Nzhyta5Hle
2017-04-30 17:30:08 +02:00
Emilio Cobos Álvarez
e611edcc48 Bug 1360157: Assert that a display: contents child always has a parent. r=mats
MozReview-Commit-ID: Cyif2yCFu5
2017-04-27 12:36:07 +02:00
Emilio Cobos Álvarez
7e1330401f Bug 1355351: Simplify nsLayoutUtils callers, and make child iterators notice display: contents pseudos. r=heycam
This also happens to fix other bugs, like making display: contents pseudos
animatable, which weren't before.

MozReview-Commit-ID: LhwTPNbFvSZ
2017-04-19 12:53:57 +02:00
Emilio Cobos Álvarez
d1f4335361 Bug 1355351: Clean up pseudo-element props. r=heycam
MozReview-Commit-ID: JZAhEN3chPs
2017-04-19 10:27:33 +02:00
Emilio Cobos Álvarez
85a881db75 Bug 1355351: Add a node property to access the ::before and ::after pseudo-elements. r=heycam
MozReview-Commit-ID: FJxJp2U0Lxh
2017-04-16 17:29:49 +02:00
Emilio Cobos Álvarez
d133d0c021 Bug 1358570: Make PurgeCompletedTransitions lookup the correct animation collection. r=hiro
Probably GetAnimationCollection itself should assert against it, but that's a
bigger task right now...

MozReview-Commit-ID: JxFWXtgMAXy
2017-04-21 16:53:21 +02:00
Astley Chen
23e215d602 Bug 1355752 - Remove B2G code from nsCSSFrameConstructor.cpp. r=dholbert
MozReview-Commit-ID: Kvzn02nmzb0
2017-04-20 13:16:43 +08:00
Emilio Cobos Álvarez
be5f37c95d Bug 1354886: null-check parent in FrameConstructor::StyleNewChildren. r=heycam
MozReview-Commit-ID: DLZxQu8LI4o
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-04-13 00:30:00 +08:00
Cameron McCormack
c023cd4030 Bug 1353317 - stylo: For newly added content, note dirty descendants in the lazy frame construction case through the flattened tree parent. r=bholley
MozReview-Commit-ID: L6MhRK3zmSc
2017-04-04 18:28:05 +08:00
Cameron McCormack
7341326d0c Bug 1351535 - Part 7: Call StyleSubtreeForReconstruct when doing frame reconstruction. r=bholley
MozReview-Commit-ID: HxoGLPKJpnt
2017-04-04 19:36:09 +08:00
Cameron McCormack
73a1b8bdaf Bug 1351535 - Part 3: Only explicitly style newly inserted content if the parent is not in a display:none subtree. r=bholley
If we append children to an element inside a display:none tree and we
decide not to do lazy frame construction, StyleNewChildren will assert.
It's also unnecessary, anyway, since we want to keep the descendants
of the display:none element free of ElementData.

MozReview-Commit-ID: 19tuzAzAIDp
2017-04-04 19:21:05 +08:00
Cameron McCormack
21a32ad0d3 Bug 1351535 - Part 2: Explicitly indicate when a ContentRangeInserted call is for frame reconstruction. r=bholley
It wasn't clear to me whether the existing check for whether we are
under a restyle was sufficient to cover all cases of reconstructing
frames, so this patch makes it more explicit by passing that state
into ContentAppended and ContentRangeInserted.

MozReview-Commit-ID: HjlDCzJv97n
2017-04-04 19:17:35 +08:00
Xidorn Quan
95cf226194 Bug 1351957 - Create URLExtraData for holding base uri, referrer, and principal. r=heycam
MozReview-Commit-ID: 1wqTb3kvvWh
2017-03-30 18:54:48 +11:00
Sebastian Hengst
4111d5a496 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: EjvlThqFc40
2017-04-02 18:52:13 +02:00
Cameron McCormack
1dac83f970 Bug 1352785 - stylo: Ensure children of elements with invalid -moz-binding URLs get styled. r=bholley
MozReview-Commit-ID: 2zot13HgjWU
2017-04-02 15:15:44 +08:00
Olli Pettay
45822311b7 Bug 1351860 - Move mType from HTMLInputElement to nsIFormControl and make GetType non-virtual inlined, r=jessica 2017-03-31 22:49:00 -04:00
Emilio Cobos Álvarez
8e43bfcdc9 Bug 1351791: Simplify PostRestyleEventForLazyConstruction. r=bholley
MozReview-Commit-ID: 2jsrojLzYeo
2017-03-31 11:56:29 +02:00
Emilio Cobos Álvarez
529ee020ee Bug 1351791: Move PostRestyleEventForLazyConstruction and PostRestyleEventInternal to GeckoRestyleManager. r=bholley
MozReview-Commit-ID: 5lrNlkbrnZb
2017-03-31 11:56:29 +02:00
Bobby Holley
b86b97cc10 Bug 1350244 - Back out bug 1348606 part 5 (Use a threadsafe array for counters). r=me
This reverts commit 07301f1c3f71b36dbe2345e8faa9bc6d643cfc97.

MozReview-Commit-ID: 8tLjUhki2C1
2017-03-29 11:05:17 -07:00
Bobby Holley
cf2cd53e13 Bug 1350441 - Clear servo data when tearing down frames for DestroyFramesFor. r=heycam
MozReview-Commit-ID: DWwu8FqSjdj
2017-03-29 09:27:24 -07:00
Boris Zbarsky
2ab5f6b014 Bug 1351139. Use only one kind of anonymous box for the block wrappers we create for a block-inside-inline split. r=dbaron
Note that this removes the useless (because this anon box is never absolutely
positioned) "clip: inherit" style.

MozReview-Commit-ID: iJJdv5VL06
2017-03-28 21:26:31 -04:00
Cameron McCormack
6893bbde8d Bug 1349487 - stylo: Eagerly style content appended in a ShadowRoot. r=bholley
MozReview-Commit-ID: FnTwSW8YF2p
2017-03-24 14:44:11 +08:00
Cameron McCormack
6c077daa8b Bug 1349134 - stylo: Style newly appended children of an element with a binding through their flattened tree parents. r=bholley
MozReview-Commit-ID: 3fQouTm2bw4
2017-03-24 14:27:22 +08:00
Ting-Yu Lin
357d8b7edc Bug 1322570 Part 5 - Use GetParentAllowServo() related to first letter frame. r=bz
::first-letter is not support by stylo yet. (bug 1324618)

MozReview-Commit-ID: KwQk2jhn53c
2017-03-20 14:13:32 +08:00