Jason Prickett
d51e46b708
Bug 1953129 - Cap totalSearches pref at 100 r=omc-reviewers,urlbar-reviewers,mviar,jteow
...
Differential Revision: https://phabricator.services.mozilla.com/D241671
2025-03-18 23:08:15 +00:00
Moritz Beier
a1b188cce4
Bug 1817233 - Pasting urls with linebreaks into urlbar does not set valueIsTyped. r=urlbar-reviewers,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D240355
2025-03-05 15:01:41 +00:00
Emilio Cobos Álvarez
831e0b767e
Bug 1951284 - Fix a race condition in UrlbarInput.startLayoutExtend(). r=urlbar-reviewers,jteow
...
hasAttribute("breakout") isn't the right check for "do we support
breakout", since we might be in the middle of recomputing the breakout
dimensions (which removes the attribute temporarily).
Use this.#allowBreakout instead.
Differential Revision: https://phabricator.services.mozilla.com/D240111
2025-03-05 12:37:11 +00:00
Mark Banner
878a5d5415
Bug 1951652 - Convert browser/components/search/ modules to use moz-src uris. r=search-reviewers,scunnane
...
Differential Revision: https://phabricator.services.mozilla.com/D240333
2025-03-05 09:24:37 +00:00
Gijs Kruitbosch
8c703a7db2
Bug 1951072 - switch reader mode modules to use moz-src URLs, r=firefox-desktop-core-reviewers ,sync-reviewers,urlbar-reviewers,mossop,jteow,markh
...
Differential Revision: https://phabricator.services.mozilla.com/D240004
2025-03-04 21:20:35 +00:00
Daisuke Akatsuka
dee672b38c
Bug 1936557: Remove delayUpdate parameter and #searchInitComplete flag r=search-reviewers,daleharvey,Standard8
...
Depends on D239701
Differential Revision: https://phabricator.services.mozilla.com/D239702
2025-02-26 19:50:51 +00:00
Daisuke Akatsuka
a25636e1a5
Bug 1936557: Wait to update placeholder/icon until user interaction on booting r=sessionstore-reviewers,daleharvey,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D239701
2025-02-26 19:50:50 +00:00
Marco Bonardo
b1c63066f1
Bug 1945422 - Change Ctrl+Enter canonization to Cmd+Enter on MacOS, due to new Sequoia context menu shortcut. r=daisuke,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D238060
2025-02-20 14:06:22 +00:00
Goloman Adrian
89bb435086
Backed out changeset 6c1483bf5f26 (bug 1945422) for causing bc failures @browser_searchSuggestions.js. CLOSED TREE
2025-02-19 23:38:47 +02:00
Marco Bonardo
3c196e2f8a
Bug 1945422 - Change Ctrl+Enter canonization to Cmd+Enter on MacOS, due to new Sequoia context menu shortcut. r=daisuke,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D238060
2025-02-19 14:45:20 +00:00
Dale Harvey
e7bd680c67
Bug 1947742 - Prevent search actions overriding other actions. r=dao,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D238407
2025-02-17 21:48:21 +00:00
Meg Viar
7ecf60304b
Bug 1946517 - Prevent URL bar from showing through preonboarding modal UI r=nalexander,emilio,urlbar-reviewers,adw
...
Addresses issue where the URL bar appeared through the UI of the preonboarding modal (see screenshot in bug).
- Show the preonboarding after the "MozAfterPaint" event fires for the browser chrome.
- If for some reason the "MozAfterPaint" event never fires of the event listener was added after it fired, show the modal after 1 second as a fallback.
Differential Revision: https://phabricator.services.mozilla.com/D237100
2025-02-10 22:46:06 +00:00
kernp25
cb1f1d5155
Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
...
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Stephanie Cunnane
c9ddaf4b3d
Bug 1932716 - Remove legacy urlbar.tips scalar and Glean urlbar.tips labeled counter. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D236590
2025-02-07 14:53:12 +00:00
Emilio Cobos Álvarez
ab23c6cf79
Bug 1945451 - Avoid breaking out the urlbar while in customize mode. r=dao,urlbar-reviewers
...
Density changes called directly into the urlbar input to update the
breakout. But when customizing the urlbar shouldn't break out.
That means that this code is mostly for when density is changed via
another window, or direct pref changes I guess.
Differential Revision: https://phabricator.services.mozilla.com/D236539
2025-02-04 19:42:04 +00:00
Moritz Beier
152f732f88
Bug 1880913 - Part 3: Move open search handling from BrowserSearch to dedicated module. r=Standard8,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D235597
2025-02-04 11:07:12 +00:00
Moritz Beier
6c0a5096a8
Bug 1880913 - Part 1: Move urlbar placeholder handling from BrowserSearch to UrlbarInput. r=urlbar-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D235595
2025-02-04 11:07:11 +00:00
Butkovits Atila
b061588f31
Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE
2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a
Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
...
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
James Teow
e18fba3011
Bug 1941467 - Allow Scotch Bonnet pref to toggle Persisted Search preference visibility - r=daleharvey,settings-reviewers,mossop
...
I also removed the Nimbus feature since there are no future plans to
run experiments solely on this feature.
Differential Revision: https://phabricator.services.mozilla.com/D234135
2025-01-16 16:54:14 +00:00
Sandor Molnar
f776616d69
Backed out 2 changesets (bug 1297008) for causing M-vt failures @ browser_link_in_tab_title_and_url_prefilled_blank_page.js CLOSED TREE
...
Backed out changeset ce85088a9340 (bug 1297008)
Backed out changeset cd90c0935331 (bug 1297008)
2025-01-10 01:14:53 +02:00
Emma Zuehlcke
5ca6a4bb43
Bug 1297008, r=mak,Gijs,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D226694
2025-01-09 17:49:09 +00:00
Daisuke Akatsuka
82f19238e9
Bug 1936545: Close search mode switcher popup when opening new tab r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D233470
2025-01-08 22:06:49 +00:00
Dale Harvey
21f91aa3cb
Bug 1938036 - Dont maintain user input when selecting contextual engine. r=daisuke,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D232946
2025-01-08 12:55:19 +00:00
Yazan Al Macki
9724bc1d84
Bug 1936278 - Prevent search mode chiclet from being dismissed when clicking in page content. r=jteow
...
Differential Revision: https://phabricator.services.mozilla.com/D232365
2024-12-25 04:08:06 +00:00
Daisuke Akatsuka
abd3414bd9
Bug 1937363: Show/Focus Unified Search Button when P&S icon group gets focus r=desktop-theme-reviewers,urlbar-reviewers,dao,tabbrowser-reviewers,daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D232160
2024-12-24 04:02:25 +00:00
Cristian Tuns
568f68ebab
Backed out changeset de5d3f6c2e3e (bug 1936278) for causing bc failures in browser_searchModeSwitcher_emptyInput.js CLOSED TREE
2024-12-19 17:57:30 -05:00
Yazan Al Macki
82b17701af
Bug 1936278 - Prevent search mode chiclet from being dismissed when clicking in page content. r=jteow
...
Differential Revision: https://phabricator.services.mozilla.com/D232365
2024-12-19 19:38:50 +00:00
Daisuke Akatsuka
aafffaa930
Bug 1936090: Show/Hide Unified Search Button dependent on pageproxystate r=desktop-theme-reviewers,tabbrowser-reviewers,daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D231636
2024-12-11 21:35:57 +00:00
Yazan Al Macki
f73656a212
Bug 1919549 - Quit actions search mode after using quick actions in new tab page. r=urlbar-reviewers,jteow
...
Differential Revision: https://phabricator.services.mozilla.com/D230313
2024-12-06 19:03:26 +00:00
Daisuke Akatsuka
8c442be904
Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-12-05 07:13:31 +00:00
Norisz Fay
5caeaca8fe
Backed out 2 changesets (bug 1928132) for causing failures on browser_mouseout_notification_panel.js and Bug 1934387, Bug 1934388, Bug 1934389 CLOSED TREE
...
Backed out changeset 2ea4986f9eb8 (bug 1928132)
Backed out changeset 4a72ad308d0c (bug 1928132)
2024-11-30 15:43:28 +02:00
Daisuke Akatsuka
38412e4cd1
Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-11-29 21:24:53 +00:00
Goloman Adrian
2cd2737f6f
Backed out 2 changesets (bug 1928132) for causing bc failures browser_popupNotification_2.js. CLOSED TREE
...
Backed out changeset 5882194e7456 (bug 1928132)
Backed out changeset 0d13b91f55e0 (bug 1928132)
2024-11-29 15:18:36 +02:00
Daisuke Akatsuka
c738c0eb32
Bug 1928132: Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228954
2024-11-29 11:18:02 +00:00
Manuel Bucher
53e7c24e8d
Bug 1924493 - Copy without site tracking: Rename to "Copy Clean Link" r=anti-tracking-reviewers,fluent-reviewers,urlbar-reviewers,flod,dao,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D230251
2024-11-28 11:40:11 +00:00
Yazan Al Macki
579f372259
Bug 1923686 - Exit search mode for non app-provided search engines. r=jteow,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D229158
2024-11-20 01:17:09 +00:00
Florian Quèze
48a799d50d
Bug 1927093 - Migrate scalars to use Glean APIs for contextual.services.topsites.*, r=chutten,urlbar-reviewers,jteow,Standard8,home-newtab-reviewers,thecount.
...
Differential Revision: https://phabricator.services.mozilla.com/D227815
2024-11-15 11:53:39 +00:00
Simon Friedberger
4fcd691190
Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 17:15:57 +00:00
Sandor Molnar
9e0c14a80e
Backed out changeset c4dfee1f9194 (bug 1919544) for causing bc failures @ browser_UrlbarInput_formatValue.js CLOSED TREE
2024-11-13 15:20:39 +02:00
Simon Friedberger
8eafd874fe
Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 11:44:43 +00:00
Daisuke Akatsuka
708d0195d5
Bug 1925532: Enter search mode without preview mode by key if there is single result r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D226865
2024-11-11 22:19:45 +00:00
Daisuke Akatsuka
c2f5c3753c
Bug 1921731: Keep actions' layout until changing the results r=urlbar-reviewers,daleharvey,adw
...
Differential Revision: https://phabricator.services.mozilla.com/D226107
2024-11-11 05:44:29 +00:00
James Teow
935394d9f6
Bug 1927113 - Ensure persisted search doesn't show search mode from another tab - r=adw,urlbar-reviewers
...
this.searchMode can return null even if a search mode is shown
in the address bar, as the getter uses the current browser as the
context and attempts to use the state data. I try to solve this
by relying on the fact that a tab switch and invalid pageproxystate
results in restoring the search mode state.
Differential Revision: https://phabricator.services.mozilla.com/D228483
2024-11-08 23:04:24 +00:00
Marco Bonardo
f13efc6b93
Bug 1925496. r=jfkthame,adw
...
Differential Revision: https://phabricator.services.mozilla.com/D228315
2024-11-08 13:50:43 +00:00
Dale Harvey
d6bf7c5a2d
Bug 1926241 - Provide tab-to-search results via actions. r=urlbar-reviewers,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D227236
2024-11-08 13:35:12 +00:00
Alexandru Marc
e2fa59c2ee
Backed out changeset 40518e514fc1 (bug 1925496) for causing bc failures @ browser_copying.js . CLOSED TREE
2024-11-08 14:51:02 +02:00
Marco Bonardo
4a15af511c
Bug 1925496. r=jfkthame,adw
...
Differential Revision: https://phabricator.services.mozilla.com/D228315
2024-11-08 10:43:36 +00:00
Florian Quèze
e704e70b3b
Bug 1927093 - Migrate scalars to use Glean APIs for urlbar.*, r=chutten,urlbar-reviewers,mak.
...
Differential Revision: https://phabricator.services.mozilla.com/D226513
2024-11-05 13:22:58 +00:00
Emilio Cobos Álvarez
a1ae05d74e
Bug 1928255 - Fix bug 1927111 in a better way. r=urlbar-reviewers,mak
...
Keep using the static position as we did before. As long as we don't
have anchor positioning this seems better than whack-a-mole-ing every
possible urlbar position change.
In order to make the fullscreen animation work, make our position
computation ignore transforms, which is how anchor positioning would
behave anyways.
Differential Revision: https://phabricator.services.mozilla.com/D227758
2024-11-04 16:11:58 +00:00