corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
863,346 Commits 1 Branch 0 Tags
d48bff0b3e786cb15c63caa06c0e2380ad84c0ab
Commit Graph

624 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
76e9b5e83c Bug 1850293 - Make CHECKED/DEFAULT states not intrinsic. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D186933
 2023-08-30 09:18:31 +00:00
Emilio Cobos Álvarez
3e9e56e2c8 Bug 1850293 - Make editable states not intrinsic. r=smaug,masayuki 
This one is tricky because form controls, though I think I got it right...

This fixes a pre-existing bug where we're not following the spec for readonly
inside content-editable.

I filed this as bug 1850390 but other browsers match the spec so add a test and
fix it while at it. This allows cheaper checks for readonlyness in a couple
places.

Differential Revision: https://phabricator.services.mozilla.com/D186896
 2023-08-30 09:18:31 +00:00
Emilio Cobos Álvarez
393b3c94fc Bug 1850293 - Make directionality state not intrinsic. r=smaug 
Allows us to reclaim some node bits too.

Differential Revision: https://phabricator.services.mozilla.com/D186893
 2023-08-28 23:39:11 +00:00
Markus Stange
a4e2816d54 Bug 1843484 - Use EventTarget* instead of nsISupports* for the event target parameter of the EventDispatcher::Dispatch methods. r=smaug 
This saves a few QueryInterface calls on the hot path.

Differential Revision: https://phabricator.services.mozilla.com/D186977
 2023-08-28 23:38:43 +00:00
Ziran Sun
5b9fbf874d Bug 1849689 - Initial steps on handling Esc key for popover. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D186643
 2023-08-28 07:47:24 +00:00
Ziran Sun
d66cffcec1 Bug 1841270 - refine focus handling in HidePopover. r=emilio 
Only run focusing steps for previouslyFocusedElement if focus is within the
popover hierarchy.

Differential Revision: https://phabricator.services.mozilla.com/D186439
 2023-08-21 07:06:13 +00:00
renevietnam29@gmail.com
ab6d41fe33 Bug 1842987 Remove dom.forms.enterkeyhint r=emilio,geckoview-reviewers,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D184620
 2023-08-14 13:52:35 +00:00
Peter Van der Beken
c10814e75a Bug 1846277 - Remove nsGlobalWindow.h. r=dom-core,necko-reviewers,jesup,farre 
Differential Revision: https://phabricator.services.mozilla.com/D184973
 2023-08-02 20:41:48 +00:00
Emilio Cobos Álvarez
ec9b2f185b Bug 1844195 - Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame 
We need to inline Self::new() so cbindgen generates the constants, which
is kinda lame, but seems better than duplicating the values and type
definitions.

Differential Revision: https://phabricator.services.mozilla.com/D183921
 2023-07-26 06:46:32 +00:00
Iulian Moraru
fc6f8616c7 Backed out changeset f3394bd0f554 (bug 1844195) for causing conflicts with another backout. 2023-07-26 04:00:57 +03:00
Emilio Cobos Álvarez
6e3644cb06 Bug 1844195 - Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame 
We need to inline Self::new() so cbindgen generates the constants, which
is kinda lame, but seems better than duplicating the values and type
definitions.

Differential Revision: https://phabricator.services.mozilla.com/D183921
 2023-07-25 21:14:39 +00:00
Iulian Moraru
9a59c751eb Backed out changeset 3a3f2d5937c4 (bug 1844195) for causing mass failures. CLOSED TREE 2023-07-25 23:07:30 +03:00
Emilio Cobos Álvarez
3e03187a1e Bug 1844195 - Avoid duplicating rust and C++ display definitions. r=layout-reviewers,jfkthame 
We need to inline Self::new() so cbindgen generates the constants, which
is kinda lame, but seems better than duplicating the values and type
definitions.

Differential Revision: https://phabricator.services.mozilla.com/D183921
 2023-07-25 18:40:30 +00:00
Sandor Molnar
24e7457734 Backed out 2 changesets (bug 1843035) for causing assertion failures in dom/html/nsGenericHTMLElement.cpp CLOSED TREE 
Backed out changeset d44bf85938f0 (bug 1843035)
Backed out changeset 238e99b4449c (bug 1843035)
 2023-07-18 17:30:09 +03:00
Mirko Brodesser
0f87fa519a Bug 1843035: part 2) Assert correctness of popover attribute state at all relevant callers of GetPopoverAttributeState(). r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D183477
 2023-07-18 08:57:26 +00:00
Mirko Brodesser
9dc774c63c Bug 1843035: part 1) Align unbinding a popover node from the tree closer to the spec. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D183381
 2023-07-18 08:57:25 +00:00
Vincent Hilla
64645ecc84 Bug 1814310 - Improve runtime of nsGenericHTMLFormElement::UpdateFormOwner. r=smaug 
Avoid intermediate DOMString in GetAttr, optimize calls to GetFormInternal.

Differential Revision: https://phabricator.services.mozilla.com/D182789
 2023-07-17 13:35:34 +00:00
Ziran Sun
659099f91f Bug 1842845 - Update the togglePopover function to follow the spec updates. r=emilio 
https://html.spec.whatwg.org/multipage/popover.html#dom-togglepopover

Differential Revision: https://phabricator.services.mozilla.com/D183572
 2023-07-17 08:21:41 +00:00
Mirko Brodesser
5beede8d62 Bug 1841505: postpone setting the popover invoker in the "show popover" algo. r=emilio 
See
<https://github.com/whatwg/html/issues/9383#issuecomment-1602227494>.

Differential Revision: https://phabricator.services.mozilla.com/D182709
 2023-07-12 10:12:23 +00:00
Ziran Sun
9fa33c2381 Bug 1840342 - Throw exception when popover attribute changes during beforetoggle in showpopover. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D182871
 2023-07-07 13:30:21 +00:00
Butkovits Atila
1966a0a941 Backed out changeset c1e40169afd9 (bug 1838450) for causing failures at nsGenericHTMLElement.cpp. 2023-07-04 15:47:36 +03:00
Ziran Sun
10a0c38bc8 Bug 1838450 - Refine attribute handling. r=emilio 
https://github.com/whatwg/dom/pull/1176
https://dom.spec.whatwg.org/#concept-element-attributes-change-ext
"attribute change steps"  at https://html.spec.whatwg.org/multipage/popover.html#attr-popover

Differential Revision: https://phabricator.services.mozilla.com/D181880
 2023-07-04 08:47:31 +00:00
avandolder
f102e83b63 Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar 
Differential Revision: https://phabricator.services.mozilla.com/D174115
 2023-06-28 04:31:22 +00:00
Emilio Cobos Álvarez
529c9ee321 Bug 1839922 - Remove usage of {Has,Get}Attr(kNameSpaceID_None, ..). r=edgar 
We have more readable and faster versions (that just omit the namespace
arg).

Mostly done via sed, with a couple helpers to use the faster lookups
where possible.

Differential Revision: https://phabricator.services.mozilla.com/D181795
 2023-06-23 10:01:32 +00:00
Peter Van der Beken
8422291d23 Bug 1825745 - Fix intermittent failure of testing/web-platform/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D180534
 2023-06-22 18:32:21 +00:00
Emilio Cobos Álvarez
a1007b18c6 Bug 1839223 - Remove nsMappedAttributes. r=smaug 
Instead, lazily schedule evaluation of them before styling, much like we
were doing for SVG.

A subtle tweak is that we only remain scheduled while in the document.
This allows us to use the "in document" bit plus the "mapped attributes
dirty" bit to know our scheduled status. It also prevents doing silly
work for disconnected elements, and having to do hashmap lookups on
adoption and node destruction.

Differential Revision: https://phabricator.services.mozilla.com/D181549
 2023-06-22 17:22:03 +00:00
Cristian Tuns
f54a728824 Backed out changeset a3e55d5f9f13 (bug 1839223) for causing multiple failures in Document.cpp CLOSED TREE 2023-06-22 11:34:15 -04:00
Emilio Cobos Álvarez
a28183ac0e Bug 1839223 - Remove nsMappedAttributes. r=smaug 
Instead, lazily schedule evaluation of them before styling, much like we
were doing for SVG.

A subtle tweak is that we only remain scheduled while in the document.
This allows us to use the "in document" bit plus the "mapped attributes
dirty" bit to know our scheduled status. It also prevents doing silly
work for disconnected elements, and having to do hashmap lookups on
adoption and node destruction.

Differential Revision: https://phabricator.services.mozilla.com/D181549
 2023-06-22 14:31:16 +00:00
Noemi Erli
0a8db96d7f Backed out 2 changesets (bug 1825745) for causing failures in form-requestsubmit.html CLOSED TREE 
Backed out changeset eb77df0ccca6 (bug 1825745)
Backed out changeset 2ce4ceb5a39d (bug 1825745)
 2023-06-22 16:35:27 +03:00
Peter Van der Beken
80f6668b4e Bug 1825745 - Fix intermittent failure of testing/web-platform/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D180534
 2023-06-22 08:07:06 +00:00
Emilio Cobos Álvarez
041813713e Bug 1839255 - Clean up a bit the mapped attribute set-up. r=smaug 
This doesn't change behavior on its own. It could be split up a bit more
if needed though over all it shouldn't be hard to follow.

Unify nsHTMLStyleSheet and nsHTMLCSSStyleSheet into AttributeStyles
because the fact that we have two right now is pretty silly. They are
also not stylesheets (they used to be pre-stylo).

Differential Revision: https://phabricator.services.mozilla.com/D181414
 2023-06-20 10:02:44 +00:00
Ziran Sun
57898e14ae Bug 1835464 - Check dialog is modal flag instead of open attribute in 'check popover validity' algorithm. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D181089
 2023-06-20 08:49:32 +00:00
Iulian Moraru
946fa366f4 Backed out changeset 9fb58fa7b8b6 (bug 1556358) for causing wpt failures on ElementInternals-setFormValue.html. CLOSED TREE 2023-06-20 08:16:50 +03:00
avandolder
ebc03e8550 Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar 
Differential Revision: https://phabricator.services.mozilla.com/D174115
 2023-06-20 01:29:58 +00:00
Natalia Csoregi
0b693ec882 Backed out changeset 08f12e7fa5f0 (bug 1556358) for causing bustage on ElementInternals.cpp. CLOSED TREE 2023-06-19 21:15:17 +03:00
avandolder
23dce8037c Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar 
Differential Revision: https://phabricator.services.mozilla.com/D174115
 2023-06-19 17:22:01 +00:00
Norisz Fay
496c99b742 Backed out changeset 1680323680fe (bug 1556358) for causing Bb bustages on ElementInternals.cpp CLOSED TREE 2023-06-19 18:33:35 +03:00
Adam Vandolder
c1d69f579f Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar 
Depends on D175542

Differential Revision: https://phabricator.services.mozilla.com/D174115
 2023-06-19 13:44:15 +00:00
Stanca Serban
3b192df9e2 Backed out 3 changesets (bug 1556358) for causing Bb build bustages in ElementInternals.cpp. CLOSED TREE 
Backed out changeset f7e94ea82252 (bug 1556358)
Backed out changeset c80f29a9cefc (bug 1556358)
Backed out changeset 413225d91666 (bug 1556358)
 2023-06-16 19:46:02 +03:00
Adam Vandolder
de0a2c439f Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar 
Depends on D175542

Differential Revision: https://phabricator.services.mozilla.com/D174115
 2023-06-16 15:02:11 +00:00
Cathie Chen
7dab75f453 Bug 1837360 - Popover: Align to the update of specification regarding nested popover, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D181121
 2023-06-16 13:59:43 +00:00
Noemi Erli
4d4d467468 Backed out 3 changesets (bug 1556358) for causing bustages in ElementInternals.cpp CLOSED TREE 
Backed out changeset 0ebda393786b (bug 1556358)
Backed out changeset c41794eef66a (bug 1556358)
Backed out changeset a07e3e226569 (bug 1556358)
 2023-06-15 01:32:38 +03:00
Adam Vandolder
138ee92ee6 Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar 
Depends on D175542

Differential Revision: https://phabricator.services.mozilla.com/D174115
 2023-06-14 20:59:29 +00:00
Kagami Sascha Rosylight
7a8aeae82a Bug 1829874 - Allow events on disabled fieldsets r=edgar 
The HTML spec does not allow fieldset to be "disabled as a form control". The spec does not explicitly define whether fieldset is a form control or not (and thus can be disabled as a child of another fieldset), but here we assume it does not as:

* It's not a "control", right?
* It would be confusing if it could not be disabled by its own but could be disabled as a child.

Differential Revision: https://phabricator.services.mozilla.com/D179986
 2023-06-13 13:11:20 +00:00
Cosmin Sabou
11fb0af2c3 Backed out changeset 487a29bd817e (bug 1829874) for fieldset related mochitest failures. 2023-06-13 15:30:05 +03:00
Kagami Sascha Rosylight
bb4f2f36b2 Bug 1829874 - Allow events on disabled fieldsets r=edgar 
The HTML spec does not allow fieldset to be "disabled as a form control". The spec does not explicitly define whether fieldset is a form control or not (and thus can be disabled as a child of another fieldset), but here we assume it does not as:

* It's not a "control", right?
* It would be confusing if it could not be disabled by its own but could be disabled as a child.

Differential Revision: https://phabricator.services.mozilla.com/D179986
 2023-06-13 11:30:18 +00:00
Ziran Sun
244d435de7 Bug 1833570 - Reset the popover invoker in showPopover(). r=emilio 
As discussed in [1], we need to reset invoker in showPopover(). If not,
It's possible that a closed popover still has an invoker.

[1] https://github.com/whatwg/html/issues/9152

Differential Revision: https://phabricator.services.mozilla.com/D179195
 2023-06-06 10:50:33 +00:00
Vincent Hilla
366864bd8a Bug 675943 - Part 3: Clean up after implementing dirname. r=edgar 
Depends on D178164

Differential Revision: https://phabricator.services.mozilla.com/D178278
 2023-06-06 07:51:37 +00:00
Ziran Sun
a8187d4437 Bug 1833570 - Correct the handling of popovertargetaction value. r=emilio 
The popovertargetaction attribute's invalid value default and missing value default are both the toggle state.

https://html.spec.whatwg.org/#popover-target-attribute-activation-behavior

Differential Revision: https://phabricator.services.mozilla.com/D179050
 2023-06-05 12:30:10 +00:00
Cathie Chen
0c512df4dc Bug 1835671 - Popover: add repeatingHide to hide all popovers until algorithm, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D179454
 2023-06-02 15:01:48 +00:00