Commit Graph

4431 Commits

Author SHA1 Message Date
Eemeli Aro
bb6c36b409 Bug 1793581 - Convert ContentCrashHandlers.jsm strings to Fluent. r=gsvelto,fluent-reviewers,flod
Relevant strings from both browser.ftl and browser.properties are collected into a new contentCrash.ftl, which is only loaded when needed.

Differential Revision: https://phabricator.services.mozilla.com/D158649
2022-10-06 12:07:11 +00:00
nchevobbe
7d2ef3026a Bug 1778959 - Tweaks to PermissionUI to delegate gated site permissions request flows to synthetic SitePermsAddon install flow. r=permissions-reviewers,pbz
This patch includes a new `PermissionUI.SitePermsAddonInstallRequestPrototype` helper, it inherits from `PermissionPromptForRequestPrototype`
and override the `prompt` method to trigger the synthetic `SitePermsAddon` install flow when a addon gated site permissions is requested
(currently only "midi" and "midi-sysex").

The new `SitePermsAddonInstallRequestPrototype` helper is then set as the `__proto__` for the `MIDIPermissionPrompt.prototype`, which
makes sure that every time the MIDI site permissions are being requested, the user is prompted to install a synthetic addon
as part of the site permission request.

When the `dom.sitepermsaddon-provider.enabled` pref is set to `false`,
or when we're dealing with a `file` scheme, we fall back to `PermissionPromptForRequestPrototype.prompt`.

Differential Revision: https://phabricator.services.mozilla.com/D151478
2022-09-30 22:07:19 +00:00
Julian Descottes
a5d45be31c Bug 1790471 - [marionette] Convert /remote/marionette JSM modules to ESM r=webdriver-reviewers,whimboo
Depends on D158295

Differential Revision: https://phabricator.services.mozilla.com/D158296
2022-09-30 11:08:08 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Mark Banner
c34ea601d2 Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D157471
2022-09-28 09:40:36 +00:00
Emilio Cobos Álvarez
4ab80589c9 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
2022-09-27 04:18:16 +00:00
Marian-Vasile Laza
338fc0a451 Backed out changeset 2f74f8f2ed19 (bug 1689816) for causing reftest failures on skip-ink-multiline-position.html. 2022-09-26 23:24:03 +03:00
Emilio Cobos Álvarez
ba878e30c1 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
2022-09-26 17:40:30 +00:00
Mathew Hodson
f84488ba91 Bug 1776578 - Replace init tasks with add_setup in mochitests. r=application-update-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D149486
2022-09-26 13:58:49 +00:00
Kirk Steuber
448ce07dc3 Bug 1756450 - Add test for updater's new internalError state r=bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D157999
2022-09-23 19:47:34 +00:00
Kirk Steuber
53c3140034 Bug 1756450 - Handle AppUpdater exceptions via new INTERNAL_ERROR state r=bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D156999
2022-09-23 19:47:33 +00:00
Kirk Steuber
ff6db15116 Bug 1756450 - Add AppUpdater.STATUS.INTERNAL_ERROR r=bhearsum,fluent-reviewers,preferences-reviewers,desktop-theme-reviewers,flod
This patch adds a state to AppUpdater to represent when an internal error has occurred. It also adds the appropriate code to the Update UI to be able to handle this state, along with a panel in each UI and a string that can go in the panels to convey to the user that update has failed.

Ideally, it would be good if this message also directed the user to a SUMO article. See Bug 1787309 for details on this. But at the moment, I would prefer to address Bug 1756450 quickly rather than wait for that to be ready.

Differential Revision: https://phabricator.services.mozilla.com/D156998
2022-09-23 19:47:33 +00:00
Evan
7be0d917de Bug 1788783 -Converted Picture in Picture JSM modules to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157039
2022-09-23 18:11:48 +00:00
Jonathan Sudiaman
febfadf50b Bug 1790758 - Convert Region.jsm and IgnoreLists.jsm JSM modules to ESMs r=Standard8,preferences-reviewers,credential-management-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157337
2022-09-20 12:21:45 +00:00
Nicholas Rishel
140b0f02a3 Bug 1789390 - Remove scheduled and Action Center notifications during uninstall. r=nalexander
Non-MSIX notifications are not removed when Firefox is uninstalled. To handled this we've added a new `uninstall` background task and extended `nsIWindowsAlertService` to deregister notifications on uninstall.

Differential Revision: https://phabricator.services.mozilla.com/D156625
2022-09-14 00:42:43 +00:00
Tooru Fujisawa
312eba66ce Bug 1790577 - Reset the tab drop indicator in tabs list. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D157197
2022-09-13 17:33:58 +00:00
Iulian Moraru
f8926a3448 Backed out 2 changesets (bug 1789390) for causing bc failures regarding unreferenced file on BackgroundTask_uninstall.jsm. CLOSED TREE
Backed out changeset 4cec525d92f4 (bug 1789390)
Backed out changeset 6fcec3502cb2 (bug 1789390)
2022-09-13 13:20:20 +03:00
Nicholas Rishel
7ff5d79899 Bug 1789390 - Remove scheduled and Action Center notifications during uninstall. r=nalexander
Non-MSIX notifications are not removed when Firefox is uninstalled. To handled this we've added a new `uninstall` background task and extended `nsIWindowsAlertService` to deregister notifications on uninstall.

Differential Revision: https://phabricator.services.mozilla.com/D156625
2022-09-13 06:09:30 +00:00
William Durand
4a4c05ab8a Bug 1789407 - Always anchor defaultsearch popup to the urlbar. r=rpl
Depends on D156960

Differential Revision: https://phabricator.services.mozilla.com/D156952
2022-09-09 18:50:32 +00:00
William Durand
e95af623c6 Bug 1790015 - Re-align extension popups when anchored to the unified extensions button. r=rpl
We cannot fully remove `popupOptions` because that wouldn't position the popups correctly in RTL mode.

Differential Revision: https://phabricator.services.mozilla.com/D156960
2022-09-09 17:41:39 +00:00
Tooru Fujisawa
8950416b74 Bug 1788782 - Limit the top of drop indicator to the parent box. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D156253
2022-09-06 03:50:52 +00:00
Tooru Fujisawa
f015fe18ad Bug 1788778 - Part 3: Use the same algorithm as tab bar to detect drag leave. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D156252
2022-09-06 03:50:52 +00:00
Tooru Fujisawa
ac2b5373cf Bug 1788778 - Part 1: Remove unnecessary call for _clearDropTarget in TabsPanel. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D156250
2022-09-06 03:50:51 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Tooru Fujisawa
ca98419193 Bug 1771831 - Make it possible to reorder tabs in "List all tabs" list by drag-and-drop. r=NeilDeakin
Also the tab list item can be dragged to the tab bar to reorder, or moved to
other window, or detached.

Differential Revision: https://phabricator.services.mozilla.com/D147709
2022-08-31 13:22:53 +00:00
Butkovits Atila
3f8c432241 Backed out changeset f47d9c27992d (bug 1771831) for causing failures at browser_tabdetach.js. CLOSED TREE 2022-08-31 03:54:04 +03:00
Tooru Fujisawa
2736be1ef4 Bug 1771831 - Make it possible to reorder tabs in "List all tabs" list by drag-and-drop. r=NeilDeakin
Also the tab list item can be dragged to the tab bar to reorder, or moved to
other window, or detached.

Differential Revision: https://phabricator.services.mozilla.com/D147709
2022-08-30 22:49:43 +00:00
Butkovits Atila
8594347f5a Backed out 2 changesets (bug 1676492) for causing failures at test_navigation.py. CLOSED TREE
Backed out changeset 09fd88048f35 (bug 1676492)
Backed out changeset bc76e6966ec9 (bug 1676492)
2022-08-30 20:56:51 +03:00
Neil Deakin
7f8f002700 Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D155003
2022-08-30 14:02:02 +00:00
Marco Bonardo
593fab652b Bug 1782854 - Don't store local uri favicons after pageShow. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D155217
2022-08-23 15:46:05 +00:00
Butkovits Atila
e9ff93e53f Backed out changeset 924abe0bf6fd (bug 1772180) for causing failures at browser_UnsubmittedCrashHandler.js. CLOSED TREE 2022-08-23 18:35:21 +03:00
Barret Rennie
4a2672304c Bug 1772180 - Port osfile.jsm usage to IOUtils in browser/modules/ r=Gijs
This patch changes calls to set access time to calls to set last modified time,
*but* setting lastModifiedTime will set both.

Differential Revision: https://phabricator.services.mozilla.com/D153697
2022-08-23 14:50:05 +00:00
Narcis Beleuzu
827876d722 Backed out changeset 64f9bfbf800e (bug 1782854) for dt failure on browser_aboutdebugging_tab_favicons.js 2022-08-22 20:47:07 +03:00
Marco Bonardo
5ed2c237f8 Bug 1782854 - Don't store local uri favicons after pageShow. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D155217
2022-08-22 16:29:37 +00:00
Max Christian Pohle
380a78b4ec Bug 1779314: Add logging to the updater interface code r=bytesized,application-update-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D154658
2022-08-19 14:37:33 +00:00
William Durand
64389ba498 Bug 1784292 - Anchor extension popups to the unified extensions button. r=mconley,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D154408
2022-08-19 06:25:13 +00:00
Emilio Cobos Álvarez
a8c8a0d2eb Bug 1785053 - Add comments that I forgot to upload to phabricator. DONTBUILD
MANUAL PUSH: Comment-only change.
2022-08-17 14:18:22 +02:00
Emilio Cobos Álvarez
dde46548e7 Bug 1785053 - Only dispatch permission state changes when permissions actually change. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D154788
2022-08-16 15:32:32 +00:00
Benjamin VanderSloot
075b335490 Bug 1777497, part 1 - Change StorageAccessPermissionRequest to allow an option specifying the top level domain, r=anti-tracking-reviewers,pbz
Differential Revision: https://phabricator.services.mozilla.com/D151278
2022-08-12 16:12:05 +00:00
Stephanie Cunnane
413b509453 Bug 1770818 - Focus the address bar when opening a new window with a custom new window URL configured. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D151946
2022-08-11 22:05:35 +00:00
Norisz Fay
bd01b00d6d Backed out 5 changesets (bug 1777497, bug 1782526) for causing build bustages on PContent.ipdl CLOSED TREE
Backed out changeset 64e16a70484e (bug 1782526)
Backed out changeset 381806d5afc3 (bug 1777497)
Backed out changeset 820f6f9c9cc3 (bug 1777497)
Backed out changeset f541ad605d6d (bug 1777497)
Backed out changeset 620681c22b83 (bug 1777497)
2022-08-11 03:20:29 +03:00
Benjamin VanderSloot
c569d80b23 Bug 1777497, part 1 - Change StorageAccessPermissionRequest to allow an option specifying the top level domain, r=anti-tracking-reviewers,pbz
Differential Revision: https://phabricator.services.mozilla.com/D151278
2022-08-11 00:04:38 +00:00
Mike Conley
7b4982e14e Bug 1783918 - Part 4: Plumb trigger event through to calls to webrtcUI.showSharingDoorhanger and have it call openPopup directly. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D154130
2022-08-10 15:05:33 +00:00
Mark Banner
19b7fb742e Bug 1782659 - Enable ESlint rule no-unused-vars on the global scope for browser/ xpcshell-tests. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D153433
2022-08-05 08:38:50 +00:00
Mark Banner
5a172d1076 Bug 1782991 - Avoid an error in BrowserUsageTelemetry when clicking in the search shortcuts table in preferences. r=Gijs
This detects if we've got to the parent document and if so, exits early - we don't appear to collect clicks on the parent document, so no need to go further.

Differential Revision: https://phabricator.services.mozilla.com/D153610
2022-08-03 14:47:52 +00:00
Iulian Moraru
1436900eb0 Backed out 5 changesets (bug 1782526, bug 1777497) for causing gv-junit failures.
Backed out changeset bb4451a7b19c (bug 1782526)
Backed out changeset cbc8344b02ac (bug 1777497)
Backed out changeset 85e6b889e139 (bug 1777497)
Backed out changeset a64c8ee85a42 (bug 1777497)
Backed out changeset fd74aafff8a7 (bug 1777497)
2022-08-02 02:45:32 +03:00
Benjamin VanderSloot
d04aaabf57 Bug 1777497, part 1 - Change StorageAccessPermissionRequest to allow an option specifying the top level domain, r=anti-tracking-reviewers,pbz
Differential Revision: https://phabricator.services.mozilla.com/D151278
2022-08-01 21:26:59 +00:00
Daisuke Akatsuka
7e4536e9fd Bug 1776609: Record source and triggeringPlaceId for sponsored tile on newtab. r=mak,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D150729
2022-08-01 00:27:50 +00:00