Commit Graph

485 Commits

Author SHA1 Message Date
Mike de Boer
55a1cbe966 Bug 1120110 - Consistently save pages bookmarked using 'Bookmark This Page' anywhere into the 'Other Bookmarks' folder. r=mak
Since we're not passing an optional parent folder around anymore, this patch also
removes PlacesCommandHook.bookmarkCurrentPage() in favor of a simplified
PlacesCommandHook.bookmarkPage() signature.

MozReview-Commit-ID: HmzwmATgQyw
2017-10-23 14:10:04 +02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
9ef3115a9b Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown, r=mikedeboer
MozReview-Commit-ID: 1zesvAmYkAM
2017-10-04 11:49:14 +01:00
Jared Wein
1d711432fe Bug 1403550 - Update the X offset of the library button when the window is resized. r=sfoster
MozReview-Commit-ID: J3XpTOZwO1Y
2017-09-27 12:40:04 -04:00
Drew Willcoxon
e3b9b7a9a0 Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs
MozReview-Commit-ID: JMviXx5ov7F
2017-09-25 13:30:08 -07:00
Gijs Kruitbosch
07dfbf4aaf Bug 1401238 - remove recent bookmarks from the bookmarks menu button and toplevel bookmarks menu, r=mak
MozReview-Commit-ID: 7JT9xCq9zcS
2017-09-20 00:38:39 +01:00
Gijs Kruitbosch
cbee9f0379 Bug 1397790 - add 'open' active state to urlbar buttons, use a more distinct background colour for it, r=abenson+572682,adw
MozReview-Commit-ID: 7QrhAB79yNw
2017-09-19 15:13:25 +01:00
Tawny Hoover
621b5e9802 Bug 260611 - Introduce pref browser.bookmarks.openInTabClosesMenu to optionally leave menu open for single bookmark menuitem clicks that open in new tab. r=mak
MozReview-Commit-ID: HreM02pdzWP
2017-09-11 12:12:21 -04:00
Jared Wein
c23fe136ee Bug 1399651 - Don't run the library animations in popup windows with toolbar=false. r=Gijs
MozReview-Commit-ID: 2vswZ2BTFwp
2017-09-13 19:37:43 -04:00
Drew Willcoxon
db557af3c5 Bug 1386745 - Activated URL/address/location bar makes bookmark doorhanger/panelUI located under "Show site information" button area after landing patch from bug #1352063. r=Gijs
MozReview-Commit-ID: Kzymx5qbp4i
2017-09-08 10:16:38 -07:00
Marco Bonardo
f5fe23e92e Bug 1398019 - Favicons missing in Bookmarks toolbar on startup. r=past
This is due to the fact now we set the icons only when the nodes visibility is updated.
The patch always updates nodes visibility when we rebuild the toolbar.
updateChevron() is being renamed accordingly and acts regardless of chevron.collapsed.

MozReview-Commit-ID: Cz1U710J42M
2017-09-08 11:43:08 +02:00
Jared Wein
be84de2851 Bug 1394588 - Include the gNavToolbox offset in the calculation of the library drop animation. r=Gijs
MozReview-Commit-ID: 90eUNtqE0ee
2017-09-05 14:50:52 -04:00
Jared Wein
58025da720 Bug 1397236 - Changing positioning of navigator-toolbox while a descendent popup is open causes the popup to close. We don't need to change the positioning of the navigator-toolbox on the fly, and can instead always keep it as position:relative for the library animation. r=Gijs
MozReview-Commit-ID: HXbjhQFCplb
2017-09-07 03:46:46 -04:00
Mark Banner
3cdc0023ed Bug 1397545 - Don't update the recently bookmarks item list when it is hidden and a bookmark is deleted. r=mak
MozReview-Commit-ID: CnbFMONaRil
2017-09-07 10:49:03 +01:00
Marco Bonardo
3b2c91b45f Bug 1392081 - Reset the Places toolbar view when the toolbar is collapsed. r=Gijs
MozReview-Commit-ID: IFOxCnslZRX
2017-08-29 23:26:24 +02:00
Sebastian Hengst
f0933e3032 Backed out changeset cf5b68506bef (bug 1392081) 2017-09-05 23:11:08 +02:00
Marco Bonardo
a26e5c816a Bug 1392081 - Reset the Places toolbar view when the toolbar is collapsed. r=Gijs
MozReview-Commit-ID: IFOxCnslZRX
2017-08-29 23:26:24 +02:00
Jared Wein
23660f4b81 Bug 1393565 - De-duplicate the JS code and CSS that sets the bookmark and pocket library animation. r=Gijs
MozReview-Commit-ID: Z1kIdrY2Um
2017-08-30 15:58:24 -04:00
Jared Wein
1512715f63 Bug 1395438 - The bookmarks panel should fade out when it times out, not close abruptly. r=adw
MozReview-Commit-ID: 2alzsK8M9Xb
2017-08-31 00:27:07 -04:00
Dão Gottwald
679bcc9530 Bug 1394753 - Remove unstarred48.png. r=mak
MozReview-Commit-ID: EKUEQsOxy50
2017-08-29 11:51:12 +02:00
Mark Banner
fd48516f32 Bug 1388687 - Change the recent bookmarks object to only update the menu items when really necessary, and only do a database query when the recent bookmarks need updating. r=mak
MozReview-Commit-ID: J4WxNoTPxkc
2017-08-21 16:05:30 +01:00
Mark Banner
adbe3fd7d8 Bug 1388687 - Split out inline functions into members of RecentBookmarksMenuUI to make testing/updates easier. r=mak
MozReview-Commit-ID: 1qD7xmlGa8y
2017-08-10 08:27:36 +01:00
Mark Banner
e438f9ac12 Bug 1388687 - Separate out the recent bookmarks menu code into its own object. r=mak
MozReview-Commit-ID: EhNk4cDLbAH
2017-08-09 11:07:50 +01:00
Jared Wein
a28e15e6eb Bug 1384953 - Run the library and pocket animations outside of the navigation-toolbar to workaround z-index issues with the selected tab. r=gijs
MozReview-Commit-ID: dXVThUXdXi
2017-08-09 20:36:17 -04:00
Dão Gottwald
e5a3be9f0f Bug 1391017 - Use a .bookmark-item placeholder for the bookmarks toolbar items in the toolbar while customizing. r=Gijs
MozReview-Commit-ID: JB9OSshDLKy
2017-08-23 13:01:06 +02:00
Mike de Boer
ab742ae535 Bug 1377968 - Add a tools section and subview to the Bookmarks subview inside the Library widget. r=Gijs
MozReview-Commit-ID: GqbUMbuvYoO
2017-08-15 13:34:41 +02:00
Ursula Sarracini
9d24d45965 Bug 1388863 - Bookmarking a link via Activity Stream context menu should give feedback r=adw
MozReview-Commit-ID: Bd2eed1rX91
2017-08-14 16:27:39 -04:00
Valentin Gosu
7a666609d4 Bug 1380617 - Change firefox code to use uri.displaySpec when unicode URLs are wanted r=Gijs
* Make URL bar show unicode URL by making losslessDecodeURI call uri.displaySpec
* Make sure URL bar copying returns unicode variant

MozReview-Commit-ID: GTESwOSJW0P
* * *
[mq]: bug1380617-url-autofill.patch

MozReview-Commit-ID: JUxFZcpc3rN
2017-08-09 17:43:51 +02:00
Michael Kohler
f15ab23e9f Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
MozReview-Commit-ID: 8w1vfF2yRui
2017-08-08 12:09:14 +02:00
Jared Wein
d016c13ec8 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU
2017-08-07 12:37:34 -04:00
Gijs Kruitbosch
a626facc1f Bug 1385083 - history panel should actually list history, r=mikedeboer
MozReview-Commit-ID: G98QMcmASv0
2017-08-07 15:24:49 +01:00
Sebastian Hengst
31742f9ca2 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
a220eeb86a Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe
2017-08-05 20:37:40 +02:00
Erica Wright
ad80e133d2 Bug 1382570 - Ignore non-left clicks on the bookmark icon. r=Gijs
MozReview-Commit-ID: KrFYUijzawU
2017-08-02 16:20:52 -04:00
Gijs Kruitbosch
4639ca807b Bug 1354117 - stop relying on gPhotonStructure in bookmarks/history code, r=adw
MozReview-Commit-ID: FqUFNrSufvQ
2017-08-01 19:55:41 +01:00
Gijs Kruitbosch
d485cb5fac Bug 1354117 - remove wrap handling for the bookmarks toolbar button and tests verifying it, r=johannh
MozReview-Commit-ID: CeSGIQrDPpw
2017-07-31 21:52:06 +01:00
Wes Kocher
6184b5919e Backed out changeset 4c8cc6044599 (bug 1382570) because it might have caused the spike in browser_page_action_menu.js failures a=backout CLOSED TREE
MozReview-Commit-ID: HCTskH7e4RF
2017-08-03 18:42:02 -07:00
Erica Wright
d4c8da7872 Bug 1382570 - Ignore non-left clicks on the bookmark icon. r=Gijs
MozReview-Commit-ID: KrFYUijzawU
2017-08-02 16:20:52 -04:00
Marco Bonardo
2703fb553f Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8
MozReview-Commit-ID: 2pSbYtPGtYx
2017-08-03 12:16:36 +02:00
Mark Banner
48ddb251f8 Bug 1094812 - Use Bookmarks.jsm in browser-places.js. r=mak
MozReview-Commit-ID: HJ1NbFMm0l8
2017-07-19 13:50:47 +01:00
Marco Bonardo
a90abdc771 Bug 1094818 - Use Bookmarks.jsm in controller.js. r=standard8
MozReview-Commit-ID: 7vli02K19bt
2017-07-18 19:18:02 +02:00
Mark Banner
1286bb379e Bug 1386197 - Show/Hide recently bookmarked menuitems don't exist in the Library window on Mac, handle the case so to avoid exceptions stopping listeners being removed. r=mak
MozReview-Commit-ID: 6zcw2Q7vRYI
2017-08-01 11:59:41 +01:00
Jared Wein
6954ff71c6 Bug 1384145 - Guard the removal of the 'animate' attribute so it only happens in builds with MOZ_PHOTON_ANIMATIONS since the attribute only makes sense when MOZ_PHOTON_ANIMATIONS=True. r=mconley
MozReview-Commit-ID: DuUCYGt5uV2
2017-07-26 08:53:04 -04:00
Jared Wein
818712371f Bug 1352063 - Implement new animation for bookmarking. r=Gijs
MozReview-Commit-ID: GDfxtaCNtZo
2017-07-24 17:52:44 -04:00
Wes Kocher
55f16cab91 Backed out changeset 9202b42e8dcb (bug 1352063) for failures in browser_startup_images.js a=backout
MozReview-Commit-ID: 4sfnaQwjv76
2017-07-24 14:38:10 -07:00
Jared Wein
ba7cd5c9a8 Bug 1352063 - Implement new animation for bookmarking. r=Gijs
MozReview-Commit-ID: GDfxtaCNtZo
2017-07-23 02:45:51 -04:00
Florian Quèze
3fa089754c Bug 1381853 - lazy load browserPlacesViews.js into the browser window, r=mconley. 2017-07-23 00:17:56 +02:00
Johann Hofmann
0bc53a79e8 Bug 1371219 - Increase margin of main menu items when accessed through touch. r=mikedeboer
MozReview-Commit-ID: 9gjxxc6O5YS
2017-07-20 16:45:02 +02:00
Mark Banner
8c8fb5a55f Bug 1381049 - Fix cases of async function definitions without await in Places code. r=mak
MozReview-Commit-ID: 3G3BD5SrJ8b
2017-07-14 17:32:22 +01:00
Mark Banner
a96f023139 Bug 1380570 - Fix setting the title when bookmarking a url from an error page when the url is not found in the history. r=mak
MozReview-Commit-ID: EMuCpR1Sg9G
2017-07-12 22:56:06 +01:00