Commit Graph

79 Commits

Author SHA1 Message Date
Karl Tomlinson
3d90560e7b Bug 1119956 remove unused ErrorRunnable r=baku
Unused since
https://hg.mozilla.org/mozilla-central/rev/d7b3c828ed45ce0fc47ebdcc12bb55ce9344ebae#l1.53

Differential Revision: https://phabricator.services.mozilla.com/D98115
2020-11-30 09:22:36 +00:00
Sylvestre Ledru
68b806d604 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
a6e7dcc53f Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE 2020-11-04 10:54:36 +02:00
Sylvestre Ledru
8f709b39e8 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Andi-Bogdan Postelnicu
f97aaa6afb Bug 1671641 - Make dom/filesystem buildable outside of unified-build environment. r=sg
Depends on D94559

Differential Revision: https://phabricator.services.mozilla.com/D94569
2020-10-27 10:01:12 +00:00
Jean-Yves Avenard
05adafa9ef Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.

This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget

Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
Jean-Yves Avenard
8e18348f93 Bug 1647133 - P1. Use nsISerialEventTarget where it's actually that. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D80419
2020-06-23 03:21:14 +00:00
Nika Layzell
747082f588 Bug 1570369 - Part 7: Use IPDL refcounted for PFileSystemRequest, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D40260
2019-08-08 16:46:37 +00:00
Sylvestre Ledru
e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Andrea Marchesini
df2d53fa11 Bug 1411257 - No MOZ_CRASH if BackgroundChild::GetOrCreateForCurrentThread() fails - part 4 - FileSystem APIs, r=asuth 2017-10-25 08:45:52 +02:00
Andrea Marchesini
c98c78bb9e Bug 1408333 Get rid of nsIIPCBackgroundChildCreateCallback - part 7 - FileSystem APIs, r=asuth 2017-10-24 12:02:40 +02:00
Bill McCloskey
ce42826bdf Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
238bf154d5 Backed out changeset 4f6302a98ae4 (bug 1372405) 2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993 Backed out changeset 9846de3bd954 (bug 1372405) 2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bevis Tseng
e6dc9e02bc Bug 1372453 - Part 2: Name the caller of ProxyReleaseEvent. r=billm
MozReview-Commit-ID: LYhSWnZkq0i
2017-06-14 09:27:17 +08:00
Bill McCloskey
284c3f3132 Bug 1365097 - Convert NS_GetCurrentThread uses in dom (except for dom/media) (r=smaug)
For the Quatum DOM project, it's better to work in terms of event targets than
threads. This patch converts DOM code to operate on event targets rather than
threads, when possible.

MozReview-Commit-ID: 5FgvpKadUA2
2017-06-12 20:20:08 -07:00
Andrea Marchesini
42bafc0e82 Bug 1358111 - Use IPCBlob in Entries API - part 2 - Entries API, r=smaug 2017-04-24 12:16:49 +02:00
Sebastian Hengst
5f26d51f34 Backed out changeset 73f62ae76c08 (bug 1358111) 2017-04-24 15:43:10 +02:00
Andrea Marchesini
c892b19da1 Bug 1358111 - Use IPCBlob in Entries API - part 2 - Entries API, r=smaug 2017-04-24 12:16:49 +02:00
Andrea Marchesini
3d4252d899 Bug 1350933 - Labeling dom/filesystem - part 3 - IPC actors, r=billm 2017-04-05 09:47:56 +02:00
Andrea Marchesini
71bb45e638 Bug 1350933 - Labeling dom/filesystem - part 2 - DispatchTo{Current,Main}Thread, r=billm 2017-04-05 09:47:34 +02:00
Andrea Marchesini
9e6a51153b Bug 1350933 - Labeling dom/filesystem - part 1 - Runnable, r=billm 2017-04-05 09:47:09 +02:00
Andrea Marchesini
78510b5b49 Bug 1346801 - No need to dispatch runnables to the main-thread for Entries API, r=qdot 2017-03-14 11:38:06 +01:00
Andrea Marchesini
9e9210ce14 Bug 1299500 - Get rid of DeviceStorage API - part 11 - FileSystem, r=ehsan 2017-03-08 20:15:45 +01:00
Andrea Marchesini
3d2923ec1d Bug 1332003 - Entries API must create BlobImpl in the parent process, r=smaug 2017-02-01 07:33:18 +01:00
Kan-Ru Chen
1b9dd22e2d Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.

MozReview-Commit-ID: AzVbApxFGZ0
2016-11-15 04:26:00 +01:00
Nicholas Nethercote
b5810a1eb4 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
2016-09-02 17:12:24 +10:00
Kan-Ru Chen
a9b19d0584 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES
2016-08-24 14:47:04 +08:00
Andrea Marchesini
3e782b8fc6 Bug 1288736 - Add some missing rv.SuppressException(), r=smaug 2016-07-22 16:50:10 +02:00
Kyle Huey
1f6993705a Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj 2016-04-11 11:40:06 -07:00
Andrea Marchesini
65cc374a11 Bug 1257180 - patch 1 - Directory clonable to workers, r=smaug 2016-04-12 08:50:38 -04:00
Sebastian Hengst
d3fc87adc9 Backed out changeset b416fc68c0a2 (bug 1257180) for crash in test_performance_user_timing.html on Android debug. r=backout on a CLOSED TREE 2016-04-12 17:56:15 +02:00
Andrea Marchesini
4109793f74 Bug 1257180 - patch 1 - Directory clonable to workers, r=smaug 2016-04-12 08:50:38 -04:00
Andrea Marchesini
32c6dd01b5 Bug 1258221 - patch 3 - Rename FileSystemTaskBase to FileSystemTaskChildBase, r=smaug 2016-04-09 19:17:28 +01:00
Andrea Marchesini
f5655f4f9e Bug 1258221 - patch 2 - Port FileSystem API and DeviceStorage API to PBackground, r=smaug 2016-04-09 19:17:02 +01:00
Andrea Marchesini
8b45de854a Bug 1258221 - patch 1 - File::CreateFromFile only for main-thread, r=smaug 2016-04-09 19:15:50 +01:00
Andrea Marchesini
6852883163 Bug 1173320 - patch 5/8 - Cleanup manual string path management, r=smaug 2016-03-20 11:56:10 +01:00
Andrea Marchesini
c5b6c2add9 Bug 1173320 - patch 2/8 - Proper naming for the FileSystem path serialization, r=smaug 2016-03-20 11:56:10 +01:00
Andrea Marchesini
d10e0b4b34 Bug 1173320 - patch 1/8 - Implement Directory object as string and not as BlobImpl, r=smaug 2016-03-20 11:56:10 +01:00
Phil Ringnalda
9e96cfb31d Backed out 8 changesets (bug 1173320) for adding dom/filesystem/tests/test_basic.html without making it work on Android
Backed out changeset 7e3a105b9160 (bug 1173320)
Backed out changeset 094819fbb07f (bug 1173320)
Backed out changeset 23b0e55ff1db (bug 1173320)
Backed out changeset 8bf8e2fcedad (bug 1173320)
Backed out changeset 3de390c6f47f (bug 1173320)
Backed out changeset fb298010e12e (bug 1173320)
Backed out changeset f1a965c2f796 (bug 1173320)
Backed out changeset 176128ba757f (bug 1173320)
2016-03-19 19:44:22 -07:00
Andrea Marchesini
870442b443 Bug 1173320 - patch 5/8 - Cleanup manual string path management, r=smaug 2016-03-19 22:29:47 +01:00
Andrea Marchesini
c3f9559efd Bug 1173320 - patch 2/8 - Proper naming for the FileSystem path serialization, r=smaug 2016-03-19 22:29:46 +01:00
Andrea Marchesini
97ca49dfa3 Bug 1173320 - patch 1/8 - Implement Directory object as string and not as BlobImpl, r=smaug 2016-03-19 22:29:46 +01:00
Andrea Marchesini
058eacf49e Bug 1234192 - part 1 - FileSystemBase should not be thread-safe, r=smaug 2015-12-30 08:53:20 +00:00
Phil Ringnalda
410f611998 Back out 2 changesets (bug 1234192) for "Assertion failure: !mFileSystem" in test_fs_createFile.html
Backed out changeset 3f37b08ceb85 (bug 1234192)
Backed out changeset bab507aa7874 (bug 1234192)
2015-12-29 19:16:40 -08:00
Andrea Marchesini
423ab43000 Bug 1234192 - part 1 - FileSystemBase should not be thread-safe, r=smaug 2015-12-29 20:41:37 +00:00
Birunthan Mohanathas
ac37dec517 Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Dragana Damjanovic
f5e3e71a6d Bug 905127 - Part 2 - remove unnecessary nsNetUtil.h includes r=jduell 2015-07-06 07:55:00 +02:00