Commit Graph

353 Commits

Author SHA1 Message Date
Silke Hofmann
62efdd5fca Bug 1481470 - Stop using xlink:href in SVG in browser/. r=nhnt11,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D117204
2021-06-13 19:01:19 +00:00
Eugen Sawin
0d32a65fd0 Bug 1691821 - [1.c.3] Rename autofill paths to use the new toolkit component. r=zbraniecki,dimi
Differential Revision: https://phabricator.services.mozilla.com/D108058
2021-04-12 17:33:16 +00:00
Eugen Sawin
b516f761de Bug 1691821 - [1.a.3] Extract common mechanics from the form autofill extension to toolkit to enable cross-platform reuse. r=zbraniecki,dimi,tgiles,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D108057
2021-04-12 17:33:15 +00:00
Dorel Luca
565aa136f7 Backed out 7 changesets (bug 1691821) for Browser-chrome failures in autofill/FormAutofillParent.jsm. CLOSED TREE
Backed out changeset d12aec06eedd (bug 1691821)
Backed out changeset 0affe1783697 (bug 1691821)
Backed out changeset f807e0d0d095 (bug 1691821)
Backed out changeset abdc3fede62b (bug 1691821)
Backed out changeset cea92bd86972 (bug 1691821)
Backed out changeset 1c86de8cd775 (bug 1691821)
Backed out changeset e955f7f5503c (bug 1691821)
2021-04-10 03:05:35 +03:00
Eugen Sawin
5ba5b5c835 Bug 1691821 - [1.c.2] Rename autofill paths to use the new toolkit component. r=zbraniecki,dimi
Differential Revision: https://phabricator.services.mozilla.com/D108058
2021-04-09 22:12:12 +00:00
Alexandru Michis
4a1415f08c Backed out 3 changesets (bug 1681985) for causing performance issues.
CLOSED TREE

Backed out changeset 7b19f4ed5182 (bug 1681985)
Backed out changeset e77582268ce1 (bug 1681985)
Backed out changeset 386a8b11c127 (bug 1681985)
2021-04-01 17:51:47 +03:00
Erik Rose
95552ad075 Bug 1681985 - Add and call Fathom ruleset. r=zbraniecki
* We make some changes to heuristicsRegexp.js to improve accuracy. (Nothing else uses these regexps, so they're safe to change.) The commenting out of some languages in the expiration fields are because they caused a lot of false positives, according to Daniel Hertenstein's recollection. In any case, we've never preffed CC autofill on for those languages.
* Delete a few tests from test_known_strings.js and one from test_getInfo.js, which were testing for the presence of regexes we removed.
* Delete tests of CC autofill against third-party sites. These tests no longer work as xpcshell tests, since Fathom expects full layout and style information. The spirit of these tests is maintained by adding these pages to Fathom's training, validation, and testing corpora at 2bfcdf23dc. A few don't make it due to iframes which confound Fathom's capture tools, but the rest all succeed--and now improve the ML model as well as acting as tests. The training results after said integration reflect this improvement, which boosts testing precision and recall for every type.
* Add a mochitest to ensure the Fathom integration code can surface a decision that a field should not be autofilled. Decisions that go the other way are taken care of by the existing autofill tests.

Differential Revision: https://phabricator.services.mozilla.com/D100141
2021-03-23 18:31:08 +00:00
Tim Nguyen
2fd0489e59 Bug 1698406 - Remove --in-content-box-background-{hover/active} variables. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D108393
2021-03-16 16:33:00 +00:00
Mark Banner
8a9fc4165b Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-26 13:42:38 +00:00
Brindusan Cristian
201069fdac Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
Backed out changeset 638c802ca1d1 (bug 1687235)
Backed out changeset ec830b771bce (bug 1687235)
Backed out changeset a7c933ddecfd (bug 1687235)
Backed out changeset c36493fb0599 (bug 1687235)
Backed out changeset 6eb33ad5d460 (bug 1687235)
2021-01-26 10:58:43 +02:00
Mark Banner
36cf48f89d Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-25 22:27:19 +00:00
Itiel
8f8918f6a6 Bug 1684530 - Minor improvements to the Saved Addresses and Saved Credit Cards dialogs r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D100833
2021-01-06 19:48:06 +00:00
James Teh
db79981fcc Bug 1664086: Use Fluent to set aria-label for credit card list options in preferences. r=zbraniecki,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D89696
2020-09-11 06:13:36 +00:00
James Teh
14c5eb2d77 Bug 1662879 part 2: Expose the credit card type via aria-label for credit card autocomplete results. r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D89549
2020-09-11 05:50:25 +00:00
James Teh
34d7542609 Bug 1662879 part 1: Expose the credit card type via aria-label in the credit card list in Preferences. r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D89548
2020-09-11 05:47:27 +00:00
Csoregi Natalia
64073d27da Backed out 2 changesets (bug 1662879) for multiple failures e.g. browser_manageCreditCardsDialog.js. CLOSED TREE
Backed out changeset 3952f1301e38 (bug 1662879)
Backed out changeset 5daec3a7ae6f (bug 1662879)
2020-09-10 10:59:01 +03:00
James Teh
b8a1c790c6 Bug 1662879 part 2: Expose the credit card type via aria-label for credit card autocomplete results. r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D89549
2020-09-10 02:41:27 +00:00
James Teh
885d3a7228 Bug 1662879 part 1: Expose the credit card type via aria-label in the credit card list in Preferences. r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D89548
2020-09-10 04:47:49 +00:00
James Teh
4a1fcd18d8 Bug 1662876: Use aria-labelledby on the credit card number field to avoid the value being included in the label. r=zbraniecki
Ideally, the error message would be outside of the wrapping label element, which would avoid inclusion of the value in the label.
However, I didn't want to potentially mess with the visual presentation, especially given the tight timeline.

Differential Revision: https://phabricator.services.mozilla.com/D89547
2020-09-09 23:51:50 +00:00
pbz
9684cdfd60 Bug 1661030 - Refactor SubDialog and TabDialogBox to support passing multiple window arguments. r=Gijs,preferences-reviewers
This also updates the behavior of the allowDuplicates check:
Instead of only checking if the top dialog is a duplicate, it will now check the whole stack and
skip the dialog open if a duplicate URL is found.
This fixes an issue where callers could alternate between dialogs to bypass the check.

Differential Revision: https://phabricator.services.mozilla.com/D88422
2020-09-02 14:24:47 +00:00
Christoph Kerschbaumer
d8034a3e61 Bug 1654260: Package all formautofill css files and load them using the internal chrome: protocol. r=MattN,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D85023
2020-08-31 13:18:56 +00:00
Sonia Singla
11e354edab Bug 1659267 - Remove usages of -moz-user-select across the Firefox codebase. r=emilio,marionette-reviewers,geckoview-reviewers,preferences-reviewers,whimboo,agi
Differential Revision: https://phabricator.services.mozilla.com/D87499
2020-08-18 23:37:51 +00:00
Zibi Braniecki
38d51aecc5 Bug 1654167 - Add preferences telemetry for Credit Card A/B testing. r=abr
Differential Revision: https://phabricator.services.mozilla.com/D84293
2020-07-28 00:29:50 +00:00
Zibi Braniecki
4d2a192059 Bug 1650222 - Verify CC number validity when editing the CC entry. r=abr
Differential Revision: https://phabricator.services.mozilla.com/D83527
2020-07-15 01:40:32 +00:00
Itiel
3c118c7cdf Bug 1651433 - Fix the telephone number to appear correctly in the preferences and in the autofill list r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D82771
2020-07-08 19:51:14 +00:00
Zibi Braniecki
023172d881 Bug 1642060 - Handle Credit Card Type select. r=abr
Differential Revision: https://phabricator.services.mozilla.com/D81015
2020-07-02 15:36:44 +00:00
Itiel
497778585c Bug 1648417 - Fix the doorhanger icon for updating an autofilled form r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D81536
2020-06-29 16:38:39 +00:00
Adam Roach [:abr]
039f38f222 Bug 1399356: Delay input to autofill popup r=zbraniecki,MattN
Differential Revision: https://phabricator.services.mozilla.com/D79775
2020-06-27 02:11:48 +00:00
Mihai Alexandru Michis
bbb9686a1b Backed out 3 changesets (bug 1399356) for causing failures in browser_anti_clickjacking.js
CLOSED TREE

Backed out changeset 4fdb0c2beacf (bug 1399356)
Backed out changeset adabcdf04413 (bug 1399356)
Backed out changeset 468066fde214 (bug 1399356)
2020-06-27 04:59:35 +03:00
Adam Roach [:abr]
25ad63e740 Bug 1399356: Delay input to autofill popup r=zbraniecki,MattN
Differential Revision: https://phabricator.services.mozilla.com/D79775
2020-06-26 16:00:10 +00:00
Cosmin Sabou
0099731769 Backed out 3 changesets (bug 1399356) for mochitest failures on several tests.
Backed out changeset 979f641a6bef (bug 1399356)
Backed out changeset aa001ccfcce3 (bug 1399356)
Backed out changeset aa54dc45b2d4 (bug 1399356)
2020-06-26 05:42:53 +03:00
Adam Roach [:abr]
70a60ba4c2 Bug 1399356: Delay input to autofill popup r=zbraniecki,MattN
Differential Revision: https://phabricator.services.mozilla.com/D79775
2020-06-26 00:36:57 +00:00
Zibi Braniecki
3c1b794afc Bug 1644510 - Update credit card doorhanger and autofill copy. r=abr,flod
Differential Revision: https://phabricator.services.mozilla.com/D79399
2020-06-25 05:41:54 +00:00
Noemi Erli
0afcea2cdb Backed out 2 changesets (bug 1399356) for causing failures in browser_anti_clickjacking.js CLOSED TREE
Backed out changeset 78ad99b4aab0 (bug 1399356)
Backed out changeset ff333cde9042 (bug 1399356)
2020-06-25 07:44:10 +03:00
Adam Roach [:abr]
027e2f0bf6 Bug 1399356: Delay input to autofill popup r=zbraniecki,MattN
Differential Revision: https://phabricator.services.mozilla.com/D79775
2020-06-25 02:53:33 +00:00
Csoregi Natalia
8cb0133d2e Backed out changeset 2e9f206b511b (bug 1399356) for test form autocomplete failures. CLOSED TREE 2020-06-25 05:47:45 +03:00
Adam Roach [:abr]
b008b03b7f Bug 1399356: Delay input to autofill popup r=zbraniecki,MattN
Differential Revision: https://phabricator.services.mozilla.com/D79775
2020-06-24 23:59:01 +00:00
Adam Roach [:abr]
71f51eec74 Bug 1647944: Add more matching rules to heuristics, r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D80786
2020-06-24 17:27:02 +00:00
Zibi Braniecki
e5bef768f4 Bug 1645922 - Reshuffle heuristic regexps to prioritize cc-name over generic name. r=abr
Differential Revision: https://phabricator.services.mozilla.com/D80338
2020-06-22 22:14:47 +00:00
Zibi Braniecki
3f6cab3d6a Bug 1645922 - Update Regexps used by heuristics to latest master. r=abr
Differential Revision: https://phabricator.services.mozilla.com/D80119
2020-06-23 01:58:59 +00:00
Brindusan Cristian
95d26ddc90 Backed out 2 changesets (bug 1645922) for xpcshell failures at test_getInfo.js. CLOSED TREE
Backed out changeset 70a0f7fd1803 (bug 1645922)
Backed out changeset 2fd3a3846d59 (bug 1645922)
2020-06-23 01:10:09 +03:00
Zibi Braniecki
e516f9624a Bug 1645922 - Reshuffle heuristic regexps to prioritize cc-name over generic name. r=abr
Differential Revision: https://phabricator.services.mozilla.com/D80338
2020-06-22 20:59:36 +00:00
Zibi Braniecki
8c20aa16e5 Bug 1645922 - Update Regexps used by heuristics to latest master. r=abr
Differential Revision: https://phabricator.services.mozilla.com/D80119
2020-06-22 20:59:36 +00:00
Zibi Braniecki
7c39d8e5e6 Bug 1642064 - Separate Add and Edit credit card and address entry UI title. r=abr,MattN
Differential Revision: https://phabricator.services.mozilla.com/D78847
2020-06-11 19:30:32 +00:00
Adam Roach [:abr]
4881146452 Bug 1624646: Fix macOS re-auth strings r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D78816
2020-06-08 22:39:54 +00:00
Zibi Braniecki
2a9e85d298 Bug 1619320 - Disable address field in Credit Card Entry. r=abr,MattN
Differential Revision: https://phabricator.services.mozilla.com/D78157
2020-06-08 19:02:53 +00:00
Adam Roach [:abr]
d5f3709c8c Bug 1642058: Add expiration date in card list view under Preferences r=zbraniecki,fluent-reviewers,MattN,flod
***

Differential Revision: https://phabricator.services.mozilla.com/D77953
2020-06-08 15:00:58 +00:00
Butkovits Atila
671cf97b02 Backed out changeset 85183f00ced0 (bug 1642058) for causing failure at browser_manageCreditCardsDialog.js. CLOSED TREE 2020-06-06 00:14:13 +03:00
Adam Roach [:abr]
f5abb1f0eb Bug 1642058: Add expiration date in card list view under Preferences r=zbraniecki,fluent-reviewers,MattN,flod
***

Differential Revision: https://phabricator.services.mozilla.com/D77953
2020-06-05 19:56:59 +00:00
Noemi Erli
356c4044c4 Backed out changeset 94f2fb2c3a94 (bug 1619320) for causing failures in browser_editCreditCardDialog.js 2020-06-05 04:27:52 +03:00