corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
877,467 Commits 1 Branch 0 Tags
d2bc47834bf63b8db8c4804f875a5011262d77d0
Commit Graph

346 Commits

Author SHA1 Message Date
Hanna Jones
53da99d2a0 Bug 1838298 - Part 2: fix color token usage in line with new Stylelint rule r=desktop-theme-reviewers,settings-reviewers,reusable-components-reviewers,home-newtab-reviewers,dao,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D222698
 2024-09-27 14:58:41 +00:00
Sandor Molnar
5b461ba013 Bug 1894797 - Disable browser_test_moving_tab_to_new_window.js on win for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D222909
 2024-09-25 13:01:51 +00:00
Florian Quèze
cd093f0a88 Bug 1918702 - Migrate telemetry events to use Glean APIs for screenshots, r=chutten. 
Differential Revision: https://phabricator.services.mozilla.com/D222607
 2024-09-20 13:58:19 +00:00
Joel Maher
1217ef421e Bug 1919776 - part 1, adjust browser/base and browser/components osx skip-if conditions to be more specific. r=sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D222841
 2024-09-20 13:15:23 +00:00
Joel Maher
04cf186cea Bug 1917223 - re-enable many tests on browser/components/[pri*-urlbar]/**/browser.toml. r=aryx,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,urlbar-reviewers,dao,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D221309
 2024-09-18 23:37:52 +00:00
Joel Maher
3c323306ab Bug 1917158 - move some skip-if -> run-if for browser/components/**/browser.toml. r=sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D221286
 2024-09-06 10:08:18 +00:00
Emilio Cobos Álvarez
f8a088017c Bug 1916004 - Use a box shadow for chrome/content separator. r=dao,desktop-theme-reviewers,tabbrowser-reviewers 
This makes it work in fullscreen and regardless of whether the sidebar
(or the toolbox for that matter) is shown.

Differential Revision: https://phabricator.services.mozilla.com/D220770
 2024-09-02 17:30:03 +00:00
Emilio Cobos Álvarez
f7551929f8 Bug 1916098 - Remove appcontent box. r=dao,desktop-theme-reviewers,devtools-reviewers,tabbrowser-reviewers,nchevobbe 
gNotificationBox doesn't go there anymore (it goes inside the toolbox),
so we have really no use for that.

Simplify how the devtools theme is set on the browser, so that it is set
on the root.

Differential Revision: https://phabricator.services.mozilla.com/D220769
 2024-09-02 13:47:45 +00:00
Noemi Erli
90b5fb50ca Backed out changeset 10ac3f66133d (bug 1896232) for causing bug 1915806 CLOSED TREE 2024-08-30 16:33:37 +03:00
Niklas Baumgardner
0fc89881f5 Bug 1896232 - Wait for screenshot to download before closing overlay. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D216083
 2024-08-29 03:21:44 +00:00
Nikki Sharpley
23a3a4bedd Bug 1910733 - Update content area and sidebar panel to have a border and box shadow. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sclements 
In Bug 1886847, there was a discussion on how best to separate chrome from content
from chrome whilst remaining true to the new look. We landed on usiong both a box
shadow and border.

Differential Revision: https://phabricator.services.mozilla.com/D218126
 2024-08-27 17:30:45 +00:00
Iulian Moraru
6faba7e3b9 Backed out 2 changesets (bug 1908205, bug 1896232) for causing bc assertion failures on nsUrlClassifierDBService.cpp. CLOSED TREE 
Backed out changeset 859b4c639883 (bug 1908205)
Backed out changeset 519e88d21955 (bug 1896232)
 2024-08-22 22:20:42 +03:00
Niklas Baumgardner
ae2879abd5 Bug 1908205 - Switch to OffscreenCanvas and blobs for screenshots. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D216723
 2024-08-22 18:36:48 +00:00
Niklas Baumgardner
b0381f7136 Bug 1896232 - Wait for screenshot to download before closing overlay. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D216083
 2024-08-22 18:36:48 +00:00
Narcis Beleuzu
073a988929 Backed out 2 changesets (bug 1908205, bug 1896232) for causing mochitests failures . CLOSED TREE 
Backed out changeset 873bbe70aa8c (bug 1908205)
Backed out changeset 0385fdac5693 (bug 1896232)
 2024-08-19 19:04:38 +03:00
Niklas Baumgardner
10850a95fb Bug 1908205 - Switch to OffscreenCanvas and blobs for screenshots. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D216723
 2024-08-19 14:40:42 +00:00
Niklas Baumgardner
ee55b5699a Bug 1896232 - Wait for screenshot to download before closing overlay. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D216083
 2024-08-19 14:40:42 +00:00
Niklas Baumgardner
8c2c80147f Bug 1910920 - Use openOrClosedShadowRoot for hovering elements in screenshots overlay. r=kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D218244
 2024-08-01 20:23:54 +00:00
Iulian Moraru
41bf68834e Backed out changeset d8c20788de55 (bug 1910920) for causing bc failures on browser_shadowRoot_test.js. CLOSED TREE 2024-08-01 18:44:01 +03:00
Niklas Baumgardner
1165a2d4ad Bug 1910920 - Use openOrClosedShadowRoot for hovering elements in screenshots overlay. r=kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D218244
 2024-08-01 14:01:16 +00:00
Niklas Baumgardner
63b3a7b051 Bug 1909926 - Highlight shadowRoot elements in screenshots overlay. r=kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D217747
 2024-07-29 17:42:08 +00:00
Niklas Baumgardner
0e39bf8f0c Bug 1894516 - Make screenshots face focusable via the keyboard. r=sfoster,desktop-theme-reviewers,fluent-reviewers,bolsson,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D213100
 2024-07-29 16:59:14 +00:00
Norisz Fay
57a529f668 Backed out changeset 41d7f0b670ae (bug 1894516) for causing bc failures on browser_screenshots_focus_test.js CLOSED TREE 2024-07-25 23:50:34 +03:00
Niklas Baumgardner
68f4030f56 Bug 1894516 - Make screenshots face focusable via the keyboard. r=sfoster,desktop-theme-reviewers,fluent-reviewers,bolsson,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D213100
 2024-07-25 14:32:27 +00:00
Kelly Cochrane
b40657ff11 Bug 1897976 - Update existing tests involving sidebar-button in the nav bar for when sidebar.revamp pref is flipped on r=places-reviewers,sidebar-reviewers,urlbar-reviewers,mak,sfoster,Gijs,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D215253
 2024-07-12 15:58:29 +00:00
Niklas Baumgardner
456cea1645 Bug 1905468 - Prevent some more mouse events from reaching the content page. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D215515
 2024-07-08 14:41:02 +00:00
Niklas Baumgardner
667bf8f161 Bug 1904961 - Wait for screenshots overlay before clicking panel buttons in test. r=sfoster,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D215030
 2024-07-01 14:18:48 +00:00
Niklas Baumgardner
d39a577986 Bug 1902303 - Focus browser before taking screenshot. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213673
 2024-06-25 16:16:32 +00:00
Narcis Beleuzu
ef43341f2c Backed out changeset 857a001b61ac (bug 1902303) for bc failures on browser_screenshots_telemetry_tests.js. CLOSED TREE 2024-06-18 02:32:29 +03:00
Niklas Baumgardner
09746b47b2 Bug 1902303 - Focus browser before taking screenshot. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213673
 2024-06-17 15:13:44 +00:00
Niklas Baumgardner
6cf7eb9f87 Bug 1902341 - Increase screenshots fallback filename length for Windows. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213609
 2024-06-15 13:52:34 +00:00
Niklas Baumgardner
0f68e482f0 Bug 1902683 - Early return on keydown when screenshots button is focused. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213811
 2024-06-15 13:40:07 +00:00
Moritz Beier
0dcee9a58f Bug 1610530 - Use classes instead of ids to access urlbar elements from UrlbarInput. r=dao,webdriver-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D212095
 2024-06-04 12:58:52 +00:00
Niklas Baumgardner
2f657dabda Bug 1899801 - Explicitly handle keydown events on screenshots overlay buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D212132
 2024-05-31 20:07:07 +00:00
Tamas Szentpeteri
823f1023c3 Backed out changeset 1cca8bfcc170 (bug 1899801) for causing mochitest failures on browser_overlay_keyboard_test.js. CLOSED TREE 2024-05-31 13:54:19 +03:00
Niklas Baumgardner
6f36bc4b5e Bug 1899801 - Explicitly handle keydown events on screenshots overlay buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D212132
 2024-05-31 09:39:18 +00:00
Niklas Baumgardner
6403a2bb15 Bug 1898027 - Update max filename length for screenshots downloads.r=sfoster,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D211223
 2024-05-29 20:58:42 +00:00
Niklas Baumgardner
132d9f5905 Bug 1897371 - Handle selectionchange events in screenshots overlay.r=kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D210813
 2024-05-27 16:38:53 +00:00
Niklas Baumgardner
8e50aa4937 Bug 1890721 - Prevent events from reaching the content page. r=sfoster,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D207749
 2024-05-15 20:17:21 +00:00
Sandor Molnar
a211f263b8 Backed out changeset cc14c4f9f46e (bug 1890721) for causing bc failures @ browser/components/screenshots/tests/browser/browser_screenshots_page_unload.js CLOSED TREE 2024-05-15 21:03:34 +03:00
Niklas Baumgardner
15944c851d Bug 1890721 - Prevent events from reaching the content page. r=sfoster,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D207749
 2024-05-15 13:45:25 +00:00
Niklas Baumgardner
0625ba53c8 Bug 1896002 - Enable screenshots preview buttons if download fails. r=sfoster,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D209979
 2024-05-15 13:44:24 +00:00
Niklas Baumgardner
5309b647f9 Bug 1880398 - Fix browser_screenshots_telemetry_tests test failures. r=sfoster,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D209847
 2024-05-09 15:21:22 +00:00
Niklas Baumgardner
71cbca48c0 Bug 1893800 - Align screenshots buttons container to viewport. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D209076
 2024-05-08 19:50:43 +00:00
Norisz Fay
f041168171 Backed out changeset 93caa282194b (bug 1893800) for causing bc failure on browser_test_resize.js 2024-05-07 05:55:47 +03:00
Niklas Baumgardner
6a43a1bc2f Bug 1893800 - Align screenshots buttons container to viewport. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D209076
 2024-05-06 21:35:39 +00:00
Norisz Fay
d7c54500fe Backed out changeset b41cffd6d5f2 (bug 1893800) for causing failures on browser_test_element_picker.js CLOSED TREE 2024-05-06 20:31:29 +03:00
Niklas Baumgardner
601e0ec15d Bug 1893800 - Align screenshots buttons container to viewport. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D209076
 2024-05-06 16:41:59 +00:00
Niklas Baumgardner
e0f484f1b4 Bug 1893680 - Offset screenshots overlay when scrollMin is negative. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D208769
 2024-05-04 19:41:59 +00:00
Niklas Baumgardner
9bcd4d4100 Bug 1801957 - Create region with keyboard for screenshots. r=sfoster,firefox-desktop-core-reviewers ,accessibility-frontend-reviewers,Gijs,morgan 
The problem I'm trying to solve: There is currently no way to create a selected region in the screenshots overlay with the keyboard.
I recently added support for resizing a selected region in bug 1801954, but a user still needs to create a region with the mouse before the keyboard can be used.

I tried to look at what other browsers are doing in this scenario. Unfortunately there isn't much to go off. Most browsers, I can't even take a screenshot and the only browser that I found to have keyboard support for screenshots is MS Edge. In Edge, when you open screenshots, if your mouse isn't over the content area it will immediately move your mouse to the center of the page. If your mouse is over the content, it remains in place. Then, arrow keys will move the cursor around and you can hit space/enter to start creating a region.

I didn't like that Edge moved the mouse immediately after opening screenshots so I took a different approach.

My approach:
Screenshots will not move the mouse until an arrow key is pressed.
How it works:
If your cursor is above the content and an arrow key is pressed, the cursor will move in the direction of the arrow key that was pressed.
If your cursor is not above the content and a arrow key is pressed, the cursor will be moved to the middle of the content. Screenshots will not move the cursor until an arrow key is pressed.

When moving around the overlay with the keyboard: only hitting an arrow key will move the cursor around by 1px. If shift + arrow key, the cursor will move around by 10px.
When space is clicked while moving the cursor, it will start a region. Moving the arrow keys allows the region to sized.
When the cursor is above an element and the hover element rect is visible, hitting enter will select that region. If no hover element region exists, enter will behave the same as space.

I am also keeping the screenshots UI focused in this patch. Tab/shift + tab will keep focus to screenshots UI. Shift + F6 will escape the focus loop I've made in this patch if needed. Although, if a user has entered screenshots, it makes sense that for the current time, only screenshots UI is focusable.

Differential Revision: https://phabricator.services.mozilla.com/D197703
 2024-05-03 22:05:52 +00:00