corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
877,467 Commits 1 Branch 0 Tags
d2bc47834bf63b8db8c4804f875a5011262d77d0
Commit Graph

3954 Commits

Author SHA1 Message Date
Dão Gottwald
b05aac4958 Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D223292
 2024-09-25 05:08:37 +00:00
William Durand
79188dd075 Bug 1920706 - Anchor "all-tabs" popup to the extensions button. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D223318
 2024-09-24 17:49:39 +00:00
Luca Greco
8235fdaa61 Bug 1920720 - testBrowserActionWithVerticalTabs pushPrefEnv should include sidebar.revamp pref along with sidebar.verticalTabs. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D223344
 2024-09-24 15:11:23 +00:00
Luca Greco
a743945aa9 Bug 1919306 - Fix browser_ext_tabs_query.js failure hit on asserting tabs.query tab's width and height values. r=willdurand 
I've hit this failure in one of my push to try (which included changes unrelated to this test), and I was able to reproduce
it consistently on Windows builds locally (and so at least locally it seems to be a perma-failure and not an intermittent).

Waiting for the chrome window document to be flushed before retrieving the clientWidth and clientHeight from the currently
selected browser element was consistently preventing the failure from being hit locally on a windows VM (and it did also
pass a run with --verify).

Differential Revision: https://phabricator.services.mozilla.com/D222844
 2024-09-20 15:04:52 +00:00
Florian Quèze
96ab8a3106 Bug 1918702 - Migrate telemetry events to use Glean APIs for homepage.preference events, r=chutten,extension-reviewers,robwu. 
Differential Revision: https://phabricator.services.mozilla.com/D222167
 2024-09-20 13:58:14 +00:00
Joel Maher
1217ef421e Bug 1919776 - part 1, adjust browser/base and browser/components osx skip-if conditions to be more specific. r=sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D222841
 2024-09-20 13:15:23 +00:00
Joel Maher
beccd9e33d Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D221307
 2024-09-19 02:52:04 +00:00
William Durand
78219a3fdc Bug 1910202 - Ensure extension widgets cannot be placed in a hidden area. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D222105
 2024-09-17 12:36:57 +00:00
Mark Banner
1cff4ca2d1 Bug 1918386 - browser.search.get() should be returning data URIs for application provided search engines. r=extension-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D222264
 2024-09-16 14:50:58 +00:00
Joel Maher
02bf7c92f9 Bug 1917073 - adjust skip-if -> run-if for browser/components/.../browser.toml. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,places-reviewers,mtigley,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D221247
 2024-09-16 06:12:31 +00:00
Mark Banner
fe5b823483 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 21:08:44 +00:00
Sandor Molnar
b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE 
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
 2024-09-12 20:45:28 +03:00
Mark Banner
4b68d25082 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 16:41:59 +00:00
Dão Gottwald
58fefccb92 Bug 1910203 - Update all-tabs button icon so we can move the button into the nav bar when vertical tabs are enabled. r=mconley,rpl,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220592
 2024-09-09 06:10:21 +00:00
Luca Greco
9ac44bcdcd Bug 1915606 - Fix ExtensionControlledPopups dialogs SUMO learn more link position. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D220562
 2024-09-05 19:53:04 +00:00
Dão Gottwald
47916b2da7 Bug 1916622 - Remove the browser.tabs.tabmanager.enabled pref. r=tabbrowser-reviewers,extension-reviewers,desktop-theme-reviewers,emilio,robwu,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D221005
 2024-09-05 13:37:09 +00:00
Butkovits Atila
d0ccccb444 Backed out changeset 9f8b9061d106 (bug 1915606) for causing failures at browser_ext_tabs_hide.js. 2024-09-05 04:18:36 +03:00
Luca Greco
47d9687aef Bug 1915606 - Fix ExtensionControlledPopups dialogs SUMO learn more link position. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D220562
 2024-09-04 20:09:41 +00:00
Dão Gottwald
ddb9309ce9 Bug 1915599 - Consolidate tabbrowser arrowscrollbox initialization and overflow/overflowing attribute checks. r=extension-reviewers,desktop-theme-reviewers,jswinarton,emilio,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D220594
 2024-09-04 08:18:46 +00:00
Mark Banner
93484bda6a Bug 1911981 - Replace use of SearchTestUtils.useTestEngines with setRemoteSettingsConfig in non-search test code. r=mbeier,backup-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D219894
 2024-08-27 16:01:45 +00:00
Adam Vandolder
ac5cc9867a Bug 1734181 - Part 4: Add tests for the backbutton intervention behaviour. r=jjaschke,peterv,dom-core,geckoview-reviewers,extension-reviewers,robwu,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D216828
 2024-08-24 19:43:32 +00:00
Mark Banner
28e4ba7093 Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani 
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.

Differential Revision: https://phabricator.services.mozilla.com/D219512
 2024-08-23 16:43:57 +00:00
Butkovits Atila
11a5a23896 Backed out 7 changesets (bug 1870226) for causing build bustages. CLOSED TREE 
Backed out changeset 619244623dba (bug 1870226)
Backed out changeset e85a5647cae4 (bug 1870226)
Backed out changeset 21ea9baf83ea (bug 1870226)
Backed out changeset a506c0f0ce28 (bug 1870226)
Backed out changeset 77c78201a206 (bug 1870226)
Backed out changeset 7a98dfef087f (bug 1870226)
Backed out changeset f64ad89c2406 (bug 1870226)
 2024-08-23 12:22:02 +03:00
Mark Banner
1ee70a0f13 Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani 
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.

Differential Revision: https://phabricator.services.mozilla.com/D219512
 2024-08-23 08:55:49 +00:00
Gijs Kruitbosch
3b619083de Bug 1822975 - clean up places that manually enable broader async stacks which is now the default in tests, r=devtools-reviewers,firefox-desktop-core-reviewers ,geckoview-reviewers,mconley,ohall 
Differential Revision: https://phabricator.services.mozilla.com/D215204
 2024-08-22 14:48:07 +00:00
timw-dev
84076b9d83 Bug 1896764 - onViewToolbarsPopupShowing and ToolbarContextMenu should move out of browser.js.r=scunnane,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D217795
 2024-08-22 11:11:50 +00:00
Moritz Beier
0a54beffb6 Bug 1870687 - Investigate removing the _locale and _extensionID options from within AppProvidedSearchEngine. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218684
 2024-08-21 14:03:31 +00:00
Norisz Fay
ea6558d555 Backed out changeset 440770be9e5e (bug 1870687) for causing bc failures on browser_searchModeSwitcher_basic.js CLOSED TREE 2024-08-19 22:04:53 +03:00
Moritz Beier
8ea05e5b29 Bug 1870687 - Investigate removing the _locale and _extensionID options from within AppProvidedSearchEngine. r=Standard8,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218684
 2024-08-19 15:39:57 +00:00
Norisz Fay
a31177f356 Backed out changeset 8b56107c9c8f (bug 1634240) for causing bc failures on browser_ext_windows_onFocusChanged.js CLOSED TREE 2024-08-09 20:26:14 +03:00
Rob Wu
05c8bb1566 Bug 1634240 - Stop exposing non-browser windows in windows.onFocusChanged r=zombie 
The extension APIs cannot do anything meaningful with windowId for
non-browser windows. Stop exposing them in windows.onFocusChanged, which
is a known way to leak non-browser windowIds.

Differential Revision: https://phabricator.services.mozilla.com/D217478
 2024-08-09 15:52:41 +00:00
Stefan Richter
551e400b7c Bug 1409262 - Notify when openerTabId changed via tabs.update() r=robwu,dao 
Differential Revision: https://phabricator.services.mozilla.com/D164982
 2024-08-05 17:49:06 +00:00
Moritz Beier
732359d637 Bug 1881739 - Create a SearchTestUtils function to simplify creating configurations for tests. r=Standard8,mcheang,urlbar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D216807
 2024-08-01 01:29:19 +00:00
William Durand
2cef18514d Bug 1907325 - Add coverage for sidebarAction.setIcon(). r=rpl 
This patch adds test coverage for the `setIcon()` method when the `sidebar.revamp` pref is set.

Depends on D217948

Differential Revision: https://phabricator.services.mozilla.com/D218039
 2024-07-30 11:13:53 +00:00
William Durand
f6e9cfa90a Bug 1907325 - Add test coverage for (new) sidebar shortcuts. r=rpl 
Depends on D217929

Differential Revision: https://phabricator.services.mozilla.com/D217948
 2024-07-30 11:13:53 +00:00
William Durand
8ba2f0419d Bug 1907325 - Skip some tests that verify the switcher when the sidebar.revamp pref is set. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D217929
 2024-07-30 11:13:53 +00:00
Luca Greco
4496ad3442 Bug 1856383 - origin control message should show on all sites on http(s) host permissions. r=robwu,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D217576
 2024-07-29 14:47:23 +00:00
Rob Wu
e709a8bf4b Bug 1795082 - Part 1/2: runtime.getURL should always return moz-extension:-URL r=zombie 
This corrects the behavior of runtime.getURL and extension.getURL when
the input looks like an absolute or protocol-relative URL.

Differential Revision: https://phabricator.services.mozilla.com/D215309
 2024-07-18 16:52:40 +00:00
Rob Wu
142e24db48 Bug 1905392 - Fix OriginControls.getState for extensions during startup r=zombie 
Differential Revision: https://phabricator.services.mozilla.com/D215247
 2024-07-18 16:50:30 +00:00
Meg Viar
76dd97ec96 Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215429
 2024-07-15 13:49:33 +00:00
Moritz Beier
12220c0dde Bug 1906875 - Remove the old search engine selector from the search service. r=Standard8,extension-reviewers,urlbar-reviewers,settings-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D216047
 2024-07-15 11:15:22 +00:00
Sandor Molnar
0aa78a67c5 Backed out changeset bccc4faa349a (bug 1904630) for causing bc perma failures @ browser/components/extensions/test/browser/browser_ext_menus.js CLOSED TREE 2024-07-12 18:55:26 +03:00
Meg Viar
ca1ff96b3d Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215429
 2024-07-12 13:53:00 +00:00
Luca Greco
3ae0a96b30 Bug 1905771 - switcherTarget element label set by SidebarController.registerExtension is still set when switching to a non extension sidebar. r=willdurand,sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D215945
 2024-07-10 17:52:30 +00:00
Luca Greco
7f1511c5bf Bug 1905931 - Do not show the attention badge for not granted origin permissions explicitly declared as optional. r=zombie,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D215430
 2024-07-09 15:16:43 +00:00
Emilio Cobos Álvarez
db0f986473 Bug 1906132 - Propagate BResize flag from viewport frame to root scroll frame. r=dholbert 
The regression range is baffling, but it just shows a missing
invalidation.

The extension has worked around this upstream:

  a48ff54cf6

But the root cause is a bug in Firefox. The popup here had styles much
like:

```
html, body, #root {
  height: 100%;
  min-height: 100%;
  width: auto;
  min-width: 320px;
}
```

The popup starts off zero-sized, but then gets re-measured async at some
point by the extension code.

Main issue here is that, due to the bresize, we reflow the viewport,
then the html, but the html loses the bresize flag. So we don't reflow
the body element to give it the right height.

Before my patch, the body was reflowed because there was a BFC under it,
so it had the NS_BLOCK_HAS_CLEAR_CHILDREN flag, which ended up papering
over this bug.

I think this can only happen with the special shrink-wrap resize mode,
because it's the only thing that can turn a percentage bsize like 100%
from behaving like a percentage to behave like auto... So I haven't been
able to reproduce outside of our extension popup usage. Otherwise the
percentages resolving to different things would set the bresize flag
appropriately.

Differential Revision: https://phabricator.services.mozilla.com/D215842
 2024-07-05 17:50:41 +00:00
Stanca Serban
990261cbe4 Backed out changeset 94a2d660b4c5 (bug 1822975) for causing browser_net_accessibility related devtools failures. CLOSED TREE 2024-07-03 00:05:37 +03:00
Gijs Kruitbosch
408b20bb30 Bug 1822975 - clean up places that manually enable broader async stacks which is now the default in tests, r=devtools-reviewers,firefox-desktop-core-reviewers ,geckoview-reviewers,mconley,ohall 
Differential Revision: https://phabricator.services.mozilla.com/D215204
 2024-07-02 19:44:29 +00:00
Rob Wu
9cb47d0a85 Bug 1905505 - Remove unnecessary resetIdleOnEvent from child modules r=rpl 
This patch updates every use of EventManager in child/ext-*.js files
that can referenced from extension contexts of envType "addon_child".

Pre patch, these could trigger "background-script-reset-idle" and
result in triggering "background-script-reset-idle" in the parent
despite the background being stopped, and consequently trigger the
reported bug. The previous patch fixes the negative consequence of this
unexpected event, this patch fixes an underlying cause by removing the
triggers.

Forcing resetIdleOnEvent to false does not have any negative impact on
these modules, because all of these events are dependencies of an
EventManager in the parent, which already activates the functionality
associated with resetIdleOnEvent=true.

To minimize the likelihood of affecting unit tests, this patch keeps the
EventManager of test.onMessage at resetIdleOnEvent=true as before, and
defers to bug 1901294 for changing it to false.

Differential Revision: https://phabricator.services.mozilla.com/D215298
 2024-07-01 17:07:10 +00:00
Luca Greco
8383e06823 Bug 1851083 - Do not show the attention badge for mv3 extensions requiring the activeTab permission. r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D215038
 2024-07-01 11:40:34 +00:00