corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
877,467 Commits 1 Branch 0 Tags
d2bc47834bf63b8db8c4804f875a5011262d77d0
Commit Graph

228 Commits

Author SHA1 Message Date
Jason Prickett
2817fb56a2 Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221538
 2024-09-26 17:54:01 +00:00
Eric Chen
7ccb2cc84f Bug 1896804 - adding support for architecture based experiment targeting r=nalexander,omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D223424
 2024-09-25 18:32:21 +00:00
Dão Gottwald
26e76365e7 Bug 1920500 - Remove --button-primary-bgcolor, --button-primary-hover-bgcolor, --button-primary-active-bgcolor, --button-primary-color. r=desktop-theme-reviewers,reusable-components-reviewers,emilio,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D223137
 2024-09-25 05:13:31 +00:00
hanna alemu
7598b19c9a Bug 1913431 - modify activeNotifications to account for newtab topic selection modal r=omc-reviewers,mviar,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D222379
 2024-09-24 21:15:26 +00:00
negin
02f4e905ae Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D222151
 2024-09-20 20:18:28 +00:00
Joel Maher
beccd9e33d Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D221307
 2024-09-19 02:52:04 +00:00
kpatenio
f4e025a957 Bug 1916016 - update opt-in card for migration to Firefox sidebar r=fluent-reviewers,omc-reviewers,shopping-reviewers,fchasen,pdahiya 
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions

Differential Revision: https://phabricator.services.mozilla.com/D221396
 2024-09-18 20:51:03 +00:00
Sandor Molnar
446bc20f4d Backed out changeset cf3a30d74dec (bug 1916016) for causing xpc failures @ test_sorted_alphabetically.js CLOSED TREE 2024-09-19 01:08:05 +03:00
kpatenio
9e138be518 Bug 1916016 - update opt-in card for migration to Firefox sidebar r=fluent-reviewers,omc-reviewers,shopping-reviewers,fchasen,pdahiya 
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions

Differential Revision: https://phabricator.services.mozilla.com/D221396
 2024-09-18 20:51:03 +00:00
Dão Gottwald
a968b39209 Bug 1919262 - Remove --button-color. r=desktop-theme-reviewers,reusable-components-reviewers,emilio,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D222439
 2024-09-18 06:04:39 +00:00
Iulian Moraru
7fadac62f4 Backed out changeset 8faf0e38aae6 (bug 1918745) for causing xpcshell failures on test_NimbusRolloutMessageProvider.js. 2024-09-16 22:08:37 +03:00
negin
0dd29c39bf Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya 
Adds `FOX_DOODLE_SET_DEFAULT` and `FAKESPOT_CALLOUT_` and removes `Q4_DEVICE_MIGRATION` and `ADDONS_STAFF_PICK` as part of live rollouts.


```
Processing rollout: 1-click-set-to-default-existing-profiles-rollout
  Processing branch: treatment-b
    Importing message: FOX_DOODLE_SET_DEFAULT
Processing rollout: us-review-checker-rollout-v2
  Processing branch: treatment-a
    Importing message 1 of 4: FAKESPOT_CALLOUT_NO_OP_DUMMY
    Importing message 2 of 4: FAKESPOT_CALLOUT_CLOSED_NOT_OPTED_IN_AUTO_OPEN
    Importing message 3 of 4: FAKESPOT_CALLOUT_PDP_NOT_OPTED_IN_REMINDER
    Importing message 4 of 4: FAKESPOT_CALLOUT_OPTED_OUT_SURVEY
Processing rollout: recommend-add-ons-staff-pick-relaunch-treatment-a-rollout
```

Differential Revision: https://phabricator.services.mozilla.com/D222151
 2024-09-16 17:17:01 +00:00
hanna alemu
84f87d979e Bug 1919061 - Fix mis-matched feature config name for configurable Bookmarks button surface r=omc-reviewers,mviar 
This fixes a bug where ASrouter was not receiving Bookmarks Bar button messages from Experimenter

Differential Revision: https://phabricator.services.mozilla.com/D222302
 2024-09-16 16:55:51 +00:00
hanna alemu
8bb0544d31 Bug 1915019 - Include hidden and isBuiltin in addonsInfo targeting values r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D222174
 2024-09-16 13:12:02 +00:00
Julian Descottes
fba56f38cc Bug 1917003 - [eslint] Fix violations for reject-multiple-await r=perftest-reviewers,credential-management-reviewers,places-reviewers,issammani,daisuke,sparky 
Depends on D221187

Differential Revision: https://phabricator.services.mozilla.com/D221306
 2024-09-16 09:13:30 +00:00
Sebastian Hengst
2cc2b0108b Bug 1892548 - disable browser_asrouter_infobar.js on Linux debug for frequent intermittent failures. r=intermittent-reviewers,omc-reviewers,ahal,hanna_a DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D221794
 2024-09-12 21:25:30 +00:00
Mark Banner
fe5b823483 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 21:08:44 +00:00
Mark Banner
aabcf18c26 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 21:08:44 +00:00
Sandor Molnar
b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE 
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
 2024-09-12 20:45:28 +03:00
Mark Banner
4b68d25082 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 16:41:59 +00:00
Mark Banner
e3981e1099 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 16:41:58 +00:00
Dão Gottwald
a771bc70eb Bug 1917588 - Stop setting --button-bgcolor, --button-hover-bgcolor, --button-active-bgcolor in browser-shared.css. r=desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D221480
 2024-09-09 14:57:46 +00:00
Jason Prickett
2622d391ce Bug 1915235 - Remove camel casing from heading links in targeting-attributes.md r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D220306
 2024-08-28 18:28:55 +00:00
Jason Prickett
6d13ee8ae8 Bug 1912351 - Create onSearch trigger and targeting r=mviar,omc-reviewers,urlbar-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D219519
 2024-08-27 16:46:02 +00:00
Gregory Pappas
fae7fba9e6 Bug 1914113 - Remove hidden window usage in ASRouterTargeting r=emilio,omc-reviewers,aminomancer 
- Use nsIXULRuntime to get prefers-reduced-motion instead of the hidden window
- Use nsIScreenManager to get the resolution of the primary display instead of the hidden window

Differential Revision: https://phabricator.services.mozilla.com/D219721
 2024-08-21 20:06:33 +00:00
hanna alemu
698a6834b4 Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 15:09:21 +00:00
Tamas Szentpeteri
03b8b4ec2d Backed out changeset 8e5aa4b063cc (bug 1901261) for causing py3 failures on make-schemas.py. CLOSED TREE 2024-07-31 17:13:20 +03:00
hanna alemu
f04c2799bc Bug 1901261 - Create a remotely configurable bookmarks bar button messaging surface r=mviar,desktop-theme-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D215252
 2024-07-31 13:21:47 +00:00
Meg Viar
a1e3ddb4a7 Bug 1907079 - [Docs] Refine Messaging System glossary r=omc-reviewers,negin 
This patch updates the messaging system glossary in Firefox Source docs to reflect recent feedback.

[[ https://docs.google.com/document/d/11crCIpvYsiHMLtbbdfIwMJ96j01bgoSzTFo8slUAbbA/edit | Google doc with feedback for V2 ]]

Differential Revision: https://phabricator.services.mozilla.com/D217964
 2024-07-30 17:18:11 +00:00
Emily McMinn
53f45deb25 Bug 1903529 - Make addon install state available to the Addons Picker r=mviar,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D216211
 2024-07-25 15:58:02 +00:00
Nipun Shukla
415fe6c69b Bug 1905090 - Update strings to reflect MSIX pin to start functionality r=fluent-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mak,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D216709
 2024-07-24 21:13:36 +00:00
Nipun Shukla
8d8dd02d0f Bug 1901621 - Use start menu pinning as targeting for messages r=aminomancer,omc-reviewers,firefox-desktop-core-reviewers ,pdahiya,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D213158
 2024-07-24 21:13:35 +00:00
Alex Cottner
998694aa4b Bug 1889617 - Enabling the new attachment bundling capability for IntermediatePreloads. r=leplatrem,gbeckley,keeler,omc-reviewers,emcminn 
Depends on D216814.
This patch enables the new attachment bundling/extraction logic for the intermediate certificate downloads.

In my local testing, this gives a significant improvement in the time it takes to download and unpack all the intermediate attachments.

Testing on my laptop (linux laptop on good wifi and gigiabit).
Before: 3.2-4.1 seconds to download and unpack
After: 0.75-0.95 seconds to download and unpack

Would love to pull before/after data for a variety of devices.

Differential Revision: https://phabricator.services.mozilla.com/D216815
 2024-07-23 16:16:10 +00:00
Shane Hughes
080905839f Bug 1905119 - Fix feature callout RTL display. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D216597
 2024-07-16 02:11:32 +00:00
negin
88cc6d35cb Bug 1905175 - add fxa toolbar badge notification message r=omc-reviewers,aminomancer 
Adds [treatment-a of toolbar badge as default experience](https://experimenter.services.mozilla.com/nimbus/firefox-accounts-toolbar-button-default-visibility-existing-users-part-3/summary)
{F7380178}

Differential Revision: https://phabricator.services.mozilla.com/D215547
 2024-07-04 23:08:16 +00:00
Meg Viar
3a2722f608 Bug 1904345 - Ignore duplicate explicit target names r=omc-reviewers,negin 
Duplicate explicit targets in the previous patches resulted in warnings. This patch updated the two remaining duplicate explicit targets to cross-referencing syntax for glossary terms [[ https://docutils.sourceforge.io/docs/user/rst/quickref.html#hyperlink-targets | See documentation here ]].

Differential Revision: https://phabricator.services.mozilla.com/D214804
 2024-07-03 13:45:55 +00:00
Cristina Horotan
77f34279ed Backed out changeset 3cd5c74698b5 (bug 1899747) for causing bc failures at browser_feature_callout.js CLOSED TREE 2024-07-03 03:34:37 +03:00
hanna alemu
6e75b37b22 Bug 1899747 - Add option to extend feature callout page_event_listener to all windows r=omc-reviewers,mviar,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D213239
 2024-07-02 23:44:49 +00:00
negin
33463aa315 Bug 1903841 - Remove ghost shadow on feature callout r=omc-reviewers,aminomancer,mviar 
Removes additional 'ghost' shadow around the feature callout container when the feature callout repositions.

Before:
{F7346454}

After:
{F7346458}

Differential Revision: https://phabricator.services.mozilla.com/D215117
 2024-06-28 14:36:21 +00:00
Shane Hughes
dea4e0688d Bug 1903684 - Fix browser_spotlight_default_messages accessible failure. r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D214350
 2024-06-26 19:06:45 +00:00
Moritz Beier
9d7c26eff8 Bug 1903247 - Remove SearchEngine.searchForm. r=Standard8,omc-reviewers,home-newtab-reviewers,aminomancer,urlbar-reviewers,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D214240
 2024-06-26 16:03:23 +00:00
Meg Viar
3e1a99cbe9 Bug 1904345 - Remove duplicate link targets from messaging glossary and add to toctree r=omc-reviewers,aminomancer 
The multiple instances of links titled "Learn more" in the original patch caused issues. Also, this should be in a toctree under messaging system.

Differential Revision: https://phabricator.services.mozilla.com/D214724
 2024-06-25 00:27:53 +00:00
Shane Hughes
8ce2ea1d0f Bug 1903697 - Slightly improve ASRouter Admin styles. r=emcminn,omc-reviewers 
- Give all bordered tables 100% width.
- Show which view is active in the sidebar by highlighting the active
  tab in blue. Adjust the sidebar styles to match about:preferences.
- Increase the space between filter columns.

Differential Revision: https://phabricator.services.mozilla.com/D214353
 2024-06-24 19:52:53 +00:00
Meg Viar
beb32f7d8e Bug 1869215 - [Docs] Create Messaging System glossary r=omc-reviewers,negin 
Add a glossary of messaging system terms to Firefox source docs.

Differential Revision: https://phabricator.services.mozilla.com/D214106
 2024-06-24 13:24:47 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn 
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
 2024-06-19 19:45:03 +00:00
Shane Hughes
17ca553f9d Bug 1899030 - Part 5: Remove miscellaneous unused asrouter code from newtab. r=mconley,omc-reviewers,frontend-codestyle-reviewers,pdahiya 
Also update nimbus rollout message provider.

Differential Revision: https://phabricator.services.mozilla.com/D211673
 2024-06-19 19:45:02 +00:00
Shane Hughes
ec1f215c37 Bug 1899030 - Part 2: Move remote-text component to asrouter. r=mconley,omc-reviewers,home-newtab-reviewers,negin,pdahiya,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D211670
 2024-06-19 19:45:01 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount 
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
 2024-06-19 19:45:01 +00:00
Shane Hughes
47a7dce369 Bug 1900511 - Fix RC survey background, shadow, and transitions. r=omc-reviewers,pdahiya,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212499
 2024-06-18 16:58:32 +00:00
negin
ea70e6fdc9 Bug 1900984 - Fix Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear r=omc-reviewers,mviar 
Before:
{F7308121}

After:
{F7308122}

Notice the lack of the arrow's shadow on mac OS.

Differential Revision: https://phabricator.services.mozilla.com/D213675
 2024-06-18 15:06:03 +00:00