corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
877,467 Commits 1 Branch 0 Tags
d2bc47834bf63b8db8c4804f875a5011262d77d0
Commit Graph

28577 Commits

Author SHA1 Message Date
Mark Striemer
7a4503972d Bug 1910358 - Unify tab and button sizes in sidebar r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sclements,nsharpley 
Also move sidebar padding into tabs from the container, show scrollbar
gutter with non-overlay scrollbars, prevent icon shifting when expanding
the sidebar, avoid cropping tab background shadows.

Co-authored-by: Tim Giles <tgiles@mozilla.com>

Differential Revision: https://phabricator.services.mozilla.com/D222659
 2024-09-27 15:19:32 +00:00
Florian Quèze
21212e9bd3 Bug 1918702 - Migrate telemetry events to use Glean APIs for security.ui.protectionspopup, r=chutten. 
Differential Revision: https://phabricator.services.mozilla.com/D223606
 2024-09-27 11:48:57 +00:00
Jason Prickett
2817fb56a2 Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221538
 2024-09-26 17:54:01 +00:00
Nicolas Chevobbe
f8685f56a2 Bug 1916355 - [devtools] Make sur waterfall ticks are visible in High Contrast Mode. r=devtools-reviewers,accessibility-frontend-reviewers,jdescottes,nlapre. 
This adds a square next to the label in the status bar that serves
as a legend for the tick. The square background re-uses the colors
of the ticks, and those colors are overridden in High Contrast Mode,
using non-system but highly contrasted colors from a palette that
was created by the accessibility team.

In order for the ticks to be visible, we need to make sure that the
background canvas is displayed, and also the call to colorToRGBA needed
a document to properly handle system colors.

Differential Revision: https://phabricator.services.mozilla.com/D223473
 2024-09-26 15:23:51 +00:00
Sarah Clements
23e1b2e481 Bug 1920958 - Add assets and string change for sidebar experiment r=Mardak,fluent-reviewers,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D223542
 2024-09-26 12:36:13 +00:00
Jonathan Sudiaman
03df9fb463 Bug 1902056 - Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings r=sidebar-reviewers,fluent-reviewers,sclements,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D223314
 2024-09-25 23:30:38 +00:00
James Teow
728cf35f79 Bug 1915273 - Allow revert button to always show until search terms change and fix keyboard focus - r=adw,desktop-theme-reviewers,urlbar-reviewers,dao 
The main purpose of this patch is to make the visibility of the revert button consistent to make it more accessible. After talking with Josh, we agreed the revert icon should always show in an `invalid` pageproxystate until `userTypedValue` differs from the search string. Doing so will make the Revert button be more predictable for keyboard users instead of hiding it when the input field is focused and then showing it again when they press tab (or not making it focusable at all).

The Go button (the right arrow button) will show up again once the user has modified the search terms. I didn't think this would be much of an issue since the Go arrow is not focusable by keyboard, it's not visible when the address bar is not focused, and "Enter" is a well known shortcut to doing the same function.

This involved checking when `persistsearchterms` was changed to `false` and removing it to instead remove `persistsearchterms` when the search terms changed. This is reflected in the new expected behavior in the tests.

One issue was adding `focus` to the revert button via CSS caused focus issues. Tabbing from the left elements (reload button) to the input would skip the input altogether and go straight to the revert button and then to the Save to Pocket button. Pressing shift + tab to try and go back from the revert button to the input would get stuck in a loop between the input field and revert button. This was fixed with `<toolbartabstop/>` . I created a hideable container to ensure the tabstop only exists when the `persistsearchterms` state is active. And the new test checks that the tab behaviour is consistent.

Lastly, because keyboard users might press the Revert button, focusing the input seemed like a logical choice, or else when the focus is lost the user would need to tab all the way back to the input to do more actions. There is also an initiative to move inline Javascript out from markup.

Differential Revision: https://phabricator.services.mozilla.com/D223423
 2024-09-25 22:07:11 +00:00
Sarah Clements
02a48271c6 Bug 1906881 - Update tab context menu strings for vertical tabs mode r=fluent-reviewers,mconley,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D223153
 2024-09-25 10:32:30 +00:00
Sandor Molnar
66bf6a75d0 Backed out changeset e2ea6ce650da (bug 1912403) because "Items pinned to the overflow menu are broken". CLOSED TREE 2024-09-25 13:16:37 +03:00
Florian Quèze
165920b94c Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi. 
Differential Revision: https://phabricator.services.mozilla.com/D222608
 2024-09-25 10:00:41 +00:00
Sandor Molnar
5868fb7220 Backed out changeset 124bf1423a9c (bug 1912403) because "Items pinned to the overflow menu are broken" CLOSED TREE 2024-09-25 12:58:42 +03:00
Sandor Molnar
5095328e2d Backed out 5 changesets (bug 1918702) for causing bc failures @ browser_aaa_eventTelemetry_run_first.js CLOSED TREE 
Backed out changeset f55480885aeb (bug 1918702)
Backed out changeset db1eaf09430d (bug 1918702)
Backed out changeset a9179f6e684d (bug 1918702)
Backed out changeset f9d3349e6fe3 (bug 1918702)
Backed out changeset 10d2957bbfe8 (bug 1918702)
 2024-09-25 12:38:05 +03:00
Florian Quèze
3cf2dde6da Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi. 
Differential Revision: https://phabricator.services.mozilla.com/D222608
 2024-09-25 07:19:05 +00:00
Tom Schuster
4e06b6ddc6 Bug 1912403 - Remove inline command handlers from navigator-toolbox. r=Gijs,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221301
 2024-09-25 07:16:43 +00:00
Dão Gottwald
b05aac4958 Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D223292
 2024-09-25 05:08:37 +00:00
Florian Quèze
c5a791b369 Bug 1918702 - Migrate telemetry events to use Glean APIs for sync, r=chutten. 
Differential Revision: https://phabricator.services.mozilla.com/D222807
 2024-09-25 02:46:36 +00:00
Gregory Pappas
49494b7cae Bug 71895 - Create the hidden window on macOS only r=firefox-desktop-core-reviewers ,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D219834
 2024-09-24 23:45:09 +00:00
Jared Hirsch
3ef6cee5fc Bug 1916506 - Init gProfiles before the end of the startup idle init block. r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D223236
 2024-09-24 16:20:40 +00:00
Butkovits Atila
e9a321c37b Backed out changeset 76c285a906b6 (bug 71895) as requested by dev. CLOSED TREE 2024-09-24 12:28:38 +03:00
Paul Zuehlcke
e6256a22e4 Bug 1915419 - ServiceWorkerCleanUp support for clearing by site and OA pattern. r=anti-tracking-reviewers,dom-storage-reviewers,asuth,timhuang 
Also adds support for clearing SW partitioned under the site to be cleared.

Differential Revision: https://phabricator.services.mozilla.com/D220608
 2024-09-24 09:17:57 +00:00
Norisz Fay
09a2236ef6 Backed out changeset fad1cda93cc8 (bug 1908426) for causing multiple failures CLOSED TREE 2024-09-24 02:13:41 +03:00
abhishekmadan30
9605ca52bd Bug 1895334 - Grey out Copy without Site Tracking option when nothing can be stripped. r=pbz,urlbar-reviewers,anti-tracking-reviewers,dao 
Co-authored-by: Manuel Bucher <manuel@mozilla.com>

Differential Revision: https://phabricator.services.mozilla.com/D215815
 2024-09-23 22:11:50 +00:00
DJ
6ca1b918f3 Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D222017
 2024-09-23 21:17:14 +00:00
tannal
574d43d077 Bug 1920352 - Remove unused dom.testing.sync-content-blocking-notifications pref. r=gregp,anti-tracking-reviewers,pbz 
Differential Revision: https://phabricator.services.mozilla.com/D223071
 2024-09-23 10:51:46 +00:00
Norisz Fay
19ae72513a Backed out changeset ceb7a7e46f59 (bug 1901826) for causing bc failures on browser_fullscreen_tab_preview.js CLOSED TREE 2024-09-20 21:05:24 +03:00
Norisz Fay
ed87104874 Backed out 6 changesets (bug 1915419) for causing xpcshell failures on test_bounce_tracking_protection.js 
Backed out changeset 65896495cce9 (bug 1915419)
Backed out changeset 042d3bc01bdb (bug 1915419)
Backed out changeset 8185b8989a78 (bug 1915419)
Backed out changeset ec3186533ad3 (bug 1915419)
Backed out changeset 0507ac7bb539 (bug 1915419)
Backed out changeset dfde58cea10c (bug 1915419)
 2024-09-20 20:50:27 +03:00
DJ
0206f801b0 Bug 1901826 - prevent tab preview from triggering fullscreen toolbar autohide. r=dao,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D218432
 2024-09-20 16:50:23 +00:00
Paul Zuehlcke
f66d439cd8 Bug 1915419 - ServiceWorkerCleanUp support for clearing by site and OA pattern. r=anti-tracking-reviewers,dom-storage-reviewers,asuth,timhuang 
Also adds support for clearing SW partitioned under the site to be cleared.

Differential Revision: https://phabricator.services.mozilla.com/D220608
 2024-09-20 15:46:37 +00:00
Kagami Sascha Rosylight
0b7ddedb99 Bug 1914417 - Refactor notification permission checker using principal partition key r=asuth,bvandersloot 
This patch keeps the current status where Firefox and Chrome both allows notification permission in ABA context although the spec does not cover it. (https://github.com/whatwg/notifications/issues/177, also listed in https://privacycg.github.io/storage-partitioning/#remaining-user-agent-state)

The child patch in bug 1914203 will add a telemetry to see whether the usage is low enough so that we can block ABA access, to make it more consistent with storage partitioning.

Differential Revision: https://phabricator.services.mozilla.com/D219908
 2024-09-20 14:02:28 +00:00
Florian Quèze
cd093f0a88 Bug 1918702 - Migrate telemetry events to use Glean APIs for screenshots, r=chutten. 
Differential Revision: https://phabricator.services.mozilla.com/D222607
 2024-09-20 13:58:19 +00:00
Florian Quèze
03b00e2a53 Bug 1918702 - Migrate telemetry events to use Glean APIs for firefoxview, r=chutten,fxview-reviewers,jsudiaman. 
Differential Revision: https://phabricator.services.mozilla.com/D222416
 2024-09-20 13:58:15 +00:00
Joel Maher
1217ef421e Bug 1919776 - part 1, adjust browser/base and browser/components osx skip-if conditions to be more specific. r=sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D222841
 2024-09-20 13:15:23 +00:00
Kelly Cochrane
8cacd1c229 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-20 11:40:04 +00:00
Tarek Ziadé
6762cdc263 Bug 1913071 - move to transformers.js v3 r=gregtatum 
Differential Revision: https://phabricator.services.mozilla.com/D220519
 2024-09-20 11:10:24 +00:00
Gregory Pappas
7bb2622a0a Bug 71895 - Create the hidden window on macOS only r=firefox-desktop-core-reviewers ,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D219834
 2024-09-20 00:54:07 +00:00
Henry Wilkes
1a0ae5644c Bug 1919363 - Only show one app menu "new window" item in permanent private browsing. r=mconley 
We also update the browser_private_browsing_window.js test.
The previous test was limited because it was referring to non-existent
"appmenu_newNavigator" and "appmenu_newPrivateWindow".

Differential Revision: https://phabricator.services.mozilla.com/D222507
 2024-09-19 19:23:04 +00:00
Jeremy Swinarton
ca4df10a2c Bug 1908424: Context menu to create a group from single or multiple tabs r=dao,dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D221825
 2024-09-19 18:54:12 +00:00
Butkovits Atila
5a9a789f82 Backed out changeset fb2f7f9f6def (bug 1906888) for causing failures at browser_newtabButton.js. CLOSED TREE 2024-09-19 22:04:46 +03:00
Kelly Cochrane
a83714bc93 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-19 15:54:02 +00:00
Gijs Kruitbosch
d4b4962785 Bug 1913704 - remove pioneer/ion now that it's been retired, r=rhelmer,chutten,firefox-desktop-core-reviewers ,extension-reviewers,desktop-theme-reviewers,emilio,mossop,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D220751
 2024-09-19 13:32:22 +00:00
Sandor Molnar
4b8abca79f Backed out changeset 0fab45288998 (bug 1901826) for causing bc perma failures @ browser_fullscreen_tab_preview.js 2024-09-19 00:18:45 +03:00
jabram
e3fe04ae61 Bug 1916823 - Update About Profiling directory list border color on hover r=cmkm,hjones,desktop-theme-reviewers,profiler-reviewers,mstange,julienw 
Differential Revision: https://phabricator.services.mozilla.com/D222353
 2024-09-18 20:15:28 +00:00
DJ
e107af3f93 Bug 1901826 - prevent tab preview from triggering fullscreen toolbar autohide. r=dao,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D218432
 2024-09-18 19:46:03 +00:00
Paul Zuehlcke
c67647610b Bug 1916659, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D222629
 2024-09-18 18:52:20 +00:00
Butkovits Atila
d779b4bd81 Backed out 12 changesets (bug 1915419) for causing failures at test_bouncetracking_purge.js. CLOSED TREE 
Backed out changeset e5c32a502e0f (bug 1915419)
Backed out changeset 8cbcbb25fc99 (bug 1915419)
Backed out changeset 947379a2f167 (bug 1915419)
Backed out changeset 4cfe3a954ade (bug 1915419)
Backed out changeset 94fba1a2786b (bug 1915419)
Backed out changeset 477b4f7c2760 (bug 1915419)
Backed out changeset ed6c8d9d39d4 (bug 1915419)
Backed out changeset e534c390101c (bug 1915419)
Backed out changeset bc3fe74a8b03 (bug 1915419)
Backed out changeset afefdce605f9 (bug 1915419)
Backed out changeset e58887b90d39 (bug 1915419)
Backed out changeset 114298b7b855 (bug 1915419)
 2024-09-18 17:49:45 +03:00
Paul Zuehlcke
0a77a5edd3 Bug 1915419 - ServiceWorkerCleanUp support for clearing by site and OA pattern. r=anti-tracking-reviewers,dom-storage-reviewers,asuth,timhuang 
Also adds support for clearing SW partitioned under the site to be cleared.

Differential Revision: https://phabricator.services.mozilla.com/D220608
 2024-09-18 12:50:39 +00:00
Tom Schuster
ef1f89bffd Bug 1918723 - Remove inline popup handlers from identity-popup. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D222283
 2024-09-18 08:40:42 +00:00
Tom Schuster
77f8722d4b Bug 1918723 - Remove inline command handlers from identity-popup. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D222135
 2024-09-18 08:40:41 +00:00
James Teow
d5710cd89a Bug 1919193 - Simplify Persisted Search UI - r=adw,desktop-theme-reviewers,urlbar-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D222489
 2024-09-18 04:44:31 +00:00
Henry Wilkes
e8235e9c72 Bug 1919297: Clean up unused isProductURL import in browser.js. r=shopping-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D222477
 2024-09-17 14:07:50 +00:00