Commit Graph

96 Commits

Author SHA1 Message Date
Jeremy Swinarton
8a3c3e1e4c Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-12 16:34:19 +00:00
Dão Gottwald
a4362055ee Bug 1930608 - Refactor _updateAfterMoveTabTo. r=jswinarton,tabbrowser-reviewers
Also simplify moveTabToStart and moveTabToEnd.

Differential Revision: https://phabricator.services.mozilla.com/D228646
2024-11-12 14:09:52 +00:00
Dão Gottwald
b567a0990b Bug 1926371 - Make "Remove from group" not move the tab into another group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228636
2024-11-12 14:09:52 +00:00
Stephen Thompson
b25e5f9796 Bug 1929384 - do not close window if there are still collapsed tab groups r=dao,tabbrowser-reviewers
When closing the last visible tab, if there are any collapsed tab groups, make one of the tabs in a tab group active. Based on pre-existing behavior, activating a tab in a collapsed tab group causes the tab group to expand.

Currently, if you close the last visible tab while you still have collapsed tab groups present on the tab bar, the browser window will close. This is surprising and sad behavior for users.

Differential Revision: https://phabricator.services.mozilla.com/D228274
2024-11-11 10:39:11 +00:00
Emilio Cobos Álvarez
883968ff6c Bug 1928151 - With vertical tabs, make the sidebar and toolbars match the toolbox. r=sidebar-reviewers,sfoster,desktop-theme-reviewers,sclements
As per discussion with UX, we might want the toolbox background to be
different in (some of) our default themes in this case, but that seems
orthogonal, and this seems somewhat straight-forward.

Differential Revision: https://phabricator.services.mozilla.com/D227494
2024-11-09 00:07:54 +00:00
Butkovits Atila
85eb562171 Backed out changeset 307c830b0d2b (bug 1908422) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-11-08 21:50:37 +02:00
Jeremy Swinarton
f5892027d4 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 17:29:38 +00:00
Alexandru Marc
f7c8138cf9 Backed out changeset 9e5edf53c876 (bug 1908422) for causing bc failures @ browser_tab_groups_a11y.js 2024-11-08 16:57:36 +02:00
Jeremy Swinarton
62d713d116 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 13:53:19 +00:00
Stephen Thompson
120dd5317f Bug 1922268: inserting tabs behaves with adjacent tab groups r=dao,tabbrowser-reviewers
Fixes a number of edge cases where tabs created/inserted in the tab strip were incorrectly being placed inside of an adjacent tab group or incorrectly being placed outside of the intended tab group

Differential Revision: https://phabricator.services.mozilla.com/D226705
2024-11-05 17:57:09 +00:00
Stephen Thompson
8e4dfe1e0e Bug 1921814 - add keyboard focus for tab group labels r=dao,dwalker,desktop-theme-reviewers,tabbrowser-reviewers
This patch makes tab group labels "focusable" using the keyboard when the tab strip contains both tabs and tab groups.

Differential Revision: https://phabricator.services.mozilla.com/D226154
2024-11-05 16:52:19 +00:00
DJ
3b0844e1e4 Bug 1922276 - addTabGroup: add showCreateUI option and don't show post-create UI by default. r=dao,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226957
2024-11-05 15:59:01 +00:00
Iulian Moraru
ba826d51af Backed out changeset 068e6a4704bf (bug 1922276) for causing bc failures on browser_tab_groups.js. 2024-11-05 01:45:16 +02:00
DJ
0de1e8d91b Bug 1922276 - addTabGroup: add showCreateUI option and don't show post-create UI by default. r=dao,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226957
2024-11-04 16:31:09 +00:00
Greg Stoll
e8e176f8e8 Bug 1926055 part 1 - add "Unload Tab" to context menu r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson
Also make sure to select another tab if unloading the currently selected
tab (or Firefox View if unloading all tabs in the window) and handle
multiselect.

Differential Revision: https://phabricator.services.mozilla.com/D226346
2024-11-04 12:20:08 +00:00
DJ
181219c0f1 Bug 1923651 - implement "move group to new window" in tabgroup edit menu. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226325
2024-10-31 15:01:07 +00:00
Sam Foster
95be994d16 Bug 1922307 - Adjust the height of the auto-hiding menu toolbar when the tabstrip is hidden. r=desktop-theme-reviewers,dao,tabbrowser-reviewers,urlbar-reviewers
* Set the 'tabs-hidden' attribute on the #navigator-toolbox instead of the #nav-bar
* Add a --urlbar-padding-block variable for the padding around the urlbar

Differential Revision: https://phabricator.services.mozilla.com/D226568
2024-10-24 22:54:23 +00:00
Gijs Kruitbosch
f479b0afd6 Bug 1926834 - put pid pref getter on tabbrowser and use from both tab hover previews and tabbrowser itself, r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D226767
2024-10-24 15:25:36 +00:00
Sandor Molnar
d6591f5235 Backed out 2 changesets (bug 1926055) for causing bc failures @ browser_multiselect_tabs_unload_with_beforeunload.js CLOSED TREE
Backed out changeset 85a555f31920 (bug 1926055)
Backed out changeset db41b497b1be (bug 1926055)
2024-10-22 06:14:17 +03:00
Greg Stoll
ec2f8cd479 Bug 1926055 part 1 - add "Unload Tab" to context menu r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson
Also make sure to select another tab if unloading the currently selected
tab (or Firefox View if unloading all tabs in the window) and handle
multiselect.

Differential Revision: https://phabricator.services.mozilla.com/D226346
2024-10-22 01:34:34 +00:00
Dão Gottwald
f049ccd8d8 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
2024-10-21 14:35:06 +00:00
Dão Gottwald
90a5fa39db Bug 1908438 - Drag and drop support for creating a group. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225799
2024-10-18 17:59:44 +00:00
Jeremy Swinarton
548e49013a Bug 1922655: New tab groups are positioned in the tab strip based on TabContextMenu.contextTab r=dao,sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225071
2024-10-16 20:04:07 +00:00
Jeremy Swinarton
0323d4afe9 Bug 1918712: Context menu to remove tab from group r=dao,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D224480
2024-10-16 15:18:21 +00:00
DJ
d43a8cef11 Bug 1923865 - revise call signature for addTabGroup. r=jswinarton,sessionstore-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D225386
2024-10-15 14:10:39 +00:00
Stephen Thompson
5a16e0d7c5 Bug 1915172 - Restore open tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
1908418 added tab groups and their tab relationships to each window. This patch will restore tab groups and the tabs within them.

Differential Revision: https://phabricator.services.mozilla.com/D224955
2024-10-14 15:31:29 +00:00
Dão Gottwald
891bd8ee42 Bug 1924041 - Stop setting the "hashiddentabs" attribute. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D225325
2024-10-11 14:25:14 +00:00
Dão Gottwald
b6f07a6c23 Bug 1924036 - Remove obsolete showOnlyTheseTabs API and reimplement in BrowserTestUtils. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D225323
2024-10-11 14:25:13 +00:00
DJ
44408879b4 Bug 1918687 - addTabGroup: select unused color if no color specified. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225102
2024-10-10 20:00:23 +00:00
Sam Foster
33db87f9be Bug 1922898 - Correct inactive titlebar color in linux; ensure titlebar toolbars get the browser-titlebar class. r=desktop-theme-reviewers,dao,tabbrowser-reviewers
- Remove the titlebar-color class which is now redundant with browser-titlebar
- Fix the specificity in the linux stylesheet ensuring titlebar toolbars show the theme's background images not the falback colors

Differential Revision: https://phabricator.services.mozilla.com/D224862
2024-10-10 17:28:23 +00:00
Jeremy Swinarton
0026e1e3bc Bug 1922262: Tab group context menu chicklet uses correct styling r=dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D224547
2024-10-10 15:00:02 +00:00
Dão Gottwald
a5b1716f01 Bug 1921860 - Tab counts should include hidden tabs and tabs in collapsed tab groups. r=sthompson
Differential Revision: https://phabricator.services.mozilla.com/D225206
2024-10-10 13:59:46 +00:00
Butkovits Atila
0cf60d509c Backed out changeset 51e855a9eb6c (bug 1922262) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-10-09 20:21:39 +03:00
Jeremy Swinarton
6e84c51003 Bug 1922262: Tab group context menu chicklet uses correct styling r=dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D224547
2024-10-09 15:26:24 +00:00
Dão Gottwald
4268ec21d4 Bug 1923635 - Various MozTabbrowserTabs cleanup. r=dwalker,tabbrowser-reviewers
Did this while working on drag-and-drop code.

Differential Revision: https://phabricator.services.mozilla.com/D225062
2024-10-09 14:46:09 +00:00
Sam Foster
58c1f20705 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-10-02 22:14:13 +00:00
Iulian Moraru
4a9432209c Backed out changeset 98b6ddc6deed (bug 1899598) for causing marionette failures on test_initialize_vertical_tabs.py. CLOSED TREE 2024-10-02 07:49:47 +03:00
DJ
d6722b5ab0 Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D222017
2024-10-02 00:48:13 +00:00
Sam Foster
15a36fe751 Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-10-01 23:37:37 +00:00
Jeremy Swinarton
f7d52456e8 Bug 1918710: Move tab to tab group from tab context menu r=dao,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D222487
2024-10-01 17:25:28 +00:00
Butkovits Atila
883f96f3dd Backed out changeset 2e5b4312b174 (bug 1908426) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-10-01 13:17:36 +03:00
Stanca Serban
24647acde4 Backed out changeset 0b970f2cd8fd (bug 1899598) for causing devtools failures in browser_aboutdebugging_devtoolstoolbox_tooltip_markupview.js. CLOSED TREE 2024-10-01 01:54:25 +03:00
DJ
5cf4713f6b Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D222017
2024-09-30 20:57:36 +00:00
Sam Foster
ef30ebaf5c Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-09-30 18:10:42 +00:00
Dão Gottwald
97f432dc06 Bug 1920922 - Update hidden tab checks to account for tabs in collapsed groups. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D223469
2024-09-26 04:18:45 +00:00
Sarah Clements
02a48271c6 Bug 1906881 - Update tab context menu strings for vertical tabs mode r=fluent-reviewers,mconley,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D223153
2024-09-25 10:32:30 +00:00
Jeremy Swinarton
054865a576 Bug 1917417: Prevent intermittents by closing tabs in tests without animation r=dao,sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D223182
2024-09-25 06:20:49 +00:00
Dão Gottwald
b05aac4958 Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D223292
2024-09-25 05:08:37 +00:00
Norisz Fay
09a2236ef6 Backed out changeset fad1cda93cc8 (bug 1908426) for causing multiple failures CLOSED TREE 2024-09-24 02:13:41 +03:00
DJ
6ca1b918f3 Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D222017
2024-09-23 21:17:14 +00:00