corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
723,152 Commits 1 Branch 0 Tags
d159b2e9fda87e11702f1047cafe36d591f7c89a
Commit Graph

154 Commits

Author SHA1 Message Date
Yulia Startsev
d159b2e9fd Bug 1311726 - Split ScriptLoader into ScriptLoader and ModuleLoader; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132683
 2021-12-09 13:26:21 +00:00
Yulia Startsev
561f830468 Bug 1311726 - Create ScriptLoaderInterface; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132614
 2021-12-09 13:26:20 +00:00
Yulia Startsev
962ed16141 Bug 1311726 - Move getScriptSource to ScriptLoadRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132950
 2021-12-09 13:26:19 +00:00
Yulia Startsev
421ad3b4ca Bug 1311726 - Move Module Evaluation into ModuleLoader; r=jonco 
Module evaluation is independent of it's context. We just need the globalObject to set up the
execution environment.

Differential Revision: https://phabricator.services.mozilla.com/D132678
 2021-12-09 13:26:19 +00:00
Yulia Startsev
c33c5b96b9 Bug 1311726 - Move Dynamic Import Methods to ModuleLoader; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132613
 2021-12-09 13:26:18 +00:00
Yulia Startsev
7d0e3305de Bug 1311726 - Move CheckModuleDependeciesLoaded to ModuleLoadRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132612
 2021-12-09 13:26:17 +00:00
Yulia Startsev
dc01df08b4 Bug 1311726 - Move methods related to resolution and error handling to ModuleLoader;r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132611
 2021-12-09 13:26:17 +00:00
Yulia Startsev
4bca24161d Bug 1311726 - Move methods related to instantiating the module tree to ModuleLoader;r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132610
 2021-12-09 13:26:17 +00:00
Yulia Startsev
4e701f81f2 Bug 1311726 - Create ModuleLoader Class; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132609
 2021-12-09 13:26:16 +00:00
Yulia Startsev
395fed5111 Bug 1311726 - Pass JSContext instead of JSAPI to FillCompileOptionsForRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132608
 2021-12-09 13:26:16 +00:00
Yulia Startsev
ac691d1891 Bug 1311726 - Split EvaluateScript into EvaluateScript and EvaluateModule; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132607
 2021-12-09 13:26:16 +00:00
Yulia Startsev
ef150421f1 Bug 1311726 - Split StartLoad into StartClassicLoad, StartModuleLoad, StartLoadInternal; r=jonco 
The goal of splitting classic script loading from module script loading was to keep a minimum
selection of methods for other script loaders to implement. In addition, the security
flags were distinct for the two cases, and had no overlap.

Caching behavior was left as shared, as it is likely modules will have this soon.

Differential Revision: https://phabricator.services.mozilla.com/D132605
 2021-12-09 13:26:15 +00:00
Butkovits Atila
9982657a6a Backed out 18 changesets (bug 1311726) for causing Hazard failures at ScriptLoader.cpp:. CLOSED TREE 
Backed out changeset 0e1179305bc2 (bug 1311726)
Backed out changeset fd3a9e4f5e5e (bug 1311726)
Backed out changeset d6f6a7d13dc2 (bug 1311726)
Backed out changeset 7b266f1fbbff (bug 1311726)
Backed out changeset 9ecb9ac4f2f7 (bug 1311726)
Backed out changeset 2deb35690efb (bug 1311726)
Backed out changeset a151ddb7068d (bug 1311726)
Backed out changeset 79aac20615b8 (bug 1311726)
Backed out changeset 258188246118 (bug 1311726)
Backed out changeset 0ef6c06dac5b (bug 1311726)
Backed out changeset 340bd3d73849 (bug 1311726)
Backed out changeset d130a9772d31 (bug 1311726)
Backed out changeset 15df1b7e0208 (bug 1311726)
Backed out changeset ebc87f932050 (bug 1311726)
Backed out changeset 68ab853d072d (bug 1311726)
Backed out changeset eac12c9d76b7 (bug 1311726)
Backed out changeset beb9e9b17522 (bug 1311726)
Backed out changeset bfea110e6afe (bug 1311726)
 2021-12-09 02:23:18 +02:00
Yulia Startsev
8e5d0bf0c6 Bug 1311726 - Split ScriptLoader into ScriptLoader and ModuleLoader; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132683
 2021-12-08 16:57:23 +00:00
Yulia Startsev
db9e217a01 Bug 1311726 - Create ScriptLoaderInterface; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132614
 2021-12-08 16:57:22 +00:00
Yulia Startsev
e149cd66c0 Bug 1311726 - Move getScriptSource to ScriptLoadRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132950
 2021-12-08 16:57:21 +00:00
Yulia Startsev
353b9d6a0e Bug 1311726 - Move Module Evaluation into ModuleLoader; r=jonco 
Module evaluation is independent of it's context. We just need the globalObject to set up the
execution environment.

Differential Revision: https://phabricator.services.mozilla.com/D132678
 2021-12-08 16:57:21 +00:00
Yulia Startsev
cfee4ee934 Bug 1311726 - Move Dynamic Import Methods to ModuleLoader; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132613
 2021-12-08 16:57:19 +00:00
Yulia Startsev
4debb9b07d Bug 1311726 - Move CheckModuleDependeciesLoaded to ModuleLoadRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132612
 2021-12-08 16:57:19 +00:00
Yulia Startsev
d28674c471 Bug 1311726 - Move methods related to resolution and error handling to ModuleLoader;r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132611
 2021-12-08 16:57:19 +00:00
Yulia Startsev
09dd32e3a0 Bug 1311726 - Move methods related to instantiating the module tree to ModuleLoader;r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132610
 2021-12-08 16:57:18 +00:00
Yulia Startsev
edb0a11ce4 Bug 1311726 - Create ModuleLoader Class; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132609
 2021-12-08 16:57:18 +00:00
Yulia Startsev
20bb49329c Bug 1311726 - Pass JSContext instead of JSAPI to FillCompileOptionsForRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132608
 2021-12-08 16:57:17 +00:00
Yulia Startsev
1b7f5ec8f1 Bug 1311726 - Split EvaluateScript into EvaluateScript and EvaluateModule; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132607
 2021-12-08 16:57:17 +00:00
Yulia Startsev
1574c2e5d3 Bug 1311726 - Split StartLoad into StartClassicLoad, StartModuleLoad, StartLoadInternal; r=jonco 
The goal of splitting classic script loading from module script loading was to keep a minimum
selection of methods for other script loaders to implement. In addition, the security
flags were distinct for the two cases, and had no overlap.

Caching behavior was left as shared, as it is likely modules will have this soon.

Differential Revision: https://phabricator.services.mozilla.com/D132605
 2021-12-08 16:57:16 +00:00
Narcis Beleuzu
dc53a1d420 Backed out 18 changesets (bug 1311726) for failures on test_script_loader_js_cache.html . CLOSED TREE 
Backed out changeset 1f9c13be6642 (bug 1311726)
Backed out changeset 2f4e89d930b0 (bug 1311726)
Backed out changeset 03f767c08221 (bug 1311726)
Backed out changeset b21e580a778f (bug 1311726)
Backed out changeset 4597b327e9be (bug 1311726)
Backed out changeset 558fec312301 (bug 1311726)
Backed out changeset b758abeed4cc (bug 1311726)
Backed out changeset a909be9fa973 (bug 1311726)
Backed out changeset 8db98e65b147 (bug 1311726)
Backed out changeset ee2e01e59950 (bug 1311726)
Backed out changeset 40c635fb36eb (bug 1311726)
Backed out changeset 6ba119a4e33e (bug 1311726)
Backed out changeset 1ad7d1308b5f (bug 1311726)
Backed out changeset dd2dbe11315d (bug 1311726)
Backed out changeset a8279e757309 (bug 1311726)
Backed out changeset 1de8b528723e (bug 1311726)
Backed out changeset f1e4c9199289 (bug 1311726)
Backed out changeset 23ea474c05ec (bug 1311726)
 2021-12-08 12:46:07 +02:00
Yulia Startsev
f0319391a8 Bug 1311726 - Split ScriptLoader into ScriptLoader and ModuleLoader; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132683
 2021-12-08 09:44:14 +00:00
Yulia Startsev
ccb851f62f Bug 1311726 - Create ScriptLoaderInterface; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132614
 2021-12-08 09:44:13 +00:00
Yulia Startsev
c7b13912f8 Bug 1311726 - Move getScriptSource to ScriptLoadRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132950
 2021-12-08 09:44:12 +00:00
Yulia Startsev
c52c6cab45 Bug 1311726 - Move Module Evaluation into ModuleLoader; r=jonco 
Module evaluation is independent of it's context. We just need the globalObject to set up the
execution environment.

Differential Revision: https://phabricator.services.mozilla.com/D132678
 2021-12-08 09:44:12 +00:00
Yulia Startsev
85fcc0427e Bug 1311726 - Move Dynamic Import Methods to ModuleLoader; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132613
 2021-12-08 09:44:11 +00:00
Yulia Startsev
dca3099826 Bug 1311726 - Move CheckModuleDependeciesLoaded to ModuleLoadRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132612
 2021-12-08 09:44:11 +00:00
Yulia Startsev
eaa6717a61 Bug 1311726 - Move methods related to resolution and error handling to ModuleLoader;r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132611
 2021-12-08 09:44:10 +00:00
Yulia Startsev
fd523172c1 Bug 1311726 - Move methods related to instantiating the module tree to ModuleLoader;r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132610
 2021-12-08 09:44:10 +00:00
Yulia Startsev
f33667d6a0 Bug 1311726 - Create ModuleLoader Class; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132609
 2021-12-08 09:44:09 +00:00
Yulia Startsev
8d491cff49 Bug 1311726 - Pass JSContext instead of JSAPI to FillCompileOptionsForRequest; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132608
 2021-12-08 09:44:09 +00:00
Yulia Startsev
76dbf51229 Bug 1311726 - Split EvaluateScript into EvaluateScript and EvaluateModule; r=jonco 
Differential Revision: https://phabricator.services.mozilla.com/D132607
 2021-12-08 09:44:09 +00:00
Yulia Startsev
283cacade0 Bug 1311726 - Split StartLoad into StartClassicLoad, StartModuleLoad, StartLoadInternal; r=jonco 
The goal of splitting classic script loading from module script loading was to keep a minimum
selection of methods for other script loaders to implement. In addition, the security
flags were distinct for the two cases, and had no overlap.

Caching behavior was left as shared, as it is likely modules will have this soon.

Differential Revision: https://phabricator.services.mozilla.com/D132605
 2021-12-08 09:44:08 +00:00
Denis Palmeiro
277c9da949 Bug 1736057 - Enable off thread full parsing by default for external JS scripts r=smaug,bas 
The results from a nightly experiment, found at https://protosaur.dev/partybal/bug_1722551_pref_full_js_parsing_experiment_nightly_94_94.html, indicate that there is a 2% improvement in the page load time by enabling full parsing for external JS scripts.  This is most noticeable in the low cpu segment, where improvements of up to 10% can be seen.  This all comes at a memory increase of about 1% in the median, and 4% in the worst case.

Differential Revision: https://phabricator.services.mozilla.com/D129158
 2021-10-25 14:54:26 +00:00
Yulia Startsev
7ea1512946 Bug 1725621 - Remove Top Level Await preference and associated code; r=mgaudet 
Differential Revision: https://phabricator.services.mozilla.com/D122586
 2021-08-17 13:08:00 +00:00
Jon Coppeard
c61f167a5e Bug 1678774 - Track more top level load requests while they are being parsed off-thread r=dpalmeiro 
The original patch had caused some assertions so I rewrote it. This now puts
all untracked top-level requests on the new list while they are being compiled
so handles preload requests too.

Differential Revision: https://phabricator.services.mozilla.com/D119386
 2021-07-12 16:31:00 +00:00
Jon Coppeard
a62fd4d79c Bug 1678774 - Cancel off-thread compilations when destroying a ScriptLoader r=dpalmeiro 
There are parse tasks present when the JS engine is being shut down that have
finished but haven't had their results collected by the embedding. This
shouldn't happen, and I think it's happening here because we're leaking a
JSRuntime (we cancel these when we shut down a runtime).

There's a comment that says this isn't necessary but cancelling outstanding
compile requests in ScriptLoader::Destroy fixes this problem on try. I don't
understand well enough to know what's going wrong with the current approach but
this fixes both the crash and the leak.

Differential Revision: https://phabricator.services.mozilla.com/D119315
 2021-07-12 16:30:59 +00:00
Butkovits Atila
c292bb3282 Backed out 3 changesets (bug 1678774) for causing assertion failures at LinkedList.h. CLOSED TREE 
Backed out changeset ed10a56d576e (bug 1678774)
Backed out changeset 31612eaf974f (bug 1678774)
Backed out changeset 867422c9aa5e (bug 1678774)
 2021-07-09 18:37:41 +03:00
Jon Coppeard
6d290c66ee Bug 1678774 - Track more top level load requests while they are being parsed off-thread r=dpalmeiro 
Depends on D119315

Differential Revision: https://phabricator.services.mozilla.com/D119386
 2021-07-09 14:07:05 +00:00
Jon Coppeard
b0faf9a843 Bug 1678774 - Cancel off-thread compilations when destroying a ScriptLoader r=dpalmeiro 
There are parse tasks present when the JS engine is being shut down that have
finished but haven't had their results collected by the embedding. This
shouldn't happen, and I think it's happening here because we're leaking a
JSRuntime (we cancel these when we shut down a runtime).

There's a comment that says this isn't necessary but cancelling outstanding
compile requests in ScriptLoader::Destroy fixes this problem on try. I don't
understand well enough to know what's going wrong with the current approach but
this fixes both the crash and the leak.

Differential Revision: https://phabricator.services.mozilla.com/D119315
 2021-07-09 14:07:05 +00:00
Denis Palmeiro
03649e1468 Bug 1709139 - Replace JS pageload proportion probes with absolute time measurements and add new probes to measure GC and main thread parsing impact during page load. r=sfink,iain,smaug 
Replace JS pageload proportion probes with absolute time measurements and add new probes to measure GC and main thread parsing impact during page load.

Differential Revision: https://phabricator.services.mozilla.com/D114388
 2021-05-12 16:38:40 +00:00
Matthew Gaudet
53b4bde8f3 Bug 1702278 - Defer setting debug metadata until after script compilation is finished. r=tcampbell,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D110459
 2021-04-20 15:31:14 +00:00
Jonatan Klemets
88fdec632f Bug 1668330 - Part 2: Modify the ScriptLoader to work with the API changes for import-assertions. r=yulia 
Differential Revision: https://phabricator.services.mozilla.com/D109495
 2021-04-14 18:04:48 +00:00
Bogdan Tara
7fb523efd6 Backed out 2 changesets (bug 1668330) for GlobalObject.h related bustage and spidermonkey failures CLOSED TREE 
DONTBUILD
Backed out changeset 2d76323e5c0c (bug 1668330)
Backed out changeset ac4f085c9f32 (bug 1668330)
 2021-04-14 18:36:35 +03:00
Jonatan Klemets
69212f8fdd Bug 1668330 - Part 2: Modify the ScriptLoader to work with the API changes for import-assertions. r=yulia 
Differential Revision: https://phabricator.services.mozilla.com/D109495
 2021-04-14 15:22:57 +00:00