corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
859,906 Commits 1 Branch 0 Tags
cf6b65c339c1704b4bd030bcdadde11f693f6d5c
Commit Graph

4254 Commits

Author SHA1 Message Date
Mike Conley
f680db2687 Bug 1892959 - Stub out initial section for backup management within about:preferences. r=backup-reviewers,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,flod,Gijs,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D209055
 2024-05-08 20:37:04 +00:00
Sandor Molnar
da02f8de36 Backed out changeset 5d2a72296044 (bug 1892959) for causing bc failures @ browser/components/preferences/tests/browser_bug731866.js CLOSED TREE 2024-05-08 19:44:06 +03:00
Mike Conley
773e48c40f Bug 1892959 - Stub out initial section for backup management within about:preferences. r=backup-reviewers,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,flod,Gijs,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D209055
 2024-05-08 15:21:37 +00:00
Sidharth Sachdev
98e0d52b70 Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-07 04:21:31 +00:00
Cristina Horotan
65bc72d8e5 Backed out 7 changesets (bug 1802809, bug 1890883, bug 1877720, bug 1403081, bug 1877717) for causing bc failures at browser_primaryPassword.js CLOSED TREE 
Backed out changeset 7bdafce80724 (bug 1877717)
Backed out changeset 4969f17f935c (bug 1877717)
Backed out changeset d700fbbd7541 (bug 1877717)
Backed out changeset 98e31d4cd373 (bug 1802809)
Backed out changeset c1e8c6c34fcc (bug 1877720)
Backed out changeset 0d8d5e77a93c (bug 1403081)
Backed out changeset 594b7bbecd22 (bug 1890883)
 2024-05-06 20:59:20 +03:00
Sidharth Sachdev
0176b1dcff Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-06 15:58:23 +00:00
Stanca Serban
fdfaad305b Backed out 7 changesets (bug 1802809, bug 1877717, bug 1403081, bug 1890883, bug 1877720) for causing localization checks failures in aboutLogins.ftl. CLOSED TREE 
Backed out changeset 62eeb65b23bd (bug 1877717)
Backed out changeset 4fde845a1182 (bug 1877717)
Backed out changeset d3124d383693 (bug 1877717)
Backed out changeset 344ac200b360 (bug 1802809)
Backed out changeset 754a1bf3b55e (bug 1877720)
Backed out changeset 961a1121017e (bug 1403081)
Backed out changeset 19b2252a4ccf (bug 1890883)
 2024-05-06 18:27:03 +03:00
Sidharth Sachdev
6fd74c4252 Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-06 14:54:16 +00:00
Cosmin Sabou
2873243069 Backed out 6 changesets (bug 1877717, bug 1802809, bug 1890883, bug 1877720, bug 1403081) for causing failures on browser_creditCard_doorhanger_action. 
Backed out changeset 8ee572259ac8 (bug 1877717)
Backed out changeset dad0f115e953 (bug 1877717)
Backed out changeset d792b9335db3 (bug 1802809)
Backed out changeset 7610115f0011 (bug 1877720)
Backed out changeset 9c53bcd6a763 (bug 1403081)
Backed out changeset aa4981999347 (bug 1890883)
 2024-05-05 20:37:16 +03:00
Sidharth Sachdev
8716cffc2b Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-05 15:59:35 +00:00
Emilio Cobos Álvarez
45b669a6a7 Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange 
Stop supporting following the system preference, but keep macOS users
able to switch to just text controls (accessibility.tabfocus=1) in the
settings.

Change the meaning of the "Use the tab key to move focus between form
controls and links" checkbox in the Firefox settings, which was
introduced in bug 1628476 to override the system setting.

The intention, I think was that this checkbox being off resulted in
"follow the system" behavior, but that didn't quite happen due to a bug
in the preferences code (this[1] won't unset the pref, because of
this[2], which means we'll just return 0).

This patch changes it so that the checkbox instead always ignores the
system setting. There will no longer be a Firefox setting (neither in
the UI nor on about:config) that means "follow system setting".

This allows us to somewhat simplify the approach compared to the
previous patch in D196110, and keep the accessibility.tabfocus working
as the source of truth without a migration.

In the future, we can think of migrating accessibility.tabfocus to a
boolean pref, which would allow us to do the cleanups to the preferences
code that D196110 did.

[1]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/browser/components/preferences/main.js#2252
[2]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/toolkit/content/preferencesBindings.js#450,483

Differential Revision: https://phabricator.services.mozilla.com/D208602
 2024-05-03 23:10:47 +00:00
Stanca Serban
ba7ef6bf02 Backed out 6 changesets (bug 1802809, bug 1890883, bug 1877717, bug 1403081, bug 1877720) multiple mochitests failures. CLOSED TREE 
Backed out changeset 8b238dd69206 (bug 1877717)
Backed out changeset c6e16bf303ed (bug 1877717)
Backed out changeset e4d8856edf45 (bug 1802809)
Backed out changeset 9a6a418a1e45 (bug 1877720)
Backed out changeset b587dcaf8f9f (bug 1403081)
Backed out changeset 17febe56cad6 (bug 1890883)
 2024-05-03 22:01:28 +03:00
Sidharth Sachdev
2ca5d5e1dd Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D201276
 2024-05-03 17:23:48 +00:00
Sandor Molnar
781c22a42f Backed out 2 changesets (bug 1892947) due to critical failure with clear on shutdown CLOSED TREE 
Backed out changeset 5c4c36caa85d (bug 1892947)
Backed out changeset eeabe25b2ac3 (bug 1892947)
 2024-05-03 19:56:31 +03:00
Tamas Szentpeteri
453ac165cb Backed out changeset 644738c3ccfe (bug 1036966) for causing mochitest failures in test_tabindex.html. CLOSED TREE 2024-05-03 04:18:36 +03:00
Emilio Cobos Álvarez
87eeb156af Bug 1036966 - Make accessibility.tabfocus default to 7 on macOS too. r=morgan,settings-reviewers,mac-reviewers,mstange 
Stop supporting following the system preference, but keep macOS users
able to switch to just text controls (accessibility.tabfocus=1) in the
settings.

Change the meaning of the "Use the tab key to move focus between form
controls and links" checkbox in the Firefox settings, which was
introduced in bug 1628476 to override the system setting.

The intention, I think was that this checkbox being off resulted in
"follow the system" behavior, but that didn't quite happen due to a bug
in the preferences code (this[1] won't unset the pref, because of
this[2], which means we'll just return 0).

This patch changes it so that the checkbox instead always ignores the
system setting. There will no longer be a Firefox setting (neither in
the UI nor on about:config) that means "follow system setting".

This allows us to somewhat simplify the approach compared to the
previous patch in D196110, and keep the accessibility.tabfocus working
as the source of truth without a migration.

In the future, we can think of migrating accessibility.tabfocus to a
boolean pref, which would allow us to do the cleanups to the preferences
code that D196110 did.

[1]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/browser/components/preferences/main.js#2252
[2]: https://searchfox.org/mozilla-central/rev/f1532761de0b60337e42c6c3f525288a523dabef/toolkit/content/preferencesBindings.js#450,483

Differential Revision: https://phabricator.services.mozilla.com/D208602
 2024-05-02 22:19:53 +00:00
Harshit Sohaney
d31c7d1d35 Bug 1892947 - (part 2) tests for clear cookies and site data on shutdown pref alignment with new clear history dialog. r=pbz,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D208411
 2024-04-26 08:04:06 +00:00
Harshit Sohaney
854b999c9d Bug 1892947 - Align clear on shutdown for cookies and site data section prefs to the new clear on shutdown prefs. r=pbz,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D208410
 2024-04-26 08:04:05 +00:00
Barret Rennie
0633e0cca7 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers 
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
 2024-04-24 20:15:19 +00:00
Nipun Shukla
0b77cf1569 Bug 1892782 - Enable Firefox launch on login by default r=nalexander,settings-reviewers,mconley 
Depends on D207595

Differential Revision: https://phabricator.services.mozilla.com/D208182
 2024-04-23 14:08:52 +00:00
Nipun Shukla
87498965b0 Bug 1888263 - Disable Firefox launch on login for MSIX builds r=nrishel,settings-reviewers,mconley,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D207595
 2024-04-23 14:08:52 +00:00
Dale Harvey
5f9ad2e51c Bug 1871206 - Implement secondary actions for the urlbar. r=mak,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203381
 2024-04-23 11:33:33 +00:00
Harshit Sohaney
6e16821d9b Bug 1890595 - Add longer timeout for new clear history dialog test. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D207634
 2024-04-23 10:32:58 +00:00
Iulian Moraru
b2f394db04 Backed out changeset 89b76affef99 (bug 1883673) for causing multiple bc failures. CLOSED TREE 2024-04-22 22:12:59 +03:00
Barret Rennie
b288396795 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers 
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
 2024-04-22 17:57:31 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D190612
 2024-04-22 16:24:30 +00:00
Erik Nordin
23f1fc2b67 Bug 1892068 - Update Translations Settings Language r=translations-reviewers,fluent-reviewers,settings-reviewers,gregtatum,bolsson 
Updates the language used in Translations Settings
from using the verb "...install..." to "...download..."

Differential Revision: https://phabricator.services.mozilla.com/D207770
 2024-04-19 14:11:58 +00:00
spdev
fdab93dde8 Bug 1844935 - Replace restart prompt when changing history settings with an in-content dialogue box. r=cmkm,settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D207202
 2024-04-18 15:43:00 +00:00
Masatoshi Kimura
4d07b74011 Bug 1891926 - Make "network.proxy.system_wpad.allowed" actually work. r=settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D207701
 2024-04-17 14:49:40 +00:00
Yi Xiong Wong
03a2372d77 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D207110
 2024-04-15 10:22:46 +00:00
Meera Murthy
6f28093de8 Bug 1876286 - [translations] Dynamically populate the dropdown menu selectors in the Secondary Translation Settings. r=nordzilla,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,translations-reviewers,emilio,bolsson,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D199604
 2024-04-10 15:40:06 +00:00
Harshit Sohaney
1e60c930a9 Bug 1881797 - (part 3) Testing for storage permission clearing in the new clear history dialog. r=pbz,settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D204919
 2024-04-09 15:39:32 +00:00
Erik Nordin
e01cd41e38 Bug 1889687 - Ensure new Translations settings is hidden form search r=Gijs,settings-reviewers 
Ensures that the new Translations Settings subpage
has the `data-hidden-from-search` attribute so that
stubbed content is not discoverable accidentally.

Differential Revision: https://phabricator.services.mozilla.com/D206669
 2024-04-05 00:30:32 +00:00
Cristian Tuns
38479260ab Backed out changeset 87bc463d10b0 (bug 1889687) for causing bc failures in browser_translations_about_preferences_settings_ui.js CLOSED TREE 2024-04-04 15:05:58 -04:00
Erik Nordin
3ef6e08d83 Bug 1889687 - Ensure new Translations settings is hidden form search r=Gijs,settings-reviewers 
Ensures that the new Translations Settings subpage
has the `data-hidden-from-search` attribute so that
stubbed content is not discoverable accidentally.

Differential Revision: https://phabricator.services.mozilla.com/D206669
 2024-04-04 16:34:49 +00:00
Joel Maher
a1c9f109b8 Bug 1889412 - skip 25+ minute manifests on asan/tsan. r=aryx,extension-reviewers,settings-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D206512
 2024-04-03 17:46:29 +00:00
Meera Murthy
b6cc86fbab Bug 1887529 - [translations] Translations Setting page showing up when about:preferences is opened for the first time. r=nordzilla,settings-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D205815
 2024-04-03 13:07:50 +00:00
Gijs Kruitbosch
d9adc27a64 Bug 1884370 - drop confusing label from DoH settings, r=mossop,settings-reviewers,desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D205345
 2024-04-02 16:07:55 +00:00
Mark Hammond
f5852b3983 Bug 1884748 - add alt text to images in about:preferences#sync. r=fluent-reviewers,flod,mconley,accessibility-frontend-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D205090
 2024-03-28 19:11:27 +00:00
Gijs Kruitbosch
ebdac1f915 Bug 1887925 - remove unused telemetryBucketForCategory and keyset handling from preferences, r=mconley,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D205732
 2024-03-26 17:54:05 +00:00
Andrew Creskey
98f23f49ec Bug 1861808 - Firefox incorrectly says DNS-over-HTTPS is active when disabled by parental controls r=necko-reviewers,settings-reviewers,valentin 
We ensure that parental controls are tested in the UI.

Differential Revision: https://phabricator.services.mozilla.com/D203035
 2024-03-25 15:38:54 +00:00
Anna Yeddi
f8da9a80ab Bug 1886268 - Add exceptions from a11y_checks for two clicks on non-interactive elements in Settings UI. r=settings-reviewers,Gijs 
The `browser/browser/components/preferences/tests/browser_subdialogs.js` sends two clicks on the following non-interactive element to check the closing of the opened dialog using an alternative way of the popup dismissal is working as expected:
1. [label with "dialogTitle" class](https://searchfox.org/mozilla-central/rev/09b59a7de6848639f27297888889a06e97561074/browser/components/preferences/tests/browser_subdialogs.js#407-414) to confirm nothing happens
1. [overlay background with "dialogTemplate" ID](https://searchfox.org/mozilla-central/rev/09b59a7de6848639f27297888889a06e97561074/browser/components/preferences/tests/browser_subdialogs.js#416-435) to confirm clicking outside of the dialog does, in fact, closes it.

For users of keyboards and assistive technology another way like pressing `Esc` key is available to dismiss the dialog, thus we need to add exceptions from the a11y_checks for this tests via `setEnv` and remove the `fail-if` notation from its test manifest.

Differential Revision: https://phabricator.services.mozilla.com/D205120
 2024-03-20 23:27:36 +00:00
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao 
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
 2024-03-18 09:15:07 +00:00
Tim Giles
4b1c3b2da6 Bug 1864606 - Fix missing label association for crash reports checkbox r=fluent-reviewers,Gijs,bolsson 
Thanks to mhowell for the STRIP_ANCHOR function in the Fluent migration.

We were using the "for" attribute on a XUL label which does not behave
like an HTML label. This prevented the programmatic association
between the checkbox and the label. By utilizing moz-label, we maintain
the accesskey behavior of the previous XUL label.

Additionally we use moz-support-link to remove the
"collection-backlogged-crash-reports-link" Fluent string.

Differential Revision: https://phabricator.services.mozilla.com/D204557
 2024-03-15 00:10:38 +00:00
Mark Banner
99b2331403 Bug 1867288 - Load application provided search engine icons from remote settings. r=search-reviewers,mcheang,mconley 
Depends on D204529

Differential Revision: https://phabricator.services.mozilla.com/D204263
 2024-03-13 22:14:28 +00:00
Butkovits Atila
f35ecbe910 Backed out 3 changesets (bug 1885193, bug 1885177, bug 1867288) for causing documentation failure. CLOSED TREE 
Backed out changeset 80f62f285117 (bug 1885193)
Backed out changeset 91c5d5cb698c (bug 1867288)
Backed out changeset e0611f8935ff (bug 1885177)
 2024-03-13 23:25:16 +02:00
Mark Banner
8432a66c33 Bug 1867288 - Load application provided search engine icons from remote settings. r=search-reviewers,mcheang,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D204263
 2024-03-13 20:25:06 +00:00
Mark Banner
f65518c3c0 Bug 1882577 - Make nsISearchEngine.getIconURL an async function. r=search-reviewers,extension-reviewers,settings-reviewers,robwu,mcheang,mak 
Differential Revision: https://phabricator.services.mozilla.com/D203026
 2024-03-13 14:51:06 +00:00
Mark Banner
12acbf468b Bug 1884181 - Introduce a DefaultEngineDropDown class for search preferences and have EngineStore notify it and EngineView appropriately. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204024
 2024-03-12 13:38:15 +00:00
Mark Banner
2fe70e7c07 Bug 1884181 - Make EngineStore._engines a public property, remove the setter/getter. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D204023
 2024-03-12 13:38:14 +00:00