corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
810,234 Commits 1 Branch 0 Tags
cf2f871874f15731e52b468ca4691237e890c67d
Commit Graph

162 Commits

Author SHA1 Message Date
James Teh
25f0d4edd4 Bug 1692110 part 3: Don't run accessibility checks for click events generated by drag/drop. r=places-reviewers,ayeddi,Gijs,Standard8 
Drag/drop generates click events, but these aren't actually a click event intended to activate a control.
Therefore, we don't want to run accessibility checks for the target.
To achieve this, EventUtils.synthesizeDropAfterDragOver instructs AccessibilityUtils to ignore click events while the event is being sent.
This requires that EventUtils has the reference to AccessibilityUtils set by the browser test harness.
As such, some tests had to be adjusted so that they use EventUtils from the browser test scope, rather than loading their own copy of EventUtils.

Depends on D190004

Differential Revision: https://phabricator.services.mozilla.com/D185776
 2023-10-09 18:20:12 +00:00
Cristian Tuns
896197e59e Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE 
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
 2023-10-07 14:43:05 -04:00
James Teh
80f8010047 Bug 1692110 part 3: Don't run accessibility checks for click events generated by drag/drop. r=places-reviewers,ayeddi,Gijs,Standard8 
Drag/drop generates click events, but these aren't actually a click event intended to activate a control.
Therefore, we don't want to run accessibility checks for the target.
To achieve this, EventUtils.synthesizeDropAfterDragOver instructs AccessibilityUtils to ignore click events while the event is being sent.
This requires that EventUtils has the reference to AccessibilityUtils set by the browser test harness.
As such, some tests had to be adjusted so that they use EventUtils from the browser test scope, rather than loading their own copy of EventUtils.

Differential Revision: https://phabricator.services.mozilla.com/D185776
 2023-10-06 18:11:30 +00:00
Marco Bonardo
6874dffc71 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-15 09:16:34 +00:00
Sandor Molnar
5d8dd001ad Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE 
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
 2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-14 16:33:13 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D177423
 2023-05-24 15:52:34 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Gijs Kruitbosch
b965c4660a Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166179
 2023-01-31 11:48:41 +00:00
Gijs Kruitbosch
5a903703c5 Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D167153
 2023-01-19 20:16:42 +00:00
Mike Conley
ffe9f710be Bug 1801678 - Refactor OverflowableToolbar to turn #webExtList into a memoizing getter. r=Gijs 
The WebExtension overflow list is created lazily because the panel itself is lazy, and only gets
inserted the first time it is needed. Originally, I had written a separate function `#getWebExtList()`
to do the work of forcing the WebExtension overflow list to de-lazify, and then hold a reference
to it in #webExtList.

It turns out, that's a bit of a footgun. More than once, I've used #webExtList directly, forgetting
that the value might turn out to be `null` because the list hasn't delazified yet.

In order to smooth out that rough edge, this patch makes `#webExtList` a memoizing (evalutes once,
caches the return value for subsequent calls) getter so that anything that uses it doesn't have
to worry about the lazification. The reference member is now called #webExtListRef, and I've
added documentation about how it's probably best not to use it directly.

Differential Revision: https://phabricator.services.mozilla.com/D162585
 2022-11-24 18:51:19 +00:00
Mike Conley
bd0a2d6a38 Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand 
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Depends on D160292

Differential Revision: https://phabricator.services.mozilla.com/D160293
 2022-11-01 21:50:56 +00:00
Butkovits Atila
517ae6c72a Backed out 3 changesets (bug 1797155) for causing failures at browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 
Backed out changeset 67f5e4af25b6 (bug 1797155)
Backed out changeset b8a8bd646606 (bug 1797155)
Backed out changeset ec7cdd68c414 (bug 1797155)
 2022-11-01 19:33:25 +02:00
Mike Conley
7ba904bf88 Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand 
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Differential Revision: https://phabricator.services.mozilla.com/D160293
 2022-11-01 16:44:33 +00:00
Marian-Vasile Laza
e32d202d39 Backed out 3 changesets (bug 1797155) for causing bc failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 
Backed out changeset ee3f27f43bc5 (bug 1797155)
Backed out changeset 863603ed770a (bug 1797155)
Backed out changeset 3fbfc3d94e5a (bug 1797155)
 2022-10-31 21:29:22 +02:00
Mike Conley
fc80458832 Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand 
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.

Differential Revision: https://phabricator.services.mozilla.com/D160293
 2022-10-31 18:05:20 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Tooru Fujisawa
f947410342 Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 04:42:09 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE 
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
 2022-06-06 07:04:25 +03:00
Tooru Fujisawa
b580e51d8f Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 02:49:13 +00:00
Mark Banner
d22663f0f9 Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D140518
 2022-03-17 22:13:08 +00:00
Cristian Tuns
a180c6cba3 Backed out changeset 528295e7cb0c (bug 1758476) for causing tabswitch failures CLOSED TREE 2022-03-14 12:27:48 -04:00
Mark Banner
beed912c8e Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D140518
 2022-03-14 10:19:40 +00:00
Mike Conley
aeb6969fe7 Bug 1746670 - Make it possible to register CUI areas with overflowable: false. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D134196
 2021-12-17 21:52:46 +00:00
Hardik Sharma
8912cde481 Bug 1716996 - Replace waitForCondition use in customizableui tests with TestUtils.waitForCondition r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D119509
 2021-07-14 15:31:12 +00:00
Emma Malysz
a5a8f40979 Bug 1692176, add restore previous session to history panel r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D110178
 2021-03-31 16:22:52 +00:00
Tim Nguyen
887622c475 Bug 1632092 - Rename all XUL namespace variables to XUL_NS. r=Gijs,marionette-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D71913
 2020-04-24 09:23:52 +00:00
Dão Gottwald
91122eb636 Bug 1610497 - Increase browser window min-width so the address bar can be focused by mouse. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D60960
 2020-01-30 15:59:29 +00:00
Dão Gottwald
6845ef2fdd Bug 1560348 - Remove CustomizeMode::_doTransition. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D58763
 2020-01-16 11:41:36 +00:00
Masayuki Nakano
6785846ee5 Bug 1605918 - Get rid of synthesizeDragStart() in EventUtils.js r=smaug 
All usage of `synthesizeDragStart()` is, starting drag, cancel `dragstart`,
and finally compares `dataTransfer` items and given expected data.  So,
we can make the users use `synthesizePlainDragAndDrop()` instead.  It's
better API because it computes position of mouse operations at runtime and
checks whether the drag start was succeeded with optional logging feature
(i.e., it's easier to debug of intermittent failures).

This patch creates `synthesizePlainDragAndCancel()` for convenience.  It
handles `dragstart` instead of the callers.

Differential Revision: https://phabricator.services.mozilla.com/D58214
 2019-12-27 16:25:24 +00:00
Dão Gottwald
37548a28a9 Bug 1582797 - OverflowableToolbar should respond to resize events immediately. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D46624
 2019-09-25 12:09:32 +00:00
harry
17bf0b1e94 Bug 1578485 - Re-enable browser_918049_skipintoolbarset_dnd.js. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D45031
 2019-09-06 17:17:07 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
 2019-07-05 09:53:32 +02:00
Andrew Swan
1ab513d145 Bug 1519577 Convert toolbarbutton to a custom element r=surkov 
Differential Revision: https://phabricator.services.mozilla.com/D31941
 2019-05-20 10:01:02 -07:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D17526
 2019-01-30 17:26:25 +00:00
Mark Banner
4d21b8103b Bug 1521707 - Move promisePopupEvent to BrowserTestUtils.jsm. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D17259
 2019-01-23 14:04:46 +00:00
Brian Grinstead
86f1e34bf2 Bug 1505734 - Remove logic from CustomizableUI toolbar XBL constructor;r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D11665
 2018-11-14 00:46:20 +00:00
Olli Pettay
9ec288f641 Bug 1498379 - browser_homeDrop.js and head.js rely on EventUtils.js to dispatch artificial mouseup after dnd, r=gijs 2018-10-15 22:33:05 -04:00
Gurzau Raul
e16c05e44c Backed out 2 changesets (bug 1498379, bug 1498381) for permafailing at /test/tabs/browser_multiselect_tabs_drag_to_bookmarks_toolbar.js a=backout 
Backed out changeset 0178681fab81 (bug 1498379)
Backed out changeset 962c7631d98c (bug 1498381)
 2018-10-15 01:14:40 +03:00
Olli Pettay
c9441cbb76 Bug 1498379 - browser_homeDrop.js and customizableui/test/head.js rely on EventUtils.js to dispatch artificial mouseup after dnd, r=gijs 2018-10-13 13:10:15 +03:00
Brendan Dahl
e9ca78bdbc Bug 1492619 - Use children instead of childNodes in customizable ui tests. r=bgrins 
Fixes browser_customization_context_menus.js

MozReview-Commit-ID: KtRIFGu5ILA

Differential Revision: https://phabricator.services.mozilla.com/D6335
 2018-09-19 22:43:04 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop 
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
 2018-08-31 05:59:17 +00:00
Boris Zbarsky
e98236cf07 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Gijs Kruitbosch
cf31d2f771 Bug 962248 - rewrite zoom test to be less terrible, r=dthayer 
MozReview-Commit-ID: ByUM61fsOgh
 2018-05-09 09:07:37 +01:00
Paolo Amadini
69d214a80c Bug 1444392 - Part 1 - Add test-only helpers to open and close the main menu. r=Gijs 
MozReview-Commit-ID: 9kvUdw2TeHB
 2018-04-04 11:34:16 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
 2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE 
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
 2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
 2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE 
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
 2018-01-30 02:32:43 +02:00