Commit Graph

135 Commits

Author SHA1 Message Date
Jared Hirsch
1b0720c6d7 Bug 1957924 - Ensure profile group ID is applied to all profiles after re-enabling data collection. r=profiles-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D244260
2025-04-07 14:41:31 +00:00
Stanca Serban
2018c5fbd0 Backed out changeset 3ffd7e1d0343 (bug 1957924) for causing mochitests failures in browser_preferences.js. CLOSED TREE 2025-04-04 04:08:27 +03:00
Jared Hirsch
5fe4b738fb Bug 1957924 - Ensure profile group ID is applied to all profiles after re-enabling data collection. r=profiles-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D244260
2025-04-03 23:59:18 +00:00
Jared Hirsch
e33e0b5fd5 Bug 1956105 - Propagate data upload pref changes between profiles in a group. r=profiles-reviewers,settings-reviewers,mossop
Add a pref that we overlooked in the original patch (bug 1933264).

Differential Revision: https://phabricator.services.mozilla.com/D242863
2025-03-26 23:25:15 +00:00
Cosmin Sabou
c0283b2ae1 Backed out changeset 4f577328f67e (bug 1956105) for causing bc failures on browser_privacy_uploadEnabled. CLOSED TREE 2025-03-27 00:54:44 +02:00
Jared Hirsch
1f15c60a14 Bug 1956105 - Propagate data upload pref changes between profiles in a group. r=profiles-reviewers,settings-reviewers,mossop
Add a pref that we overlooked in the original patch (bug 1933264).

Differential Revision: https://phabricator.services.mozilla.com/D242863
2025-03-26 16:05:08 +00:00
Niklas Baumgardner
4650044b77 Bug 1955397 - Only get computed theme colors if default theme. r=profiles-reviewers,jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D242569
2025-03-25 14:15:54 +00:00
Jared Hirsch
a78e75d919 Bug 1933264 - Copy data preferences between profiles in a group. r=profiles-reviewers,fluent-reviewers,settings-reviewers,mossop,bolsson
Also add an explanatory note to preferences.

Differential Revision: https://phabricator.services.mozilla.com/D241902
2025-03-20 17:17:57 +00:00
Niklas Baumgardner
13d3167b04 Bug 1950167, 1953316 - Use InspectorUtils.colorToRGBA to get correct color values for profiles themeObserver. r=profiles-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D241229
2025-03-19 14:57:39 +00:00
Norisz Fay
3c61b6da79 Backed out changeset bf1fbdd6bd71 (bug 1950167) for causing profiles related failures 2025-03-17 21:58:44 +02:00
Niklas Baumgardner
3adef40ecc Bug 1950167, 1953316 - Use InspectorUtils.colorToRGBA to get correct color values for profiles themeObserver. r=profiles-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D241229
2025-03-17 16:42:09 +00:00
Dave Townsend
7d1cb65882 Bug 1926997: New profile directories should not be world readable. r=profiles-reviewers,jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D241597
2025-03-17 15:08:58 +00:00
Dave Townsend
1c393c8eed Bug 1952597: Fix passing command line arguments to the correct Firefox profile. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D240838
2025-03-10 14:04:20 +00:00
Jared Hirsch
8936495a5b Bug 1933222 - Work around vanishing macos dock icon by overwriting it a second later. r=mossop,spohl,profiles-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240555
2025-03-06 23:07:34 +00:00
Dave Townsend
6fe220c9fd Bug 1937061: Hide new profile instances from the recent applications section of the dock. r=nika,spohl,profiles-reviewers,jhirsch
Adds an API to nsIMacDockSupport to allow launching an application bundle and hiding it from the
list of recent applications.

Differential Revision: https://phabricator.services.mozilla.com/D238206
2025-03-06 14:28:08 +00:00
Butkovits Atila
847b25f4e8 Backed out changeset 72ea1c22c996 (bug 1937061) for causing failures at test_delete_last_profile.js. 2025-03-06 15:06:44 +02:00
Dave Townsend
8c83e98f5e Bug 1937061: Hide new profile instances from the recent applications section of the dock. r=nika,spohl,profiles-reviewers,jhirsch
Adds an API to nsIMacDockSupport to allow launching an application bundle and hiding it from the
list of recent applications.

Differential Revision: https://phabricator.services.mozilla.com/D238206
2025-03-06 11:32:40 +00:00
Niklas Baumgardner
1fdd122166 Bug 1927925 - Allow last profile to be deleted via SelectableProfileService. r=profiles-reviewers,jhirsch,mossop
Differential Revision: https://phabricator.services.mozilla.com/D239158
2025-03-04 17:18:25 +00:00
Sandor Molnar
45772aceef Backed out changeset 3f5fd40efb0f (bug 1927925) for causing xpc failures @ test_delete_last_profile.js CLOSED TREE 2025-03-03 18:03:46 +02:00
Niklas Baumgardner
811a886162 Bug 1927925 - Allow last profile to be deleted via SelectableProfileService. r=profiles-reviewers,jhirsch,mossop
Differential Revision: https://phabricator.services.mozilla.com/D239158
2025-03-03 15:11:53 +00:00
Cieara Meador
84808154a0 Bug 1936632 - Enable Profiles pref if enrolled in experiment r=emcminn,profiles-reviewers,mossop,jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D239216
2025-02-27 16:51:20 +00:00
Niklas Baumgardner
fb210d2cf0 Bug 1927193 - Read color values for default theme in profiles themeObserver. r=profiles-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D237943
2025-02-19 19:33:36 +00:00
Dave Townsend
16739ed121 Bug 1927808: Profiles should remain disabled if BlockAboutProfiles enterprise policy is active. r=mkaply,profiles-reviewers,firefox-desktop-core-reviewers ,Gijs,jhirsch
This also ensures we are more consistent about using the state of `SelectableProfileService.isEnabled` to check if the feature is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D236848
2025-02-18 11:28:15 +00:00
Goloman Adrian
0e650176ac Backed out changeset 23237bed6270 (bug 1927808) for causing xpc failures @test_sync_warning_dialogs.js. CLOSED TREE 2025-02-17 13:45:43 +02:00
Dave Townsend
9ae2b19dba Bug 1927808: Profiles should remain disabled if BlockAboutProfiles enterprise policy is active. r=mkaply,profiles-reviewers,firefox-desktop-core-reviewers ,Gijs,jhirsch
This also ensures we are more consistent about using the state of `SelectableProfileService.isEnabled` to check if the feature is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D236848
2025-02-17 10:52:15 +00:00
Goloman Adrian
260e6fa6bb Backed out changeset cc9c1dbec866 (bug 1927808) for causing multiple failures. CLOSED TREE 2025-02-17 12:20:26 +02:00
Dave Townsend
b4ae0c1ece Bug 1927808: Profiles should remain disabled if BlockAboutProfiles enterprise policy is active. r=mkaply,profiles-reviewers,firefox-desktop-core-reviewers ,Gijs,jhirsch
This also ensures we are more consistent about using the state of `SelectableProfileService.isEnabled` to check if the feature is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D236848
2025-02-17 09:07:43 +00:00
Dave Townsend
906a8c5f30 Bug 1945207: Open URLs passed via NSApplicationDelegate in the correct profile. r=jhirsch,profiles-reviewers
Unlike other platforms on macOS if Firefox is already running and an application wants to open a URL
it doesn't use a command line call. Instead the URLs are passed via the NSApplicationDelegate
instance, our implementation of that creates a new nsICommandLine and runs it through the existing
handlers. This entirely skips the startup logic for choosing the default profile and so URLs are
simply opened in whatever profile happens to be running. Not sure what the precise logic is when
multiple profiles are running, it seems like the oldest one wins, not the most recently used one
which is what we want.

Here we intercept the new command line, attempt to guess if we may need to send it to a different
profile and if so do so by using the normal command line approach which will then use the startup
logic to choose the correct profile to use.

One niggle to this is that macOS also automatically focuses the existing instance of Firefox prior
to sending us the URLs which causes us to immediately switch the default profile. This patch
introduces a delay to that so we process the URLs before the default profile can change.

Differential Revision: https://phabricator.services.mozilla.com/D237221
2025-02-14 14:32:37 +00:00
Norisz Fay
a8aa5a296d Backed out changeset b30669a3b55f (bug 1945207) for causing bc failures on browser_update_profile_on_window_switch.js 2025-02-13 13:10:07 +02:00
Dave Townsend
b624e1ec3a Bug 1945207: Open URLs passed via NSApplicationDelegate in the correct profile. r=jhirsch,profiles-reviewers
Unlike other platforms on macOS if Firefox is already running and an application wants to open a URL
it doesn't use a command line call. Instead the URLs are passed via the NSApplicationDelegate
instance, our implementation of that creates a new nsICommandLine and runs it through the existing
handlers. This entirely skips the startup logic for choosing the default profile and so URLs are
simply opened in whatever profile happens to be running. Not sure what the precise logic is when
multiple profiles are running, it seems like the oldest one wins, not the most recently used one
which is what we want.

Here we intercept the new command line, attempt to guess if we may need to send it to a different
profile and if so do so by using the normal command line approach which will then use the startup
logic to choose the correct profile to use.

One niggle to this is that macOS also automatically focuses the existing instance of Firefox prior
to sending us the URLs which causes us to immediately switch the default profile. This patch
introduces a delay to that so we process the URLs before the default profile can change.

Differential Revision: https://phabricator.services.mozilla.com/D237221
2025-02-13 10:06:41 +00:00
Goloman Adrian
bc8a66a1e1 Backed out changeset 39e6a7e77cfb (bug 1927808) for causing multiple failures. CLOSED TREE 2025-02-06 14:50:21 +02:00
Dave Townsend
89b6c18f30 Bug 1927808: Profiles should remain disabled if BlockAboutProfiles enterprise policy is active. r=mkaply,profiles-reviewers,firefox-desktop-core-reviewers ,Gijs,jhirsch
This also ensures we are more consistent about using the state of `SelectableProfileService.isEnabled` to check if the feature is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D236848
2025-02-06 10:23:36 +00:00
Niklas Baumgardner
04cb067c2d Bug 1936670 - Add alt text to profile avatars. r=profiles-reviewers,fluent-reviewers,jhirsch,flod
Differential Revision: https://phabricator.services.mozilla.com/D235056
2025-01-28 18:49:11 +00:00
Dave Townsend
f4f8b6ccb5 Bug 1931299: Update the taskbar overlay whenever a window activates. r=profiles-reviewers,niklas
Differential Revision: https://phabricator.services.mozilla.com/D235146
2025-01-22 15:31:35 +00:00
Dave Townsend
071a9a4194 Bug 1933422: Set the current profile as the default for the group immediately after launching. r=profiles-reviewers,jhirsch
We set the current profile as default whenever a window activates, but we don't add that listener
until after the first window has activated so the default remains the previous profile until you
change window focus. This always sets the default immediately on startup.

Differential Revision: https://phabricator.services.mozilla.com/D234670
2025-01-17 19:25:01 +00:00
Niklas Baumgardner
05cf0080f5 Bug 1933147 - Initialize user prefs for selectable profile window. r=mossop,jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D231954
2025-01-13 17:33:46 +00:00
Dave Townsend
48f5fd3bcf Bug 1934218: Always flush the profile data to disk when changing the selector state or switching windows. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D232623
2025-01-08 15:11:19 +00:00
Sandor Molnar
ce7ef748cb Backed out changeset 19d40900062f (bug 1934218) for causing bc failures @ browser_update_profile_on_window_switch.js CLOSED TREE 2025-01-07 17:02:11 +02:00
Dave Townsend
d3a9a8ee2e Bug 1934218: Always flush the profile data to disk when changing the selector state or switching windows. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D232623
2025-01-07 14:06:31 +00:00
Niklas Baumgardner
0f7ec7d1ef Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 20:46:00 +00:00
Goloman Adrian
8893c682ad Backed out changeset b732fa6b4026 (bug 1919600) for causing bc failures @browser_preferences_usage.js. CLOSED TREE 2024-12-19 19:47:31 +02:00
Niklas Baumgardner
99881abf10 Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 16:07:05 +00:00
Jared Hirsch
2c96f01523 Bug 1918813 - Record an event when we update the default profile in a group. r=niklas,chutten
Differential Revision: https://phabricator.services.mozilla.com/D228127
2024-12-19 01:31:14 +00:00
Jared Hirsch
545de6bdb9 Bug 1931110 - Update async flush behavior to flush the group profile, not the current profile. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D228922
2024-12-18 22:31:28 +00:00
Jared Hirsch
640c9c9605 Bug 1933911 - Show the profile selector window on first restart after creating multiple profiles. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D232015
2024-12-18 22:30:41 +00:00
Dave Townsend
b30ec04bcb Bug 1933756: Keep a strong reference to the taskbar icon controller as long as the window is alive. r=jhirsch
A window's icon controller is only held weakly by the widget code and once it is destroyed it
appears to completely remove the taskbar entry for that window. This maintains a strong reference
the the icon controller once created until the window that owns it is destroyed.

Differential Revision: https://phabricator.services.mozilla.com/D231089
2024-12-05 09:35:46 +00:00
Dave Townsend
68cdb43963 Bug 1931982: Fix the startup profile UI to correctly signal back to nsAppRunner what profile needs to launch. r=jhirsch
When displaying the profile selector on startup we cannot use the normal method of launching a
selected profile by simply launching an new instance of Firefox. This would lose all state from
the original process including any passed command line arguments. Instead we must signal back to
nsAppRunner what profile it should launch. We also need to properly shut down the sqlite database
before shutdown begins as our normal hook isn't in place and the process crashes if the database
hasn't been shut down correctly.

Differential Revision: https://phabricator.services.mozilla.com/D229921
2024-11-27 09:18:52 +00:00
Butkovits Atila
3441807fa1 Backed out changeset e4a8608d96d5 (bug 1931982) for causing failures at test_first_startup.py. CLOSED TREE 2024-11-26 15:54:00 +02:00
Dave Townsend
fc5276df54 Bug 1931982: Fix the startup profile UI to correctly signal back to nsAppRunner what profile needs to launch. r=jhirsch
When displaying the profile selector on startup we cannot use the normal method of launching a
selected profile by simply launching an new instance of Firefox. This would lose all state from
the original process including any passed command line arguments. Instead we must signal back to
nsAppRunner what profile it should launch. We also need to properly shut down the sqlite database
before shutdown begins as our normal hook isn't in place and the process crashes if the database
hasn't been shut down correctly.

Differential Revision: https://phabricator.services.mozilla.com/D229921
2024-11-26 09:21:46 +00:00
Niklas Baumgardner
b339a1b405 Bug 1927572 - Set favicon for profiles pages. r=jhirsch,dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228374
2024-11-21 14:55:51 +00:00