Sylvestre Ledru
cec75ca74a
Bug 1498586 - Add clang-format off to avoid the reformatting of the data structures r=Ehsan
...
Too hard/impossible for the tool to format correctly these structs
Differential Revision: https://phabricator.services.mozilla.com/D8569
2018-10-12 20:48:24 +00:00
Andrew McCreight
05b70f0bb6
Bug 1493737 - Fix many trivial calls to do_QueryInterface r=smaug
...
If class A is derived from class B, then an instance of class A can be
converted to B via a static cast, so a slower QI is not needed.
Differential Revision: https://phabricator.services.mozilla.com/D6861
2018-10-01 21:38:01 +00:00
Nicholas Nethercote
beb45f5f20
Bug 1486690 - Rename NS_str{,}dup and remove unnecessary checks after calls to them. r=glandium
...
The 'x' prefix makes it clearer that these are infallible.
A couple of nsJSID methods are now also infallible.
2018-08-28 15:58:54 +10:00
Nicholas Nethercote
cd127441a0
Bug 1486690 - Remove unnecessary checks after moz_xmalloc() calls. r=glandium
...
There are surprisingly many of them.
(Plus a couple of unnecessary checks after `new` calls that were nearby.)
2018-08-28 15:56:01 +10:00
Valentin Gosu
7621447682
Bug 1476928 - Remove nsIURI.CloneIgnoringRef and nsIURI.CloneWithNewRef r=JuniorHsu
...
The patch introduces NS_GetURIWithNewRef and NS_GetURIWithNewRef which perform the same function.
Differential Revision: https://phabricator.services.mozilla.com/D2239
2018-07-23 11:28:47 +00:00
Marco Bonardo
1d1df3d74b
Bug 1470961 - Remove unnecessary use of SQLITE_IGNORE. r=asuth
...
MozReview-Commit-ID: GhZzTzLULWp
2018-06-26 13:50:57 +02:00
Andi-Bogdan Postelnicu
99cba2dd23
Bug 1457411 - Update netwerk module to make use of newer methods introduced with c++11 and c++14. r=valentin
...
MozReview-Commit-ID: 666LNaHyiuQ
2018-04-30 19:46:04 +03:00
Eric Rahm
d40cdc9aa0
Bug 1293375 - Annotate sql index warnings in nsDiskCacheDeviceSQL. r=mayhemer
...
This annotates two SQL statements that are responsible for a large amount of
warning spam due to "suboptimal indexes." Given we no longer wish to update
appcache code we can just disable the warning with a commment instead.
2018-02-09 16:19:31 -08:00
Masatoshi Kimura
c3d2ca2e93
Bug 685236 - Stop using GetNativePath in netwerk/. r=mayhemer
...
MozReview-Commit-ID: JdHhXPiS0fv
2017-12-15 20:21:19 +09:00
Eric Rahm
aa1c7019aa
Bug 1423798 - Remove headers included for backwards compat in nsString.h. r=njn on a CLOSED TREE
...
Remove the headers included for "backwards compatibility" and just include them
where required.
2017-12-06 19:36:57 -08:00
Csoregi Natalia
1e8a0c5ae0
Backed out changeset e2beba7e6875 (bug 1423798) for failing Browser Chrome tests browser_temporary_permissions_expiry.js on Windows 7 debug. r=backout on a CLOSED TREE
2017-12-09 07:23:35 +02:00
Eric Rahm
16586909f6
Bug 1423798 - Remove headers included for backwards compat in nsString.h. r=njn
...
Remove the headers included for "backwards compatibility" and just include them
where required.
2017-12-06 19:36:57 -08:00
Tom Schuster
94407af561
Bug 1410620 - Change CacheInfo interfaces in network to use ACString. r=michal,froydnj
2017-10-29 12:19:48 +01:00
Andrea Marchesini
c9ad4ef15f
Bug 1409329 - NS_NewBufferedOutputStream should take the ownership of the outputStream, r=smaug
2017-10-24 14:38:23 +02:00
Sylvestre Ledru
9d4a84d778
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
2017-07-06 14:00:35 +02:00
Bill McCloskey
ce42826bdf
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Nicholas Nethercote
4ce1e9c11f
Bug 1374580 (part 3) - Remove ns{,C}Substring typedefs. r=froydnj.
...
All the instances are converted as follows.
- nsSubstring --> nsAString
- nsCSubstring --> nsACString
2017-06-20 19:19:52 +10:00
Carsten "Tomcat" Book
238bf154d5
Backed out changeset 4f6302a98ae4 (bug 1372405)
2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993
Backed out changeset 9846de3bd954 (bug 1372405)
2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b
Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bill McCloskey
5aec5bf1e9
Bug 1365101 - Convert NS_GetCurrentThread uses in netwerk/ (r=meyhemer)
...
MozReview-Commit-ID: IHBt6XAG8em
2017-06-12 20:21:43 -07:00
Honza Bambas
730a380b59
Bug 1333568. r=valentin
2017-02-18 11:35:50 -05:00
Tom Tromey
e90d95a3f9
Bug 1060419 - make AppendPrintf and nsPrintfCString use Printf.h, r=froydnj
...
MozReview-Commit-ID: 2E8FoiNxU8L
2016-12-14 09:32:21 -07:00
Tom Tromey
a4b717ab39
Bug 1060419 - make log_print use Printf.h, r=froydnj
...
MozReview-Commit-ID: BIZ1GQEZ1vs
2016-12-15 20:16:31 -07:00
Andrea Marchesini
46a9207d60
Bug 1328653 - Merging all the various *OriginAttributes to just one, r=huseby
2017-01-12 17:38:48 +01:00
Ehsan Akhgari
5980492397
Bug 1318888 - Remove a few other mentions of appId's from Necko; r=mcmanus
2016-11-21 15:00:49 -05:00
Gerald Squelart
9d0ac8d6fb
Bug 1316206 - Fix RefPtr assignments from 0 - r=froydnj
...
Giving '0' (literal zero) to RefPtr is now ambiguous, as both
RefPtr(decltype(nullptr)) and RefPtr(T*) could be used.
In any case, our coding standards mandate the use of 'nullptr' for pointers.
So I'm changing all zeroes into nullptr's where necessary.
MozReview-Commit-ID: A458A4e9for
2016-11-08 14:34:06 +11:00
Nicholas Nethercote
ee63ad186f
Bug 1296164 (part 1) - Use [must_use] on nsIFile.{create,createUnique}. r=froydnj.
...
And fix numerous missing checks that this change identifies.
2016-08-18 13:30:12 +10:00
Chris Peterson
d4a6fed530
Bug 1295085 - Replace PR_snprintf and s[n]printf calls with SprintfLiteral in netwerk/. r=jduell
2016-08-15 01:09:06 -07:00
Igor
9c81c3c1ee
Bug 1293384 - Part 2: Rename Snprintf.h header to Sprintf.h. r=froydnj
2016-08-14 23:43:21 -07:00
Igor
972b8460e2
Bug 1293384 - Part 1: Rename snprintf_literal to SprintfLiteral. r=froydnj
2016-08-14 23:44:00 -07:00
Nicholas Nethercote
1f65390cc9
Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
...
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.
As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
2016-08-08 12:18:10 +10:00
Honza Bambas
be0e14e259
Bug 1286735 - Add after-shutdown nullchecks to the appcache code, r=michal
2016-07-27 12:10:00 +02:00
Kyle Huey
a9cf047227
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
Nathan Froyd
d84a75ed80
Bug 1262397 - fix a few emacs modelines; r=me
...
DONTBUILD because comment fixes are always safe, right?
2015-10-12 23:45:30 -04:00
J. Ryan Stinnett
f6d23d0dde
Bug 1238160 - Rename OriginAttributes.mInBrowser and associated methods. r=bz,mayhemer
...
This change renames OriginAttributes.mInBrowser to mInIsolatedMozBrowser and
nsIPrincipal::GetIsInBrowserElement to GetIsInIsolatedMozBrowserElement. Other
methods that pass these values around also have name changes.
Tokens such as "inBrowser" have previously been serialized into cache keys, used
as DB column names, stored in app registries, etc. No changes are made to any
serialization formats. Only runtime method and variable names are updated.
No behavior changes are made in this patch, so some renamed methods may have
nonsensical implementations. These are corrected in subsequent patches
focused on behavior.
MozReview-Commit-ID: 66HfMlsXFLs
2016-03-02 10:35:56 -06:00
Honza Bambas
77f04af9ec
Bug 1165256 - Make appcache fully work with OriginAttribues. r=jduell
2016-01-18 20:20:08 +01:00
Patrick McManus
c07974e685
Bug 1238290 - fix bad necko deps on unified_sources r=valentin.gosu
...
---
netwerk/base/ARefBase.h | 2 ++
netwerk/base/CaptivePortalService.cpp | 1 +
netwerk/base/CaptivePortalService.h | 1 +
netwerk/base/EventTokenBucket.cpp | 4 +++-
netwerk/base/LoadContextInfo.cpp | 3 +++
netwerk/base/LoadInfo.cpp | 3 +++
netwerk/base/MemoryDownloader.cpp | 1 +
netwerk/base/Predictor.cpp | 1 +
netwerk/base/RedirectChannelRegistrar.h | 1 +
netwerk/base/nsBaseChannel.cpp | 1 +
netwerk/base/nsChannelClassifier.cpp | 1 +
netwerk/base/nsDirectoryIndexStream.cpp | 3 ++-
netwerk/base/nsDownloader.cpp | 1 +
netwerk/base/nsIOService.cpp | 1 +
netwerk/base/nsIncrementalDownload.cpp | 3 +++
netwerk/base/nsNetUtil.cpp | 4 ++++
netwerk/base/nsNetUtil.h | 1 +
netwerk/base/nsProtocolProxyService.cpp | 1 +
netwerk/base/nsSecCheckWrapChannel.cpp | 2 ++
netwerk/base/nsUDPSocket.cpp | 4 +++-
netwerk/cache/nsDiskCacheBinding.cpp | 2 +-
netwerk/cache/nsDiskCacheDeviceSQL.cpp | 2 ++
netwerk/cache/nsMemoryCacheDevice.cpp | 2 +-
netwerk/cache2/CacheFileUtils.cpp | 2 ++
netwerk/cache2/CacheStorageService.h | 1 +
netwerk/ipc/NeckoParent.cpp | 1 +
netwerk/ipc/RemoteOpenFileChild.cpp | 1 +
netwerk/protocol/about/nsAboutBloat.cpp | 1 +
netwerk/protocol/about/nsAboutCacheEntry.cpp | 1 +
netwerk/protocol/about/nsAboutProtocolHandler.cpp | 1 +
netwerk/protocol/data/DataChannelParent.cpp | 1 +
netwerk/protocol/file/nsFileProtocolHandler.cpp | 1 +
netwerk/protocol/ftp/FTPChannelParent.cpp | 2 ++
netwerk/protocol/ftp/FTPChannelParent.h | 1 +
netwerk/protocol/ftp/nsFtpConnectionThread.cpp | 1 +
netwerk/protocol/ftp/nsFtpProtocolHandler.h | 1 +
netwerk/protocol/http/Http2Compression.cpp | 1 +
netwerk/protocol/http/Http2Session.cpp | 1 +
netwerk/protocol/http/Http2Stream.h | 2 ++
netwerk/protocol/http/HttpBaseChannel.cpp | 4 ++++
netwerk/protocol/http/HttpBaseChannel.h | 1 +
netwerk/protocol/http/HttpChannelChild.cpp | 25 ++--------------------
netwerk/protocol/http/HttpChannelChild.h | 24 +++++++++++++++++++++
netwerk/protocol/http/HttpChannelParent.cpp | 1 +
netwerk/protocol/http/HttpChannelParent.h | 1 +
.../protocol/http/HttpChannelParentListener.cpp | 1 +
netwerk/protocol/http/HttpChannelParentListener.h | 1 +
netwerk/protocol/http/InterceptedChannel.cpp | 1 +
netwerk/protocol/http/NullHttpChannel.cpp | 1 +
netwerk/protocol/http/NullHttpTransaction.cpp | 1 +
netwerk/protocol/http/PackagedAppService.cpp | 14 ++++++++++--
netwerk/protocol/http/PackagedAppService.h | 4 +++-
netwerk/protocol/http/PackagedAppVerifier.cpp | 1 +
netwerk/protocol/http/nsCORSListenerProxy.cpp | 2 +-
netwerk/protocol/http/nsHttpBasicAuth.cpp | 1 +
netwerk/protocol/http/nsHttpChannel.cpp | 2 ++
netwerk/protocol/http/nsHttpChunkedDecoder.cpp | 1 +
netwerk/protocol/http/nsHttpConnectionInfo.cpp | 2 ++
netwerk/protocol/http/nsHttpConnectionMgr.cpp | 1 +
netwerk/protocol/http/nsHttpDigestAuth.cpp | 1 +
netwerk/protocol/viewsource/nsViewSourceHandler.h | 4 ++++
.../protocol/websocket/BaseWebSocketChannel.cpp | 1 +
.../websocket/WebSocketEventListenerParent.cpp | 1 +
.../protocol/websocket/WebSocketEventService.cpp | 3 +++
netwerk/protocol/websocket/WebSocketFrame.cpp | 2 ++
netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp | 1 +
.../protocol/wyciwyg/nsWyciwygProtocolHandler.cpp | 1 +
netwerk/streamconv/converters/mozTXTToHTMLConv.cpp | 1 +
.../streamconv/converters/nsFTPDirListingConv.cpp | 1 +
.../streamconv/converters/nsHTTPCompressConv.cpp | 2 ++
netwerk/streamconv/converters/nsHTTPCompressConv.h | 1 +
netwerk/streamconv/converters/nsIndexedToHTML.cpp | 1 +
netwerk/streamconv/converters/nsMultiMixedConv.cpp | 2 ++
netwerk/streamconv/converters/nsTXTToHTMLConv.cpp | 2 ++
netwerk/streamconv/converters/nsUnknownDecoder.cpp | 2 ++
75 files changed, 147 insertions(+), 32 deletions(-)
2016-01-08 20:20:50 -05:00
Nicholas Nethercote
f1d8c3cff2
Bug 1186783 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in netwerk/ with iterators. r=valentin.
2015-11-19 15:31:28 -08:00
Yoshi Huang
47c69d1edb
Bug 1209162 - Create OriginAttributes subtypes. IGNORE IDL r=sicking.
2015-11-03 09:50:54 +08:00
Madhurima
146983f2f2
Bug 1197313 - remove PR_snprintf calls in netwerk/; r=froydnj
2015-10-29 16:07:44 -04:00
Honza Bambas
9f2c9a0082
Bug 1220215 - Add '#' between client id and suffix in appcache groud id, r=jduell
2015-10-30 10:14:00 +01:00
Phil Ringnalda
f8fdc4304c
Back out changeset ea8093d8be6a (bug 1197313) for Linux xpcshell bustage in test_offlinecache_custom-directory.js
...
CLOSED TREE
2015-10-31 12:14:38 -07:00
Madhurima
dd31bb522c
Bug 1197313 - remove PR_snprintf calls in netwerk/; r=froydnj
2015-10-29 16:07:44 -04:00
Honza Bambas
0a9b52bb1d
Bug 1198792 - Clear Application Cache internal hashtables on Clear Recent History, r=jduell
2015-10-15 09:56:00 +02:00
Nathan Froyd
4e6d8f6705
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
2015-10-18 01:24:48 -04:00
Honza Bambas
213ca181dd
Bug 1165269 - Use OriginAttributes in nsILoadContextInfo, r=michal+allstars
2015-10-11 18:13:09 +02:00
Birunthan Mohanathas
a29151dc87
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Emanuel Hoogeveen
b30abdc582
Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell
2015-07-07 04:17:00 +02:00