corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
708,203 Commits 1 Branch 0 Tags
ce4534f20681c1ba4bb15583d65fa29df12edbcc
Commit Graph

241 Commits

Author SHA1 Message Date
Sandor Molnar
ce4534f206 Backed out changeset e5cfc59f9063 (bug 1716736) for causing bc failures in browser_setDefaultBrowser. CLOSED TREE 2021-07-26 01:17:51 +03:00
Andrei Oprea
3037ecf02e Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D118367
 2021-07-25 21:01:16 +00:00
Ed Lee
bd972c2af9 Bug 1714466 - Relax upgrade dialog dependency on unrelated/deprecated prefs, e.g., whatsNewPanel and aboutwelcome r=pdahiya 
Check default pref branch instead of user when looking for enterprise policy changes.

Differential Revision: https://phabricator.services.mozilla.com/D118089
 2021-06-17 22:23:28 +00:00
Emily McMinn
b0b2a2322f Bug 1712869 - Set keyboard focus on the correct button for each screen of the upgrade modal r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D117364
 2021-06-15 17:12:23 +00:00
Ed Lee
5e8f1563a8 Bug 1633883 - TelemetryTestUtils.assertScalar assumes Number (so behaves odd for boolean, strings) r=chutten 
Split assertScalar to assertScalarUnset to allow the former to plain check the value including strings, false and 0.

Differential Revision: https://phabricator.services.mozilla.com/D117457
 2021-06-11 21:06:26 +00:00
Ed Lee
06d1c0878c Bug 1715348 - Add telemetry environment boolean scalar for kept in macOS Dock r=pdahiya 
Add BrowserGlue task and telemetry Scalar matching is_taskbar_pinned but for macOS as is_kept_in_dock.

Differential Revision: https://phabricator.services.mozilla.com/D117346
 2021-06-10 20:58:08 +00:00
Ed Lee
ed2b031c72 Bug 1699842 - Keep Firefox in Dock for macOS where windows would Pin without showing images r=pdahiya,flod 
Update ShellService to also check mac pinned but only from the main process, so have AboutWelcomeChild request pinned for use in getDefaults and prepareContent. Remove windows images and consolidate back to single shared css without spacers and instead use margin: auto with logo that is no longer fixed. Split out pin strings to own screen/section and use PLATFORM. Add macOS default prompt message without touching existing windows one.

Differential Revision: https://phabricator.services.mozilla.com/D115967
 2021-05-28 11:04:22 +00:00
Ed Lee
73ff0e3c14 Bug 1706963 - Close other window modal subdialog before quit/close window prompts r=Gijs 
Allow quit/close dialogs to jump the queue with new method gDialogBox.replaceDialogIfOpen().

Differential Revision: https://phabricator.services.mozilla.com/D114654
 2021-05-21 17:56:20 +00:00
Michelle Goossens
692ff0bb41 Bug 1711497 - Remove browser.proton.enabled checks/setters from tests r=Gijs,marionette-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D115539
 2021-05-20 13:03:51 +00:00
Ed Lee
9b565e102d Bug 1710955 - Also disable welcome in addition to upgrade for whats_new_page test r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D115325
 2021-05-18 04:41:51 +00:00
Ed Lee
7cfdae56eb Bug 1710955 - Change MR1 upgrade onboarding to Pin then Default then Theme screens r=fluent-reviewers,flod,pdahiya,k88hudson 
Copy / migrate strings from onboarding/defaultBrowserNotification. Add updated ltr/rtl images and show them for pin and pin+default. Dynamically adjust steps and record telemetry to identify what was shown. Handle button actions based on string ids. Alias upgradeDialog to aboutwelcome for now. Avoid oddness with scrollbars by hiding horizontal scroll.

Differential Revision: https://phabricator.services.mozilla.com/D115142
 2021-05-18 03:16:34 +00:00
Mike Conley
97ed72f91f Bug 1708056 - Add a dedicated primary button string for the upgrade dialog for Win7. r=Mardak,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D114783
 2021-05-10 23:49:53 +00:00
Ed Lee
8363182baa Bug 1706279 - Tighten up upgrade dialog spacing on short windows to be more usable before showing scrollbar r=pdahiya 
Detect if there's not enough vertical space to switch to compact mode. Use selectors and variables to adjust font-sizes, margins, etc.

Differential Revision: https://phabricator.services.mozilla.com/D114421
 2021-05-06 19:10:48 +00:00
Andrei Oprea
8573ee7fea Bug 1708652 - Add checks to remote defaults helper to ensure proper init r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D113945
 2021-05-05 15:54:57 +00:00
Ed Lee
840011ef5a Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya 
Detect old windows version to change content reusing an asrouter "Okay" string for now.

Differential Revision: https://phabricator.services.mozilla.com/D113583
 2021-04-29 06:30:11 +00:00
Alexandru Michis
ad95115f4d Backed out changeset 48f696159514 (bug 1707141) for causing bc failures in browser_browserGlue_upgradeDialog.js 
CLOSED TREE
 2021-04-29 07:32:43 +03:00
Ed Lee
a8bea67136 Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya 
Detect old windows version to change content reusing an asrouter "Okay" string for now.

Differential Revision: https://phabricator.services.mozilla.com/D113583
 2021-04-27 23:37:37 +00:00
Andrei Oprea
80ba0dff4d Bug 1681130 - Remove the Set to Default notification bar r=Mardak,jaws 
Differential Revision: https://phabricator.services.mozilla.com/D112350
 2021-04-22 19:27:55 +00:00
Ed Lee
a7d3feaf6f Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r=nanj 
Reuse existing "show" event object to track which primary button was shown on the first screen. Update Events.yaml with longer description of expected values.

Differential Revision: https://phabricator.services.mozilla.com/D112837
 2021-04-21 07:42:13 +00:00
smolnar
1d97e06982 Backed out changeset 3ac594597045 (bug 1706489) for causing bc failures in browser_browserGlue_upgradeDialog. CLOSED TREE 2021-04-21 09:10:07 +03:00
Ed Lee
6af6ea1386 Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r=nanj 
Reuse existing "show" event object to track which primary button was shown on the first screen. Update Events.yaml with longer description of expected values.

Differential Revision: https://phabricator.services.mozilla.com/D112837
 2021-04-21 01:38:46 +00:00
Ed Lee
320f970bf9 Bug 1705334 - Dismiss upgrade dialog on quit to allow quit window modal prompt to show r=andreio 
Observe "quit-application-requested" to close the dialog. Use TelemetryTestUtils.assertEvents to check all events.

Differential Revision: https://phabricator.services.mozilla.com/D112303
 2021-04-16 13:39:49 +00:00
Andrei Oprea
92f4335606 Bug 1701948 - Early startup cache should work for Nimbus remote defaults r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D111320
 2021-04-15 19:50:39 +00:00
Csoregi Natalia
db0b28082b Backed out changeset 90163e505c3f (bug 1701948) for failures on browser_remotesettingsexperimentloader_remote_defaults.js. CLOSED TREE 2021-04-15 21:58:41 +03:00
Andrei Oprea
a079750568 Bug 1701948 - Early startup cache should work for Nimbus remote defaults r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D111320
 2021-04-15 17:28:14 +00:00
Andrei Oprea
c9bdc2839c Bug 1702004 - Add Firefox logo to the default browser prompt title r=Gijs 
Check for headerIconURL in asyncConfirmEx to show a custom icon.

Differential Revision: https://phabricator.services.mozilla.com/D111233
 2021-04-14 20:08:45 +00:00
Andrei Oprea
11fa928338 Bug 1702000 - Add pin to taskbar action to the primary button r=andreio 
Share needPin and pin methods from ShellService and reuse from default prompt, upgrade dialog and special message actions. Use these to show "primary" vs "default" in the prompt.

Differential Revision: https://phabricator.services.mozilla.com/D111244
 2021-04-14 15:09:34 +00:00
smolnar
05e21e1d85 Backed out changeset d39717cd014e (bug 1702000) for causing mochitest bc failures in browser_aboutNewTab_defaultBrowserNotification. CLOSED TREE 2021-04-14 15:27:51 +03:00
Andrei Oprea
6a90939695 Bug 1702000 - Add pin to taskbar action to the primary button r=andreio 
Share needPin and pin methods from ShellService and reuse from default prompt, upgrade dialog and special message actions. Use these to show "primary" vs "default" in the prompt.

Differential Revision: https://phabricator.services.mozilla.com/D111244
 2021-04-14 10:24:19 +00:00
Ed Lee
4f6ed79897 Bug 1701867 - Change set to default prompt from an infobar to a modal r=andreio 
Differential Revision: https://phabricator.services.mozilla.com/D111969
 2021-04-14 09:26:00 +00:00
Andrei Oprea
5dfc6e86df Bug 1701998 - Change the checkbox behavior for the default browser prompt r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D111104
 2021-04-13 15:45:48 +00:00
Ed Lee
bb13089f2c Bug 1697222 - Record telemetry events for various upgrade dialog interactions. r=nanj 
Add new Events.yaml upgrade_dialog category and use various methods/objects to record behaviors.

Differential Revision: https://phabricator.services.mozilla.com/D111295
 2021-04-13 00:04:30 +00:00
Ed Lee
29aff927a9 Bug 1697222 - Show upgrade dialog without conflicting with existing default browser prompt. r=andreio 
Add new NimbusFeatures.upgradeDialog with fallback enabled pref. Remember if the browser just did a major uprgade and check other conditions for showing before other default browser messages.

Differential Revision: https://phabricator.services.mozilla.com/D111041
 2021-04-13 00:04:30 +00:00
Ed Lee
47b9f9c155 Bug 1697222 - Add window modal dialog for existing users on upgrade highlighting Proton improvements r=pdahiya,flod,sfoster 
Add new dialog with related scripts, strings and styles that can adjust the window modal backdrop to show off themes.

Differential Revision: https://phabricator.services.mozilla.com/D110330
 2021-04-13 00:04:30 +00:00
Adam Gashlin
2881573ca1 Bug 1701542 - Use the correct default for the removed recentlyUsedOrder pref. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D110051
 2021-03-29 02:33:53 +00:00
Bernard Igiri
186b5a93bd Bug 1692303 - Flip default value to browser.ctrlTab.recentlyUsedOrder to false r=mstriemer,mconley,preferences-reviewers 
Changed default Ctrl+Tab preference to false and added UI migration to reset it for users who haven't not used the feature before.

Differential Revision: https://phabricator.services.mozilla.com/D109653
 2021-03-26 21:56:41 +00:00
Tom Schuster
0b4d307c8a Bug 1692716 - Make browser_quit_disabled.js more robust. r=Gijs 
I realized that we wouldn't notice if the quit-application-requested observer wasn't called.

Differential Revision: https://phabricator.services.mozilla.com/D105121
 2021-02-23 21:23:24 +00:00
smolnar
a5bf207b81 Backed out changeset b17481ba70ba (bug 1692716) for causing bc failures in browser_quit_disabled. CLOSED TREE 2021-02-15 17:12:36 +02:00
Tom Schuster
85e9e13b3a Bug 1692716 - Make browser_quit_disabled.js more robust. r=Gijs 
I realized that we wouldn't notice if the quit-application-requested observer wasn't called.

Differential Revision: https://phabricator.services.mozilla.com/D105121
 2021-02-15 10:28:36 +00:00
Mark Banner
c991d8611e Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D104683
 2021-02-11 22:02:15 +00:00
Tom Schuster
e393c0b8a8 Bug 52821 - Add a pref to disable the quit application shortcut. r=Gijs 
browser.quitShortcut.disabled=true will disable the Ctrl + Q shortcut on all platforms.

Differential Revision: https://phabricator.services.mozilla.com/D104189
 2021-02-10 17:02:57 +00:00
Doug Thayer
b734998339 Bug 1680258 - Change first paint notification event when skele UI enabled r=florian 
Having the window present earlier changes the ordering of these events, such
that it doesn't come through at the time that the browser_startup test needs it
to. I think this event should be correct anyway, given that we already painted
the skeleton UI?

Differential Revision: https://phabricator.services.mozilla.com/D98478
 2020-12-10 03:38:14 +00:00
Mihai Alexandru Michis
7d01febd47 Backed out 7 changesets (bug 1680258) for causing osx mochitest timeouts. 
CLOSED TREE

Backed out changeset 4b885b40c787 (bug 1680258)
Backed out changeset 8eb4ebbd13d0 (bug 1680258)
Backed out changeset 403d7441eb0c (bug 1680258)
Backed out changeset a253801a3155 (bug 1680258)
Backed out changeset 183d89827d4b (bug 1680258)
Backed out changeset 268d2aac128e (bug 1680258)
Backed out changeset e9b9f97caa6c (bug 1680258)
 2020-12-09 23:03:09 +02:00
Doug Thayer
cf019e329d Bug 1680258 - Change first paint notification event when skele UI enabled r=florian 
Having the window present earlier changes the ordering of these events, such
that it doesn't come through at the time that the browser_startup test needs it
to. I think this event should be correct anyway, given that we already painted
the skeleton UI?

Differential Revision: https://phabricator.services.mozilla.com/D98478
 2020-12-08 22:35:26 +00:00
Florian Quèze
c9cdba401b Bug 1678418 - avoid stopping the profiler for performance tests that don't require a startup profile, r=Gijs. 
Differential Revision: https://phabricator.services.mozilla.com/D97780
 2020-11-20 16:50:14 +00:00
Marco Bonardo
e11487ed42 Bug 1592498 - Remove UI migrations up to Firefox 59 and migration 66 for intermittent failures. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D96999
 2020-11-16 11:56:47 +00:00
Kirk Steuber
6cf69af6ed Bug 1668096 - Replace activeUpdate with downloadingUpdate and readyUpdate in tests r=mhowell 
Differential Revision: https://phabricator.services.mozilla.com/D92291
 2020-10-06 18:07:56 +00:00
Mark Banner
deca0a790d Bug 1643471 - Remove the browser.search.cohort preference from user profiles. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D91000
 2020-09-22 14:02:20 +00:00
Mark Banner
38f72ec854 Bug 1619926 - Remove distribution search directory provider definitions. r=daleharvey 
Also remove DirectoryProvider as it is now unused.

Depends on D88018

Differential Revision: https://phabricator.services.mozilla.com/D88019
 2020-09-01 18:08:22 +00:00
Butkovits Atila
bb187bd62f Backed out 15 changesets (bug 1612824, bug 1661234, bug 1619926, bug 1612380, bug 1559530, bug 1642990) for Xpc failures. CLOSED TREE 
Backed out changeset 426d017d7e46 (bug 1642990)
Backed out changeset 84ab4021d403 (bug 1559530)
Backed out changeset 82a8305543e5 (bug 1559530)
Backed out changeset 38832c1185b8 (bug 1559530)
Backed out changeset f16918c10a6b (bug 1661234)
Backed out changeset 3a13258fbd51 (bug 1661234)
Backed out changeset abf8d8b24845 (bug 1612824)
Backed out changeset 7dfeb065a385 (bug 1619926)
Backed out changeset bc9d3e210fe7 (bug 1619926)
Backed out changeset 786164c461ae (bug 1619926)
Backed out changeset d89793e9d17d (bug 1619926)
Backed out changeset d665885bc912 (bug 1619926)
Backed out changeset 9260b6620943 (bug 1619926)
Backed out changeset af69a4896f2f (bug 1619926)
Backed out changeset b9cd6b7047b9 (bug 1612380)
 2020-09-01 21:03:23 +03:00