Commit Graph

282 Commits

Author SHA1 Message Date
Mike Conley
98e129ef96 Bug 1698883 - Remove the panel-footer-menulike class. r=mhowell
We kept this class around so that we could toggle back and forth between the
Photon-era footer button style, and the Proton-era menuitem style for footer
buttons.

Now that v89 has shipped, we can remove that class and switch the markup and
styling over completely to the Proton styling.

Differential Revision: https://phabricator.services.mozilla.com/D117553
2021-06-23 13:54:41 +00:00
Brindusan Cristian
b99e075aeb Backed out changeset e88b44182dda (bug 1698883) for causing bc failures in browser_documentnavigation.js and browser_protectionsUI.js.
CLOSED TREE
2021-06-17 22:43:47 +03:00
Mike Conley
f1e9c77fc7 Bug 1698883 - Remove the panel-footer-menulike class. r=mhowell
We kept this class around so that we could toggle back and forth between the
Photon-era footer button style, and the Proton-era menuitem style for footer
buttons.

Now that v89 has shipped, we can remove that class and switch the markup and
styling over completely to the Proton styling.

Differential Revision: https://phabricator.services.mozilla.com/D117553
2021-06-17 15:34:17 +00:00
Gijs Kruitbosch
7ad523084b Bug 1711523 - remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D116009
2021-05-28 19:33:38 +00:00
Mike Conley
b112fe1814 Bug 1707754 - Make Protections Panel use the subviewbutton-nav class for subview navigation buttons. r=Itiel,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D114890
2021-05-12 20:45:00 +00:00
Anshul Sahai
4ca3a9e11d Bug 1709106-Making changes so that "You are securely connected to this site" doesn't overlap the lock icon. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D114470
2021-05-07 14:29:27 +00:00
Anshul Sahai
2a913386b4 Bug 1575080 - Changing the identity icon and the string inside the identity panel for net error pages. r=fluent-reviewers,johannh
Differential Revision: https://phabricator.services.mozilla.com/D112384
2021-05-03 07:51:14 +00:00
Emma Malysz
215f1834c6 Bug 1703012: fix control center and identity panel proton styling r=desktop-theme-reviewers,fluent-reviewers,mconley,flod,pbz,Itiel
Migrates two strings to fluent and uses sentence casing.
Places identity security block into a toolbar button.
Fixes margin spacing.
Removes green color from secure connection.

Differential Revision: https://phabricator.services.mozilla.com/D111368
2021-04-19 18:51:37 +00:00
Molly Howell
11c3e5164c Bug 1705540 - Use toolbarseparator elements for protections panel subviews. r=desktop-theme-reviewers,harry
Mainly this is the easiest way to reduce the width of the separators when using
the Proton design (they look unchanged if the Proton prefs are disabled), but
it should also make any other future styling changes we might want easier too.

Differential Revision: https://phabricator.services.mozilla.com/D112291
2021-04-16 20:35:32 +00:00
Bogdan Tara
eae3ca9d91 Backed out 2 changesets (bug 1704827, bug 1703012) for screenshots mochitest timeouts CLOSED TREE
Backed out changeset 95a07d286cd7 (bug 1704827)
Backed out changeset 5e8a1732b021 (bug 1703012)
2021-04-16 22:40:48 +03:00
Bogdan Tara
f5c3fcf7b7 Backed out changeset e40c2fa01489 (bug 1705540) for conflict when backing out bug 1703012 CLOSED TREE 2021-04-16 22:39:04 +03:00
Molly Howell
1600bf2a66 Bug 1705540 - Use toolbarseparator elements for protections panel subviews. r=desktop-theme-reviewers,harry
Mainly this is the easiest way to reduce the width of the separators when using
the Proton design (they look unchanged if the Proton prefs are disabled), but
it should also make any other future styling changes we might want easier too.

Differential Revision: https://phabricator.services.mozilla.com/D112291
2021-04-16 17:33:50 +00:00
Luz De La Rosa
3a880a5b68 Bug 1703586 - Fix tiny layout issues in the protections panel. r=prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D112140
2021-04-16 16:53:06 +00:00
Emma Malysz
9f8c716fe0 Bug 1703012: fix control center and identity panel proton styling r=desktop-theme-reviewers,fluent-reviewers,mconley,flod,pbz,Itiel
Migrates two strings to fluent and uses sentence casing.
Places identity security block into a toolbar button.
Fixes margin spacing.
Removes green color from secure connection.

Differential Revision: https://phabricator.services.mozilla.com/D111368
2021-04-16 16:38:02 +00:00
Brindusan Cristian
228db3e1be Backed out 2 changesets (bug 1704827, bug 1703012) for causing bc failures in browser_parsable_css.js. CLOSED TREE
Backed out changeset e3567ea32072 (bug 1704827)
Backed out changeset 43bb3216b816 (bug 1703012)
2021-04-16 18:53:26 +03:00
Emma Malysz
1fbdc78f15 Bug 1703012: fix control center and identity panel proton styling r=desktop-theme-reviewers,fluent-reviewers,mconley,flod,pbz,Itiel
Migrates two strings to fluent and uses sentence casing.
Places identity security block into a toolbar button.
Fixes margin spacing.
Removes green color from secure connection.

Differential Revision: https://phabricator.services.mozilla.com/D111368
2021-04-16 14:42:57 +00:00
Tim Huang
c33f6b2a43 Bug 1676074 - Part 1: Add a learn more link into the "Cross-site cookies" permission header description. r=johannh,fluent-reviewers,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D112044
2021-04-15 09:27:26 +00:00
Molly Howell
c69fee2a81 Bug 1703635 - Fix several protections panel styling issues. r=mconley
This patch makes a few changes to bring the protections panel closer in line
with the Proton spec:
1) Add a few pixels of width to the tracking protection toggle switch.
2) Add underlining to the "site not working" link.
3) Replace the borders between sections of the panel with toolbarseparator
   elements, so that they become narrower than the panel width (and also
   match the panel header's separator).

Differential Revision: https://phabricator.services.mozilla.com/D111717
2021-04-13 18:57:06 +00:00
Paul Zuehlcke
d128258d65 Bug 1699669 - Added learn more link to the shim-allow warning in the protections panel. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D110150
2021-04-13 16:11:21 +00:00
Paul Zuehlcke
348e064eba Bug 1699668 - Refactor siteProtections blockers and add a warning for trackers allowed by shims. r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D109717
2021-04-13 16:11:21 +00:00
Emma Malysz
dd71b38d47 Bug 1703476, update site permission panel formatting r=mconley,pbz
Changes includde padding/margin changes and button structure

Differential Revision: https://phabricator.services.mozilla.com/D111479
2021-04-12 16:28:01 +00:00
Mike Conley
66673da107 Bug 1697947 - Apply Proton button stylings to the footers of more panels. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D108261
2021-03-16 21:48:37 +00:00
Noemi Erli
abe663dea2 Backed out changeset c35c310c49d3 (bug 1697947) for causing failures in browser_parsable_css.js 2021-03-16 22:58:27 +02:00
Mike Conley
e49c230e43 Bug 1697947 - Apply Proton button stylings to the footers of more panels. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D108261
2021-03-16 19:20:22 +00:00
Paul Zuehlcke
a1d23766c7 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-02-05 13:40:35 +00:00
Narcis Beleuzu
926d2f6257 Backed out 2 changesets (bug 1596897) for bc failures on browser_search_discovery.js
Backed out changeset 635972f169e7 (bug 1596897)
Backed out changeset a84b667007e2 (bug 1596897)
2021-01-30 04:01:21 +02:00
Paul Zuehlcke
480794a586 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-01-29 16:06:08 +00:00
Brindusan Cristian
b0f9bc02f2 Backed out 2 changesets (bug 1596897) for mochitest failures at browser_setIgnoreCertificateErrors.js. CLOSED TREE
Backed out changeset 00c45a405129 (bug 1596897)
Backed out changeset 61304ccbaada (bug 1596897)
2021-01-28 21:53:46 +02:00
Paul Zuehlcke
032c94dfc0 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-01-28 18:00:44 +00:00
Nihanth Subramanya
8c3573600b Bug 1643191 - Show storage access permissions in the identity panel. r=pbz,fluent-reviewers,johannh,flod
This patch adds storage access permission items in the identity panel. This is a new
class of permission - multiple permission items might exist for the category i.e.
one for each third-party that has been granted access. To achieve this, we add support
for an "anchorfor" attribute in the permission list markup, which when present will
signal to the code that the element is to be the container for permission items of type
matching the value of the attribute. This hence adds support generally for categorical
permission types.

Differential Revision: https://phabricator.services.mozilla.com/D94703
2020-11-09 00:21:13 +00:00
julianwels
3671d66d85 Bug 1671291 - Clarified that HTTPS-Only identity-panel UI only affects the current page. r=ntim,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D93651
2020-10-16 12:54:31 +00:00
julianwels
d2086b7851 Bug 1653026 - Added new HTTPS-Only Mode UI in site-identity panel and removed permission from list. r=flod,ewright,fluent-reviewers,desktop-theme-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D90332
2020-10-06 00:35:05 +00:00
Brindusan Cristian
3cc0d3988e Backed out 2 changesets (bug 1653026) for mochitest failures at WindowGlobalParent.cpp. CLOSED TREE
Backed out changeset 54c69c99b241 (bug 1653026)
Backed out changeset e70649f78910 (bug 1653026)
2020-10-03 10:49:04 +03:00
julianwels
9fc4f235f4 Bug 1653026 - Added new HTTPS-Only Mode UI in site-identity panel and removed permission from list. r=flod,ewright,fluent-reviewers,desktop-theme-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D90332
2020-10-02 21:11:46 +00:00
Ingrid Buh
ebd9f22441 Bug 1639826 - Fix hover effects on link texts in the protection panel. r=prathiksha,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D85755
2020-08-04 10:29:38 +00:00
Andreea Pavel
e9e7d4b8d3 Backed out changeset f7bb83828578 (bug 1639826) for failing bc at browser_protectionsUI.js on a CLOSED TREE 2020-07-24 15:25:59 +03:00
Ingrid Buh
ce6fee46c4 Bug 1639826 - Fix hover effects on link texts in the protection panel. r=prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D81309
2020-07-24 10:30:07 +00:00
julianwels
e3c9ee5f46 Bug 1647336 - Fixed incorrect icon and site-identity information on HTTPS-Only Error Page. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D83134
2020-07-14 14:07:50 +00:00
Gijs Kruitbosch
480e677a3b Bug 1634032 - use a template to wrap the protections popup while it's not needed, r=nhnt11
This also only updates per-category block information in the protections panel
while it's open or when it's about to be shown. To do this, the patch:

1. changes the `categoryItem` getter on all blockers to avoid memo'izing null when the popup is unavailable;
2. changes the `updateCategoryItem` method on all blockers to deal with `categoryItem` being null;
3. stops calling `updateCategoryItem` from the blockers' `init` method, instead delegating this responsibility
   to gProtectionsHandler doing so when the popup first becomes available. Note that we still need (2) because
   pref changes can trip us calling into `updateCategoryItem` anyway. We cannot avoid instantiating the pref
   getters because they are relied on by some of the `isDetected` and `isBlocking` implementations.
4. reorganizes `onContentBlockingEvent` so it updates the icon, reports telemetry, and updates internal state -
   but only updates the panel if it's visible, and otherwise simply memorizes the last event (which is just
   a number!);
5. ensures showing the panel updates the panel's category data based on the memorized state from (4).

Differential Revision: https://phabricator.services.mozilla.com/D81926
2020-07-10 21:32:09 +00:00
Bogdan Tara
7689a981c8 Backed out changeset add40bc29da9 (bug 1634032) for browser_controlCenter.js failures CLOSED TREE 2020-07-10 21:10:42 +03:00
Gijs Kruitbosch
ec4fcaf060 Bug 1634032 - use a template to wrap the protections popup while it's not needed, r=nhnt11
This also only updates per-category block information in the protections panel
while it's open or when it's about to be shown. To do this, the patch:

1. changes the `categoryItem` getter on all blockers to avoid memo'izing null when the popup is unavailable;
2. changes the `updateCategoryItem` method on all blockers to deal with `categoryItem` being null;
3. stops calling `updateCategoryItem` from the blockers' `init` method, instead delegating this responsibility
   to gProtectionsHandler doing so when the popup first becomes available. Note that we still need (2) because
   pref changes can trip us calling into `updateCategoryItem` anyway. We cannot avoid instantiating the pref
   getters because they are relied on by some of the `isDetected` and `isBlocking` implementations.
4. reorganizes `onContentBlockingEvent` so it updates the icon, reports telemetry, and updates internal state -
   but only updates the panel if it's visible, and otherwise simply memorizes the last event (which is just
   a number!);
5. ensures showing the panel updates the panel's category data based on the memorized state from (4).

Differential Revision: https://phabricator.services.mozilla.com/D81926
2020-07-10 15:28:58 +00:00
Butkovits Atila
73a0d4bed1 Backed out changeset 71ca1673171d (bug 1634032) for assertion failure on DOMJSProxyHandler.cpp. CLOSED TREE 2020-07-10 01:36:16 +03:00
Gijs Kruitbosch
06c3b72ba5 Bug 1634032 - use a template to wrap the protections popup while it's not needed, r=nhnt11
This also only updates per-category block information in the protections panel
while it's open or when it's about to be shown. To do this, the patch:

1. changes the `categoryItem` getter on all blockers to avoid memo'izing null when the popup is unavailable;
2. changes the `updateCategoryItem` method on all blockers to deal with `categoryItem` being null;
3. stops calling `updateCategoryItem` from the blockers' `init` method, instead delegating this responsibility
   to gProtectionsHandler doing so when the popup first becomes available. Note that we still need (2) because
   pref changes can trip us calling into `updateCategoryItem` anyway. We cannot avoid instantiating the pref
   getters because they are relied on by some of the `isDetected` and `isBlocking` implementations.
4. reorganizes `onContentBlockingEvent` so it updates the icon, reports telemetry, and updates internal state -
   but only updates the panel if it's visible, and otherwise simply memorizes the last event (which is just
   a number!);
5. ensures showing the panel updates the panel's category data based on the memorized state from (4).

Differential Revision: https://phabricator.services.mozilla.com/D81926
2020-07-09 20:23:14 +00:00
Gijs Kruitbosch
a25d1a59b7 Bug 1646780 - use a template to wrap the identity popup while it's not needed, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D78894
2020-06-23 14:04:49 +00:00
Dorel Luca
10867ecce0 Backed out changeset 3671a57712e4 (bug 1646780) for Browser-chrome failures in webrtc/browser_devices_get_user_media_tear_off_tab.js 2020-06-19 04:22:23 +03:00
Gijs Kruitbosch
e7ae448a2d Bug 1646780 - use a template to wrap the identity popup while it's not needed, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D78894
2020-06-19 00:02:11 +00:00
Gijs Kruitbosch
1e63ce3253 Bug 1644863 - fix trailing whitespace in browser/toolkit/devtools/mobile frontend code files, r=mossop,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D79201
2020-06-17 22:40:53 +00:00
Erica Wright
da2c78bf70 Bug 1641627 - Update string for protection panel entrypoint to protections dashboard. r=prathiksha,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D77314
2020-05-28 17:44:58 +00:00
Erica Wright
1ea362fe09 Bug 1635218 - Update Protections Dashboard entry points. r=prathiksha,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D74940
2020-05-19 16:58:51 +00:00
Artem
e206d05827 Bug 1609559 - Migrate protectionsPanel.inc.xhtml to Fluent r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D71234
2020-04-28 06:23:10 +00:00