Commit Graph

270 Commits

Author SHA1 Message Date
Nick Fitzgerald
e2b9500fa0 servo: Merge #9774 - Implement removeAttributeNode (from nox:remove-attribute-node); r=nox
Supersedes #8727

Source-Repo: https://github.com/servo/servo
Source-Revision: 6c65e154f481afca53f155736c0d226e3ae44916
2016-02-27 14:53:06 +05:00
Anthony Ramine
a163e999dd servo: Merge #9064 - Implement Element.getAttributeNames (from nox:them-attr-names); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 918681931f0eff7f7e5658b8d869eba233bbd1c6
2016-02-27 00:14:24 +05:00
Eli Friedman
ed6993fee8 servo: Merge #9743 - Use presentation hints correctly for the dimensions of <img> (from jdm:image-preshint-rebase); r=pcwalton
Mostly straightforward; includes some extra fixes to make `<canvas>`
work the same way as `<img>` for reflow.

Rebase of #8531.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8c23cbb78b36ac143bbea3b2e64961bfc46d8e0d
2016-02-26 00:39:32 +05:00
Anthony Ramine
1856ae1166 servo: Merge #9742 - Make use of From<String> for Atom (from nox:atom-from-string); r=ecoal95
Source-Repo: https://github.com/servo/servo
Source-Revision: b3b6f092062eed2f323da88991553d0285da6a16
2016-02-25 08:09:44 +05:00
Matt Brubeck
cf6376f15e servo: Merge #9722 - Dirty elements whose selectors are affected by sibling changes (from mbrubeck:slow-selector); r=nox
This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc.  Fixes #8191 and other intermittent layout bugs.

This code is based on the following flags from Gecko:
https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134

Depends on servo/rust-selectors#71. r? @SimonSapin

There are a couple of TODO items in this commit, but I'd appreciate feedback on the general approach before I finish it up.  (Also, if someone who knows more than I do could give some advice about atomic orderings...)

Source-Repo: https://github.com/servo/servo
Source-Revision: 438b3a444b40ea85e53be0bd1c4689680d577727
2016-02-24 18:25:39 +05:00
Anthony Ramine
011de9f1aa servo: Merge #9532 - Say farewell to in-tree HeapSizeOf (from nox:dedup-heapsize); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 2a6707ce58df27d93e865bffb6b44d396b810c99
2016-02-05 03:10:36 +05:00
Emilio Cobos Álvarez
3a8bc8c62b servo: Merge #9510 - Update rust-selectors (from nox:bump-selectors); r=SimonSapin
This commits updates rust-selectors to use the generic parser, and as
such it moves the element state into the style crate.

Source-Repo: https://github.com/servo/servo
Source-Revision: ae20f2556bc7807b39b6649ac1f738644abcc26a
2016-02-03 06:34:11 +05:00
Mathieu Hordesseaux
8f51eece76 servo: Merge #9061 - Implement SetNamedItem and SetNamedItemNS (from mathieuh:setNameItem); r=eefriedman
@nox Can you add the "it needs tests" tag or so?

Source-Repo: https://github.com/servo/servo
Source-Revision: 55d4773311b7d15b5e1a7fc4b17047a51e097933
2016-01-28 16:36:41 +05:00
Bobby Holley
b6f2595391 servo: Merge #9261 - Remove the msg dependency from style (from bholley:geckolib_nomsg); r=Manishearth
This is part of slimming down the dependencies of geckolib.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3680e82cab766a412a969a21c0cdff0c7f97d7bc
2016-01-12 08:53:31 +05:00
Manish Goregaokar
a2398b7ad6 servo: Merge #8983 - Various textinput fixes (from Manishearth:cursors); r=jdm
- Currently the cursor sticks around if you click elsewhere. Now the text inputs are relayout-ed on blur.
 - Currently whitespace gets collapsed in text input (https://github.com/servo/servo/issues/8772). Not anymore.

Source-Repo: https://github.com/servo/servo
Source-Revision: 099beee85c02d391b854dc5e06da34f89df8b760
2016-01-11 22:51:03 +05:00
Ying-Ruei Liang (KK)
9083178191 servo: Merge #9119 - Parse size attribute of HTMLInputElemnt correctly (from TheKK:input_element_size); r=eefriedman
Should fix #8773

Source-Repo: https://github.com/servo/servo
Source-Revision: 64e968d8bc88f646ebe9ae148c883d1b036f73d1
2016-01-06 08:27:19 +05:00
Guillaume Gomez
5ae987f50b servo: Merge #9146 - Generate PartialEq automatically (from GuillaumeGomez:generate_partial_eq); r=nox
r? @nox

Fixes #8804

Source-Repo: https://github.com/servo/servo
Source-Revision: 1096183cceea9ec78ab02caa33ee2d14668d977d
2016-01-04 00:07:10 +05:00
Iszak Bryan
e00f47053b servo: Merge #9137 - #9135 Optimise get_root_element for elements in documents (from iszak:issue-9135); r=nox
Fixes https://github.com/servo/servo/issues/9135

Source-Repo: https://github.com/servo/servo
Source-Revision: 4a141fb63f041d8101af89566401a1b7931246b6
2016-01-03 11:03:00 +05:00
Johannes Linke
bb6c128359 servo: Merge #9123 - Fix a bunch of clippy lints (from karyon:clippy_cleanup); r=Manishearth
This fixes about 130 clippy lints. Let me know if i should split up the commit.

I wasn't sure about some of the changes, especially map_or instead of map(...).unwrap_or(...) and if let instead of single arm match were not always a strict improvement in my opinion, but i'll leave that decision to the reviewer :)

There are about 150 lints left which i thought were clippy bugs or i didn't know how to fix.

cc @Manishearth

Source-Repo: https://github.com/servo/servo
Source-Revision: 9da739acefc7d1776bf727c8bf782eb79f241028
2016-01-03 08:46:34 +05:00
Corey Farwell
4f18da8c7f servo: Merge #9099 - Remove fields with parsed attribute values on HTMLTextAreaElement (from frewsxcv:rm-parsed-attr); r=nox
https://github.com/servo/servo/issues/7863

Source-Repo: https://github.com/servo/servo
Source-Revision: 5e497cf3112194e4e35776c7df97930f8ff7e153
2016-01-01 00:45:13 +05:00
David Raifaizen
72bb0a52d2 servo: Merge #8420 - Enabled use of FontFamily enum type (from craftytrickster:8371/generic-font-family); r=glennw
https://github.com/servo/servo/issues/8371

In addition to replacing loose strings with the FontFamily enum in `font_cache_task.rs`, I also centralized the add_generic_font calls into one single function. If centralizing into one function is not desired or if anything else needs to be changed, please let me know.

Source-Repo: https://github.com/servo/servo
Source-Revision: 66c8aa8cdac24ad956be5e99be3b7bc07c5f798c
2015-12-31 16:19:48 +05:00
Josh Matthews
7a3267dde4 servo: Merge #8109 - Make button elements activatable (from jdm:buttonactivate); r=eefriedman
Source-Repo: https://github.com/servo/servo
Source-Revision: 4a8e22c864a0fa1b6fca1c82374a3227afa3298d
2015-12-30 03:22:26 +05:00
Anthony Ramine
d5a2223cae servo: Merge #8506 - Properly propagate changes when range or trees are mutated (from nox:finish-ranges); r=dzbarsky
Does the same thing as #6817, but storing Range instances directly in their start and end containers.

Cc @dzbarsky

Source-Repo: https://github.com/servo/servo
Source-Revision: 89ab368258eb827b0dcc8d6e6deecd3ed3c1de71
2015-12-26 03:38:15 +05:00
Mathieu Agopian
c4a46a7e14 servo: Merge #9019 - Use Url.join instead of UrlParser.base_url(...).parse (#9002) (from magopian:9002-use-url.join); r=SimonSapin
Fix issue #9002

Source-Repo: https://github.com/servo/servo
Source-Revision: f9141ef2db693518fef676740f25abee3b938cac
2015-12-19 01:28:56 +05:00
Alan Jeffrey
b23b662826 servo: Merge #8992 - Bump string_cache version to 0.2.5 (from asajeffrey:bump_string_cache_version); r=nox
Atom::to_lower_case() now returns an Atom rather than a String,
so there are a few asserts that need a different collection of &s and *s.

Source-Repo: https://github.com/servo/servo
Source-Revision: 85b43ea31726776b5d9aafa58786850c12e2c852
2015-12-16 04:03:50 +05:00
GauriGNaik
f9f1c0b345 servo: Merge #8971 - Add pipeline information to CSS error reporting (from jdm:expose-css-errors-1); r=jdm
Rebase of #8838.

Source-Repo: https://github.com/servo/servo
Source-Revision: d11f96e27074b0130760a02d39d2da4e003c820e
2015-12-14 21:21:41 +05:00
Simon Sapin
686c7f590d servo: Merge #8852 - Add link to issue for :visited (from servo:visited-issue-link); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 2af23dc06151475b053bd76976fd9da899f27b8b
2015-12-06 01:36:40 +05:00
Eli Friedman
cc82f1bb12 servo: Merge #8786 - Remove unnecessary conversion to/from DOMString for localName (from eefriedman:localname-atom); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 63762d2b52ee6026216d304c8826bf8b4a5fdd20
2015-12-03 14:35:22 +05:00
Sam Gibson
b846355dca servo: Merge #7323 - Adds support for input element's maxlength attr (from samfoo:input-maxlength); r=jdm
This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8
2015-12-03 09:58:24 +05:00
Guillaume Gomez
ffbd83be65 servo: Merge #8675 - Add XMLDocument object (from GuillaumeGomez:master); r=nox
Fixes #8000

(Still working on it)

Source-Repo: https://github.com/servo/servo
Source-Revision: 99223656fbf6cade8c41d161a9e61a39f58ec796
2015-11-27 18:59:04 +05:00
GauriGNaik
192058cf08 servo: Merge #8682 - Defined new trait ParseErrorReporter and added error_reporter member … (from jdm:css-error-reporter); r=jdm
…to ParserContext.

Rebase of #8210.

Source-Repo: https://github.com/servo/servo
Source-Revision: f5ef2f4f75cd58a3c6f1f123e413dc9d3a24f841
2015-11-27 03:26:08 +05:00
Alan Jeffrey
4d3e2c8d46 servo: Merge #8667 - Update string cache (from asajeffrey:update-string-cache); r=SimonSapin
Updated string_cache to 0.2, and updated the dependencies that depend on string_cache.
Removed references to string_cache_plugin.
Import atom! and ns! from string_cache.
Replaced ns!("") by ns!().
Replaced ns!(XML) and co by ns!(xml) and co.
Replaced Atom::from_slice by Atom::from.
Replaced atom.as_slice() by &*atom.

r? @SimonSapin

Source-Repo: https://github.com/servo/servo
Source-Revision: 188fa9378c103093f1f8dac24bff0d9d237fd2bc
2015-11-25 23:40:39 +05:00
Ms2ger
49d6b5042b servo: Merge #8569 - Rustfmt some of script (from Ms2ger:fmt-script); r=metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: 7a87312121a69b590b364f9b5095f3145554e24b
2015-11-18 15:14:30 +05:00
Ms2ger
1535f2b370 servo: Merge #8533 - Remove the legacy module (from Ms2ger:legacy); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: b6f519cd0a9bdec909dcc5498f36f33e05f1115a
2015-11-15 18:43:13 +05:00
Corey Farwell
ce9719cac4 servo: Merge #8526 - Fix parse_length 0 values, implement <hr> 'width' (from frewsxcv:parse-length); r=eefriedman
Follow-up to https://github.com/servo/servo/issues/8424

Source-Repo: https://github.com/servo/servo
Source-Revision: 3ef0a9a79dffcde41cdd6081ef79a0f0593b5104
2015-11-15 03:00:46 +05:00
Alan Jeffrey
128ce4b968 servo: Merge #8477 - Opaque DOMString (from asajeffrey:opaque-domstring); r=asajeffrey
This patch makes DOMString an opaque wrapper round String (currently it's a transparent wrapper).

The changes are:

* Replacing DOMString(foo) by DOMString::from(foo).
* Replacing foo.0 by String::from(foo).
* Adding functions clear, push_str and extend for in-place mutation of DOMStrings.
* Replacing DOMString by String in other threads (devtools, storage and filereader).
* Making DOMString implement !Send.
* Removing the pub attribute from the contents of DOMString.

This enables experimenting with other string representations in the DOM.

Source-Repo: https://github.com/servo/servo
Source-Revision: 62acdd303b78951885c2c90747b31f318907d6c9
2015-11-13 06:47:30 +05:00
Corey Farwell
d0db054547 servo: Merge #8459 - Simplify iterating over Element attributes (from frewsxcv:namednodemap-iter); r=Ms2ger
Source-Repo: https://github.com/servo/servo
Source-Revision: 5e6efd62c1f19408f2d0dd50c48345b4122c0269
2015-11-11 19:49:49 +05:00
Corey Farwell
1a4c362d74 servo: Merge #8453 - Prefer Atoms over strs for comparison (from frewsxcv:atoms); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: fd5540df626508a57f6698b71d4d8ac8e95fb12e
2015-11-11 06:25:39 +05:00
Bobby Holley
7f2310076d servo: Merge #8381 - Implement attribute restyle hints (from bholley:attr_restyle_hints); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: 13226f847234cd0130820338d5a272277780d278
2015-11-11 00:57:45 +05:00
Eli Friedman
7d5ad1a7d8 servo: Merge #8431 - Move storage of bgcolor for <tr> and <tbody> (from eefriedman:table-bgcolor); r=frewsxcv
Source-Repo: https://github.com/servo/servo
Source-Revision: b386008623132deca21049f125ac761b20edc1dd
2015-11-10 06:28:16 +05:00
Eli Friedman
397a718894 servo: Merge #8404 - Misc cleanup for DOM attributes (from eefriedman:misc-attributes); r=nox
No functional change; just cleanups related to parsing attributes.

Source-Repo: https://github.com/servo/servo
Source-Revision: d8df028197505ca439363cdb05bed58fe9b4b726
2015-11-10 00:02:24 +05:00
Corey Farwell
4dddf85b6a servo: Merge #8419 - Implement <hr> 'color' attribute (from frewsxcv:html-hr-element-color-attribute); r=eefriedman
Source-Repo: https://github.com/servo/servo
Source-Revision: 3780fb7fe02ed66bd391421a0c5506b5635279dd
2015-11-09 04:58:51 +05:00
Bobby Holley
cd9a09c9f2 servo: Merge #8341 - Fix restyle hints to handle non-last psuedo-selectors, and track pristine state values rather than changesets (from bholley:state_hint_selector_ordering); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: 65c3185b202b8dd57a39e1d84872d7528723b191
2015-11-07 09:23:19 +05:00
Ms2ger
9ee6885f3c servo: Merge #8312 - Make DOMString a newtype around String, rather than a typedef (from Ms2ger:DOMString); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: abfd1fb1bf071961bc8a581927eaa96a2d3e2cba
2015-11-04 16:17:41 +05:00
David Zbarsky
97e45a8d2e servo: Merge #8305 - Get rid of a bunch of explicit derefs (from dzbarsky:roots); r=Ms2ger,
Source-Repo: https://github.com/servo/servo
Source-Revision: 4b9fa13f2f6a1aa38d180367426498f01f6414c9
2015-11-04 10:33:54 +05:00
rohan.prinja
f3c30d6ffd servo: Merge #8221 - move modules around (from ajnirp:8130-reorganise); r=jdm
for #8130

Source-Repo: https://github.com/servo/servo
Source-Revision: daad09d44245228fba9118316937add71bec7c58
2015-11-04 02:26:02 +05:00
Ms2ger
9329f94aa0 servo: Merge #8294 - Remove RawLayoutHTMLInputElementHelpers (from Ms2ger:layout-input); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 5c11c88e92ccbc3013501096d5625778774c9fee
2015-11-02 19:14:51 +05:00
David Zbarsky
73f9e4ad42 servo: Merge #7400 - Allow more valid use of calc expressions (from dzbarsky:angle); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: e72bd1437c667d5429f2e288701ae99aac5c4b4e
2015-11-02 12:16:43 +05:00
KALPESH KRISHNA
76e4f8e603 servo: Merge #8260 - Implementing activation behavior for <label> (from martiansideofthemoon:my-code-fix); r=Manishearth
Attempt to resolve #8179
@Manishearth , could you give me some resources having more information about what each function in `Activatable` does? The code compiles on my machine but I guess a lot more is needed

Source-Repo: https://github.com/servo/servo
Source-Revision: 53d8f04ac4894480aa8bc7a6a79fb5e02ae050d1
2015-10-31 21:55:27 +05:00
nxnfufunezn
c6b8ff7ba2 servo: Merge #8262 - Removed JS::root #8251 (from nxnfufunezn:Remove_JS_root); r=Ms2ger
Fixes #8251

r? @Ms2ger

Source-Repo: https://github.com/servo/servo
Source-Revision: 37c03c78165fbb77eb024f2c3376d5e33cd7e446
2015-10-31 17:54:23 +05:00
Bobby Holley
6797370361 servo: Merge #8162 - Centralize event states in rust-selectors (from bholley:centralize_event_states); r=pcwalton
This still needs a rev bump on rust-selectors once https://github.com/servo/rust-selectors/pull/55 gets merged.

Source-Repo: https://github.com/servo/servo
Source-Revision: 521a87180a85709f8f704df33537f79bd131bf71
2015-10-31 09:35:45 +05:00
Michael Wu
4d86b05893 servo: Merge #8273 - Minor cleanups for DOM (from michaelwu:cleanups); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: c887aaf6943c3945aed391e6fbbc23c709a4517f
2015-10-31 00:59:25 +05:00
Bobby Holley
3eb79a9936 servo: Merge #8098 - Track event state changes on Document and do the dirtying from layout (from bholley:dirty_from_layout); r=jdm
This is a first step in fixing #6942.

Source-Repo: https://github.com/servo/servo
Source-Revision: 285e29c06637f31a8b8a27c2e454468717924ebd
2015-10-28 23:54:53 +05:00
Tetsuharu OHZEKI
c5eb63ef20 servo: Merge #8183 - script: Element.webkitMatchesSelector() (from saneyuki:matches); r=nox
spec:
- 9ac9c15486
  - https://github.com/whatwg/compat/issues/3

Source-Repo: https://github.com/servo/servo
Source-Revision: 47a8256c2cdd254943aaaf71e68204f9dcd70744
2015-10-25 02:47:30 -05:00
Anthony Ramine
db09beb657 servo: Merge #8041 - Introduce trait Castable (from nox:castable); r=jdm
Removes all those messy FooCast structures in InheritTypes.rs.

Source-Repo: https://github.com/servo/servo
Source-Revision: 674589c370d978f543e71f995d58c5b28e6e9842
2015-10-21 07:57:32 -06:00