Commit Graph

44420 Commits

Author SHA1 Message Date
Mark Banner
cd639ffbbf Bug 1963781 - Improve some type definitions in the browser/components/search code. r=mbeier
Differential Revision: https://phabricator.services.mozilla.com/D247423
2025-05-13 18:36:08 +00:00
Chris H-C
59665244c3 Bug 1963704 - Remove unused 'uitour-tag' ping r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D248645
2025-05-13 16:46:29 +00:00
Dão Gottwald
aa008038e2 Bug 1966040 - Tab group drag image offset should match that of tabs. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D249046
2025-05-13 16:43:31 +00:00
agoloman
9e8fab34c1 Revert "Bug 1962454 - Pass origin instead of host/port to Windows notification r=nalexander,win-reviewers,firefox-desktop-core-reviewers ,gstoll" for causing xpc failures @test_backgroundtask_experiments.js.
This reverts commit 1ee24b59e7.
2025-05-13 16:41:37 +00:00
Sebastian Hengst
1ee24b59e7 Bug 1962454 - Pass origin instead of host/port to Windows notification r=nalexander,win-reviewers,firefox-desktop-core-reviewers ,gstoll
This is to match NotificationDB that uses origin.

Differential Revision: https://phabricator.services.mozilla.com/D236586
2025-05-13 14:58:01 +00:00
Meg Viar
ac61100a31 Bug 1964816 - Support Localization in Universal Infobars r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D248136
2025-05-13 14:15:51 +00:00
Gijs Kruitbosch
03f21bee51 Bug 1958948 - fix category selection error in settings for CSS injection, r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D249005
2025-05-13 12:33:50 +00:00
Valentin Gosu
58db94290b Bug 1948543 - Do not use file extension when sniffing mime type r=necko-reviewers,willdurand,kershaw,devtools-reviewers,bomsy,geckoview-reviewers,nalexander
This patch adds a network.sniff.use_extension pref.
When false, the file extension of a URL will only be used to sniff file://

Differential Revision: https://phabricator.services.mozilla.com/D246585
2025-05-13 10:34:58 +00:00
Tooru Fujisawa
7661d784e2 Bug 1931058 - Do not coerce the javascript: return value to a string. r=smaug,devtools-reviewers,nchevobbe
Update the code to follow the spec change:
9997cd93c6

Differential Revision: https://phabricator.services.mozilla.com/D229475
2025-05-13 07:35:57 +00:00
Daniel Thorn
66f5b9c82a Bug 1959483 - Port tests from ExperimentFakes and ExperimentTestUtils to NimbusTestUtils for browser/components/tests r=nimbus-reviewers,beth,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D247013
2025-05-13 04:05:09 +00:00
Cristian Tuns
321046281b Revert "Bug 1956399 - Add the 'Sponsors help support our mission' message with the fox in the Settings panel after the "Recommended stories" section r=home-newtab-reviewers,fluent-reviewers,bolsson,settings-reviewers,desktop-theme-reviewers,reemhamz,mconley,sfoster" for causing bc failures
This reverts commit c1e837bd01.
2025-05-13 03:42:23 +00:00
Atila Butkovits
6677b18a72 Revert "Bug 1948543 - Do not use file extension when sniffing mime type r=necko-reviewers,willdurand,kershaw,devtools-reviewers,bomsy,geckoview-reviewers,nalexander" for causing bustages at IndexOutOfBoundsException.
This reverts commit 5eef155802.
2025-05-13 02:30:01 +00:00
Nina Pypchenko
c1e837bd01 Bug 1956399 - Add the “Sponsors help support our mission” message with the fox in the Settings panel after the "Recommended stories" section r=home-newtab-reviewers,fluent-reviewers,bolsson,settings-reviewers,desktop-theme-reviewers,reemhamz,mconley,sfoster
- Refactored the code for `about:settings#home` page to rely more on the page template and less on dynamic node injection.

- Added the mission message between settings blocks for Top stories and Recent activity.

- Removed code that switched to/from an obsolete row number preference for Top stories.

- Updated tests.

Differential Revision: https://phabricator.services.mozilla.com/D243042
2025-05-13 01:49:42 +00:00
Mark Striemer
6c85e64f09 Bug 1963938 - Disable config-based prefs when locked r=reusable-components-reviewers,settings-reviewers,tgiles
Differential Revision: https://phabricator.services.mozilla.com/D247503
2025-05-13 01:48:52 +00:00
Valentin Gosu
5eef155802 Bug 1948543 - Do not use file extension when sniffing mime type r=necko-reviewers,willdurand,kershaw,devtools-reviewers,bomsy,geckoview-reviewers,nalexander
This patch adds a network.sniff.use_extension pref.
When false, the file extension of a URL will only be used to sniff file://

Differential Revision: https://phabricator.services.mozilla.com/D246585
2025-05-13 01:48:28 +00:00
Vasish Baungally
33c648d5ab Bug 1964774 - Improve Suggest Latency for Smart Tabs by preloading. r=ngrato,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D248098
2025-05-13 01:47:38 +00:00
Cristian Tuns
f2b97e2ffe Revert "Bug 1964428 - Remove coarse_os_version and add country to newtab-content ping r=home-newtab-reviewers,amy" for causing conflict when backing out Bug 1964445
This reverts commit 69f1aedced.
2025-05-13 00:56:07 +00:00
Beth Rennie
0ab5091f13 Bug 1959208 - Use GleanPing::TestSubmission in browser/components/pocket r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D247506
2025-05-13 00:24:35 +00:00
Moritz Beier
d485c1efce "Bug 1963590 - Fix isURILike with nsINavHistoryResultNodes. r=places-reviewers,mak"
This reverts commit 572b2c4826.
2025-05-13 00:03:02 +00:00
Cristian Tuns
9eeeff4b0b Revert "Bug 1959206 - Use GleanPing::TestSubmission in browser/components/aboutwelcome r=omc-reviewers,emcminn" for causing bc failures in browser_aboutwelcome_glean.js
This reverts commit af42175f5a.
2025-05-12 23:38:14 +00:00
Beth Rennie
af42175f5a Bug 1959206 - Use GleanPing::TestSubmission in browser/components/aboutwelcome r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D244835
2025-05-12 22:32:50 +00:00
Beth Rennie
80ea752013 Bug 1959207 - Use GleanPing::TestSubmission in browser/components/asrouter r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D247505
2025-05-12 22:32:26 +00:00
Atila Butkovits
68a16d54b6 Revert "Bug 1965386 - Skip enrollment for nonexistant features r=nimbus-reviewers,relud,search-reviewers,jteow" for causing failures at browser_defaultPrivate_nimbus.js.
This reverts commit 143dd8a55a.
2025-05-12 22:14:09 +00:00
Kelly Cochrane
b9f3692262 Bug 1965742 - Don't add/remove MosPosTracker listeners for tab preview popups r=sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D248958
2025-05-12 20:59:25 +00:00
Beth Rennie
143dd8a55a Bug 1965386 - Skip enrollment for nonexistant features r=nimbus-reviewers,relud,search-reviewers,jteow
We already reject recipes in the RemoteSettingsExperimentLoader if they
have reference features not found in the feature manifest. However,
there are several tests that reference bogus features which should
really be failing. We now refuse to enroll silently in these recipes.

Tests will now fail loudly if they use the `NimbusTestUtils.enroll()` or
`NimbusTestUtils.enrollWithFeatureConfig()` APIs.

Differential Revision: https://phabricator.services.mozilla.com/D248561
2025-05-12 20:53:33 +00:00
Nathan Barrett
69f1aedced Bug 1964428 - Remove coarse_os_version and add country to newtab-content ping r=home-newtab-reviewers,amy
Differential Revision: https://phabricator.services.mozilla.com/D247788
2025-05-12 20:52:44 +00:00
Atila Butkovits
572b2c4826 Revert "Bug 1963590 - Fix isURILike with nsINavHistoryResultNodes. r=places-reviewers,mak" for causing failures at browser_native_font_cache_macos.js.
This reverts commit b27474929f.
2025-05-12 18:54:24 +00:00
Moritz Beier
b8324c0e82 Bug 1965438 - Correctly restore search engines at end of test. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D248637
2025-05-12 17:09:54 +00:00
Moritz Beier
b27474929f Bug 1963590 - Fix isURILike with nsINavHistoryResultNodes. r=places-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D247898
2025-05-12 17:03:58 +00:00
Stephen Thompson
5b3f57be44 Bug 1954005 - URL bar search should not show saved tab groups in private windows r=dao,dwalker,urlbar-reviewers,tabbrowser-reviewers
In bug 1933744 we prevented SessionStore from reopening a saved tab group into a private window. In bug 1946761 we prevented users from saving tab groups from a private window. The general design principle has been to prevent tab group information leaking between private and non-private windows.

ActionsProviderTabGroups already respected privacy through the implementation of `Tabbrowser.getAllTabGroups`, but `SessionStore.getSavedTabGroups` doesn't respect privacy. Perhaps it should. But in any case, this patch ensures that search results in private windows don't include saved tab groups.

Differential Revision: https://phabricator.services.mozilla.com/D248351
2025-05-12 15:19:01 +00:00
Emilio Cobos Álvarez
02216609fd Bug 1965660 - Remove unneeded ::-moz-focus-inner usage from the front-end. r=devtools-reviewers,webcompat-reviewers,twisniewski,nchevobbe
These became unneeded either when:

 * We shipped the non-native theme (for newtab etc).
 * We made unthemed buttons not show this inner ring.

Differential Revision: https://phabricator.services.mozilla.com/D248698
2025-05-12 15:18:37 +00:00
Francesco Lodolo
e2b6a89c7f Bug 1965661 - Use correct IDs when generating blocklist names in settings, r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D248704
2025-05-12 12:01:51 +00:00
Tom Schuster
a2ab9b17e7 Bug 1962053 - Don't allow bypassing the CSP for scripts loaded as SystemPrincipal. r=simonf
Differential Revision: https://phabricator.services.mozilla.com/D246455
2025-05-12 11:03:41 +00:00
Connor Pearson
579264d5e4 Bug 1661664 - Part 2: Include favicon when adding custom search engine. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D240377
2025-05-12 09:13:44 +00:00
Moritz Beier
0516176778 Bug 1661664 - Part 1: Add changeIcon method to UserSearchEngine. r=Standard8,settings-reviewers,mossop
Also separates out _setIcon to allow re-using the resize functionality, and simplifies the edit engine dialog to use UserSearchEngine directly.

Differential Revision: https://phabricator.services.mozilla.com/D247571
2025-05-12 09:13:40 +00:00
Moritz Beier
094ffaecef Bug 1960237 - Only offer "Add Search Engine" for forms with an explicit action attribute. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D247775
2025-05-12 09:08:28 +00:00
Rob Wu
c2fb04ffe8 Bug 1965714 - Drop optional from queryInfo in tabGroups.query() r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D248716
2025-05-12 02:20:24 +00:00
Beth Rennie
6f53714516 Bug 1950237 - Use ExperimentAPI.manager in browser/components/urlbar r=urlbar-reviewers,Standard8
As part of this bug, the global ExperimentManager will no longer be
exported from ExperimentManager.sys.mjs and will only be available as a
property on the ExperimentAPI.

Differential Revision: https://phabricator.services.mozilla.com/D248317
2025-05-11 19:37:18 +00:00
Mike Conley
7a95f03263 Bug 1960560 - Follow-up: Remove accidental repeat of 4th step for Chrome password import in wizard. r=Gijs,migration-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D248699
2025-05-10 19:24:03 +00:00
Beth Rennie
5b712aad1b Bug 1959486 - Use NimbusTestUtils.assert.storeIsEmpty and NimbusTestUtils.removeStore everywhere r=nimbus-reviewers,settings-reviewers,relud
Differential Revision: https://phabricator.services.mozilla.com/D248563
2025-05-10 18:41:33 +00:00
Cristian Tuns
dbf6b952be Revert "Bug 1959486 - Use NimbusTestUtils.assert.storeIsEmpty and NimbusTestUtils.removeStore everywhere r=nimbus-reviewers,settings-reviewers,relud" for causing bc failures in browser_windows_launch_on_login.js
This reverts commit 47c7b39975.
2025-05-10 14:52:22 +00:00
Beth Rennie
47c7b39975 Bug 1959486 - Use NimbusTestUtils.assert.storeIsEmpty and NimbusTestUtils.removeStore everywhere r=nimbus-reviewers,settings-reviewers,relud
Differential Revision: https://phabricator.services.mozilla.com/D248563
2025-05-10 13:15:19 +00:00
Alexandru Marc
2c4e93088b Revert "Bug 1959486 - Use NimbusTestUtils.assert.storeIsEmpty and NimbusTestUtils.removeStore everywhere r=nimbus-reviewers,settings-reviewers,relud" for causing bc failures @ browser_about_settings.js
This reverts commit bfd3073ff0.
2025-05-10 03:19:48 +00:00
Beth Rennie
e66b17993a Bug 1959209 - Use GleanPing::TestSubmission in browser/components/reportbrokensite r=webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D247507
2025-05-10 02:25:12 +00:00
Beth Rennie
e0aad13b7a Bug 1959212 - Use GleanPing::TestSubmission in browser/components/tests r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D247509
2025-05-10 02:24:13 +00:00
Beth Rennie
8e07ab43dc Bug 1959211 - Use GleanPing::TestSubmission in browser/components/search r=search-reviewers,jteow
Differential Revision: https://phabricator.services.mozilla.com/D247508
2025-05-10 02:23:39 +00:00
Beth Rennie
bfd3073ff0 Bug 1959486 - Use NimbusTestUtils.assert.storeIsEmpty and NimbusTestUtils.removeStore everywhere r=nimbus-reviewers,settings-reviewers,relud
Differential Revision: https://phabricator.services.mozilla.com/D248563
2025-05-10 02:14:28 +00:00
Tim Xia
f69e73edb1 Bug 1962756 - add button to link preview to jump to settings - r=Mardak,firefox-ai-ml-reviewers,fluent-reviewers,bolsson
- update styles with moz-button
- redirect to #general-link-preview
- add dismiss event dispatch

Differential Revision: https://phabricator.services.mozilla.com/D248343
2025-05-09 22:57:00 +00:00
Beth Rennie
640c25685e Bug 1950237 - Use ExperimentAPI.manager in browser/components/preferences r=settings-reviewers,Gijs
As part of this bug, the global ExperimentManager will no longer be
exported from ExperimentManager.sys.mjs and will only be available as a
property on the ExperimentAPI.

Differential Revision: https://phabricator.services.mozilla.com/D248316
2025-05-09 22:16:00 +00:00
Alexandru Marc
ccce73c96b Revert "Bug 1960237 - Only offer "Add Search Engine" for forms with an explicit action attribute. r=search-reviewers,scunnane" for causing bc failures @ browser_search_userEngineDialog.js
This reverts commit 0a65c6f1cb.

Revert "Bug 1661664 - Part 3: Add tests for UserSearchEngine favicons. r=search-reviewers,Standard8,settings-reviewers,mossop"

This reverts commit f093133692.

Revert "Bug 1661664 - Part 2: Include favicon when adding custom search engine. r=Standard8"

This reverts commit 8a4a96e8b8.

Revert "Bug 1661664 - Part 1: Add changeIcon method to UserSearchEngine. r=Standard8,settings-reviewers,mossop"

This reverts commit 15a19beb80.
2025-05-09 22:07:01 +00:00