corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
903,474 Commits 1 Branch 0 Tags
cc33cd20bb9efd8895f57236f8d3b19c65c6a608
Commit Graph

502 Commits

Author SHA1 Message Date
Florian Quèze
9ec8cc29a6 Bug 1956726 - Migrate histograms to use Glean APIs in browser/, r=chutten,sessionstore-reviewers,tabbrowser-reviewers,mconley,nsharpley. 
Differential Revision: https://phabricator.services.mozilla.com/D243706
 2025-04-03 17:09:35 +00:00
Stephen Thompson
895511dc6f Bug 1938430 - add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers 
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Differential Revision: https://phabricator.services.mozilla.com/D241884
 2025-04-03 14:12:43 +00:00
Kelly Cochrane
43f88580f8 Bug 1956909 - Prevent expand on hover jumping animation after browser restart r=tabbrowser-reviewers,sidebar-reviewers,jsudiaman,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D244203
 2025-04-03 10:09:14 +00:00
Rolf Rando
830f66b654 Bug 1955955 - Handle user cancel of Smart Tab Grouping Opt-in or clustering r=ngrato,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D244086
 2025-04-02 18:02:22 +00:00
Nick Grato
5d6e28533b Bug 1957708 - Add link place holder to optin message r=fluent-reviewers,tabbrowser-reviewers,firefox-ai-ml-reviewers,flod,txia 
Adding additional functionality for there to be a link in the message part of the optin component. Using a place holder link to support for now. This will be updated to a new SUMO article.

Differential Revision: https://phabricator.services.mozilla.com/D244069
 2025-04-02 16:28:38 +00:00
Nick Grato
9202f6836f Bug 1957777 - highlight name field when label is suggested r=dwalker,tabbrowser-reviewers 
highlight text when label is suggested but also un-focus the input when a user clicks out of the input anywhere on the panel.

Differential Revision: https://phabricator.services.mozilla.com/D244096
 2025-04-02 16:10:37 +00:00
Vasish Baungally
7a6a4ff8f9 Bug 1957097 - Add telemetry for empty suggestion from ML topic model. r=rrando,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D243465
 2025-04-01 20:35:12 +00:00
Stephen Thompson
8f903ac1e3 Bug 1952530 - prevent pinned tabs from dropping outside of pinned area r=dao,tabbrowser-reviewers 
When dragging a pinned tab into an overflowing tab strip, it's possible to drop the pinned tab after the first unpinned tab. This causes one of the pinned tabs to be covered up, it breaks the browser's count of pinned tabs, and it can lead to breakages in drag-drop and the visual rendering of the tab strip.

An additional constraint on the drop position will make sure that a pinned tab can't drop between unpinned tabs and an unpinned tab can't drop between pinned tabs.

Differential Revision: https://phabricator.services.mozilla.com/D242748
 2025-04-01 14:30:25 +00:00
Rolf Rando
24ded0f086 Bug 1956522 - Fix issue with private tab and smart tab grouping r=tabbrowser-reviewers,vazish 
Differential Revision: https://phabricator.services.mozilla.com/D243392
 2025-03-28 15:50:02 +00:00
Jeremy Swinarton
b5d0e3b6a6 Bug 1953801: Update SessionStore cache immediately after creating a tab group. r=sthompson,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241634
 2025-03-28 15:16:23 +00:00
Fred Chasen
f43d5bc2ba Bug 1953534 - Clean up Review Checker location change handlers. r=shopping-reviewers,kpatenio,tabbrowser-reviewers 
Now that the ReviewChecker sidebar can auto-open and close, the logic for finding distinct navigations needs to be updated.
This allow us to detect the first time new products URLs are requested to shown in the sidebar and to check if a tab should auto-open the sidebar after it was closed.

- `isDistinctProductPageVisit` now works the same as it did in the ShoppingSidebar, indicating that there was a product navigation while a tab was in the background.
- `reviewCheckerWasClosed` now prevents the sidebar from re-opening on tab changes for a location it was closed on.
- `isSimulated` is set to false in the location change handlers on tab changes where there was an unhandled background product navigation.
- Moves the `isSameProduct` check to `ShoppingUtils` and use that to test previous URIs passed to `hasLocationChanged`.
- Manager will only handle product page specific parts of location changes when the sidebar is not open to handle them.

Differential Revision: https://phabricator.services.mozilla.com/D241446
 2025-03-28 00:07:40 +00:00
Nick Grato
21173d07c3 Bug 1956643 - Change Select all tabs to a checkbox from a toggle button r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,sthompson,hjones 
when the user is presented with the AI suggested tabs in STG, change the action button that toggles the select and deselect actions to just being a simple select all checkbox that only selects all when checked. Remove the deselect all functionality.

Differential Revision: https://phabricator.services.mozilla.com/D243221
 2025-03-27 20:49:38 +00:00
Dão Gottwald
e1ac9df163 Bug 1939518 - Reimplement vertical tab group line to be more consistent with horizontal tabs, and move container tab line to the end of the tab. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242949
 2025-03-27 19:27:07 +00:00
Jeremy Swinarton
34d9e59418 Bug 1938426: Record telemetry event when saving a tab group r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242984
 2025-03-27 15:29:19 +00:00
Nikki Sharpley
52f6f5d35b Bug 1954966 - Update drag behaviour for pinned tabs in expand on hover mode r=sidebar-reviewers,tabbrowser-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D242768
 2025-03-27 13:51:25 +00:00
Kelly Cochrane
6685a37131 Bug 1950419 - Prevent sidebar from collapsing when opening context menu if expand on hover is enabled r=tabbrowser-reviewers,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D242740
 2025-03-26 19:14:46 +00:00
Cosmin Sabou
ced1f3c105 Backed out changeset 68d101b370d8 (bug 1938430) for permafailures on browser_tab_manager_groups.js (Bug 1938697). 2025-03-27 00:21:30 +02:00
Nick Grato
4113c7ce84 Bug 1956077 - Enhance STG user flow with assorted UX callouts r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,firefox-ai-ml-reviewers,sthompson,bolsson,hjones 
Update strings in STG user flow. Update button styles. Add new footer paragraph and link to model optin component. Expand the panel when showing suggested tabs. Fix messaging coloring when there are no tabs to suggest.

Differential Revision: https://phabricator.services.mozilla.com/D242786
 2025-03-26 17:16:39 +00:00
Chris Shiohama
79000c00ff Bug 1945404 - Added focusUrlBar property to new tabs created with right click context menu. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D242855
 2025-03-26 16:33:41 +00:00
Vasish Baungally
2e7c7849b7 Bug 1956073 - Add Opt-in & additional telemetry for Smart Tab Grouping r=rrando,dwalker,tabbrowser-reviewers 
- Telemetry for opt-in
     - For each onboarding step
- Telemetry updates for existing
     - Clicking away with ML group name without explicitly clicking "done" or "cancel"
     - When there are no suggestions for "suggest other tabs"
     - Add group id to ml telemetry
     - Move stg telemetry under tab group telemetry
     - Remove num_ from events

Differential Revision: https://phabricator.services.mozilla.com/D242784
 2025-03-26 15:41:49 +00:00
Stephen Thompson
78282be03c Bug 1938430 - add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers 
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Differential Revision: https://phabricator.services.mozilla.com/D241884
 2025-03-25 21:16:37 +00:00
Dão Gottwald
8b40ef8567 Bug 1956252 - Don't let #moveTabNextTo move unpinned tabs between pinned ones. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242935
 2025-03-25 15:45:37 +00:00
Cosmin Sabou
782522ac2f Backed out changeset bfb6d89e6bb9 (bug 1953801) for causing bc failures on browser_restore_container_tabs_oa. CLOSED TREE 2025-03-25 19:36:35 +02:00
Dão Gottwald
270b9d5781 Bug 1955276 - Consolidate moveTabTo checks. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242338
 2025-03-25 14:16:54 +00:00
Dão Gottwald
f9a2272451 Bug 1955361 - Make dropping a link insert the new tab at the correct drop index. r=jswinarton,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242632
 2025-03-25 14:05:34 +00:00
Jeremy Swinarton
39b35f9816 Bug 1953801: Update SessionStore cache immediately after creating a tab group. r=sthompson,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241634
 2025-03-25 13:39:45 +00:00
DJ
4467bf52f4 Bug 1955388 - prevent pinned tabs from commingling with non-pinned tabs when there are hidden tabs present. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242596
 2025-03-24 18:22:30 +00:00
Dão Gottwald
e588889083 Bug 1954341 - Disable tabdrop-samewindow transition for dragged tab groups. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242642
 2025-03-24 15:51:54 +00:00
Dão Gottwald
9150b253ca Bug 1955112 - Finish tab moving animation when a drag session wasn't ended properly. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242631
 2025-03-24 15:00:26 +00:00
Rolf Rando
6457c1eed4 Bug 1954648 - Smart Tab Group settings in Preferences->Tabs r=ngrato,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,dwalker,flod 
Differential Revision: https://phabricator.services.mozilla.com/D241922
 2025-03-23 04:03:31 +00:00
Dão Gottwald
e05dcb5003 Bug 1955391 - Make elementIndex throw on tabs that aren't visible. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242544
 2025-03-21 20:27:57 +00:00
Nick Grato
a637f54059 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones 
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
 2025-03-21 16:03:03 +00:00
Francesco Lodolo (:flod)
2dc7e3ee3a Bug 1955573 - Don't generate Fluent IDs at run-time for Tab Group colors, r=tabbrowser-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D242520
 2025-03-21 15:33:38 +00:00
Florian Quèze
41442e60fd Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_CLOSE_*, r=chutten,tabbrowser-reviewers,nsharpley. 
Differential Revision: https://phabricator.services.mozilla.com/D242169
 2025-03-21 15:32:40 +00:00
Florian Quèze
1c4eb07f93 Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten,tabbrowser-reviewers,mconley. 
Differential Revision: https://phabricator.services.mozilla.com/D242167
 2025-03-21 15:32:40 +00:00
shaneziegler
37f81a03af Bug 1954799 - Move new tab, new window, home button drag/drop handlers out of browser.js into ToolbarDropHandler.sys.mjs r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D242203
 2025-03-21 14:37:32 +00:00
Dão Gottwald
ddb726f7e6 Bug 1955621 - Make the tabGroups.enabled Nimbus feature variable use setPref instead of fallbackPref. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242546
 2025-03-21 14:16:57 +00:00
Dão Gottwald
5b7b89286d Bug 1954865 - Fix closing the last unpinned tab via mouse. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242292
 2025-03-21 12:46:03 +00:00
Butkovits Atila
a1232f30d3 Backed out changeset e2836c2d1f98 (bug 1951524) for causing failures at browser_all_files_referenced.js. 2025-03-21 08:37:42 +02:00
Nick Grato
2a66d14721 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones 
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
 2025-03-21 03:23:11 +00:00
Stanca Serban
7df2c7072f Backed out 5 changesets (bug 1950710) for causing timeout related failures. CLOSED TREE 
Backed out changeset 7a1f8fe65c63 (bug 1950710)
Backed out changeset d2514bee519f (bug 1950710)
Backed out changeset c5f6cd03c1d4 (bug 1950710)
Backed out changeset 9e57a5c12317 (bug 1950710)
Backed out changeset 482b8c741722 (bug 1950710)
 2025-03-21 06:29:53 +02:00
Stanca Serban
dfcc675d76 Backed out changeset c0e6b3896ea0 (bug 1954865) for causing mochitests failures in browser_standalonePinnedTab.js. 2025-03-21 06:18:11 +02:00
Florian Quèze
4ec5f45bdb Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_CLOSE_*, r=chutten,tabbrowser-reviewers,nsharpley. 
Differential Revision: https://phabricator.services.mozilla.com/D242169
 2025-03-20 20:14:04 +00:00
Florian Quèze
3a92537eb9 Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten,tabbrowser-reviewers,mconley. 
Differential Revision: https://phabricator.services.mozilla.com/D242167
 2025-03-20 20:14:03 +00:00
Dão Gottwald
ba53c891e3 Bug 1954865 - Fix closing the last unpinned tab via mouse. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D242292
 2025-03-20 17:46:50 +00:00
Gijs Kruitbosch
fcab2ecd6a Bug 1953575 - move gShareUtils to its own module, r=firefox-desktop-core-reviewers ,tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D241485
 2025-03-20 15:54:31 +00:00
Dão Gottwald
dbbbda7272 Bug 1954275 - Expand group when dragging a link over collapsed group label. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241724
 2025-03-20 03:27:20 +00:00
Sandor Molnar
53925bf70d Backed out changeset 272d0dd8b6a7 (bug 1954648) for causing bc failures @ browser_experimental_features.js 2025-03-19 23:36:30 +02:00
Rolf Rando
07417b054d Bug 1954648 - Smart Tab Group settings in Preferences->Tabs r=ngrato,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,dwalker,flod 
Differential Revision: https://phabricator.services.mozilla.com/D241922
 2025-03-19 17:14:19 +00:00
Dão Gottwald
3ba48b6655 Bug 1950904 - Use element index instead of tab index for the drop indicator. r=dwalker,jswinarton,tabbrowser-reviewers,perftest-reviewers,fbilt 
Differential Revision: https://phabricator.services.mozilla.com/D239937
 2025-03-19 15:07:53 +00:00