Florian Quèze
9ec8cc29a6
Bug 1956726 - Migrate histograms to use Glean APIs in browser/, r=chutten,sessionstore-reviewers,tabbrowser-reviewers,mconley,nsharpley.
...
Differential Revision: https://phabricator.services.mozilla.com/D243706
2025-04-03 17:09:35 +00:00
Jeremy Swinarton
d0cf81701e
Bug 1927527: Add test to ensure session store cleans up stale closed tab groups r=dwalker,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D243519
2025-04-02 13:16:43 +00:00
Jeremy Swinarton
b5d0e3b6a6
Bug 1953801: Update SessionStore cache immediately after creating a tab group. r=sthompson,sessionstore-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D241634
2025-03-28 15:16:23 +00:00
Cosmin Sabou
782522ac2f
Backed out changeset bfb6d89e6bb9 (bug 1953801) for causing bc failures on browser_restore_container_tabs_oa. CLOSED TREE
2025-03-25 19:36:35 +02:00
Jeremy Swinarton
39b35f9816
Bug 1953801: Update SessionStore cache immediately after creating a tab group. r=sthompson,sessionstore-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D241634
2025-03-25 13:39:45 +00:00
Dão Gottwald
3ba48b6655
Bug 1950904 - Use element index instead of tab index for the drop indicator. r=dwalker,jswinarton,tabbrowser-reviewers,perftest-reviewers,fbilt
...
Differential Revision: https://phabricator.services.mozilla.com/D239937
2025-03-19 15:07:53 +00:00
Jeremy Swinarton
92c3e82bc9
Bug 1954488: Delete removeAfterRestore property from savedGroups if the session is being quit for the second time r=dwalker,sthompson,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D241978
2025-03-18 20:48:58 +00:00
DJ
dcb7322bc1
Bug 1954603 - prevent error in initSession when initializing a windowless session. r=sthompson,jswinarton,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D241886
2025-03-18 17:32:53 +00:00
Dão Gottwald
43ec83d3e6
Bug 1954271 - Update Session Restore triage rotation. r=sessionstore-reviewers,jswinarton
...
Differential Revision: https://phabricator.services.mozilla.com/D241721
2025-03-17 19:11:26 +00:00
Greg Stoll
52693f9877
Bug 1926973 - make only explicitly unloaded tabs have a grayscale dimmed favicon r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers
...
This is what UX has decided makes sense, and will be much less disruptive
than dimming out all favicons on session restore. When we're ready the
default value of "browser.tabs.fadeOutExplicitlyUnloadedTabs" will be
true, and the default value of "browser.tabs.fadeOutUnloadedTabs" will
remain false.
Differential Revision: https://phabricator.services.mozilla.com/D241481
2025-03-15 00:30:28 +00:00
DJ
fb605dda4c
Bug 1950611 - fix save and restore of groups when they trigger window closing. r=sthompson,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D241490
2025-03-14 14:18:20 +00:00
Jeremy Swinarton
80b8a844b4
Bug 1951319: Deferred session restore re-opens tab groups r=dao,sthompson,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D241012
2025-03-12 17:46:04 +00:00
Sam Foster
5e0d65a91e
Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman
...
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
2025-03-12 16:41:47 +00:00
Stephen Thompson
a4e5d1a634
Bug 1952902 - closed tab groups and saved tab groups should retain all tabs r=dao,sessionstore-reviewers
...
When closing single or multiple tabs, session state has historically capped the number of closed tabs being tracked. The main motivation was to prevent session file sizes on disk from getting too large.
When we introduced tab groups to session state, we avoided those caps when the tab group itself is being closed/saved. Users think of tab groups as whole entities. We were successfully saving tab groups with any number of tabs.
I introduced a regression causing closed tab groups and saved-and-closed tab groups to have their tab lists in session state capped. This patch resolves the regression by bypassing the cap when a closing tab is being closed as part of a tab group closing as a whole. Single or multiple tabs that are closed directly by the user should still be capped even if those tabs were in a tab group.
Differential Revision: https://phabricator.services.mozilla.com/D241087
2025-03-12 03:02:39 +00:00
DJ
b4c31cf534
Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D240273
2025-03-11 18:55:05 +00:00
Goloman Adrian
6847fa7ceb
Backed out changeset 4754bc9e58f3 (bug 1921536) for causing bc failures @browser_toolbarKeyNav.js
2025-03-08 09:15:01 +02:00
Sam Foster
ace31bb084
Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman
...
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
2025-03-08 05:17:08 +00:00
Goloman Adrian
7f877be10f
Backed out changeset edc7847f9776 (bug 1950973) for causing bc failures @browser_prompt_close_groups.js .
2025-03-07 05:08:36 +02:00
Dão Gottwald
f2fda56c21
Bug 1908439 - Drag and drop for moving a group within the window. r=dwalker,tabbrowser-reviewers,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D239494
2025-03-07 01:58:05 +00:00
Goloman Adrian
e5e07cd91e
Backed out changeset 58ef1accf6e7 (bug 1908439) for causing mochitest failures @test_tabbrowser.xhtml. CLOSED TREE
2025-03-07 02:42:12 +02:00
Dão Gottwald
0fb65f4185
Bug 1908439 - Drag and drop for moving a group within the window. r=dwalker,tabbrowser-reviewers,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D239494
2025-03-06 22:20:21 +00:00
DJ
3526f7e308
Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D240273
2025-03-06 20:59:11 +00:00
Butkovits Atila
76f1949306
Backed out changeset cd8f12bed08a (bug 1950973) for causing failures at test_restore_manually_with_tab_groups.py. CLOSED TREE
2025-03-06 18:05:15 +02:00
DJ
fb9b1427f2
Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D240273
2025-03-06 11:25:20 +00:00
Sandor Molnar
b51ff49434
Backed out changeset f56181344f2a (bug 1921536) for causing bc failures @ browser_bookmark_context_menu_contents.js & browser_reviewchecker_sidebar.js CLOSED TREE
2025-03-06 06:15:10 +02:00
Sam Foster
dc4f09430e
Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman
...
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
2025-03-06 01:52:28 +00:00
Eric Chen
11dbf7050d
Bug 1915739 - Part 5: Prevent window features from being restored for taskbar tab windows r=sessionstore-reviewers,nsharpley
...
Differential Revision: https://phabricator.services.mozilla.com/D234542
2025-03-03 16:40:08 +00:00
Goloman Adrian
a048ca4c8b
Backed out changeset b0a8901d8246 (bug 1921536) for casuing failures @test_sidebar_state.js.
2025-02-27 10:46:12 +02:00
Sam Foster
d318c71f26
Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman
...
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
2025-02-27 07:22:17 +00:00
Daisuke Akatsuka
a25636e1a5
Bug 1936557: Wait to update placeholder/icon until user interaction on booting r=sessionstore-reviewers,daleharvey,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D239701
2025-02-26 19:50:50 +00:00
Jeremy Swinarton
8ab002aa2c
Bug 1950123: Allow forgetting history for closed tabs from closed groups r=dao,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D239739
2025-02-26 16:40:38 +00:00
DJ
5b2c34c50b
Bug 1948078 - When restore is deferred, convert last session's open groups to saved groups. r=jswinarton,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D239451
2025-02-25 15:55:51 +00:00
Joel Maher
6d2e459f55
Bug 1948426 - Carry over annotations from macosx 11.20 to 15.30. r=aryx,pip-reviewers,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,jteow,nsharpley,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D238336
2025-02-20 22:03:44 +00:00
Florian Quèze
3f36c09d17
Bug 1944631 - Migrate histograms to use Glean APIs for FX_SESSION_RESTORE_* histograms, r=chutten,sessionstore-reviewers,nsharpley.
...
Differential Revision: https://phabricator.services.mozilla.com/D238095
2025-02-19 19:52:06 +00:00
Jeremy Swinarton
782cb8d757
Bug 1936284: Open recently closed grouped tabs from Firefox View. r=dao,fxview-reviewers,sessionstore-reviewers,nsharpley
...
Differential Revision: https://phabricator.services.mozilla.com/D238122
2025-02-19 16:27:49 +00:00
Meg Viar
7c54ffb59e
Bug 1946446 - Update about:rights r=geckoview-reviewers,desktop-theme-reviewers,fluent-reviewers,dao,flod,m_kato,sessionstore-reviewers,Gijs,nsharpley
...
- Redirect about:rights to terms page
- Remove code related to old in-tree about:rights page
[[ https://mozilla-hub.atlassian.net/browse/FIDE-2485 | See Jira ticket ]]
Differential Revision: https://phabricator.services.mozilla.com/D237913
2025-02-18 18:27:15 +00:00
Dão Gottwald
9092f40692
Bug 1948257 - Deleted tab groups in the app menu's history view should use the filled-in group icon. r=dwalker
...
Differential Revision: https://phabricator.services.mozilla.com/D238195
2025-02-14 16:41:11 +00:00
DJ
a0b1928d27
Bug 1945169 - prevent a closing window from saving a group that is being adopted. r=dao,sessionstore-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D237988
2025-02-13 19:39:28 +00:00
Jeremy Swinarton
97dd33ecbd
Bug 1947503: Closed tab groups code supports session store files created before Firefox 135 r=dao,dwalker,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D237904
2025-02-13 15:10:03 +00:00
Jeremy Swinarton
566b514ef6
Bug 1946761: Prevent saving tab groups in private windows r=dao,sessionstore-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D237588
2025-02-11 13:43:27 +00:00
Jeremy Swinarton
016c599fa5
Bug 1944416: Restore individual tabs from closed groups in closed windows r=dao,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D237110
2025-02-07 21:35:32 +00:00
Dão Gottwald
e68210bd1a
Bug 1946539 - Use default group icon in recently closed tabs menu. r=jswinarton,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D237181
2025-02-07 15:23:51 +00:00
Jeremy Swinarton
2290ebcc4a
Bug 1944328: "Reopen All Tabs" supports closed tab groups from closed windows r=dao,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D236872
2025-02-05 21:06:43 +00:00
Sam Foster
c32900b41c
Bug 1942314 - Avoid showing sidebars and responding to sidebar events in popup windows. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements
...
- Guard the main entry-points in SidebarController to handle the window being a popup
- Amend the test to also try the shortcut to show a sidebar in a popup window
Differential Revision: https://phabricator.services.mozilla.com/D236292
2025-02-04 07:43:21 +00:00
Jeremy Swinarton
140b7bce30
Bug 1945111: Only include tabs inside groups at deletion time in closed tab groups in history menus r=dao,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D236432
2025-02-03 14:45:41 +00:00
Jeremy Swinarton
3414d7d519
Bug 1915174: Restore closed tabs to their original tab group r=dao,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D236347
2025-02-03 14:22:39 +00:00
Jeremy Swinarton
a86608a71b
Bug 1943850: Recently closed tabs use correct indexing r=dao,sessionstore-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D235813
2025-01-28 15:14:45 +00:00
Nikki Sharpley
551f8d2aaa
Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane,sessionstore-reviewers
...
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel
Differential Revision: https://phabricator.services.mozilla.com/D234592
2025-01-28 00:51:28 +00:00
Sandor Molnar
4cfec08470
Bug 1775616 - Disable test 'browser_async_window_flushing.js' on win/linux/mac- opt & asan for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D235521
2025-01-25 00:46:16 +00:00
Florian Quèze
466d8c2170
Bug 1935420 - rewrite more JS code storing histograms in local variables (includes changes done by hand), r=chutten,search-reviewers,anti-tracking-reviewers,sessionstore-reviewers,dao.
...
Differential Revision: https://phabricator.services.mozilla.com/D234009
2025-01-24 16:18:32 +00:00