Commit Graph

2017 Commits

Author SHA1 Message Date
Gijs Kruitbosch
1f9bc17f1b Bug 1956101 - use child context for private browsing determination in ContentSearch code, r=Standard8
Also updating to use a sprinkling more modern JS and getting PB info directly from the actor's window global.

Differential Revision: https://phabricator.services.mozilla.com/D242825
2025-04-02 19:02:28 +00:00
Stephanie Cunnane
f5c0b3c735 Bug 1953239 - Stop calling BrowserSearchTelemetry.recordSearchSuggestionSelectionMethod from address bar code. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D243196
2025-03-31 16:13:37 +00:00
Moritz Beier
b3f32df67e Bug 1955066 - Enter search mode after adding an HTML form as a search engine. r=urlbar-reviewers,search-reviewers,scunnane,daisuke
Differential Revision: https://phabricator.services.mozilla.com/D242187
2025-03-26 09:58:54 +00:00
Moritz Beier
a53fc7dc78 Bug 1949719 - Part 2: Allow editing custom search engines using the dialog. r=Standard8,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,urlbar-reviewers,bolsson,mossop,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D240846
2025-03-26 08:50:42 +00:00
Mark Banner
b1971685d9 Bug 1953479 - In the sap.counts event probe, account for search engines being overridden by allowed third parties. r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D242775
2025-03-25 21:40:15 +00:00
Mark Banner
59952e7d62 Bug 1953479 - Add a SearchUITestUtils helper with a function for checking search SAP counts. r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D242774
2025-03-25 21:40:14 +00:00
Moritz Beier
0ec0f97c13 Bug 1953182 - Fix CMD+K in Library Window on macOS. r=search-reviewers,scunnane,urlbar-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D241045
2025-03-17 14:16:55 +00:00
Moritz Beier
8f0c55f22e Bug 1948636 - Change query parameter handling in EngineURL to be consistent, regardless of how the full URL is specified. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D240008
2025-03-14 12:34:33 +00:00
Florian Quèze
9adb938e1a Bug 1938930 - Duplicate remaining legacy telemetry probes into Glean (Search), r=Standard8.
Differential Revision: https://phabricator.services.mozilla.com/D240999
2025-03-12 15:15:27 +00:00
Moritz Beier
082864bf29 Bug 1949714 - Add title to add engine from HTML form dialog. r=Standard8,desktop-theme-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D240007
2025-03-12 12:35:31 +00:00
Mark Banner
0a65c77269 Bug 1938929 - Add a new event to record initiated searches on search engines. r=search-reviewers,scunnane
This will replace the SEARCH_COUNTS/sap.legacy_counts metrics.

Differential Revision: https://phabricator.services.mozilla.com/D240625
2025-03-11 20:54:11 +00:00
Mark Banner
e992091b5f Bug 1938929 - Duplicate SEARCH_COUNTS histogram into Glean telemetry and use the Glean interfaces. r=search-reviewers,scunnane
This is needed so that we can keep recording SEARCH_COUNTS into legacy, until we're ready to stop using legacy telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D240624
2025-03-11 20:54:11 +00:00
Mark Banner
e815d16c42 Bug 1952713 - Update rust search engine selector integration to handle the search configuration overrides collection. r=mcheang
Differential Revision: https://phabricator.services.mozilla.com/D240791
2025-03-10 22:27:16 +00:00
Mark Banner
6e0dc51abf Bug 1951919 - Move browser_aboutHome_search* tests into the search component code and de-duplicate. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D240621
2025-03-06 23:50:10 +00:00
Moritz Beier
f043970fbb Bug 1951767 - Wait until dialog in browser_addSearchEngineFromForm.js fully closes to fix intermittent. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D240461
2025-03-06 08:44:13 +00:00
Mark Banner
878a5d5415 Bug 1951652 - Convert browser/components/search/ modules to use moz-src uris. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D240333
2025-03-05 09:24:37 +00:00
Moritz Beier
34069ddca2 Bug 1948326 - Part 2: Add feature to generate search engine from HTML forms. r=Standard8,fluent-reviewers,bolsson,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238277
2025-03-04 17:18:21 +00:00
Moritz Beier
0b21fd50d4 Bug 1948326 - Part 1: Move addEngine dialog from preferences to search component. r=Standard8,fluent-reviewers,settings-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D238276
2025-03-04 17:18:21 +00:00
Goloman Adrian
55008ab2ea Backed out 2 changesets (bug 1948326) for causing bc failures @nsContentSecurityUtils.cpp. CLOSED TREE
Backed out changeset 172464722456 (bug 1948326)
Backed out changeset 855648c27237 (bug 1948326)
2025-03-04 15:12:56 +02:00
Moritz Beier
4841f6aadb Bug 1948326 - Part 2: Add feature to generate search engine from HTML forms. r=Standard8,fluent-reviewers,bolsson,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D238277
2025-03-04 12:24:49 +00:00
Moritz Beier
40e83a9163 Bug 1948326 - Part 1: Move addEngine dialog from preferences to search component. r=Standard8,fluent-reviewers,settings-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D238276
2025-03-04 12:24:49 +00:00
James Teow
bb99f7fe94 Bug 1949294 - Part 3: Update search tests to target correct SERP categorization components - r=scunnane,search-reviewers
Depends on D240040

Differential Revision: https://phabricator.services.mozilla.com/D240041
2025-03-04 04:05:44 +00:00
James Teow
5861251795 Bug 1949294 - Part 1: Move SERP categorization into its own component file - r=scunnane,search-reviewers
This includes some renaming for consistency and reduce redundancy.

Differential Revision: https://phabricator.services.mozilla.com/D240039
2025-03-04 04:05:41 +00:00
Daisuke Akatsuka
dee672b38c Bug 1936557: Remove delayUpdate parameter and #searchInitComplete flag r=search-reviewers,daleharvey,Standard8
Depends on D239701

Differential Revision: https://phabricator.services.mozilla.com/D239702
2025-02-26 19:50:51 +00:00
James Teow
8ddb33d76d Bug 1948490 - Reference browser element in subframe request - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D238404
2025-02-22 01:54:25 +00:00
Stephanie Cunnane
4a917e543e Bug 1932707 - Remove legacy FX_URLBAR_SELECTED_RESULT_METHOD histogram. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D239003
2025-02-21 21:47:34 +00:00
Stephanie Cunnane
002c094a5c Bug 1932713 - Remove legacy urlbar.picked.* scalars and Glean urlbar.picked.* labeled counters. r=adw,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D237974
2025-02-18 21:18:58 +00:00
Stephanie Cunnane
dff74b6859 Bug 1932711 - Remove legacy urlbar.engagement and urlbar.abandonment scalars, as well as their mirrors to Glean counters. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D237255
2025-02-13 16:57:41 +00:00
James Teow
ee1aef478e Bug 1944002 - Update search telemetry schema for detecting subframes - r=Standard8
Depends on D235731

Differential Revision: https://phabricator.services.mozilla.com/D235732
2025-02-10 19:51:47 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
James Teow
af3320fb69 Bug 1943998 - Part 2: Observe clicks in sponsored subframes - r=Standard8
Depends on D235730

Differential Revision: https://phabricator.services.mozilla.com/D235731
2025-02-10 06:22:05 +00:00
James Teow
4870d998c9 Bug 1943998 - Part 1: Enable the ability to detect subframes on SERPs - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D235730
2025-02-10 06:22:04 +00:00
Alexandru Marc
f01c71ca19 Backed out 2 changesets (bug 1943998) for causing wd failures @ phases.py CLOSED TREE
Backed out changeset 9b48fbc77a42 (bug 1943998)
Backed out changeset 2b88f3b5d92f (bug 1943998)
2025-02-08 17:15:48 +02:00
James Teow
2e28bcf87b Bug 1943998 - Part 2: Observe clicks in sponsored subframes - r=Standard8
Depends on D235730

Differential Revision: https://phabricator.services.mozilla.com/D235731
2025-02-07 23:02:08 +00:00
James Teow
d9006203a4 Bug 1943998 - Part 1: Enable the ability to detect subframes on SERPs - r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D235730
2025-02-07 23:02:07 +00:00
Gijs Kruitbosch
747d34d801 Bug 1916424 - allow idle dispatch from BrowserUtils' category manager-based invocations, r=mossop,search-reviewers,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D220896
2025-02-07 16:54:50 +00:00
Mark Banner
309b3c5ae6 Bug 1943499 - Disable browser_search_glean_serp_event_telemetry_categorization_enabled_by_pref.js on mac because of frequent failures. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D236706
2025-02-06 15:08:35 +00:00
Moritz Beier
16914fd2b6 Bug 1880913 - Part 6: Remove BrowserSearch and BrowserSearchTelemetry from browser.js. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D236218
2025-02-04 11:07:13 +00:00
Moritz Beier
4afb8b6192 Bug 1880913 - Part 5: Display search engine removal notification via category manager. r=Standard8,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236217
2025-02-04 11:07:13 +00:00
Moritz Beier
4ff8ed5deb Bug 1880913 - Part 4: Remove BrowserSearch.searchBar getter. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D235598
2025-02-04 11:07:12 +00:00
Moritz Beier
152f732f88 Bug 1880913 - Part 3: Move open search handling from BrowserSearch to dedicated module. r=Standard8,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235597
2025-02-04 11:07:12 +00:00
Moritz Beier
3ef77c7282 Bug 1880913 - Part 2: Move search request handling from browser.js to SearchUIUtils. r=search-reviewers,firefox-desktop-core-reviewers ,mossop,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D235596
2025-02-04 11:07:11 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Tom Schuster
48c5102a90 Bug 1895770 - Improve the verification of the CSP in about: pages. r=tjr,freddyb,search-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234484
2025-01-27 08:29:25 +00:00
Florian Quèze
466d8c2170 Bug 1935420 - rewrite more JS code storing histograms in local variables (includes changes done by hand), r=chutten,search-reviewers,anti-tracking-reviewers,sessionstore-reviewers,dao.
Differential Revision: https://phabricator.services.mozilla.com/D234009
2025-01-24 16:18:32 +00:00
Stephanie Cunnane
c4977b805b Bug 1942929 - Fix typos in 'seperatePrivateDefaultUIEnabled' and 'seperatePrivateDefaultUrlbarResultEnabled' Nimbus variable names. r=search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D235077
2025-01-24 15:40:34 +00:00
Mike Conley
e9c91b99ec Bug 1941026 - Decouple tippytop from the newtab codebase and move under the topsites component. r=pdahiya,jteow,home-newtab-reviewers,urlbar-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D235316
2025-01-24 15:16:59 +00:00
Mark Banner
c73c87c505 Bug 1883685 - Migrate Nimbus searchConfiguration feature to use setPref instead of isEarlyStartup. r=beth,search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D234887
2025-01-23 16:37:41 +00:00
Mark Banner
99ef8eb766 Bug 1942099 - Clean up search entries in Nimbus' FeatureManifest.yml. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D234535
2025-01-23 16:37:40 +00:00