Commit Graph

95 Commits

Author SHA1 Message Date
Kris Maglione
c56a653ac3 Bug 1446250: Part 2 - Optimize/reduce calls into the Photon PageAction API. r=mixedpuppy
Calling into the Photon PageAction API to update a property is orders of
magnitude more expensive than the simple DOM-based updates we used previously.
To make matters worse, a lot of our caching was removed during the migration,
and the Photon API introduces a lot of duplicated work when selecting icons.

This patch caches the last known state for each property to avoid calling into
the Photon APIs to update each property more than necessary, and removes the
extraneous preferred icon size calculations that the Photon code already
duplicates.

MozReview-Commit-ID: LjPPxolmcd6
2018-03-15 20:20:33 -07:00
Oriol Brufau
78d5ac58ff Bug 1439246 - Clear browser and page actions when inactive tabs navigate r=mixedpuppy,zombie
MozReview-Commit-ID: 5uGHmXEiMQS
2018-02-18 21:03:36 +01:00
Oriol Brufau
a2c735dd35 Bug 1437178 - Fix various pageAction visibiltiy issues when using show_matches and hide_matches r=mixedpuppy
MozReview-Commit-ID: 5jQ7MkkKWRk
2018-02-09 22:22:43 +01:00
Drew Willcoxon
e1ca839f9c Bug 1435992 - Disabled page actions still show extension context menu items. r=mixedpuppy
MozReview-Commit-ID: JmC6PXtW1SK
2018-02-06 11:15:50 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Oriol Brufau
4791668dc2 Bug 1424538 - Allow pageAction and sidebarAction set* methods to accept a null value (desktop). r=mixedpuppy
MozReview-Commit-ID: FqcRrFDYqWp
2017-12-18 20:41:10 +01:00
Oriol Brufau
025ddf566c Bug 1427431 - Add methods to check if browser/page/sidebar actions are enabled/shown/open r=mixedpuppy
MozReview-Commit-ID: DPbg8SwKVQL
2018-01-11 18:19:02 +01:00
Shane Caraveo
b6a7a9f51d Bug 1419842 support pattern matching to show/hide pageActions, r=aswan
MozReview-Commit-ID: bYcR08xX8r
2017-12-05 14:41:21 -08:00
Drew Willcoxon
7708c2f9fb Bug 1413574 - Hide disabled page actions and offer a "Manage Extension" command for actions in extensions. r=Gijs
MozReview-Commit-ID: HJpu9Jfi2bB
2017-11-10 11:06:02 -05:00
Drew Willcoxon
0b3c1c5d8b Bug 1413692 - Extensions page actions are pinned to address bar again and again. r=mixedpuppy
MozReview-Commit-ID: HrhYTNSwygH
2017-11-06 21:19:26 -05:00
Shane Caraveo
924abfcc8a Bug 1413648 fix default extension icon use, r=aswan
MozReview-Commit-ID: 3Dh2DjGIAgn
2017-11-02 15:49:38 -07:00
Drew Willcoxon
6102777cd1 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: WebExtensions changes. r=mixedpuppy
MozReview-Commit-ID: 4vBNSmCU1a0
2017-10-30 17:50:33 -04:00
Phil Ringnalda
c8ae0986f8 Backed out 2 changesets (bug 1412170) for eslint bustage
Backed out changeset a9a646fe54ec (bug 1412170)
Backed out changeset 8b46ed411edf (bug 1412170)

MozReview-Commit-ID: Et3MnX3ieBe
2017-10-30 14:21:45 -07:00
Drew Willcoxon
251ef6f1dd Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: WebExtensions changes. r=mixedpuppy
MozReview-Commit-ID: 4vBNSmCU1a0
2017-10-30 16:53:42 -04:00
Drew Willcoxon
f35c08c797 Bug 1395387 - Reconcile WebExtension page actions and Photon page actions: WebExtensions changes. r=mixedpuppy
MozReview-Commit-ID: n2eR3q1aZF
2017-10-27 17:39:57 -04:00
Luca Greco
6d6f77e024 Bug 1397196 - Fix pageAction icon loading when an extension has a cached browserAction theme-based icon. r=mixedpuppy
MozReview-Commit-ID: Lmi5pLerzul
2017-09-06 12:40:45 +02:00
Shane Caraveo
a9b17aeedb Bug 1380597 - Ensure the url can be loaded by the extension. r=kmag
MozReview-Commit-ID: GH31FlHxpVu
2017-09-07 17:09:40 -04:00
Shane Caraveo
c01f2f1be3 Bug 1341126 implement open for browser/page/sidebar actions, r=kmag,zombie
MozReview-Commit-ID: 5r5aGpyPQ6W
2017-03-08 23:36:25 -08:00
Dão Gottwald
fcc243e9bd Bug 1389740 - Rename urlbar-icons to page-action-buttons. r=gijs
MozReview-Commit-ID: 980Rvv8mxtU
2017-08-14 16:45:17 +02:00
Carsten "Tomcat" Book
b83067d218 merge mozilla-inbound to mozilla-central a=merge 2017-08-08 13:18:14 +02:00
Kris Maglione
5b5382fb8b Bug 1387907: Part 3 - Merge ext-browser.js and ext-utils.js. r=mixedpuppy
MozReview-Commit-ID: CmOax5b5Gki
2017-08-06 18:20:25 -07:00
Kris Maglione
bd77a32908 Bug 1387899: Part 2 - Cache pageAction icon data for startup. r=mixedpuppy
MozReview-Commit-ID: 2ZK19neRcrQ
2017-08-06 16:16:33 -07:00
Kris Maglione
8077ebeb20 Bug 1387898: Remove unnecessary uses of EventEmitter.decorate. r=mixedpuppy
MozReview-Commit-ID: FRCdXHc3S4K
2017-08-07 14:42:57 -07:00
Tomislav Jovanovic
80c37829b7 Bug 1370716 - Only try to add _action menus if extension has permission r=mixedpuppy
MozReview-Commit-ID: KpT1RH30NMh
2017-08-06 23:27:10 +02:00
Andrew Swan
3358f38632 Bug 1369577 Part 2 Propagate isHandlingUserInput for browserAction, pageAction, and menus r=kmag
The implementations of browserAction, pageAction, and menu onClick
handlers now stash the current <browser> until we get a reply from
the extension process indicating that the handler has finished running.
We also have to take care to keep that <browser> around even if the
permissions api has to be loaded asynchronously.

MozReview-Commit-ID: BYJaiwdj40u
2017-06-15 12:48:40 -07:00
Andrew Swan
3d501bbfd5 Bug 1369577 Part 1 Rename SingletonEventManager to EventManager r=kmag
MozReview-Commit-ID: 7nsYWdSTJCG
2017-06-09 13:49:07 -07:00
Sebastian Hengst
8642712c2a Backed out changeset 26fd6d0a1254 (bug 1369577) for failing xpcshell's test_ext_simple.js and test_ext_startup_cache.js on Android. r=backout 2017-06-30 01:01:13 +02:00
Sebastian Hengst
c48d1b793d Backed out changeset dfb376de5c23 (bug 1369577) 2017-06-30 00:59:59 +02:00
Andrew Swan
e77019e2bd Bug 1369577 Part 2 Propagate isHandlingUserInput for browserAction, pageAction, and menus r=kmag
The implementations of browserAction, pageAction, and menu onClick
handlers now stash the current <browser> until we get a reply from
the extension process indicating that the handler has finished running.
We also have to take care to keep that <browser> around even if the
permissions api has to be loaded asynchronously.

MozReview-Commit-ID: BYJaiwdj40u
2017-06-15 12:48:40 -07:00
Andrew Swan
c140bd9d12 Bug 1369577 Part 1 Rename SingletonEventManager to EventManager r=kmag
MozReview-Commit-ID: 7nsYWdSTJCG
2017-06-09 13:49:07 -07:00
Bob Silverberg
4fb3991429 Bug 1376888 - pageAction popup telemetry does not report the correct times, r=kmag
Move the call to TelemetryStopwatch.finish to after the contentReady promise of the PanelPopup resolves.

MozReview-Commit-ID: F1hfaDHVuJi
2017-06-28 13:28:15 -07:00
Bob Silverberg
4bfe8fd443 Bug 1297167 - Part 1: Add telemetry probe for PageAction open timing, r=bsmedberg,kmag
MozReview-Commit-ID: 44xIqcFZXLO
2017-05-03 08:28:34 -04:00
Mark Banner
9916415caf Bug 1371292 - Clean up more ESLint global definitions in configuration files in toolkit/ and browser/. r=mossop
MozReview-Commit-ID: 5KC23kzaCFN
2017-06-08 10:59:12 +01:00
Kris Maglione
db3ec327d2 Bug 1368189: Move more code out of ExtensionUtils.jsm. r=mixedpuppy
Also removes some dead code.

A lot of the code in ExtensionUtils.jsm is not needed in all processes, and a
lot of the rest isn't needed until extension code runs. Most of it winds up
being loaded into all processes way earlier than necessary.

MozReview-Commit-ID: CMRjCPOjRF2
2017-05-26 15:44:41 -07:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Tomislav Jovanovic
fa9e24877d Bug 1362445 - Fix _action context menus when module is not loaded r=bsilverberg,mixedpuppy
MozReview-Commit-ID: AOzcpXSgy8d
2017-05-07 21:38:01 +02:00
Kris Maglione
d90dddf7d5 Bug 1362224: requestAnimationFrame before changing browserAction/pageAction buttons. r=aswan
MozReview-Commit-ID: H9Eq7z5L4Xq
2017-05-05 14:56:19 -07:00
Kris Maglione
25a66508a9 Bug 1362224: Cache per-tab icon data for browserAction/pageAction. r=aswan
MozReview-Commit-ID: JifAtY36gKA
2017-05-05 14:21:07 -07:00
Kris Maglione
da08b6926c Bug 1317697: Remove things from ExtensionUtils that don't belong there. r=mixedpuppy
MozReview-Commit-ID: CTX0TckLqoV
2017-04-07 13:39:06 -07:00
Kris Maglione
52b67bf633 Bug 1350522: Part 7 - Merge pageAction/browserAction/sidebarAction/commands helper classes into API instances. r=aswan
MozReview-Commit-ID: 6aRQ1uybAmg
2017-03-26 18:42:59 -07:00
Kris Maglione
ef300362e4 Bug 1350522: Part 6 - Cleanup per-api-instance state logic. r=aswan
MozReview-Commit-ID: 5ixBA34fvFf
2017-03-25 11:36:56 -07:00
Kris Maglione
937291f42b Bug 1350522: Part 4 - Convert browser APIs to lazy loading. r=aswan
MozReview-Commit-ID: BQoWF9nHOuF
2017-04-02 11:59:55 -07:00
Kris Maglione
e607ae18d8 Bug 1260548: Part 3 - Factor out the extension popup code into its own module. r=aswan
MozReview-Commit-ID: HpaAkt5nBqf
2017-01-28 15:00:15 -08:00
Kris Maglione
bbe2608ca7 Bug 1260548: Part 1 - Factor out the common functionality of the tabs API. r=aswan
MozReview-Commit-ID: AS7asn6nXzr
2017-01-30 22:44:16 -08:00
Carsten "Tomcat" Book
f4f95b21aa merge mozilla-central to mozilla-inbound 2017-01-27 11:16:17 +01:00
Florian Quèze
c8cf49999e Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00