Sylvestre Ledru
cb15c544b5
Bug 1531176 - Split the Google key management between gls and safe browsing r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D21459
2019-03-07 11:31:18 +00:00
Andrea Marchesini
83054c5a7a
Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D21538
2019-03-07 10:21:15 +00:00
Ciure Andrei
d4b3b08047
Backed out changeset 6c2e00bcd2bb (bug 1531176) due to google-location-api-keyfile build busatges CLOSED TREE
2019-03-07 10:49:26 +02:00
Sylvestre Ledru
c07450d96f
Bug 1531176 - Split the Google key management between gls and safe browsing r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D21459
2019-03-06 23:06:10 +00:00
Dorel Luca
688429d9d6
Backed out 6 changesets (bug 1353956) for Linux Build bustage
...
Backed out changeset 71dafccc22ae (bug 1353956)
Backed out changeset f1f29fe519cf (bug 1353956)
Backed out changeset 4978556a66f6 (bug 1353956)
Backed out changeset bc0b91abce9b (bug 1353956)
Backed out changeset 6b8412db5a05 (bug 1353956)
Backed out changeset 3d326cfcd002 (bug 1353956)
2019-03-07 01:49:03 +02:00
dlee
57ada30b9f
Bug 1353956 - P6. Load the old prefixset(.pset) when there is no .vlpset. r=gcp
...
To avoid forcing a redownload of SafeBrowsing v4 list.
Differential Revision: https://phabricator.services.mozilla.com/D21876
2019-03-06 09:41:34 +00:00
dlee
8846f51858
Bug 1353956 - P5. Remove old v4 prefix files after new files are stored. r=gcp
...
This patch is to cleanup old SafeBrowsing v4 prefix files.
Differential Revision: https://phabricator.services.mozilla.com/D21464
2019-03-05 18:32:23 +00:00
dlee
cd1fa6d7c2
Bug 1353956 - P4. Add header and CRC32 checksum to SafeBrowsing V4 prefix files. r=gcp
...
After this patch, we may have the following files in SafeBrowsing
directory:
- (v2) .sbstore : Store V2 chunkdata, for update, MD5 integrity check
while load
- (v2) .pset : Store V2 prefixset, for lookup, load upon startup, no
integrity check
- (v4) .metadata : Store V4 state, for update, no integrity check
- (v4) .vlpset : Store V4 prefixset, for lookup, load upon startup,
CRC32 integrity check
- (v4) .pset : V4 prefix set before this patch, should be removed
The magic string is also added to ".vlpset" header so we can add
a telemetry to see if sanity check is good enough for prefix set
integrity check (The telemetry is not yet added). If yes, we can remove
the CRC32 in the future for even better performance.
Differential Revision: https://phabricator.services.mozilla.com/D21463
2019-03-06 22:57:12 +00:00
Dimi Lee
82b58b495d
Bug 1353956 - P3. Separate file processing and prefix data processing for SafeBrowsing prefix set. r=gcp
...
SafeBrowsing prefix files LOAD/SAVE operations are handled in xxxPrefixSet.cpp.
It would be more clear if xxxPrefixSet.cpp only processes prefix data,
while LookupCacheV2/LookupCacheV4 which use prefix set process file.
This patch doesn't change any behavior, testcases need to update because
the LookupCache & xxxPrefixSet APIs are changed.
Differential Revision: https://phabricator.services.mozilla.com/D21462
2019-03-04 21:22:46 +00:00
dlee
d8899e5669
Bug 1353956 - P2. Do not use SHA-256 while loading the V4 prefix files. r=gcp
...
SHA256 is an expensive operation, we should avoid using them if
possible. SafeBrowsing prefix files are loaded during startup and
verify integrity with SHA256 which may affect the performance
especially on the low-end device.
This patch simply removes the SHA256 integrity check. CRC32 version
integrity check will be introduced in the other patch.
This patch also changes the behavior of recording
"Telemetry::URLCLASSIFIER_VLPS_LOAD_CORRUPT" a little bit.
It used to records only once per session(during startup, the first
time we load prefix set), now it records per update.
Differential Revision: https://phabricator.services.mozilla.com/D21461
2019-02-28 08:18:46 +00:00
Dimi Lee
15191963de
Bug 1353956 - P1. Rename checksum used in SafeBrowsing V4 to SHA256. r=gcp
...
SafeBrowsing V4 protocol use SHA-256 as the checksum to check integrity
of update data and also the integrity of prefix files.
SafeBrowsing V2 HashStore use MD5 as the checksum to check integrity of
.sbstore
Since we are going to use CRC32 as the integrity check of V4 prefix files,
I think rename V4 "checksum" to SHA256 can improve readability.
Differential Revision: https://phabricator.services.mozilla.com/D21460
2019-02-28 08:12:36 +00:00
Dorel Luca
9a275b4283
Backed out 16 changesets (bug 1525245) for Android failures. CLOSED TREE
...
Backed out changeset 9f8a1b410320 (bug 1525245)
Backed out changeset 0ef284a9a1d5 (bug 1525245)
Backed out changeset 835e5f642a03 (bug 1525245)
Backed out changeset 362f5a8d033c (bug 1525245)
Backed out changeset 9da3ab33cf67 (bug 1525245)
Backed out changeset 6aacd2d6e835 (bug 1525245)
Backed out changeset 8ff9e8f45e02 (bug 1525245)
Backed out changeset 2020227181cc (bug 1525245)
Backed out changeset fc3c64c330b9 (bug 1525245)
Backed out changeset 2762bf88e050 (bug 1525245)
Backed out changeset ffc10fdc50a6 (bug 1525245)
Backed out changeset bb6ade1207d7 (bug 1525245)
Backed out changeset 1875eb5085e4 (bug 1525245)
Backed out changeset 7e4f67a6d6f1 (bug 1525245)
Backed out changeset e671fc9581eb (bug 1525245)
Backed out changeset b89f5def8d0d (bug 1525245)
2019-03-06 21:07:49 +02:00
Andrea Marchesini
88186754be
Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D21538
2019-03-06 17:04:06 +00:00
dlee
9b4fea92b0
Bug 1529728 - P2. Remove previous testcase workaround. r=baku
...
Remove the workaround in Bug 1525458 because the issue is fixed.
Differential Revision: https://phabricator.services.mozilla.com/D21781
2019-03-04 08:26:17 +00:00
Ryan Hunt
743a2a46fe
Bug 1523969 part 23 - Move method definition inline comments to new line in 'toolkit/'. r=ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D21124
2019-02-25 16:12:51 -06:00
Ehsan Akhgari
e44136bf76
Bug 1525458 - Part 3: Work around bug 1529728 by disabling tracking annotations in flash blocking classifier tests; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D20876
2019-02-28 17:10:18 -05:00
Jonathan Kingston
8397774fdf
Bug 1525319 - Removing context from OnDataAvailable r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20881
2019-02-27 23:42:27 +00:00
Jonathan Kingston
1d7c7a19d3
Bug 1525319 - Changing js to remove context from onStartRequest and onStopRequest r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20771
2019-02-27 23:41:54 +00:00
Jonathan Kingston
3ef1df37e1
Bug 1525319 - Removing context from OnStopRequest r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20770
2019-02-27 23:41:31 +00:00
Jonathan Kingston
649c453cbd
Bug 1525319 - Removing context from OnStartRequest r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20769
2019-02-27 23:41:04 +00:00
Dorel Luca
2dfae9a24a
Backed out 4 changesets (bug 1525319) for Android failures in dom/base/test/test_progress_events_for_gzip_data.html
...
Backed out changeset b73f033efb41 (bug 1525319)
Backed out changeset 1d318d5c6b98 (bug 1525319)
Backed out changeset 6d73418988d4 (bug 1525319)
Backed out changeset 84ca79bd2dc3 (bug 1525319)
2019-02-25 04:06:11 +02:00
Jonathan Kingston
b6e28d0b8e
Bug 1525319 - Removing context from OnDataAvailable r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20881
2019-02-24 20:27:55 +00:00
Jonathan Kingston
ba03516b3f
Bug 1525319 - Changing js to remove context from onStartRequest and onStopRequest r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20771
2019-02-25 00:07:42 +00:00
Jonathan Kingston
4334f239c3
Bug 1525319 - Removing context from OnStopRequest r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20770
2019-02-24 20:26:59 +00:00
Jonathan Kingston
d6fffaf979
Bug 1525319 - Removing context from OnStartRequest r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20769
2019-02-24 20:26:16 +00:00
Ehsan Akhgari
6bcfe664eb
Bug 1527505 - Part 9: Make nsIPermissionManager accept ACString arguments for permission types instead of raw C strings; r=nika
...
This will mean that in places like the tight loop in GetTypeIndex()
we would no longer require calling strlen() on the input type argument
once per loop iteration.
Depends on D20236
Differential Revision: https://phabricator.services.mozilla.com/D20237
2019-02-21 22:54:28 +00:00
Christoph Kerschbaumer
1a72eb2a6b
Bug 1528677: Remove nullchecks for loadinfo since we have loadinfo on all channels. r=baku
2019-02-20 13:27:25 +01:00
Bogdan Tara
6b584210a2
Merge mozilla-central to autoland. a=merge CLOSED TREE
2019-02-19 19:36:33 +02:00
Andrea Marchesini
0fd63f6e02
Bug 1528596 - Devirtualize accesses to nsUrlClassifierUtils, r=dimi
...
Differential Revision: https://phabricator.services.mozilla.com/D20086
2019-02-19 14:35:57 +00:00
Masatoshi Kimura
26288e989f
Bug 1528651 - Re-enable warnings-as-errors on Windows in some directories. r=dmajor
2019-02-17 15:03:02 +09:00
Kris Maglione
7592c0339c
Bug 1524688: Part 8 - Convert URL classifier to static registration r=Ehsan
2019-01-29 18:41:19 -08:00
Csoregi Natalia
ddfb8b53b5
Backed out 79 changesets (bug 1524687, bug 1524688) for crashes on mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *). CLOSED TREE
...
Backed out changeset 68a001a42406 (bug 1524687)
Backed out changeset 328de611bcd3 (bug 1524688)
Backed out changeset 68cffca6927a (bug 1524687)
Backed out changeset 81dc12cc9257 (bug 1524688)
Backed out changeset c7c49f64048f (bug 1524688)
Backed out changeset fb23a0271da0 (bug 1524688)
Backed out changeset 0c1d1248e59e (bug 1524688)
Backed out changeset 9e9ec7de4160 (bug 1524688)
Backed out changeset de0b9993bd5d (bug 1524688)
Backed out changeset 92877cf4fe33 (bug 1524688)
Backed out changeset b4938f2ff8fd (bug 1524688)
Backed out changeset 230d2feaf941 (bug 1524688)
Backed out changeset 6c63bc240972 (bug 1524688)
Backed out changeset 0ad5465eace1 (bug 1524688)
Backed out changeset 1e75ce91029b (bug 1524688)
Backed out changeset 34a978503b1d (bug 1524688)
Backed out changeset 183602e8a30b (bug 1524688)
Backed out changeset 12a9135dc005 (bug 1524688)
Backed out changeset 978ef5dac9db (bug 1524688)
Backed out changeset 28105bf7bf6a (bug 1524688)
Backed out changeset a9fb74beaf2b (bug 1524688)
Backed out changeset fe106b369a72 (bug 1524688)
Backed out changeset e657e77d4271 (bug 1524688)
Backed out changeset 09f626870ad0 (bug 1524688)
Backed out changeset fe9b6695212e (bug 1524688)
Backed out changeset 995ea188bc31 (bug 1524688)
Backed out changeset 01c4d3edb1b0 (bug 1524688)
Backed out changeset 1bb7dfbb9f48 (bug 1524688)
Backed out changeset 56c61e0a1f45 (bug 1524688)
Backed out changeset c819943ff466 (bug 1524688)
Backed out changeset a1dd5cec066e (bug 1524688)
Backed out changeset 517838ee0c3c (bug 1524688)
Backed out changeset f509a5759fdf (bug 1524688)
Backed out changeset 56f5c8f0d708 (bug 1524688)
Backed out changeset 5746311ef859 (bug 1524688)
Backed out changeset df02f7d25212 (bug 1524688)
Backed out changeset c9846136d105 (bug 1524688)
Backed out changeset 2bd48db9cd0f (bug 1524688)
Backed out changeset ff120b4eeb79 (bug 1524688)
Backed out changeset fe583e7aae8d (bug 1524688)
Backed out changeset 18f156d6355a (bug 1524688)
Backed out changeset f4eaebbe2e0f (bug 1524688)
Backed out changeset bf6b18e23f69 (bug 1524688)
Backed out changeset dd89eb7e9b0d (bug 1524688)
Backed out changeset 4cbbb367ba0b (bug 1524688)
Backed out changeset 4ed0cf6be580 (bug 1524688)
Backed out changeset d8efb5ed62b1 (bug 1524688)
Backed out changeset ea347d57d73a (bug 1524688)
Backed out changeset 911689ef9f33 (bug 1524688)
Backed out changeset 28670fdc418d (bug 1524688)
Backed out changeset 38e1e42a0fb0 (bug 1524688)
Backed out changeset 35a5f031dd1e (bug 1524688)
Backed out changeset b586d55d76d5 (bug 1524688)
Backed out changeset 6dcacead1746 (bug 1524688)
Backed out changeset 9895239d8ac6 (bug 1524688)
Backed out changeset 25f982fd53bd (bug 1524688)
Backed out changeset 4fb0f0a59fe2 (bug 1524688)
Backed out changeset fdc6c4ed241a (bug 1524688)
Backed out changeset 5ce5986068f0 (bug 1524688)
Backed out changeset ab64ed7388ae (bug 1524688)
Backed out changeset 56607c5a301a (bug 1524688)
Backed out changeset 6b3684e7d8f9 (bug 1524688)
Backed out changeset ee28258a5724 (bug 1524688)
Backed out changeset 9201a7ea3c54 (bug 1524688)
Backed out changeset d5dca413e2da (bug 1524688)
Backed out changeset 68eb174a337b (bug 1524688)
Backed out changeset 625f71135038 (bug 1524687)
Backed out changeset 46e13c453538 (bug 1524687)
Backed out changeset 614be688767f (bug 1524687)
Backed out changeset 9c24919ac5c2 (bug 1524687)
Backed out changeset b9862758b98c (bug 1524687)
Backed out changeset 92d9e927deec (bug 1524687)
Backed out changeset f4ee175bc5bd (bug 1524687)
Backed out changeset 191afe83da2e (bug 1524687)
Backed out changeset c58caf41bb94 (bug 1524687)
Backed out changeset df95a56dae04 (bug 1524687)
Backed out changeset 10c69df4444d (bug 1524687)
Backed out changeset 219b84a58f50 (bug 1524687)
Backed out changeset e96e61bd282f (bug 1524687)
2019-02-14 11:50:23 +02:00
Kris Maglione
6ba6e0b08e
Bug 1524688: Part 8 - Convert URL classifier to static registration r=Ehsan
2019-01-29 18:41:19 -08:00
Jonathan Kingston
58708e007c
Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin
...
Replacing js and text occurences of asyncOpen2
Replacing open2 with open
Differential Revision: https://phabricator.services.mozilla.com/D16885
2019-02-12 16:08:25 +00:00
Eugen Sawin
ec698cd716
Bug 1525388 - [1.0] Set URL classifier update prefs to enable list updates and remove previous workaround. r=dimi
...
Differential Revision: https://phabricator.services.mozilla.com/D18736
2019-02-06 07:23:39 +00:00
Andrea Marchesini
5a9e597f3d
Bug 1522210 - Fingerprinting and cryptomining classifiers must have separate nsIWebProgressListener blocking state codes - part 1 - UrlClassifierFeatureFactory::IsClassifierBlockingErrorCode, r=ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D17637
2019-01-30 13:43:34 +01:00
Myk Melez
5ecc2c1225
Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
shindli
776effa650
Merge mozilla-central to inbound. a=merge CLOSED TREE
2019-01-29 23:54:31 +02:00
shindli
ab4e6c3ffb
Merge inbound to mozilla-central. a=merge
2019-01-29 23:37:33 +02:00
Kris Maglione
1dad1ad235
Bug 1478124: Follow-up: Fix merge conflict. r=bustage CLOSED TREE
2019-01-29 13:13:00 -08:00
Andrea Marchesini
766206546d
Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 5 - Fix a method name call, r=me CLOSED TREE
2019-01-29 15:21:43 +01:00
Andrea Marchesini
9acb35ab86
Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 4 - Phishing Protection, r=dimi
2019-01-29 10:11:34 +01:00
Andrea Marchesini
416f469b5c
Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 3 - DBService updated, r=dimi
2019-01-29 10:11:34 +01:00
arthur.iakab
e2d46fcd9f
Backed out 4 changesets (bug 1522265) for mochitest assertion failures on extensions/cookie/nsPermissionManager.cpp CLOSED TREE
...
Backed out changeset 38b4179568c7 (bug 1522265)
Backed out changeset 38b824df9d02 (bug 1522265)
Backed out changeset 6085d51681f8 (bug 1522265)
Backed out changeset e6a0832f3b11 (bug 1522265)
2019-01-29 14:25:00 +02:00
Andrea Marchesini
d093c9582c
Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 4 - Phishing Protection, r=dimi
2019-01-29 10:11:34 +01:00
Andrea Marchesini
6ea43382ea
Bug 1522265 - Moving malware, phishing and blocked URIs to features - part 3 - DBService updated, r=dimi
2019-01-29 10:11:34 +01:00
arthur.iakab
127fb281ff
Backed out 16 changesets (bug 1478124) for failing android geckoview-junit CLOSED TREE
...
Backed out changeset fce62c77a56b (bug 1478124)
Backed out changeset eb2fa3b5edf7 (bug 1478124)
Backed out changeset 8dacce59fcc0 (bug 1478124)
Backed out changeset 012fd0107204 (bug 1478124)
Backed out changeset 496aaf774697 (bug 1478124)
Backed out changeset 21f4fda03159 (bug 1478124)
Backed out changeset b0444e0bc801 (bug 1478124)
Backed out changeset d94039b19943 (bug 1478124)
Backed out changeset 5d85deac61c2 (bug 1478124)
Backed out changeset 929fd654c9df (bug 1478124)
Backed out changeset 1ddd80d9e91a (bug 1478124)
Backed out changeset b8d2dfdfc324 (bug 1478124)
Backed out changeset f500020a273a (bug 1478124)
Backed out changeset dd00365ebb55 (bug 1478124)
Backed out changeset 538e40c5ee13 (bug 1478124)
Backed out changeset bedaa9c437ad (bug 1478124)
2019-01-29 10:03:06 +02:00
Dimi Lee
01a82811a6
Bug 1513535 - Support the ability to separate feature toggle and list update in URL classifier. r=gcp
...
Add preferences "browser.safebrowsing.features.[feature name].update".
Normally these preferences won't be set so the SafeBrowsing uses features's
enable/disable preferences to decide if it should update the list or
not.
If an update preference is present, then it has higher priority then the
enable/disable one.
This provides a way for the SafeBrowsing consumer to be able to separate
feature toggle and upodate.
Differential Revision: https://phabricator.services.mozilla.com/D17233
2019-01-22 16:13:41 +00:00
Kris Maglione
856fa07b17
Bug 1514594: Part 3 - Change ChromeUtils.import API.
...
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Ehsan Akhgari
867bd3195b
Bug 1522630 - Report content blocking status notifications from the idle event queue; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D17554
2019-01-28 10:05:58 -05:00