Commit Graph

46 Commits

Author SHA1 Message Date
Chris Peterson
82d3961d8f Bug 1207031 - Suppress -Wshadow warnings from google-breakpad headers in xpcom/threads. r=froydnj 2015-09-21 22:41:52 -07:00
Jim Chen
a3b0963b55 Bug 1196381 - Eliminate breakpad dependency in ThreadStackHelper; r=nfroyd r=snorp
The breakpad dependency in ThreadStackHelper is preventing us from
upgrading our in-tree copy to a newer version (bug 1069556). This patch
gets rid of that dependency. This makes native stack frames not work
for BHR, but because of the ftp.m.o decommissioning, native
symbolication was already broken and naive stack frames already don't
work, so we don't really lose anything from this patch.

Eventually we want to make ThreadStackHelper use other means of
unwinding, such as LUL for Linux

I added | #if 0 | around the code to fill the thread context, but left
the code in because I think we'll evenually want to reuse some of that
code.
2015-09-18 09:17:10 -04:00
Miko Mynttinen
7ac3faa6c3 Bug 1197316 - Remove PR_snprintf calls in xpcom/. r=froydnj 2015-08-22 17:57:52 -07:00
Birunthan Mohanathas
a29151dc87 Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Nathan Froyd
1f9672eb8e Bug 1169034 - include <cstdlib> in ThreadStackHelper.cpp to declare correct overload for std::abs; r=jseward
The integer-valued {,l,ll}abs functions come from <stdlib.h>, and so the
integer-valued overload for std::abs comes from <cstdlib>.
2015-05-27 16:54:38 -04:00
Jim Chen
d226e2c08b Bug 1164090 - Check for Windows path separator in BHR file name; r=snorp 2015-05-19 11:27:18 -04:00
Trevor Saunders
2cab0ab3a9 bug 1146027 - more final r=froydnj 2015-03-24 17:51:43 -04:00
Jim Chen
8c8c301f3e Bug 1113416 - Don't read stack labels inside hang monitor sighandler; r=nfroyd r=snorp
When we're inside the hang monitor's signal handler, we must not read any string labels. Doing so may result in on-demand decompression kicking in on Android, which may result in a deadlock.
2015-01-10 12:41:48 -05:00
Jim Chen
e034c991d4 Bug 1109291 - Include better paths for hanging chrome scripts in profile extensions directory; r=snorp r=bsmedberg 2014-12-16 17:09:17 -05:00
Jim Chen
982fedb933 Bug 1091758 - Report full paths for most chrome scripts; r=snorp 2014-11-25 15:35:21 -08:00
Julian Seward
6cf9921f9c Bug 1100911 - For MacOS builds running on Valgrind, make ThreadStackHelper::GetStack be a no-op. r=nchen. 2014-11-20 20:50:26 +01:00
Tom Schuster
4e0dfb7481 Bug 1069694 - Remove OldDebugAPI from the browser. r=shu 2014-10-12 19:37:41 +02:00
Tom Schuster
27edac60d0 Bug 1069694 - Remove or move around functions in OldDebugAPI. r=shu 2014-09-23 15:25:31 +02:00
Birunthan Mohanathas
6e9ec233ed Bug 1046841 - Fix more style violations in previously touched .cpp files in xpcom/. r=froydnj 2014-08-25 12:17:15 -07:00
Jim Chen
9318e6e2f2 Bug 1050440 - Remove repeated js::RunScript frames in ThreadStackHelper; r=snorp 2014-08-14 17:17:55 -04:00
Julian Seward
0ca4d05ba8 Bug 1050185 - Make ThreadStackHelper::FillThreadContext Valgrind-friendly. r=nchen 2014-08-12 12:15:06 +02:00
Jim Chen
cee6c98c81 Bug 1049161 - Fix ThreadStackHelper thread handle permissions on Windows; r=snorp 2014-08-08 18:11:53 -04:00
Jeff Walden
4e7053ed2b Bug 1047123 - ThreadStackHelper should use UniquePtr<uint8_t[]>, not ScopedDeleteArray. r=jchen 2014-08-01 10:49:37 -07:00
Jan Beich
cc56bb4105 Bug 1045176 - Unbreak build on non-SPS platforms after bug 1016629. r=nchen 2014-07-28 12:29:00 +02:00
Jim Chen
6593aa5354 Bug 1016629 - g. Avoid ASan flag when copying stack; r=snorp 2014-07-28 13:30:22 -04:00
Jim Chen
bc67208ff7 Bug 1016629 - e. Implement platform-specific code for filling in context; r=snorp r=jseward 2014-07-28 13:30:21 -04:00
Jim Chen
20e91cc373 Bug 1016629 - d. Add and implement GetNativeStack method in ThreadStackHelper; r=snorp r=jseward 2014-07-28 13:30:21 -04:00
Jim Chen
751190fb1d Bug 1016629 - c. Add define for ThreadStackHelper pseudostack support; r=snorp 2014-07-28 13:30:20 -04:00
Jim Chen
7a41d1bffa Bug 1016629 - b. Use RAII class to assign mStackToFill; r=snorp 2014-07-28 13:30:20 -04:00
Carsten "Tomcat" Book
d1a0bd3244 Backed out changeset 4e4358c01816 (bug 1016629) 2014-07-25 15:59:55 +02:00
Carsten "Tomcat" Book
e38f67c609 Backed out changeset 3e869dd7e82a (bug 1016629) 2014-07-25 15:59:52 +02:00
Carsten "Tomcat" Book
99c2b2026a Backed out changeset 8d539315541d (bug 1016629) 2014-07-25 15:59:49 +02:00
Carsten "Tomcat" Book
ce6517549a Backed out changeset e008d505335a (bug 1016629) 2014-07-25 15:59:46 +02:00
Carsten "Tomcat" Book
109439bb25 Backed out changeset 7cae21b839ad (bug 1016629) 2014-07-25 15:59:33 +02:00
Jim Chen
f59825f0e1 Bug 1016629 - g. Avoid ASan flag when copying stack; r=snorp 2014-07-24 22:33:49 -04:00
Jim Chen
942b50411a Bug 1016629 - e. Implement platform-specific code for filling in context; r=snorp r=jseward 2014-07-24 22:33:47 -04:00
Jim Chen
22aca3e0ba Bug 1016629 - d. Add and implement GetNativeStack method in ThreadStackHelper; r=snorp r=jseward 2014-07-24 22:33:46 -04:00
Jim Chen
16a3098f2f Bug 1016629 - c. Add define for ThreadStackHelper pseudostack support; r=snorp 2014-07-24 22:33:46 -04:00
Jim Chen
39ee7fe82e Bug 1016629 - b. Use RAII class to assign mStackToFill; r=snorp 2014-07-24 22:33:45 -04:00
Jim Chen
01d22a3f36 Bug 1016441 - Switch to using real-time signal in ThreadStackHelper; r=snorp 2014-07-08 14:53:17 -04:00
Birunthan Mohanathas
8a4a4c8465 Bug 1022456 - Fix modelines in xpcom/{base,glue,io,string,threads}/. r=froydnj 2014-06-30 08:39:45 -07:00
Jim Chen
d73297430f Bug 1023461 - Record filename and line number for chrome JS entries; r=snorp 2014-06-20 14:28:10 -04:00
Jim Chen
0a66dbe970 Bug 1023461 - Remove temporary stack buffer in ThreadStackHelper; r=snorp 2014-06-20 14:28:10 -04:00
Jim Chen
23291c8c8f Bug 1013326 - Distinguish chrome and content scripts in pseudostack; r=snorp 2014-06-06 18:39:40 -04:00
Birunthan Mohanathas
a108f37fc2 Bug 995730 - Convert xpcom/threads/ to Gecko style. r=froydnj 2014-05-27 10:15:35 +03:00
Jim Chen
7670c9292d Bug 985155 - Add signal trampoline on ARM Linux to work around kernel bug. r=snorp 2014-04-21 17:15:44 -04:00
Jim Chen
0585a2ee02 Bug 978262 - Ignore duplicate frames when getting BHR stack. r=froydnj 2014-03-05 08:47:46 -05:00
Jim Chen
bcd7df32ff Bug 951431 - Don't get stacks during profiler runs on Linux; r=BenWa 2014-01-14 10:33:32 -06:00
Jim Chen
965e06ad04 Bug 946817 - Don't assert mPseudoStack on B2G. r=BenWa 2013-12-06 09:50:21 -05:00
Jan Beich
3543b54705 Bug 942488 - Don't report pseudo-stacks without SPS profiler. r=nchen 2013-11-25 09:24:00 -05:00
Jim Chen
03ef6b66b6 Bug 935092 - Add ThreadStackHelper to get a thread's pesudo-stack; r=BenWa 2013-11-22 14:17:30 -05:00