Commit Graph

159 Commits

Author SHA1 Message Date
Ehsan Akhgari
1ab9c7bcb4 Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:

# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.cc" \
         -o -iname "*.mm" \) | \
    xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
                   media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
                   modules/libmar/src/mar_private.h \
                   modules/libmar/src/mar.h


# assert_replacer.py
#!/usr/bin/python

import sys
import re

pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")

def replaceInPlace(fname):
  print fname
  f = open(fname, "rw+")
  lines = f.readlines()
  for i in range(0, len(lines)):
    while True:
      index = re.search(pattern, lines[i])
      if index != None:
        index = index.start()
        lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
        for j in range(i + 1, len(lines)):
          if lines[j].find("                 ", index) == index:
            lines[j] = lines[j][0:index] + lines[j][index+4:]
          else:
            break
      else:
        break
  f.seek(0, 0)
  f.truncate()
  f.write("".join(lines))
  f.close()

argc = len(sys.argv)
for i in range(1, argc):
  replaceInPlace(sys.argv[i])
2013-07-18 13:59:53 -04:00
Justin Lebar
8cc88f21ce Bug 820686 - Remove code after MOZ_CRASH or MOZ_ASSUME_NOT_REACHED. r=(see below)
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=waldo for js
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else
2013-06-28 18:38:32 -07:00
Justin Lebar
de89040a2c Bug 802686 - s/MOZ_NOT_REACHED/MOZ_CRASH/ in Gecko. r=(see below)
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else

This is a mechanical change made with sed.  Later patches in this queue
clean up the whitespace errors and so on.
2013-06-28 18:38:30 -07:00
Catalin Iacob
f88cdc0744 Bug 798914 (part 5) - Use newly introduced mozilla::MallocSizeOf instead of nsMallocSizeOfFun. r=njn. 2013-06-23 14:03:39 +02:00
Aryeh Gregor
cfbfebd4ba Bug 859817 - Make nsStringBuffer::Alloc return already_AddRefed; r=bz 2013-04-22 14:13:22 +03:00
Aryeh Gregor
03b4600974 Bug 859817 - Make NS_NewAtom return already_AddRefed; r=bz 2013-04-22 14:13:22 +03:00
Boris Zbarsky
7dcac6dfc4 Bug 858671. Make do_GetAtom infallible. r=khuey 2013-04-08 17:04:21 -04:00
Chris Peterson
6031ca870d Bug 839962 - Part 2: Replace some XPCOM thread NS_ASSERTIONs with MOZ_ASSERTs. r=bsmedberg 2013-02-07 21:54:20 -08:00
Nicholas Nethercote
740d2cc136 Bug 810215 - Fix stupid defect causing the "explicit/atoms-table" reporter to always return 0. r=khuey. 2012-11-09 00:46:34 -08:00
Isaac Aggrey
990e90e88a Bug 791906: Replace NSPR integer limit constants with stdint ones; r=ehsan 2012-09-28 01:57:33 -05:00
Randell Jesup
3b4961b603 Bug 773151: Convert nsCAutoString->nsAutoCString CLOSED TREE r=bsmedberg 2012-09-01 22:35:17 -04:00
Ehsan Akhgari
243c878d26 Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Aryeh Gregor
8b4a23fc4c Bug 777292 part 2 - Change all nsnull to nullptr 2012-07-30 17:20:58 +03:00
Nathan Froyd
5bfb1e0bd8 Bug 765326 - atom-table numbers should include the static atom table; r=njn 2012-06-15 15:51:42 -04:00
Ehsan Akhgari
6c1914b71f Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (XPCOM parts); r=bsmedberg 2012-06-05 19:51:58 -04:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Benjamin Smedberg
2b55dddfca Bug 734847 part 2 - treewide changes resulting from the default-infallibility of hashtables; either remove useless result checks, or use the fallible version of APIs, depending on context, r=jlebar 2012-05-18 13:30:49 -04:00
Justin Lebar
8dfd539864 Bug 729940 - Part 2: Stop using crappy hash functions in Gecko. r=bz 2012-03-12 18:53:18 -04:00
Jacob Holzinger
bfaddb970e Bug 696242 - Convert NS_RegisterStaticAtoms and nsCSSScanner::ReportUnexpectedParams to take an array-reference rather than a pointer and length, making it impossible to pass a pointer/length that are inconsistent. r=jwalden 2012-03-08 18:22:57 -08:00
Boris Zbarsky
c632ee6a66 Bug 730414. Expose a quick way to get a hash key for an atom. r=bsmedberg 2012-02-29 21:40:51 -05:00
Nicholas Nethercote
c1dd090b4c Bug 715453 - Remove computedSize from nsMallocSizeOfFun. r=jlebar,bhackett. 2012-01-25 00:52:51 -08:00
Nicholas Nethercote
d11022690d Bug 712835 (part 3 of 3) - Move AtomImpl and PermanentAtomImpl out of the header. r=khuey. 2011-12-22 17:24:44 -08:00
Nicholas Nethercote
e9f15ea380 Bug 712835 (part 2 of 3) - Add a memory reporter for the nsAtomTable. r=khuey. 2011-12-22 17:24:43 -08:00
Jeff Walden
e6c7fadf0c Bug 712129 - Implement MOZ_STATIC_ASSERT and MOZ_STATIC_ASSERT_IF. r=luke 2011-12-19 16:58:30 -05:00
Ehsan Akhgari
478ad1a412 Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
Michael Wu
0fe7772ece Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones 2011-09-28 23:19:26 -07:00
Matheus Kerschbaum
44209e0bdf Bug 678155 - Remove NS_COM. r=bsmedberg 2011-08-18 15:46:39 +02:00
Jonas Sicking
0d0238b01e Bug 534136 part 4bis: Fix review comments from peterv that should have been in initial patch. 2010-03-08 08:03:55 -08:00
Jonas Sicking
6f2017e1c2 Bug 534136 Part 6: Properly handle invalid UTF8 string being passed to NS_NewAtom/do_GetAtom. r=jst 2010-03-08 07:45:00 -08:00
Jonas Sicking
8f76ee7397 Bug 534136 Part 5: Clean up atomtable hash entries. r=jst 2010-03-08 07:45:00 -08:00
Jonas Sicking
9d30378b7a Bug 534136 Part 4: Inline accessors on nsIAtom. r=peterv sr=jst 2010-03-08 07:45:00 -08:00
Jonas Sicking
6859a5ac8e Bug 534136 Part 2: Use 16bit-char buffers inside atoms. r=bz sr=mrbkap 2010-03-08 07:45:00 -08:00
Jonas Sicking
48366287f1 Bug 534136 Part 1: Make atoms keep a pointer to an nsStringBuffer rather than storing the data inline. r=bsmedberg 2010-03-08 07:44:59 -08:00
Henri Sivonen
2fa812bf83 Bug 514661 - Introduce scoped atom tables for the HTML5 parser. r=bsmedberg, sr=dbaron. 2009-09-18 18:13:10 +03:00
Serge Gautherie
93a9dae745 Bug 306840 - Improve PR_GetEnv() usages; (Cv1a) <XpCom/nsAtomTable.cpp> (= sync'ed Bv2); r=timeless sr=neil 2009-06-11 19:47:33 +02:00
Arpad Borsos
1b55360c07 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Sudheer Kumar Peddireddy
427ecfea83 Increase the initial sizes of hash tables that are guaranteed to grow. b=432633 r=dbaron 2008-06-03 15:25:31 -07:00
7b34ae7602 Back out bug 412320 and various followups because the perf impact was minimal and the code is more complicated 2008-02-21 12:39:20 -08:00
db8d572868 Bug 412320 - Try code-generation for QI impls, r=roc+luser 2008-01-25 09:14:48 -08:00
a113c5d648 Bug 387023: minor string cleanup in nsAtomTable.cpp. r=bsmedberg, a=bzbarsky. 2007-09-05 18:13:42 -07:00
8a277235d9 Bug 348748 - Cleanup from the handful of patches which have landed since the initial landing that have readded cast macros; I intend to remove the rest of the instances Very Soon, all but certainly before the M8 freeze, so the macro definitions can be removed, again all but certainly before the M8 freeze, if people are okay with them being removed. Still r=bsmedberg, a=no-functionality-change 2007-09-04 23:41:35 -07:00
126c483d51 Bug 387445: Remove thread safety from atoms. r+sr=dbaron, a=bzbarsky 2007-08-07 12:16:52 -07:00
8be89d4076 Fixing bug 377360. Fix atom table crash due to invalid UTF data in atoms. r=jonas@sicking.cc, sr=peterv@propagandism.org 2007-07-11 13:46:43 -07:00
98de634631 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
0f08b75950 Remove unused getKey callback from PLDHashTableOps/JSDHashTableOps. b=374906 r=bsmedberg 2007-03-27 08:33:38 -07:00
mats.palmgren@bredband.net
7f3bcc12a7 Don't crash on OOM. b=353997 r+sr=darin 2006-09-30 05:15:57 +00:00
dbaron@dbaron.org
3ad2463c7a Fix threadsafety regression so we're back to the old broken state. b=335734 r=sicking rs=brendan 2006-05-06 17:49:21 +00:00
dbaron@dbaron.org
7452284d8f Make IsPermanent non-virtual so it can be called in the destructor. b=334605 r=mrbkap rs=brendan 2006-04-19 21:46:47 +00:00
cbiesinger@web.de
aae44b57d9 bug 183156 remove *UCS2* functions, replacing them with *UTF16* ones
r+sr=darin
2006-02-03 14:18:39 +00:00
bzbarsky@mit.edu
b47c9f2b3e Implement a in-place (no copy) CompareUTF8toUTF16, and use it to make the atom
hashtable lookups zero-copy.  Patch by jst, bug 314465 (with lots of the
discussion in bug 277479), r=bsmedberg,dbaron,brendan (on the PLDHashTable
keyhash value assumptions), sr=bzbarsky, moa=shaver.
2005-11-04 19:52:18 +00:00