Commit Graph

68 Commits

Author SHA1 Message Date
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Irving Reid
a803765fb8 Bug 760356: Only show the addon compat UI when necessary; r=unfocused 2014-05-20 13:16:39 -04:00
Irving Reid
b814820d30 Bug 760356: #1 Always request all add-ons when loading AddonRepository; r=unfocused 2014-05-20 13:16:37 -04:00
Irving Reid
f9b81592db Bug 1010449: Add telemetry for add-on compatibility changes, upgrades during startup time add-on update check; r=unfocused 2014-05-20 13:15:24 -04:00
Irving Reid
1b152f9fe9 Bug 772484 - Allow user to cancel add-on update check and clean up correctly when they do. r=Unfocused 2014-03-14 08:52:55 -04:00
Alexander J. Vincent
124eff5db7 Bug 952307 - Move some addon-private JSM's to a subdirectory. r=Unfocused 2014-01-07 20:14:08 -08:00
Irving Reid
95cf27ed4c Bug 965788 - Use XHR timeout for addon checks. r=Mossop, r=Unfocused 2014-02-11 14:14:32 -05:00
Jonathan Kamens
3797f4a999 Bug 823042 - Fix redeclared argument warnings. r=Mossop 2012-12-19 09:10:19 -05:00
Atul Jangra
db8be2ae7c Bug 767236 - Part 4: Name all anonymous functions in remaining Add-ons Manager code. r=Unfocused 2012-10-24 22:58:00 +13:00
Marcos S.
d10d3c97af Bug 758950 - Part 2a: Use more for...of loops in Add-ons Manager frontend and backend code. r=Unfocused 2012-09-21 22:35:00 +12:00
Neil Rashbrook
3f194429dd Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-26 00:11:16 +01:00
Ed Morley
4bd90ea948 Backout ec9451e9e830 (bug 758354) for PGO linux permaorange in browser_bug422590.js and friends 2012-06-25 19:14:43 +01:00
Neil Rashbrook
d9a10be7eb Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-25 09:24:49 +01:00
Blair McBride
b3b05ec84b Bug 746908 - Add parameter guards to AddonManager/AddonManagerPrivate API functions. r=dtownsend 2012-05-30 18:34:32 +12:00
Marcos Santiago
59df26ce78 Bug 740237 - Use for...of loops in Add-ons Manager frontend and backend code. r=Unfocused 2012-05-28 00:21:48 +12:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Blair McBride
5c141ea5c9 Bug 718630 - Add-ons with compatibility override are displayed as enabled and incompatible if skipping compatibility check after upgrade. r=dtownsend 2012-02-15 15:07:29 +13:00
Dave Townsend
5edc7e570b Bug 704987: Ignore the hotfix add-on when warning users about incompatible add-ons. r=robstrong 2011-12-16 12:04:40 -08:00
Blair McBride
5bf15b09c4 Bug 706777 - Automatically repopulate AddonRepository database on application upgrade. r=dtownsend 2011-12-07 23:48:33 +13:00
Blair McBride
e57aa19f20 Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Gavin Sharp
7a6bbaa11d Back out 0f11ca4d1733 (bug 670023) due to xpcshell test failures 2011-07-21 22:20:21 -04:00
Blair McBride
a27157de11 Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Tim Taubert
39def6724d Backed out changeset a115d824218c (bug 670023) 2011-07-20 03:28:05 +02:00
Blair McBride
8c3e67983f Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Dave Townsend
fa7d28d97e Bug 666431: Track changes made to add-ons during early startup. r=robstrong
try: -b do -p linux,linuxqt,linux64,macosx64,win32,macosx -u xpcshell,mochitest-o -t none
2011-06-29 14:50:43 -07:00
Robert Strong
4e337362c9 Bug 608138 - Exclude plugins from the compatibility wizard checks. r=dtownsend, a=b7 2010-10-29 12:04:52 -07:00
Robert Strong
9e24522f45 Bug 608115 - ReferenceError: strings is not defined in a couple of obvious places in update.js. r=dtownsend, a=b7 2010-10-29 12:04:38 -07:00
Dave Townsend
3ba86f405e Bug 599105: Default wizard page of update extensions window shown when switching between builds. r=robstrong, a=blocks-final 2010-10-12 10:52:44 -07:00
Dave Townsend
6f3926e557 Bug 557956: Update compatibility information for installed add-ons when the application is upgraded. r=robstrong, a=blocking-beta5 2010-08-17 12:08:33 -07:00
Michael Kohler
61fec64afe Bug 506041 Part 2: Correct misspellings in source code
r=timeless
2010-05-13 14:19:50 +02:00
Dão Gottwald
37102a6574 Bug 526987 - getItemList, getIncompatibleItemList, getDependentItemListForID and updateAndGetNewBlocklistedItems itemCount out params should be optional. r=dtownsend 2009-11-07 09:21:07 +01:00
Dave Townsend
9c762fa05b Bug 516506: Add-on update check (after Firefox update) is broken. r=robstrong 2009-09-15 12:09:10 +01:00
Dave Townsend
e6138e3a57 Bug 392180: updateURL should have variable indicating the context of the check. r=robstrong, sr=bsmedberg 2009-09-10 19:50:41 +01:00
Ian van den Berg
5708e6b539 Bug 393951 - Remove appID from nsIExtensionManager.getIncompatibleItemList. r=rstrong, sr=vlad 2009-07-30 17:35:02 -07:00
Dave Townsend
769f2c3958 Bug 496287: App update incompatible list should not warn about disabled/blocklisted items. r=robstrong 2009-06-06 18:09:58 +01:00
e198b6fecb Bug 489953 Remove extraneous semicolons
r=gavin
2009-05-03 09:28:43 -07:00
Robert Strong
95328782a9 Bug 458839 - Move errors.xul from update over to extensions since the add-ons mgr. is the only consumer. r=dtownsend 2008-10-10 15:36:46 -07:00
9f5c9807c1 Bug 406184: PlugIns installed in the user profile directory are not loaded. r=robstrong 2008-03-06 18:02:49 -08:00
b3f05aeb3a Bug 299716 - Need for em:targetApplication marker for 'the toolkit'. patch=ajvincent, r=dtownsend, r=rstrong 2007-08-29 01:16:15 -07:00
0d8d954035 Bug 335942 - nsIExtensionManager.update wants true and false for a long
param. r=robstrong
2007-06-25 08:51:51 -07:00
rob_strong@exchangecode.com
2c083a43dc Bug 345353 - Compatibility Wizard string changes. r=sspitzer, ui-r=beltzner 2006-07-26 22:59:56 +00:00
rob_strong@exchangecode.com
f799643938 Bug 342606 - Compatibility Wizard is broken in oh so many ways (unreachable code paths, messages not shown, etc.). r=sspizter 2006-07-20 18:49:51 +00:00
rob_strong@exchangecode.com
a2d1734cb7 Bug 333860 - When starting offline, Compatibility Wizard should not be checking for updates. patch=Dave Townsend (Mossop), r=rob_strong, ui-r=beltzner 2006-07-19 20:11:40 +00:00
rob_strong@exchangecode.com
a96eff24d0 Fix review comment for bug 310745. r=bsmedberg 2006-06-21 20:10:52 +00:00
rob_strong@exchangecode.com
a50a52d214 Bug 310745 - Extension update compatibility wizard tries to install updates when xpinstall is disabled. r=bsmedberg 2006-06-21 20:07:46 +00:00
rob_strong@exchangecode.com
f883b76753 Extension compatibility updates check never completes. r=bsmedberg 2005-11-03 14:53:42 +00:00
mozilla.mano@sent.com
62ddb8c6c5 Bug 313205 - software update 'Check Now' uses the same accesskey as 'Next'. r=mconnor. 2005-10-23 07:40:38 +00:00
rob_strong@exchangecode.com
8d8fc560cd Bug 310421 - Updates fail due to missing hash. r=bsmedberg, sr=dveditz 2005-09-29 17:41:29 +00:00
rob_strong@exchangecode.com
b2a4c5e328 Bug 306478 - Extension manager should use xpinstall crypto hashes. r=bsmedberg 2005-09-28 04:33:38 +00:00