Commit Graph

33 Commits

Author SHA1 Message Date
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Neil Rashbrook
3f194429dd Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-26 00:11:16 +01:00
Ed Morley
4bd90ea948 Backout ec9451e9e830 (bug 758354) for PGO linux permaorange in browser_bug422590.js and friends 2012-06-25 19:14:43 +01:00
Neil Rashbrook
d9a10be7eb Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-25 09:24:49 +01:00
Marcos Santiago
59df26ce78 Bug 740237 - Use for...of loops in Add-ons Manager frontend and backend code. r=Unfocused 2012-05-28 00:21:48 +12:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Blair McBride
e57aa19f20 Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Gavin Sharp
7a6bbaa11d Back out 0f11ca4d1733 (bug 670023) due to xpcshell test failures 2011-07-21 22:20:21 -04:00
Blair McBride
a27157de11 Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Tim Taubert
39def6724d Backed out changeset a115d824218c (bug 670023) 2011-07-20 03:28:05 +02:00
Blair McBride
8c3e67983f Bug 670023 - Use ES5's strict mode in Add-ons Manager frontend and backend code. r=dtownsend 2011-07-19 13:16:35 -07:00
Blair McBride
a8b2f64c7c Bug 614865 - Addon about window does not handle overflow very well. r=dtownsend, a=blocking-final 2010-12-07 13:32:08 +13:00
Blair McBride
38d1c73e91 Bug 601022 - Add final visual style and graphics to add-ons manager. r=dtownsend,dao a=blocking 2010-10-07 13:20:06 +13:00
Blair McBride
b66c99fe0b Bug 554007: New add-ons manager UI (main UI). r=dtownsend
* * *
Bug 554007 - cleanup of about.js
2010-05-06 11:12:59 -07:00
Dave Townsend
c92630540b Backout new add-ons manager due to Ts regression on OSX 10.5 2010-05-01 11:04:44 -07:00
Blair McBride
97a2387b18 Bug 554007: New add-ons manager UI (main UI). r=dtownsend
* * *
Bug 554007 - cleanup of about.js
2010-04-29 10:37:34 -07:00
Dave Townsend
e4587ebcbc Bug 510909: Integrate most recently used lightweight themes into the themes list in the add-ons manager. r=robstrong, r=dao 2009-09-17 10:03:33 +01:00
rob_strong@exchangecode.com
b362ce7b5a supplemental patch for Bug 262575 - 'Visit Homepage' and 'Get More Extensions/Themes' in Extension and Theme manager should respect tabbed browsing preferences. r=sspitzer 2006-07-21 22:10:36 +00:00
rob_strong@exchangecode.com
f9d719526d Bug 262575 - 'Visit Homepage' and 'Get More Extensions/Themes' in Extension and Theme manager should respect tabbed browsing preferences. patch=mwu, r=rob_strong 2006-07-18 00:25:57 +00:00
rob_strong@exchangecode.com
8cb031d0a8 Bug 269505 - <translator> element in EM RDF (themes and extensions). r=bsmedberg 2006-05-02 18:27:34 +00:00
gavin@gavinsharp.com
25b1d2d158 Followup to bug 315004, r=mconnor. 2005-11-07 04:49:19 +00:00
mconnor@steelgryphon.com
db4be88dc9 bug 315004 - only allow http/https URLs for addon homepages, patch by dveditz, r=me 2005-11-06 19:18:44 +00:00
gerv@gerv.net
c7ca93d489 Bug 236613: change to MPL/LGPL/GPL tri-license. 2005-02-01 17:07:35 +00:00
bugzilla@arlen.demon.co.uk
0e17752635 Bug 261267 helper application dialog has title issues when opening an unknown filetype
Relanding after aviary branch landing - already reviewed
2004-12-01 11:12:21 +00:00
ben@bengoodger.com
5003aacad6 Landing the Aviary Branch (Toolkit sections excluding toolkit/content). 2004-11-30 22:54:13 +00:00
bugzilla@arlen.demon.co.uk
a83525061d Bug 261267 helper application dialog has title issues when opening an unknown filetype - browser/toolkit parts
p=me r=vladimir sr=shaver
2004-10-20 20:31:20 +00:00
ben@bengoodger.com
e43cd733ee OK, merge back changes from the branch. for real this time 2004-06-19 05:54:09 +00:00
ben@bengoodger.com
ba88afd92f fuck it. 2004-06-19 05:50:12 +00:00
ben@bengoodger.com
fc5e909886 various updates from the branch - extension manager, update service, etc. 2004-06-19 04:56:21 +00:00
silver@warwickcompsoc.co.uk
3878a31aee Bug 246429 - null-check some vars before QIing them.
r=mconnor
patch by pike@pikey.me.uk
2004-06-19 02:32:44 +00:00
ben@bengoodger.com
0b2e4d445e 170006 - various updates to support pre-configured extensions 2004-05-10 23:30:11 +00:00
ben@bengoodger.com
5bb30c72d2 More extensions FE stuff (170006) not used yet 2004-03-29 23:22:00 +00:00
ben@bengoodger.com
072822cc18 Add new Extension Manager front end as part of 170006. Not currently hooked up to anything. 2004-03-29 20:37:02 +00:00