Commit Graph

96 Commits

Author SHA1 Message Date
Marco Bonardo
bd650f47ab Bug 1150678 - Part 1: notify the old value in onItemChanged (only URI changes for now). r=ttaubert 2015-08-05 23:10:11 +02:00
Wes Kocher
37bf9a868e Backed out 2 changesets (bug 1150678) for xpcshell bustage
Backed out changeset 1c24d237080c (bug 1150678)
Backed out changeset 9f1f1e11ca37 (bug 1150678)
2015-08-05 16:24:58 -07:00
Marco Bonardo
1c0eadb6f7 Bug 1150678 - Part 1: notify the old value in onItemChanged (only URI changes for now). r=ttaubert 2015-08-05 23:10:11 +02:00
Andrew McCreight
1ac060e051 Bug 1189369, part 5 - Use the nice cycle collector macro template for nsNavHistoryResult. r=mak
Also, fix up the CC template so it works.
2015-08-04 13:55:01 -07:00
Andrew McCreight
706d040db4 Bug 1189369, part 1 - Remove trailing whitespace from some nsNavHistory* files. r=mak 2015-08-04 13:55:01 -07:00
Andrew McCreight
343830ddd2 Bug 1074416 - Don't AddRef or Release nav history result observers during CC traversal. r=smaug
Doing an AddRef or Release of a cycle collected object during CC
traversal can cause leaks. traverseResultObservers does this in two
places. First, it accidentally copies the array that is passed
in. Second, the GetValue() method that is being implicitly called in
the line with |aObservers.ElementAt(i);| does a QI.

This patch fixes the former problem by passing a reference. It fixes
the latter problem by returning the raw underlying pointer held by the
nsMaybeWeakPtrArray, which is what the CC wants anyways, because it
does not care about weak referents.
2015-07-29 20:36:00 -04:00
mchenryc
d0d004ee8b Bug 1163447 - Allow Places tree selectItems() to recurse into folder-shortcuts. r=mak 2015-06-04 13:02:00 -07:00
Mohamed Waleed
33af67854d Bug 1062894 - Avoid batching tag changes if number of changed tags is low. r=mak, ttaubert 2015-04-27 21:24:21 +02:00
Denis Volk
1872a62df8 Bug 1095098 - move do_QueryObject templates into their own header; r=froydnj 2015-04-15 12:47:03 -04:00
Mike Hommey
338d086ead Bug 1134920 - Use moz_xmalloc/moz_xrealloc/free instead of nsMemory::Alloc/Realloc/Free. r=nfroyd 2015-04-01 13:51:45 +09:00
Nathan Froyd
26a0b56c7a Bug 1142503 - don't use QueryInterface when the compiler can do the cast for us; r=ehsan
Calling QueryInterface with a statically known IID should typically not
be necessary.  In those cases where it's not, the compiler can do the
cast for us, though we have to supply the reference-counting that
QueryInterface would do.

In passing, several redundant null-checks for the result of |new T| have
been deleted.
2015-03-12 09:43:50 -04:00
Asaf Romano
bba5e8921d Bug 1107308 - Round dateAdded and lastModified values to milliseconds precision in places cpp components. r=mak 2014-12-04 14:09:48 -08:00
Asaf Romano
926ea4a18e Bug 1105866 - Implement folderShorcutNode.targetFolderGuid (guid version of folderShortcutNode.folderItemId). r=mak 2014-12-10 19:03:15 +02:00
Asaf Romano
af9f408732 Bug 1085291 - A bookmark node that is inserted by live-update code is missing bookmarkGuid value. r=mak (Relanding with the test file included this time). 2014-11-25 11:43:26 +02:00
Carsten "Tomcat" Book
4ac659e2c3 Backed out changeset 6db486ed2de1 (bug 1085291) for breaking Builds on a CLOSED TREE 2014-11-25 09:25:11 +01:00
Asaf Romano
b3ed43173e Bug 1085291 - A bookmark node that is inserted by live-update code is missing bookmarkGuid value. r=mak. 2014-11-25 09:06:37 +02:00
Marco Bonardo
77be050825 Bug 1095069 - Cannot copy or delete bookmarks from search results in library. r=mano 2014-11-13 10:19:19 +01:00
Asaf Romano
fbed712ada Bug 1068671 - folderReadOnly doesn't pertain to bookmarks or results. r=mak 2014-10-14 17:03:28 +03:00
Carsten "Tomcat" Book
720b2367b9 Backed out changeset b30d47d94a85 (bug 1068671) for bc1 test failures 2014-10-01 13:14:06 +02:00
Asaf Romano
ce0d37a700 Bug 1068671 - Remove 'read-only' folders support from places. r=mak 2014-10-01 12:19:06 +03:00
Nicholas Nethercote
663b82ea3b Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
* * *
imported patch rm-dummy-params
2014-08-06 06:31:21 -07:00
Daniel Holbert
4603496899 Bug 992670 part 3 - Comment out failing assertion, with reference to followup bug. r=mak 2014-08-06 22:40:37 -07:00
Birunthan Mohanathas
27d6126b64 Bug 992670 part 2 - Make all child insertions/removals non-temporary in nsNavHistoryContainerResultNode. r=mak 2014-08-06 22:40:36 -07:00
Birunthan Mohanathas
7cf1e3a5e4 Bug 992670 part 1 - Fix always true assertion condition in nsNavHistoryResult.cpp. r=mak 2014-08-06 22:40:35 -07:00
Hiroyuki Ikezoe
0dfebbe786 Bug 1010634 - Use Contains instead of NoIndex to avoid relocation error. r=briansmith 2014-06-01 18:30:00 -04:00
Birunthan Mohanathas
eeb9aaaa94 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Birunthan Mohanathas
e2b133b310 Bug 900903 - Part 2: Change uses of numbered macros in nsCycleCollectionParticipant.h to the variadic variants. r=smaug 2014-04-25 12:49:00 -04:00
Drew Willcoxon
5a25763248 Bug 911307 - Reflect changes to top sites immediately in about:newtab (part 1, Places patch). r=mak 2014-03-28 23:30:04 -07:00
Phil Ringnalda
304bd1a718 Backed out 2 changesets (bug 911307) for frequent timeouts in browser_newtab_perwindow_private_browsing.js
Backed out changeset 70638b7c97f1 (bug 911307)
Backed out changeset 3951f7e82b4c (bug 911307)
2014-03-29 12:13:11 -07:00
Drew Willcoxon
4d07122113 Bug 911307 - Reflect changes to top sites immediately in about:newtab (part 1, Places patch). r=mak 2014-03-28 23:30:04 -07:00
Marco Bonardo
8d70ce8c70 Back out Bug 894331 to solve browser hangs when deleting history. a=lsblakk 2013-11-13 09:45:41 -05:00
Trevor Saunders
b4ae5fdd96 bug 949821 - use MOZ_UTF16 more and NS_LITERAL_STRING less r=froydnj 2013-12-12 20:50:01 -05:00
Ehsan Akhgari
9f7249b2f0 Bug 943993 - Build toolkit/components/places in unified mode; r=mak 2013-11-29 18:29:49 -05:00
Marco Bonardo
e965af96da Bug 914294 - Don't throw exceptions from the history result end batch macro to retain backwards compatibility.
r=mano
2013-10-15 14:30:33 +02:00
Birunthan Mohanathas
b55ff3bd65 Bug 784739 - Switch from NULL to nullptr in toolkit/components/ (1/2); r=ehsan 2013-10-10 16:38:05 -04:00
Robert O'Callahan
51222bdd45 Bug 910989. Remove nsTHashtable::Init, fallible allocation, and MT hashtables. r=ehsan,bsmedberg 2013-09-02 20:41:57 +12:00
Raymond Lee
6b22554a73 Bug 627487 - Bookmark JSON backup should contain new-style GUIDs. r=mano 2013-09-03 11:56:25 +08:00
Marco Bonardo
071effdef9 Bug 894331 - Use an automatic batching behavior in Places results.
Stop relying on manual batching and onBegin/OnEndUpdateBatch for batching in
Places results, instead count related changes and start batching when they
are over a given threshold.
r=Mano
2013-08-06 13:05:01 +02:00
Asaf Romano
d22bebd8c5 Bug 895839 - Remove support for binary annotations. r=mak. sr=gavin. 2013-08-03 14:06:47 +03:00
Mike Hommey
0dc9c0ef85 Bug 881323 - Re-implement CycleCollectorParticipant with actual vtables, with constexpr to avoid static initializers. r=mccr8 2013-08-02 10:29:05 +09:00
Andrew McCreight
2d6ad984ff Bug 874583 - Use NS_IMPL_CYCLE_COLLECTION_INHERITED_n in more places. r=smaug 2013-05-21 16:23:53 -07:00
Marco Bonardo
1e3da3a614 Bug 561450 - Stop supporting session ids in Places.
r=Mano sr=gavin
2013-03-25 14:44:41 +01:00
Marco Bonardo
c2b070dd3b Bug 830423 part 2 - Avoid history view refreshes when onvisit falls into the Today bucket.
r=Mano
2013-03-18 16:09:11 +01:00
Marco Bonardo
af09e77c2d Bug 826409 - Remove onBeforeDeleteURI and onBeforeItemRemoved notifications.
r=Mano sr=gavin
2013-02-06 20:48:56 +01:00
Marco Bonardo
f0beb158de Bug 831094 - Avoid replacing nodes in Places query results.
r=Mano sr=gavin
2013-02-06 20:48:09 +01:00
Marco Bonardo
8d75bfac8c Bug 838304 - null out mResult when removing container nodes.
r=Mano
2013-02-05 21:56:05 +01:00
Marco Bonardo
e9f2755651 Backout 890368240f48 (bug 838304) for xpcshell-test failures 2013-02-05 23:06:16 +01:00
Marco Bonardo
935ed3a8aa Bug 838304 - null out mResult when removing container nodes.
r=Mano
2013-02-05 21:56:05 +01:00
Daniel Holbert
d10594b5da Bug 835543 part 1: Remove unused class nsNavHistoryFullVisitResultNode. r=mak 2013-01-29 14:30:13 -08:00
Marco Bonardo
127da661ad Bug 824074 - Properly update frecency sorting in bookmarks queries.
r=Mano
2013-01-22 21:19:01 +01:00