Michael Comella
287c0968fd
Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret
...
These patches added complexity that we're removing by implementing this bug.
2015-06-01 14:16:55 -07:00
Michael Comella
e145de50f6
Bug 1166868 - review: Add clarifying comments to FaviconView. r=trivial
2015-05-22 16:18:56 -07:00
Michael Comella
7f8b683cbc
Bug 1166868 - Update default favicon for custom search engines. r=margaret"
2015-05-22 11:32:09 -07:00
Michael Comella
a9c3bb3308
Bug 1158282 - Correct showDefaultFavicon comment. r=me
...
I thought the dominant color box was always used, but it is only used when it
is enabled in XML attrs.
2015-05-22 11:35:45 -07:00
Michael Comella
758b728cf2
Bug 1158282 - Clarify existing comment in FaviconView.formatImage. r=margaret
2015-05-21 14:11:41 -07:00
Michael Comella
a92dfa649e
Bug 1158282 - Handle the default favicon as any other favicon. r=margaret
...
This removes the complications of handling the "default favicon" as a special
case simplifying the code into two branches - no favicon (i.e. blank) and a
custom favicon. Under the hood, the Android framework probably does a similar
amount of work (e.g. opening & scaling the bitmap) so I doubt this is less
efficient.
This solves the custom search engine icons changing on FaviconView reuse
(i.e. scrolling) and the incorrect scaling of the default favicon in the
search engine bar.
I attempted to solve the issue while keeping the default favicon as a special
case and it caused a lot of hard to follow code branches so it wasn't worth it.
This special casing is also why this bug existed in the first place!
One caveat to the handle-the-default-as-any-other-approach is mentioned in
the code comments (see FaviconView.showDefaultFavicon).
2015-05-21 14:03:16 -07:00
Michael Comella
dddea44a85
Bug 1106935 - Remove new tablet branch in selecting default toolbar favicons. r=mhaigh
...
As a cleanup, this required the move of favicon -> favicon_globe and the
creation of new resources toolbar_favicon_default, which is aliased to
favicon_globe on phones.
2015-02-03 18:18:21 -08:00
Ryan VanderMeulen
c3f83dac4f
Backed out 7 changesets (bug 1106935) for Android API9 mass-fails on a CLOSED TREE.
...
Backed out changeset f8366cf7e7c8 (bug 1106935)
Backed out changeset efa9411df1c4 (bug 1106935)
Backed out changeset f292df38d7eb (bug 1106935)
Backed out changeset 319511aa757a (bug 1106935)
Backed out changeset 78cb4369b396 (bug 1106935)
Backed out changeset fb066050757e (bug 1106935)
Backed out changeset 9080887b3cc4 (bug 1106935)
2015-02-18 16:30:40 -05:00
Michael Comella
07a1c4e9c9
Bug 1106935 - Remove new tablet branch in selecting default toolbar favicons. r=mhaigh
...
As a cleanup, this required the move of favicon -> favicon_globe and the
creation of new resources toolbar_favicon_default, which is aliased to
favicon_globe on phones.
2015-02-03 18:18:21 -08:00
vivek
7989430b18
Bug 847435 - Redesign tab history menu. r=bnicholson
2014-11-05 10:13:56 -08:00
Chris Kitching
5d126e171c
Bug 1081397: Finalise large numbers of fields. r=rnewman
...
* * *
Bug 1081397
2014-10-11 00:17:01 +01:00
Sriram Ramasubramanian
1974eed805
Bug 934001: ImageView's setImageBitmap() is worse. [r=mfinkle]
2013-11-01 15:56:41 -07:00
Sriram Ramasubramanian
8a25793eea
Bug 933459: Reduce drawables created for FaviconsView. [r=mfinkle]
2013-11-01 13:18:29 -07:00
Chris Kitching
4b5361b6e0
Bug 914296: Add more intelligent caching to the Favicons system. r=rnewman
2013-10-11 16:42:39 -07:00
Chris Kitching
649831247f
Bug 922116 - Don't clear FaviconView image data in formatImage. r=lucasr,margaret
2013-10-02 11:31:37 -04:00
Chris Kitching
c835c0bfc5
Bug 918917 - Show no favicon until load fails, then show default favicon, or the result (r=margaret)
2013-09-27 12:12:22 +01:00
Chris Kitching
1cd448bb6d
Bug 916588 - Show default favicon when we bail in FaviconView.formatImage. r=margaret
2013-09-18 13:47:35 -04:00
Lucas Rocha
04ec48d565
Bug 905685 - Clear favicon until the new image finishes loading in TwoLinePageRow (r=sriram)
2013-09-18 12:58:58 -04:00
Chris Kitching
2dfc46a57b
Bug 895423 - Use a FaviconView to display the icons for the customise search menu. r=liuche
2013-09-14 12:09:14 -07:00
Chris Kitching
f62447e490
Bug 888326 - Part 5: Make the FaviconView able to resize strangely sized inputs to more appropriate sizes, if enabled. r=mleibovic
2013-09-12 10:50:20 -04:00
Chris Kitching
8937b73a41
Bug 888326 - Part 2: Refactoring Favicons to be static, not a singleton - the singleton instance was staticly assigned and never cleared. r=mleibovic
2013-09-12 10:49:20 -04:00
Chris Kitching
399abf169d
Bug 888326 - Part 1: Move the favicons class into its own package and, while we're at it, get rid of unused imports in the touched files. r=mleibovic
2013-09-12 10:48:59 -04:00
Margaret Leibovic
734b657c0e
Bug 869634 - Update default favicon style. r=bnicholson
2013-05-09 09:51:53 -04:00
Margaret Leibovic
c4c6ceffd9
Bug 867627 - Speed up dominant color favicon backgrounds. r=bnicholson
2013-05-06 16:13:59 -04:00
Margaret Leibovic
ec9e009c09
Bug 839855 - Use dominant color as background for small favicons. r=wesj
2013-04-29 17:06:14 -07:00
Margaret Leibovic
d36baae4a2
Bug 839855 - Update tabs from last time favicons to match awesomescreen favicons. r=bnicholson
2013-04-29 17:05:55 -07:00
