Commit Graph

31 Commits

Author SHA1 Message Date
Michael Comella
cd19012d07 Bug 1155855 - Don't override animations when opening the browser from the share overlay. r=liuche
When used to do our own animation when opening the browser from the
share overlay. That caused this bug: we didn't call `finish` until
`onAnimationEnd` but since `startActivity` was called, the application
was switched before `onAnimationEnd`, and thus `finish`, could be
called. When we returned to the share overlay, it was in an unexpected
state (`isAnimating` was true) and the user could no longer interact
with it, blocking access to the app the ShareOverlay was opened from.

We fix this by not doing our custom animations and just calling `finish`.

Note: in any case, overriding the animation when opening the browser
could be unintuitive to users because they might expect a consistent
app-switch animation throughout the system.
2015-08-28 17:32:23 -07:00
Ahmed Khalil
02d98c1078 Bug 1178981 - Remove unused ParcelableClientRecord. r=nalexander 2015-07-01 13:18:00 -04:00
Ahmed Khalil
0cfc0b1786 Bug 1159020 - Move share overlay's access to sync to TabsProvider, r=nalexander
This includes a JUnit 3 test (not yet run in automation) to test this
functionality.
2015-05-28 14:39:16 -07:00
Nathan Toone
55b9d2c2a4 Bug 1161195 - Part 2: Rename variables. r=nalexander
Rename variables to be consistent with the name used in confvars.sh.
2015-05-05 20:11:15 -06:00
Jannis Pinter
f1f62db7dc Bug 1144807 - Moved variables to resources in OverlayDialogButton and made use of StateListDrawable. r=mcomella 2015-04-01 10:33:13 +02:00
Michael Comella
45f79e2253 Bug 1151089 - Move slide up animations to onResume. r=liuche
This should mean we do the slide up animation every time, not just when the
Activity is created.
2015-04-03 15:45:49 -07:00
Michael Comella
79b1fd368a Bug 1130203 - Reset the first item background drawable state onResume. r=mhaigh
The Activity can be re-used in Android L (bug 1137928) so we have to reset any
changed state.
2015-03-19 18:08:48 -07:00
Michael Comella
264739aad4 Bug 1130203 - Round the corners of the first item in the share overlay. r=mhaigh 2015-03-17 17:47:38 -07:00
Michael Comella
b26779ba88 Bug 1130203 - Remove Firefox logo from share overlay. r=mhaigh 2015-02-25 17:10:17 -08:00
Michael Comella
0b791d9b49 Bug 1130203 - Remove header container in share overlay & roughly style text. r=mhaigh
Removing the header container also has the benefit of improving performance by
flattening the View hierarchy. Note that this patch also improves performance
by switching the outermost container from a RelativeLayout to a FrameLayout.

Final text styling is awaiting UX mocks.
2015-02-05 19:29:01 -08:00
Michael Comella
df01b5c763 Bug 1145892 - Add null check in ShareDialog.handleSendTabUIEvent. r=rnewman 2015-03-20 16:30:05 -07:00
Michael Comella
c16489267a Bug 1122302 - Review: Address nits. r=me
Changes include indentation fixes, null checks, and renames.
2015-03-13 14:01:12 -07:00
Michael Comella
528345f9ae Bug 1122302 - Make the device list in the share overlay always show up only for the current channel. r=rnewman 2015-03-12 12:12:51 -07:00
Michael Comella
a2c7124a6f Bug 1122302 - Handle reusing the share overlay. r=rnewman
Ideally, we'd want to create a new instance of the share overlay on each call
but Android L changes the behavior and forces reuse (bug 1137928). Ugh.
2015-03-12 11:59:35 -07:00
Michael Comella
deaee82c6d Bug 1122302 - Add escape hatch in case clients list is empty in share overlay. r=rnewman 2015-03-04 15:01:43 -08:00
Michael Comella
3801bb8ca0 Bug 1122302 - Only show the device list when opening "Send to other devices" in Firefox. r=rnewman 2015-03-03 17:16:31 -08:00
Michael Comella
0e31126b82 Bug 1132720 - Hide the dialog on animation end to prevent flicker on Activity.finish(). r=margaret 2015-02-20 10:47:47 -08:00
Margaret Leibovic
32da62fa20 Bug 1123102 - Always create reading list panel, regardless of device memory capabilities. r=nalexander 2015-02-13 15:55:18 -08:00
Richard Newman
832cb9a1a3 Bug 1131257 - Part 1: split LocalReadingListDB out of LocalBrowserDB. r=margaret
Centralizing reading list access logic will make Bug 1130461 much easier. This bug is the first part of that.

We follow the same pattern as for URLMetadata, TabsAccessor, and Searches; BrowserDB hands over a single class that's specialized to handle the Reading List.
2015-02-10 16:42:13 -08:00
Richard Newman
b708878fb3 Bug 1109000 - Split statics out of BrowserLocaleManager. r=nalexander, a=java-only on a CLOSED TREE 2014-12-09 18:07:07 +00:00
Chris Kitching
366d3412f5 Bug 1061409: Telemetry for share overlays. r=rnewman 2014-09-06 20:30:50 -07:00
Richard Newman
9d0c3c4a96 Bug 1090385 - More robust handling of external intents. r=snorp 2014-10-28 14:28:31 -07:00
Richard Newman
62da9d987d Bug 1064263 - Part 1: avoid crash when Sync is partially configured. r=nalexander 2014-10-16 19:50:41 -07:00
Richard Newman
1a04d0632b Bug 1073010 - Allow browsing from share overlay. r=margaret 2014-10-14 17:05:31 -07:00
Richard Newman
8894240481 Bug 1077645 - Be paranoid when parsing external intent extras. r=snorp 2014-10-03 23:32:28 -07:00
Chris Kitching
6f4796faea Bug 1067543: Hide reading list add button from overlay on low memory devices. r=rnewman 2014-09-19 18:28:31 -07:00
Chris Kitching
8d5340936d Bug 1067025: Abort when no extra_text present in share dialog. r=rnewman 2014-09-14 21:49:45 -07:00
Chris Kitching
2f99fbaa56 Bug 1061721: Handle items already in bookmarks/reading list in overlays. r=rnewman 2014-09-05 16:53:51 -07:00
Chris Kitching
4698888f5e Bug 1061384: Colour tweaks for the share overlay. r=rnewman 2014-09-02 16:43:27 -07:00
Chris Kitching
454716adc7 Bug 1061685: Don't crash when we get a share with no URL r=rnewman 2014-09-02 16:29:12 -07:00
Chris Kitching
b4c4d69a3c Bug 1044947 - Frontend for share handler. r=rnewman 2014-08-25 04:24:47 -07:00