Commit Graph

16 Commits

Author SHA1 Message Date
Jim Chen
26c224bfb7 Bug 1200343 - Add native calls for pref events; r=snorp
This patch adds two native calls to PrefsHelper to avoid using
GeckoEvent for getting prefs.
2015-09-28 12:07:09 -04:00
Wes Kocher
090df7a4a5 Backed out 4 changesets (bug 1200343) for android talos failures
Backed out changeset 67dc42cbf02b (bug 1200343)
Backed out changeset b077acafcebb (bug 1200343)
Backed out changeset e115ca114601 (bug 1200343)
Backed out changeset 905e1fb54fd4 (bug 1200343)
2015-09-25 13:21:58 -07:00
Jim Chen
d406c38990 Bug 1200343 - Add native calls for pref events; r=snorp
This patch adds two native calls to PrefsHelper to avoid using
GeckoEvent for getting prefs.
2015-09-25 15:03:34 -04:00
Richard Newman
095f66d110 Bug 1118818 - Flush Gecko preferences when they change in Settings. r=bnicholson
This is the simplest and most durable option: when Settings (GeckoPreferences) sends a Preferences:Set message to Gecko, typically via PrefsHelper and a SharedPreferences change observer, we include a "flush": true field.

When browser.js handles Preferences:Set, it checks for this and flushes.

The scope of this change, then, is preferences changes within Settings; nothing else (e.g., turning on search suggestions) is affected.

I decided to do this rather than sending a flush message when leaving Settings for three reasons:

* One less message.
* No flushes if nothing changed.
* No data loss if we crash before the user completes the departure from Settings (e.g., they change something then hit the Android 'home' button).
2015-04-06 10:23:04 -07:00
Chris Kitching
16733ab9af Bug 1064644: Remove inner-access comments. r=rnewman 2014-09-08 18:11:51 -07:00
Chris Kitching
6c49e51198 Bug 1041836: Delete redundant initialisers. (generated) r=rnewman 2014-07-25 20:14:47 -07:00
Richard Newman
828df4c4d6 Bug 1041632 - Part 8: eliminate enclosing instance member access in PrefsHelper. r=ckitching 2014-07-21 10:24:15 -07:00
Jim Chen
e4d1c9a6fc Bug 1004073 - Refactor EventDispatcher usages; r=fennec-team 2014-05-02 14:34:40 -04:00
Lucas Rocha
e2520474a7 Bug 962968 - Replace HashMap with SparseArray in PrefsHelper (r=rnewman) 2014-01-23 19:00:06 +00:00
Nathan Froyd
d3295af55b Bug 906088 - part 5 - send preference requests to JS through JNI and XPConnect rather than JSON; r=blassey,mfinkle
Small fix to notifyPrefObservers to call getPreferences with the new argument style.
Carrying over r+.
2013-09-04 09:58:23 -04:00
Nathan Froyd
e21ade183c Bug 906088 - part 1b - add ArrayList getPrefs method to PrefsHelper; r=bnicholson
Related to the last patch, this is the lone place where we transfer an ArrayList.
Just move the code into PrefsHelper in case anybody ever wants to do something similar.
2013-09-04 09:57:49 -04:00
Chris Lord
cff3116ad3 Bug 846772 - Add prefs observing to PrefsHelper/browser.js on Android. r=kats 2013-03-12 18:32:25 +00:00
Ryan VanderMeulen
c8102cb870 Backed out 5 changesets (bug 846772) for Android reftest-3 orange on a CLOSED TREE. 2013-03-12 17:37:16 -04:00
Chris Lord
b67af6f05f Bug 846772 - Add prefs observing to PrefsHelper/browser.js on Android. r=kats 2013-03-12 18:32:25 +00:00
Brian Nicholson
1c31a98bcf Bug 845612 - Add @Override annotations for implemented interfaces. r=kats 2013-02-26 21:48:00 -08:00
Kartikaya Gupta
ab6b4da662 Bug 753312 - Extract a PrefsHelper class that manages getting/setting of gecko prefs, and updated existing code to use it. r=cpeterson 2012-09-17 14:22:28 -04:00