Commit Graph

170 Commits

Author SHA1 Message Date
Bobby Holley
53f8074964 Bug 1072150 - Use the opt-out for various sloppy consumers. r=bz 2015-09-24 14:02:41 -07:00
Chris Peterson
752223fd52 Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium 2015-09-22 21:39:03 -07:00
Nicholas Nethercote
2087a666fc Bug 1201135 - Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}. r=mccr8. 2015-09-15 20:49:53 -07:00
Nicholas Nethercote
5c81422b5c Bug 1121760 (part 3) - Remove PL_DHashTableRemove(). r=poiru. 2015-09-14 14:23:24 -07:00
Nicholas Nethercote
3bbd89a422 Bug 1121760 (part 2) - Remove PL_DHashTableAdd(). r=poiru. 2015-09-14 14:23:12 -07:00
Nicholas Nethercote
f9fdfba566 Bug 1121760 (part 1) - Remove PL_DHashTableSearch(). r=poiru. 2015-05-21 00:34:25 -07:00
Nicholas Nethercote
12fec02dfb Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
2015-08-27 20:44:53 -07:00
Nicholas Nethercote
4500bfa831 Bug 1170416 (part 3) - Remove the PLDHashTable2 typedef. r=froydnj. 2015-05-19 16:46:17 -07:00
Nicholas Nethercote
5aab44ed9b Bug 1166598 (part 3) - Use PLDHashTable2 in nsCommandParams. r=froydnj. 2015-05-05 18:23:39 -07:00
Andrew McCreight
e1ad9621ca Bug 1164049 - Fix some mode lines in embedding/. r=smaug
embedding/browser, embedding/components/commandhandler/, embedding/components/find/, embedding/components/windowwatcher/
2015-05-12 08:30:00 +02:00
Birunthan Mohanathas
93f2fcdcb0 Bug 1130096 - Convert embedding/components/commandhandler/ to Gecko style. r=mccr8 2015-05-11 12:35:14 -07:00
Mike Hommey
4d93988786 Bug 1134923 - Remove NS_Alloc/NS_Realloc/NS_Free. r=nfroyd
They are kept around for the sake of the standalone glue, which is used
for e.g. webapprt, which doesn't have direct access to jemalloc, and thus
still needs a wrapper to go through the xpcom function list and get to
jemalloc from there.
2015-05-01 09:40:30 +09:00
Trevor Saunders
2cab0ab3a9 bug 1146027 - more final r=froydnj 2015-03-24 17:51:43 -04:00
Nathan Froyd
26a0b56c7a Bug 1142503 - don't use QueryInterface when the compiler can do the cast for us; r=ehsan
Calling QueryInterface with a statically known IID should typically not
be necessary.  In those cases where it's not, the compiler can do the
cast for us, though we have to supply the reference-counting that
QueryInterface would do.

In passing, several redundant null-checks for the result of |new T| have
been deleted.
2015-03-12 09:43:50 -04:00
Nicholas Nethercote
3b0764a330 Bug 1131901 (part 1) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
2015-02-02 14:48:58 -08:00
Nicholas Nethercote
1ce96de5ae Back out changesets 2fcef6b54be7, 2be07829fefc, 66dfe37b8532, df3fcd2be8fd, 0a436bce77a6 (bug 1050035) for causing intermittent crashes and assertion failures. 2015-02-10 14:39:49 -08:00
Nicholas Nethercote
a3bf151ee6 Bug 1050035 (part 4) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
2015-02-02 14:48:58 -08:00
Nicholas Nethercote
c38455902a Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.

For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.

I'll do the trickier ones in subsequent patches.
2015-01-22 21:06:55 -08:00
Nicholas Nethercote
a7b8cb65b0 Bug 1124920 - Remove PLDHashTable::Operate(). r=froydnj. 2015-01-22 15:43:18 -08:00
Nicholas Nethercote
d746138aca Bug 1121304 (part 2, attempt 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj. 2015-01-14 14:35:56 -08:00
Phil Ringnalda
41e41579d9 Backed out 2 changesets (bug 1121304) for consistent b2g hangs in webgl-color-test.html?frame=1&__&preserve&premult&_____
Backed out changeset 20651ac19549 (bug 1121304)
Backed out changeset 758afec77c95 (bug 1121304)
2015-01-14 22:02:23 -08:00
Nicholas Nethercote
70f5bf6167 Bug 1121304 (part 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj. 2015-01-14 14:35:56 -08:00
Nicholas Nethercote
43fc26b699 Bug 1120476 (part 4) - Remove PLDHashTableOps::finalize. r=froydnj. 2015-01-13 19:02:35 -08:00
Nicholas Nethercote
eda870fe92 Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj. 2015-01-13 16:42:13 -08:00
Nicholas Nethercote
e50b60e3c8 Bug 1120476 (part 2) - Avoid using PLDHashTable::data in nsCommandParams. r=froydnj. 2015-01-13 16:40:47 -08:00
Michael Pruett
cbe37abc44 Bug 1118024 - Use new PL_DHashTable{Add,Lookup,Remove} functions. r=nfroyd 2015-01-05 20:27:28 -06:00
Neil Deakin
2e8bdbdfac Bug 1060529, send the enabled state of child process commands to the parent on update, without the test, r=smaug,ehsan 2014-12-09 10:48:27 -05:00
Wes Kocher
b1e13576b9 Backed out 2 changesets (bug 1060529) for introducing a new intermittent bc1 orange
Backed out changeset 5ddd9eb25925 (bug 1060529)
Backed out changeset d4f962fb38be (bug 1060529)
2014-12-08 16:40:55 -08:00
Neil Deakin
d6ba3abdad Bug 1060529, send the enabled state of child process commands to the parent on update, now with improved test, r=smaug,ehsan 2014-12-08 08:12:22 -05:00
Ehsan Akhgari
276d45afcd Bug 1061059 - Fix more bad implicit constructors in embedding; r=bsmedberg 2014-09-02 18:22:57 -04:00
Nicholas Nethercote
74de2855c1 Bug 1057914 (part 2) - Fix the style of nsCommandParams.{h,cpp}. r=ehsan. 2014-08-25 16:20:01 -07:00
Nicholas Nethercote
e68da95e21 Bug 1057914 (part 1) - Remove enumeration methods from nsICommandParams. r=ehsan. 2014-08-17 21:58:10 -07:00
Birunthan Mohanathas
a5df2a90cc Bug 1054703 - Part 3: Flatten embedding/components/commandhandler/{public,src}/ into parent directory. r=bsmedberg 2014-08-20 10:27:16 -07:00
Nicholas Nethercote
d888a69229 Bug 1050036 (part 2) - Fix leaks in nsCommandParams cause by a bad moveEntry() function for the pldhash. r=roc. 2014-08-17 15:42:20 -07:00
Nicholas Nethercote
663b82ea3b Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
* * *
imported patch rm-dummy-params
2014-08-06 06:31:21 -07:00
Mike Hommey
ea36b79845 Bug 1041860 - Avoid setting FINAL_LIBRARY to libraries that further use a FINAL_LIBRARY. r=mshal 2014-07-23 08:37:51 +09:00
Benoit Jacob
2f26b0839d Bug 1028588 - Fix dangerous public destructors in embedding/ - r=bsmedberg 2014-06-30 18:11:52 -04:00
Wes Kocher
8d34dc1b3b Backed out 4 changesets (bug 1028588) for build bustage
Backed out changeset 13a8bae671ca (bug 1028588)
Backed out changeset 19a19833f1d6 (bug 1028588)
Backed out changeset d5fae80054de (bug 1028588)
Backed out changeset 5942ad3859b8 (bug 1028588)
2014-06-30 15:50:19 -07:00
Benoit Jacob
660473eccc Bug 1028588 - Fix dangerous public destructors in embedding/ - r=bsmedberg 2014-06-30 18:11:52 -04:00
Anuj Agarwal
261ac869ed Bug 984123, part 2 - Converted nsTArray<char*> to nsTArray<nsCString>. r=ehsan 2014-05-13 09:46:37 -07:00
Andrew McCreight
867013f77c Backed out changeset 22994a1e0af4 for having the wrong author. 2014-05-13 09:45:41 -07:00
Andrew McCreight
656fb1c608 Bug 984123, part 2 - Convert nsTArray<char*> to nsTArray<nsCString>. r=ehsan 2014-05-13 09:42:41 -07:00
Anuj Agarwal
60d4d7a43b Bug 984123, part 1 - Convert nsControllerCommandGroup::mGroupsHash and nsGroupsEnumerator::mHashtable to nsClassHashtable. r=ehsan 2014-05-13 09:42:41 -07:00
Bobby Holley
4a34fb9f37 Bug 997987 - Cache the system principal on nsContentUtils and remove nsIScriptSecurityManager::SubjectPrincipalIsSystem. r=Ms2ger,sr=bz 2014-05-06 15:43:03 -07:00
Birunthan Mohanathas
eeb9aaaa94 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Arpad Borsos
8452f32624 Bug 474369 - remove nsVoidArray includes; r=ehsan 2014-04-26 16:12:45 +02:00
Andrew McCreight
e75a4dc110 Bug 998779 - Remove unused #includes of nsHashtable.h. r=froydnj 2014-04-21 09:41:58 -07:00
Andrew McCreight
aded529f53 Bug 962608 - Make PL_DHashTableInit infallible by default. r=briansmith,bsmedberg,ehsan,froydnj,jduell,jfkthame,roc,smaug 2014-02-27 10:04:09 -08:00
Andrew McCreight
f2ca92fc76 Bug 967999, part 2 - Convert nsControllerCommandTable::mCommandsTable to use nsInterfaceHashtable. r=ehsan 2014-02-11 14:56:45 -08:00
Andrew McCreight
2b08c478d3 Bug 967999, part 1 - Remove some trailing whitespace from nsControllerCommandTable. r=ehsan 2014-02-11 14:56:44 -08:00