Commit Graph

11666 Commits

Author SHA1 Message Date
chanial@noos.fr
01a921b431 - fix regression 221118: Can't drag links into bookmark manager or bookmark sidebar.
- logic change: a transaction will not be performed when one of its item can not be acted on. Before, the only the valid items were processed. A LOT of simplifications have come up. I am slowly moving toward the resolution of bug 168411, by simplifying the interface that will be needed to move the transactions to the bookmarks service.
- fix bug 221550: the selection is not retained when performing an invalid transaction
- no need to restore the selection after an action that doesn't touch the datasource.
- during a batch, the bookmarks toolbar observer wasn't notified.
- much faster preUpdateTreeSelection
- various code cleanup
- DND bookmarks in tree is now significantly faster.
- still need to figure out what is the best BATCH_LIMIT value.
2003-10-08 09:01:48 +00:00
chanial@noos.fr
67a79e71eb checking in back the fix for bug 172113.
an additional fix is included: if no ...#BookmarksToolbarFolder arc is found, then search for an (obsolete) resource "NC:PersonalToolbarFolder" (221410).
When none of them is found, then a new btf is created (only once!).
2003-10-08 08:17:23 +00:00
chanial@noos.fr
a163ed48c9 For the next cycles: backing out the changes for bug 172113 to investigate perf because I landed them just after the tinderbox went down and also because large landings occurred before it went up. 2003-10-08 04:45:29 +00:00
chanial@noos.fr
d28be3c644 - bug 172113: rewrite the way we handle the bookmarks toolbar folder. Now, there is no more 2 ways to characterize the BTF: by an arc to the resource "...#BookmarksToolbarFolder" that points to the literal "true". As a consequence, the resource NC:PersonalToolbarFolder and "...#folderType" are dead.
- remove unused functions. Note that RDF commands were already broken, so deleteBookmarkItem and insertBookmarkItem (that were not used) may come back, but in another form.
- remove the "New Bookmark Folder" and "New Search Folder"
- refactor the "html" serializer to avoid some duplicated code.
- remove the use of the profile name for the bookmarks root.
- enforce synthax "aArgument" in some random places.
2003-10-03 20:30:14 +00:00
chanial@noos.fr
51a8082b59 - code level cleaning up of bookmarksProperties.js
- fixing a potential crash in nsBookmarksService::GetTarget (when the RDF resource is null)
- remove unused function isChildOfContainer and GetResource in bookmarks.js though we may need later the latter.
2003-09-30 16:16:56 +00:00
chanial@noos.fr
d86477c8f7 fixing bustage by putting back placeholders for AddBookmarkImmediately and IsBookmarked since they are used in nsInternetSearchResult.cpp.
I'll fix later these useless callers.
2003-09-30 15:56:16 +00:00
chanial@noos.fr
95d2ef0813 - adding bookmark/separator in the bookmark manager now calls the property dialog for consistency with the folders.
- fix the use of the immutable bookmarks.
- remove unused methods: GetLastCharset and AddBookmarkImmediately
- porting several small fixes mainly from Jan's work
- more prototyping for BookmarkTransaction
2003-09-29 21:43:11 +00:00
bryner@brianryner.com
0808ae905d Updating my email address 2003-09-29 06:04:02 +00:00
asa@mozilla.org
f92ffd27b2 Follow-up checkin to bug 165653.
Drop Firebird's dependency on Gecko's DOM for the sidebar; it should provide it itself.
Patch=caillon
r=bryner
sr=jst
2003-09-26 23:45:44 +00:00
ben@bengoodger.com
29d70ad6c6 Fix Firebird bugs
217195 (patch by Jesse Ruderman) - security hole in markLinkVisited (exploited with link.href usage)

219875 (patch by Mike Connor) - localize strings for provisional security UI in Advanced Options panel
2003-09-23 19:34:25 +00:00
noririty@jcom.home.ne.jp
8392a7f8a8 Fix 213994 - hide incompatible themes. Patch by mpconnor@rogers.com 2003-09-12 21:00:01 +00:00
ben@bengoodger.com
9216487d36 Move "Fonts & Colors" from Web Features to General 2003-09-12 07:23:36 +00:00
bryner@brianryner.com
07be0d6849 Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan. 2003-09-07 21:37:51 +00:00
ben@bengoodger.com
19bb48a69b oops, add these styles back 2003-09-02 08:37:35 +00:00
ben@bengoodger.com
d8a2c1d504 Change "Settings..." to "Options..." to be consistent with our use of configuration labels. 2003-09-02 05:14:17 +00:00
ben@bengoodger.com
4b0c1d5fa3 Fixing broken preferences dialog by backing out 213994 2003-08-31 07:30:46 +00:00
ben@bengoodger.com
6dfce43dca Tidy up expander action 2003-08-31 07:22:30 +00:00
blakeross@telocity.com
73b7f57b62 Slightly better patch. 2003-08-28 23:23:30 +00:00
noririty@jcom.home.ne.jp
287227de01 fixing button focus regression 2003-08-28 15:11:38 +00:00
blakeross@telocity.com
f0f7034bbd Undo versioning changes for now. Gotta think it through. 2003-08-28 05:56:32 +00:00
blakeross@telocity.com
5e3cdc3440 217410 - Change skin/locale versions to fb0.7. 2003-08-28 02:16:27 +00:00
blakeross@telocity.com
d26a8f3583 Hacky workaround for bug 210910 -- to be removed after 0.7. 2003-08-27 19:03:27 +00:00
ben@bengoodger.com
3ac2716a76 b215898 - Provisional Security UI for Firebird .7. Also reintroduce some XUL blake removed, but commented out. 2003-08-27 17:52:04 +00:00
ben@bengoodger.com
9a5f478e96 Moving downloads options UI to new mozapps application support package that will live for now over in toolkit/mozapps so that thunderbird can share the new downloading options. 2003-08-25 22:21:31 +00:00
ben@bengoodger.com
72d4cbd51f Move downloading options UI to new mozapps application support package that is stored for now in toolkit/mozapps so that thunderbird can pick up the new downloading options. 2003-08-25 22:12:41 +00:00
blakeross@telocity.com
00a38af090 undo last change. 2003-08-25 07:12:38 +00:00
blakeross@telocity.com
67a3ad5673 Focus the textbox when the dialog is opened. 2003-08-25 05:04:56 +00:00
blakeross@telocity.com
0d17a4f9a6 A little polish in the exceptions window (clear and focus the textbox after adding a site) 2003-08-24 18:22:00 +00:00
noririty@jcom.home.ne.jp
025a0e7e19 Fix - 172778 fix overflow of progress percentage. Patch by mook_moz@yahoo.com 2003-08-24 14:13:00 +00:00
blakeross@telocity.com
f55bed9128 A little more clean-up...still work to do. 2003-08-24 04:58:23 +00:00
blakeross@telocity.com
43c6152641 An attempt to make the preferences UI a little easier/less cluttered. The styling, the functionality--all this is subject to change as we explore what to do with this panel. 2003-08-24 04:50:59 +00:00
blakeross@telocity.com
7786836b59 ick...ick ick ick. Try to fix preferences. 2003-08-24 01:01:46 +00:00
blakeross@telocity.com
1840ea44ca Persist window size/position. 2003-08-23 19:03:28 +00:00
blakeross@telocity.com
ac8802fea7 Fixing some reported bugs. 2003-08-23 18:20:07 +00:00
chanial@noos.fr
8906e9d31b fixing bustage: pref-features-images.properties is not used and is not in the repository 2003-08-23 11:47:27 +00:00
blakeross@telocity.com
d5b4cc7fdc Add a little error checking. 2003-08-23 09:29:55 +00:00
blakeross@telocity.com
dc52424c9a Lots of preferences changes. The main new things:
- implement cookie whitelisting
- split up cookie manager
- make popup, image and cookie lists behave like other prefs, i.e., don't save them until you hit OK in prefs (so, for example, removing all cookies is no longer a "live" change).

I expect bugs =)
2003-08-23 09:23:36 +00:00
blakeross@telocity.com
ab29c7f3ae adding placeholder file 2003-08-23 09:19:34 +00:00
blakeross@telocity.com
14eccb1058 adding placeholder 2003-08-23 09:15:29 +00:00
noririty@jcom.home.ne.jp
8b65a7e1a0 actually fixing typo 2003-08-22 18:16:00 +00:00
noririty@jcom.home.ne.jp
db11717d1a fix more strict warning for popup whitelisting UI 2003-08-22 14:54:28 +00:00
noririty@jcom.home.ne.jp
4717bc7bbc code clean up. 2003-08-22 14:49:52 +00:00
noririty@jcom.home.ne.jp
821ee2d4e0 fix typo b=174594 2003-08-21 15:57:22 +00:00
noririty@jcom.home.ne.jp
3880a1644c Fix 208104 add percent to download sidebar. Patch by admin@mozillatranslator.org 2003-08-21 15:00:41 +00:00
noririty@jcom.home.ne.jp
69867bb1b2 Fix 172735 - fix JS error 2003-08-21 14:56:42 +00:00
noririty@jcom.home.ne.jp
f9bb3d78ae Fix 174594 - Popup whitelisting UI bustage. Patch by mpconnor@rogers.com 2003-08-21 13:24:44 +00:00
noririty@jcom.home.ne.jp
26a3765924 Fix 207601 - Add Find As You Type prefs. Patch by mpconnor@rogers.com 2003-08-20 19:08:20 +00:00
noririty@jcom.home.ne.jp
caf148b39d Fix 216719 - Update themes and extensions page uris 2003-08-20 01:58:29 +00:00
noririty@jcom.home.ne.jp
f4fd2d34b3 Fix 215745 - Inconsistent ellipsis. Patch by borggraefe@despammed.com 2003-08-19 14:54:44 +00:00
chanial@noos.fr
254ba8f026 port textbox fix for bug 197486:
callback method in textbox is no more, use oncommand instead for the same functionality.
2003-08-17 11:17:00 +00:00