The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):
- Never set the buffer's mode.
Years ago, Emacs did not have a good JavaScript mode, so it made sense
to use Java or C++ mode in .js files. However, Emacs has had js-mode for
years now; it's perfectly serviceable, and is available and enabled by
default in all major Emacs packagings.
Selecting a mode in the -*- file variable line -*- is almost always the
wrong thing to do anyway. It overrides Emacs's default choice, which is
(now) reasonable; and even worse, it overrides settings the user might
have made in their '.emacs' file for that file extension. It's only
useful when there's something specific about that particular file that
makes a particular mode appropriate.
- Correctly propagate settings that establish the correct indentation
level for this file: c-basic-offset and js2-basic-offset should be
js-indent-level. Whatever value they're given should be preserved;
different parts of our tree use different indentation styles.
- We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
Remove tab-width: settings, at least in files that don't contain tab
characters.
- Remove js2-mode settings that belong in the user's .emacs file, like
js2-skip-preprocessor-directives.
this is needed for bug #380735, for when we persist day and host container
open state in the history sidebar.
additionally, call load() instead of using .place directly to avoid doing queriesToQueryString() only to call queryStringToQueries().
r=mano
add "show sessions" to the history query options, so that we can disable it.
by default, disable sessions for the history-on-places sidebar (as we are initially going for Firefox 2.0 parity on top of places.)
To enable sessions, toggle the hidden "browser.history.showSessions" boolean pref.
Thanks to Dan Mills <thunder@mozilla.com> for the fix.
r=sspitzer,gavin
make MOZ_PLACES (if enabled) only build the places based history UI, use MOZ_PLACES_BOOKMARKS to turn off the places based bookmarks UI.
also addresses bugs:
bug #330923: "View -> Sidebar menu" is empty if you build with places
bug #355738: implement history sidebar on top of places backend
bug #356175: hook up the history menu to the places backend
bug #356453: add back "Clear Private Data" menu item
bug #356630: add back "History | Show in Sidebar" menu item
bug #356631: remove "search in history" and "view all history" menu items
bug #357301: add back history and bookmark sidebar toolbar button items, remove places toolbar button
bug #358831: history sidebar, right mouse button click should not expand / collapse item
r=dietrich, r=gavin
