Commit Graph

448 Commits

Author SHA1 Message Date
Kelly Cochrane
cae199c0f2 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao
Differential Revision: https://phabricator.services.mozilla.com/D233098
2025-02-05 18:04:20 +00:00
Emilio Cobos Álvarez
f592072c68 Bug 1946016 - Don't be explicit about window size when detaching tabs on Linux. r=dao,tabbrowser-reviewers
Let Gecko choose a suitable size. This seems to result in the desired
behavior (same as Ctrl+N). Tested GNOME and Kwin, X11 and Wayland.

The reason for the behavior change here is because `outerWidth` before
the regressing patch returned the inner, not the outer width. Combined
with the pre-existing behavior that decorations are added asynchronously
by the window manager, it just happened to conveniently cancel out that
bug, which is now fixed.

It's unclear we need this at all on macOS fwiw. IIRC Cmd+N does also the
same thing as Windows, so maybe we can remove this block altogether.

Separate patch tho, as I don't have a macOS build ready to test it this
very moment, but I think it should just work.

Differential Revision: https://phabricator.services.mozilla.com/D236867
2025-02-05 17:02:24 +00:00
Stanca Serban
0efa589b90 Backed out changeset 1be8354cedcd (bug 1930201) for causing mochitests failures. CLOSED TREE 2025-02-05 19:11:28 +02:00
Dão Gottwald
84d41371c1 Bug 1935022 - Wait for two animation frames before tracking mouse movement in the ctrl-tab panel. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D236854
2025-02-05 14:10:40 +00:00
Kelly Cochrane
03c6b75a99 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao
Differential Revision: https://phabricator.services.mozilla.com/D233098
2025-02-05 14:05:08 +00:00
Dão Gottwald
fda9eb5278 Bug 1945264 - Let related new tabs inherit the current tab group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236731
2025-02-04 23:32:36 +00:00
Dão Gottwald
de0ae0ca64 Bug 1943589 - Allow adoptTab to adopt tabs into a tab group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236722
2025-02-04 19:32:43 +00:00
DJ
7a91af273e Bug 1942347 - Disable 'move group to new window' if group is only thing in window. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236717
2025-02-04 16:57:19 +00:00
Emma Zuehlcke
c4bd8080a9 Bug 1866661, r=hjones,reusable-components-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D235457
2025-02-04 14:26:29 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Nick Grato
00132688f5 Bug 1944154 - State Machine for tab states r=tabbrowser-reviewers,dao
To prep for the transition of code migrating from Larch to Central, for STG (Smart Tab Grouping), the best technique would be to implement peace by peace not to overwhelm a single patch.

This bug is the beginning of said work by setting the ground work for the state machine that manages the many additional states used by the STG feature.

Differential Revision: https://phabricator.services.mozilla.com/D235712
2025-02-03 18:11:17 +00:00
DJ
b8dcc05a73 Bug 1944733 - fix caller window for open-tab-group-context-menu_moveToNewWindow. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236087
2025-02-03 15:41:48 +00:00
Dão Gottwald
ae8e1343e4 Bug 1945440 - Fix tab drag and drop in RTL mode. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236512
2025-02-03 14:21:52 +00:00
Dão Gottwald
bc676fe35e Bug 1943971 - Let moving tabs to start/end not keep or put them in groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236318
2025-02-03 10:15:25 +00:00
Dão Gottwald
0093579918 Bug 1945118 - Revert change from bug 1944844 and fix differently, by having #triggerDragOverCreateGroup update dragData. r=dwalker,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236343
2025-01-31 14:22:14 +00:00
Dão Gottwald
69404071c4 Bug 1936282 - When using the tab context menu to create a group from the all tabs panel, make sure we close that panel so that it doesn't obscure the tab group creation panel. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236160
2025-01-31 06:49:38 +00:00
Goloman Adrian
1527be7ffd Backed out changeset bb54bd88c1ec (bug 1936282) for causing bc failures @browser_tab_groups.js. CLOSED TREE 2025-01-30 23:30:56 +02:00
Dão Gottwald
4d47d13ad1 Bug 1943885 - Pinning first tab should ungroup it. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236212
2025-01-30 17:01:11 +00:00
Butkovits Atila
47e8c80ae0 Backed out changeset 2e12f5d5b652 (bug 1944733) for causing failures at browser_tab_manager_groups.js. CLOSED TREE 2025-01-30 18:13:15 +02:00
Dão Gottwald
106b2aad45 Bug 1936282 - When using the tab context menu to create a group from the all tabs panel, make sure we close that panel so that it doesn't obscure the tab group creation panel. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236160
2025-01-30 14:49:12 +00:00
Dão Gottwald
89a390256e Bug 1944844 - Set dropElement before returning early. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D236159
2025-01-30 14:44:07 +00:00
DJ
cf0f30d512 Bug 1944733 - fix caller window for open-tab-group-context-menu_moveToNewWindow. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D236087
2025-01-30 13:06:56 +00:00
Jonathan Sudiaman
70919ebe73 Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs r=sidebar-reviewers,fluent-reviewers,tabbrowser-reviewers,dao,bolsson,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D236035
2025-01-29 23:29:40 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
2025-01-29 19:09:19 +00:00
Dão Gottwald
a49bb76e1e Bug 1932489: Drag/drop based on "element index" instead of tab index. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234804
2025-01-29 18:37:29 +00:00
Dão Gottwald
ff4e18557b Bug 1944555 - Update triage rotation to account for Stephen's leave. r=mossop,tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D235966
2025-01-29 14:46:54 +00:00
DJ
8d61f15c5c Bug 1943032 - Localize tabgroup aria-label and description. r=dao,fluent-reviewers,tabbrowser-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D235640
2025-01-28 14:51:28 +00:00
Dão Gottwald
5e253e3ce8 Bug 1944083 - Clicking outside the tab group create panel should keep the new group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235667
2025-01-28 11:39:14 +00:00
Butkovits Atila
b76f85c5bf Backed out changeset 8fc3326bce7f (bug 1943032) for causing failures at browser_tab_groups_a11y.js. CLOSED TREE 2025-01-28 07:57:01 +02:00
DJ
c120fd16a2 Bug 1943032 - Localize tabgroup aria-label and description. r=dao,fluent-reviewers,tabbrowser-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D235640
2025-01-28 04:44:31 +00:00
Dão Gottwald
6f30f874cf Bug 1940269 - Place a "Show more" button in tab overflow menu in tab groups section if there's more than 6 tab groups. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D235422
2025-01-25 00:49:15 +00:00
Dão Gottwald
f32e1c5b18 Bug 1943635 - Set tooltips on color options in the tab group panel. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D235464
2025-01-24 23:27:41 +00:00
Dão Gottwald
4f0670fdb8 Bug 1940335 - Add tooltips to tab groups in the tab overflow menu to expose tab group states in an accessible way, besides group icons. r=dwalker,fluent-reviewers,tabbrowser-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D235337
2025-01-24 11:53:47 +00:00
Stanca Serban
149deaac25 Backed out 3 changesets (bug 1325876) for causing Linux related puppeteer failures. CLOSED TREE
Backed out changeset 2dcbd388c95f (bug 1325876)
Backed out changeset ba3a433729a6 (bug 1325876)
Backed out changeset 42f5ed6abce5 (bug 1325876)
2025-01-24 03:47:23 +02:00
Sean
5f0c924ed3 Bug 1325876 - Add a pref for showing error page for HTTP responses with error codes and Content-Length: 0 r=necko-reviewers,valentin,credential-management-reviewers,tabbrowser-reviewers,dimi,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D232429
2025-01-23 21:57:38 +00:00
DJ
6c42b70610 Bug 1940981 - fix permafail in browser_tab_manager_groups.js. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235318
2025-01-23 15:28:30 +00:00
Emilio Cobos Álvarez
77261b9adc Bug 1943301 - Simplify tab throbber animation syncing. r=dao,tabbrowser-reviewers
We just need to make sure all the throbber animations share a start
time, and we can use an arbitrary time (i.e., zero) rather than going
through all the tabs.

Differential Revision: https://phabricator.services.mozilla.com/D235300
2025-01-23 15:02:01 +00:00
Dão Gottwald
ff3720f743 Bug 1942170 - Properly label tab group color radio buttons. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D234965
2025-01-22 12:45:40 +00:00
Jeremy Swinarton
4c0ff4a071 Bug 1940752: 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234680
2025-01-21 23:07:02 +00:00
Dão Gottwald
f88b753dc2 Bug 1942156 - Fix tab group dialog's role and name. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234954
2025-01-21 15:23:55 +00:00
Dão Gottwald
44026bd308 Bug 1921034 - Remove bug reference. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D234949
2025-01-21 12:45:36 +00:00
Dão Gottwald
c4a94bbaa7 Bug 1942176 - Handle context menu key for tab group labels, r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234668
2025-01-20 15:25:23 +00:00
DJ
857429c48c Bug 1937856 - prevent saving tab groups with only discarded tabs. r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234505
2025-01-17 14:46:24 +00:00
Shane Hughes
65116b6a5c Bug 1941391 - Check for popups before opening tab preview panel. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234085
2025-01-17 14:32:44 +00:00
Dão Gottwald
602f317a6a Bug 1941645 - Stop scrolling to the selected tab when collapsing/expanding a group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234326
2025-01-17 11:48:38 +00:00
Joel Maher
bcc50efbeb Bug 1940980 - Green up win11-64 opt/debug/asan/ccov. r=aryx,media-playback-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,urlbar-reviewers,aosmond,mconley,ochameau,dimi,jteow,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D233862
2025-01-16 23:02:48 +00:00
Greg Stoll
96e0daa1a5 Bug 1926396 - when unloading current tab, don't switch to an unloaded tab r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D234569
2025-01-16 19:53:09 +00:00
Dão Gottwald
9ba878fc03 Bug 1941832 - In the all tabs menu, sort saved groups by when they were closed. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234355
2025-01-16 15:21:07 +00:00
Alexandru Marc
3f4b115f67 Bug 1903733 - Disable browser_tab_manager_keyboard_access.js on linux1804 opt for frequent failures r=intermittent-reviewers,tabbrowser-reviewers,jmaher,dao DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D234400
2025-01-16 12:50:32 +00:00