corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
894,175 Commits 1 Branch 0 Tags
cae199c0f215be80d656d34a19dfe2a5e53ff11a
Commit Graph

354 Commits

Author SHA1 Message Date
Rebecca King
ddcdf53352 Bug 1938421 - Implement callout 6 for RC in the sidebar, when a user closes RC - r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D235003
 2025-02-03 22:55:31 +00:00
Sandor Molnar
603aa1973c Backed out changeset d98b62477b98 (bug 1904441) for causing bc failures & assertion failures @ browser_messagepreview_receivemessage.js / nsContentSecurityUtils.cpp CLOSED TREE 2025-02-03 23:36:24 +02:00
Emily McMinn
b0ba7f9890 Bug 1904441 - Add test suite to about:messagepreview r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D222032
 2025-02-03 17:18:47 +00:00
Mike Conley
6db006549f Bug 1938452 - Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce 
Differential Revision: https://phabricator.services.mozilla.com/D233874
 2025-02-03 16:45:33 +00:00
Mike Conley
0cab9e0390 Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount 
This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873
 2025-02-03 16:45:33 +00:00
Mike Conley
829da877ed Bug 1938452 - Move newtab documentation to browser/extensions/newtab. r=omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,pdahiya,mossop,amy 
Differential Revision: https://phabricator.services.mozilla.com/D233866
 2025-02-03 16:45:30 +00:00
Alexandru Marc
88e7c19d5c Backed out 10 changesets (bug 1938452) for causing node failures CLOSED TREE 
Backed out changeset f6a771e83261 (bug 1938452)
Backed out changeset 69f385bc90ce (bug 1938452)
Backed out changeset 9c8837fc4805 (bug 1938452)
Backed out changeset c9737e213e42 (bug 1938452)
Backed out changeset ac0a50aaf347 (bug 1938452)
Backed out changeset f1f41e902e36 (bug 1938452)
Backed out changeset aef74a3d077d (bug 1938452)
Backed out changeset 8ca1a633192a (bug 1938452)
Backed out changeset 88df910fa038 (bug 1938452)
Backed out changeset cd4fdafb2594 (bug 1938452)
 2025-02-03 18:28:59 +02:00
Mike Conley
661a090489 Bug 1938452 - Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce 
Differential Revision: https://phabricator.services.mozilla.com/D233874
 2025-02-03 15:07:11 +00:00
Mike Conley
5cc1e5190e Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount 
This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873
 2025-02-03 15:07:10 +00:00
Mike Conley
b75d1059ab Bug 1938452 - Move newtab documentation to browser/extensions/newtab. r=omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,pdahiya,mossop,amy 
Differential Revision: https://phabricator.services.mozilla.com/D233866
 2025-02-03 15:07:08 +00:00
negin
746f501995 Bug 1939921 - [FxMS Docs] Adds Triggers and User Actions, schema links under Messaging System source doc r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D234904
 2025-01-30 17:29:15 +00:00
Emily McMinn
c749a0b825 Bug 1944103 - Refine targeting for tab groups onboarding messages r=omc-reviewers,dao,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D235698
 2025-01-29 22:15:28 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn 
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
 2025-01-29 19:09:19 +00:00
Emily McMinn
da797a5490 Bug 1943442 - Land onboarding callouts for Tab Groups r=omc-reviewers,aminomancer,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D235376
 2025-01-24 21:56:55 +00:00
Meg Viar
7dca8efc49 Bug 1941807 - Add ability to toggle AboutWelcome screen content by clicking a configurable header r=omc-reviewers,jprickett 
Support a second variant of the preonboarding modal design by adding the ability to configure a header that toggles visiblity of content tiles.

- See design for [[ https://docs.google.com/presentation/d/1dDC9M9y-W3q90mkVRp4gq3p-x3u7F6qgy0jVeE4MwUw/edit#slide=id.g325219d6753_0_95 | modal Variant B ]]

Differential Revision: https://phabricator.services.mozilla.com/D235325
 2025-01-24 13:30:07 +00:00
Punam Dahiya
a7b627a8a4 Bug 1942895 - Move FilterAdult into shared browser/modules folder r=home-newtab-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D235259
 2025-01-23 23:07:57 +00:00
Punam Dahiya
0628dbd0a7 Bug 1937172 - Remove SectionManager and TopSitesFeed dependancy on ASRouterStorage r=home-newtab-reviewers,omc-reviewers,mconley,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D234447
 2025-01-23 21:32:23 +00:00
Tooru Fujisawa
8084bcd8ca Bug 1881888 - Part 10: Remove ChromeUtils.import. r=Standard8,mccr8,profiler-reviewers,omc-reviewers,home-newtab-reviewers,julienw,mconley,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D233722
 2025-01-23 05:21:58 +00:00
Tooru Fujisawa
ac7fdd6102 Bug 1881888 - Part 9: Remove ChromeUtils.defineModuleGetter. r=Standard8,mccr8,profiler-reviewers,omc-reviewers,home-newtab-reviewers,julienw,mconley,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D233721
 2025-01-23 05:21:58 +00:00
Tooru Fujisawa
6de3931fde Bug 1940422 - Remove XPCOMUtils.defineLazyModuleGetters. r=mccr8,credential-management-reviewers,omc-reviewers,home-newtab-reviewers,mconley,pdahiya,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D233379
 2025-01-23 05:21:54 +00:00
Punam Dahiya
4f67dc494e Bug 1937170 - Transfer ownership of ActivityStreamStorage to ASRouter r=backup-reviewers,home-newtab-reviewers,omc-reviewers,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D234113
 2025-01-22 05:59:40 +00:00
Punam Dahiya
59e4ab14a7 Bug 1937166 - Decouple ASRouter from NewTab TelemetryFeed r=home-newtab-reviewers,omc-reviewers,aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D233458
 2025-01-21 18:56:18 +00:00
Meg Viar
645b9b4605 Bug 1942323 - Add carat icon to Content Tile headers and ensure proper border-radius on headers above non-toggleable tiles r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D234731
 2025-01-21 18:43:09 +00:00
Emily McMinn
3748e6bed5 Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer,negin 
Differential Revision: https://phabricator.services.mozilla.com/D233953
 2025-01-20 21:31:06 +00:00
Sandor Molnar
2d18e11253 Backed out changeset 232515e209c7 (bug 1940476) for causing bc failures @ browser_asrouter_trigger_docs.js 2025-01-18 07:46:06 +02:00
Emily McMinn
f4e1bff7e4 Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D233953
 2025-01-18 00:02:55 +00:00
kpatenio
4f78e49bfd Bug 1925408 - add illustrations for opt-in UI. r=shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson,fchasen,pdahiya 
- Adds new illustrations and copy
- Shows a variant using emptyStateB for supported sites and PDPs
- Shows a variant using emptyStateC for unsupported sites
- To test the feature, set browser.shopping.experience2023.integratedSidebar=true, browser.shopping.experience2023.shoppingSidebar=true. Also set browser.shopping.experience2023.optedIn=0.
- To see the variant with emptyStateB, go to any page within amazon.com, bestbuy.com or walmart.com.
- To see the variant with emptyStateC, go to any page that's not amazon, bestbuy or walmart.
- Added tests to distinguish between empty state variants for the opt-in screen

Differential Revision: https://phabricator.services.mozilla.com/D226075
 2025-01-17 01:52:35 +00:00
Norisz Fay
149fb6e550 Backed out changeset 6d26e856d73e (bug 1940476) for causing xpcshell failures on test_backgroundtask_targeting.js 2025-01-16 23:43:14 +02:00
Emily McMinn
418d1decfb Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D233953
 2025-01-16 19:28:08 +00:00
Meg Viar
9e8ae04a1b Bug 1936656 - Add ability to show multiple content tiles on a single aboutwelcome screen with option to toggle visibility r=emcminn,omc-reviewers,jprickett 
**Primary Updates**
- Add ability to show multiple content tiles on a single AboutWelcome screen by supporting an array of tile objects and/or sub-arrays of tile objects to be groups together as a value for "tiles" in screen content
- Keep compatibility with messages that use a single tile object as the value of "tiles" in screen content
- Add updates to `setMultiSelectActions` to ensure we can handle actions across multiple MultiSelect tiles.
- Add optional tile headers which can be displayed in place of the tile until clicked, closing any other tile with a header that's currently open
- Send click event telemetry when a user clicks a tile header to open the tile
- Update aboutwelcome source docs related to content tiles to include this new capability

**Additional Updates to Support UX Designs**
[[ https://www.figma.com/design/F63Ac1akw2q1fN5D59rgS5/Privacy?node-id=4110-16458&t=kSzPUp4XFLq0dKg8-4 |
See Figma designs ]]
- Add ability to configure `display`, `padding`, and `width` for aboutwelcome screens (this allows us to support the proposed Spotlight modal designs, which include anchoring the modal towards the top of the screen and expanding it downward when a tile is opened, rather than centering vertically)
- Add ability to configure action buttons to show above screen content

{F11717546}

Differential Revision: https://phabricator.services.mozilla.com/D231856
 2025-01-15 16:29:23 +00:00
Punam Dahiya
a0ac6c95d0 Bug 1940141 - Move resourceUriPlugin from browser/components/newtab into a common location r=home-newtab-reviewers,omc-reviewers,mconley,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D234066
 2025-01-14 17:14:12 +00:00
Emily McMinn
efeb1ce68d Bug 1938446 - Land illustrations & animations for Tab Groups callouts r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D233445
 2025-01-13 18:48:32 +00:00
Punam Dahiya
8050d3e240 Bug 1939918 - Remove newtab utils dependancy in aboutwelcome and asrouter karma unit tests r=omc-reviewers,mconley,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D233428
 2025-01-13 17:52:42 +00:00
Cosmin Sabou
efae93e17d Backed out 2 changesets (bug 1938446, bug 1919598) for causing failures on browser_tabnotificationbox_switch_tabs and conflicts. CLOSED TREE 
Backed out changeset be28df34cc76 (bug 1938446)
Backed out changeset ffa630d286bb (bug 1919598)
 2025-01-11 01:58:14 +02:00
Emily McMinn
b2b5a8709e Bug 1938446 - Land illustrations & animations for Tab Groups callouts r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D233445
 2025-01-10 21:50:48 +00:00
negin
34caedb5e0 Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud 
Differential Revision: https://phabricator.services.mozilla.com/D229198
 2025-01-10 21:31:18 +00:00
Cosmin Sabou
05bc4c0400 No bug - correct some typos in manifest files. a=typo-fix 
CLOSED TREE
 2025-01-10 23:43:19 +02:00
Punam Dahiya
f52a594a1a Bug 1866170 - Give about:welcome and asrouter their own try-runner.js test job runner scripts r=home-newtab-reviewers,omc-reviewers,mviar,mconley,ahal 
Differential Revision: https://phabricator.services.mozilla.com/D233111
 2025-01-09 22:20:59 +00:00
Punam Dahiya
cf58fbd5e3 Bug 1618001 - Move React vendored libraries to the toolkit to prevent multiple instances r=sylvestre,omc-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,firefox-ai-ml-reviewers,aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D232431
 2025-01-08 21:08:16 +00:00
Punam Dahiya
750029ed7c Bug 1899027 - Move asrouter tests from newtab to asrouter r=home-newtab-reviewers,omc-reviewers,mconley,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D233024
 2025-01-08 17:37:31 +00:00
Meg Viar
81a9ec1500 Bug 1937625 - Strengthen embedded browser element flags in Messaging System r=omc-reviewers,nalexander,nika,negin 
Enhancements for the embedded browser component in AboutWelcome:

- Improve the speed at which the browser starts by predicting the `remoteType` the load is going to finish in
- Set `maychangeremoteness` attribute to true to allow changing remoteness if user navigates to a different URL that requires this (such as an `about:` page, though with the current set up `about:` pages won't load for security reasons).
- Set `nodefaultsrc` attribute to true to avoid loading a default URL if `src` is blank

Differential Revision: https://phabricator.services.mozilla.com/D232425
 2025-01-08 00:14:40 +00:00
hanna.alemu
8670cfe616 Bug 1927369 - [FxMS Docs] Add aboutwelcome and asrouter build steps in source docs r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D232851
 2024-12-30 14:26:02 +00:00
Meg Viar
d7704cbe37 Bug 1937599 - Address ASRouter console error on first startup due to this._storage being null r=omc-reviewers,pdahiya 
- Wait for ASRouter to be initialized before recording screen impressions to ensure the impression for the first screen in `about:welcome` isn't lost because ASRouter's `_storage` variable is still null

- Local testing shows that this first screen impression is lost when an attempt is made to record it before ASRouter is initialized. It's unclear if this is an issue on production, or just when running locally. Locally the issue occurs consistently, but this can't be the case on production as telemetry includes impressions from the first screen of `about:welcome`. However, we should monitor telemetry for possible changes after this fix goes out to see if there is an increase in screen impressions for the first screen of about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D232736
 2024-12-20 21:16:28 +00:00
Emily McMinn
c52497660c Bug 1923722 - Add fakespot opt-out survey strings for translation && move survey callout into code r=omc-reviewers,aminomancer,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D232540
 2024-12-20 16:10:00 +00:00
Mike Conley
4647ce1c30 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya 
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
 2024-12-20 16:07:56 +00:00
Goloman Adrian
1683c8c8b5 Backed out 4 changesets (bug 1937234) for causing newtab failures @asrouter. CLOSED TREE 
Backed out changeset 3fd6a002577a (bug 1937234)
Backed out changeset 6ab7c2107849 (bug 1937234)
Backed out changeset baa639909c0e (bug 1937234)
Backed out changeset 77e5bd035f08 (bug 1937234)
 2024-12-19 19:46:38 +02:00
Mark Banner
d0718e3c69 Bug 1937739. r=frontend-codestyle-reviewers,perftest-reviewers,mossop,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D232598
 2024-12-19 17:05:08 +00:00
Mike Conley
f391c2f6b4 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya 
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
 2024-12-19 16:43:39 +00:00
Emilio Cobos Álvarez
becf088418 Bug 1929400 - Don't use :has() to hide BookmarksBarButton message. r=aminomancer,desktop-theme-reviewers,omc-reviewers,dao 
This is faster, no point in making customize mode slower for something
that almost never shows up anyways.

Differential Revision: https://phabricator.services.mozilla.com/D228104
 2024-12-19 14:32:52 +00:00
Stanca Serban
b21fd0feda Backed out 4 changesets (bug 1937234) for causing newtab failures. 
Backed out changeset 9c4ec733448e (bug 1937234)
Backed out changeset 05d3d5a45230 (bug 1937234)
Backed out changeset 27877e1ab900 (bug 1937234)
Backed out changeset d56b2c3bfd0e (bug 1937234)
 2024-12-19 03:55:28 +02:00