corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
812,233 Commits 1 Branch 0 Tags
ca85c591b98fe1e30b15c2035ab93dbe4db2d79c
Commit Graph

310 Commits

Author SHA1 Message Date
jneuberger
5e86299d08 Bug 1863801 - P2. Add DOMFormRemoved event listener after successful fetch or XHR request r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D193308
 2023-12-06 14:55:01 +00:00
Issam Mani
03b2ed51e3 Bug 1864379 - P1. Don't dispatch LoginManager DOM events for disconnected input elements. r=dimi,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194768
 2023-12-04 11:39:19 +00:00
Noemi Erli
5cc944ee91 Backed out 7 changesets (bug 1863801, bug 1865876) for causing failures in browser_creditCard_doorhanger_iframe.js CLOSED TREE 
Backed out changeset 395e2da83ee8 (bug 1865876)
Backed out changeset c27de56bd433 (bug 1863801)
Backed out changeset 8d297207efc7 (bug 1863801)
Backed out changeset 193d5c08a17f (bug 1863801)
Backed out changeset dd78261ec1d8 (bug 1863801)
Backed out changeset 5f6ad20da89e (bug 1863801)
Backed out changeset 31e08bae4ce6 (bug 1863801)
 2023-12-01 22:16:15 +02:00
jneuberger
22a0fc66c2 Bug 1863801 - P2. Add DOMFormRemoved event listener after successful fetch or XHR request r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D193308
 2023-12-01 19:12:54 +00:00
Tooru Fujisawa
209a1f050c Bug 1864168 - Part 1: Use 1-origin column number in nsIContentSecurityPolicy. r=smaug,devtools-reviewers,ochameau,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D193369
 2023-11-22 12:31:30 +00:00
Natalia Csoregi
e0d56104a6 Backed out 14 changesets (bug 1865005, bug 1864168, bug 1864155, bug 1862814, bug 1862693) for causing bustage on nsRFPService.cpp. CLOSED TREE 
Backed out changeset a4f3e7625abf (bug 1865005)
Backed out changeset ab38141e470b (bug 1862814)
Backed out changeset a679b50dc4a9 (bug 1862814)
Backed out changeset e340886ce62a (bug 1862814)
Backed out changeset 1378502e64b0 (bug 1862814)
Backed out changeset 8ee94e5e79c2 (bug 1862814)
Backed out changeset 6d4ef1cdfabb (bug 1864168)
Backed out changeset 2c30c4d757fc (bug 1864168)
Backed out changeset d4db9576559b (bug 1864168)
Backed out changeset 8ffec0d83028 (bug 1864168)
Backed out changeset fa77d852b494 (bug 1864168)
Backed out changeset f6646771a26a (bug 1864168)
Backed out changeset 7bd0ff6986df (bug 1864155)
Backed out changeset 39867b503289 (bug 1862693)
 2023-11-22 14:01:55 +02:00
Tooru Fujisawa
676bd2ea73 Bug 1864168 - Part 1: Use 1-origin column number in nsIContentSecurityPolicy. r=smaug,devtools-reviewers,ochameau,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D193369
 2023-11-22 11:13:54 +00:00
Vincent Hilla
5fa2e02f27 Bug 1648733 - Report invalid and hidden form controls to console. r=dom-core,jjaschke 
Differential Revision: https://phabricator.services.mozilla.com/D189459
 2023-10-30 11:48:49 +00:00
Adam Vandolder
a1cf2d6b5d Bug 1685926 - Group disconnected radio buttons together. r=saschanaz,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D162349
 2023-09-28 15:47:11 +00:00
Natalia Csoregi
51f7d1bb14 Backed out changeset 8f8492410799 (bug 1685926) for causing bustage on SVGAnimatedPathSegList.cpp. CLOSED TREE 2023-09-28 10:40:31 +03:00
Adam Vandolder
aee8834b7a Bug 1685926 - Group disconnected radio buttons together. r=saschanaz,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D162349
 2023-09-28 06:35:44 +00:00
Cristian Tuns
f84b646496 Backed out changeset 37ade77d181e (bug 1685926) for causing build bustages in PerformanceEventTiming.cpp CLOSED TREE 2023-09-25 12:40:22 -04:00
Adam Vandolder
305c6a88bf Bug 1685926 - Group disconnected radio buttons together. r=saschanaz,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D162349
 2023-09-25 14:39:08 +00:00
Vincent Hilla
53f2c918c1 Bug 1066940 - Align return type of HTMLFormElement::elements with spec. r=dom-core,webidl,peterv 
Differential Revision: https://phabricator.services.mozilla.com/D188246
 2023-09-14 16:37:14 +00:00
Emilio Cobos Álvarez
72f00fc947 Bug 1850293 - Make validity states non-intrinsic. r=smaug 
Add a RAII helper to notify of multiple state changes together for
these.

The UpdateState CustomElementInternals calls that are getting removed
are unnecessary (the state should be up-to-date by then, there's nothing
changing there particularly).

Same for the call in nsGenericHTMLFormElement::UnbindFromTree. ClearForm
already does an state update.

Differential Revision: https://phabricator.services.mozilla.com/D187033
 2023-08-30 09:18:32 +00:00
Emilio Cobos Álvarez
76e9b5e83c Bug 1850293 - Make CHECKED/DEFAULT states not intrinsic. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D186933
 2023-08-30 09:18:31 +00:00
Markus Stange
a4e2816d54 Bug 1843484 - Use EventTarget* instead of nsISupports* for the event target parameter of the EventDispatcher::Dispatch methods. r=smaug 
This saves a few QueryInterface calls on the hot path.

Differential Revision: https://phabricator.services.mozilla.com/D186977
 2023-08-28 23:38:43 +00:00
avandolder
8898fd2eec Bug 1837540 - Make radio button group navigation follow tree-order. r=sefeng,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D183426
 2023-08-03 01:52:19 +00:00
Narcis Beleuzu
ed85f561c2 Backed out changeset 013278adabc7 (bug 1837540) for build bustages on mochitest.ini . CLOSED TREE 2023-08-03 02:25:53 +03:00
avandolder
9d805ab56a Bug 1837540 - Make radio button group navigation follow tree-order. r=sefeng,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D183426
 2023-08-02 23:04:07 +00:00
Peter Van der Beken
9ec5838ef5 Bug 1843968 - Hold some strong references. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D184803
 2023-08-01 12:09:36 +00:00
Vincent Hilla
ba2163ab57 Bug 1820403 - Skip parts of form submission when the method is dialog. r=dom-core,sefeng 
https://github.com/whatwg/html/pull/8943 moved dialog submission in the form submission algorithm from step 24 to step 11.

Differential Revision: https://phabricator.services.mozilla.com/D183168
 2023-07-18 13:00:27 +00:00
Gregory Pappas
853e673a0f Bug 1842974 - Remove dom.dialog_element.enabled pref r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D183711
 2023-07-17 10:02:53 +00:00
Emilio Cobos Álvarez
529c9ee321 Bug 1839922 - Remove usage of {Has,Get}Attr(kNameSpaceID_None, ..). r=edgar 
We have more readable and faster versions (that just omit the namespace
arg).

Mostly done via sed, with a couple helpers to use the faster lookups
where possible.

Differential Revision: https://phabricator.services.mozilla.com/D181795
 2023-06-23 10:01:32 +00:00
Peter Van der Beken
06b0782ce5 Bug 1825745 - Fix intermittent failure of testing/web-platform/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D181792
 2023-06-22 18:32:21 +00:00
june wilde
69995f692b Bug 1550743 - Change DoSecureToInsecureSubmitCheck to use IsSecureContext; r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D176319
 2023-06-06 15:04:41 +00:00
Masayuki Nakano
68d5732829 Bug 1829570 - part 2: Add an overload of AsyncEventDispatcher::RunDOMEventWhenSafe r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D176488
 2023-05-15 01:07:29 +00:00
Adam Vandolder
ef24860971 Bug 1653625 - Make the submission from default action of a submit button also deferred. r=edgar 
The submission from requestSubmit() call is non-deferred due to
mDeferSubmission
being cleared in HTMLFormElement::PostHandleEvent when handling a submit
event. The
mDeferSubmission clearing is also to make the submission from the default
action
of a submit button non-deferred.

This patch makes the submission from default action of a submit button
deferred
which could fix this bug, and also simplify the logic a bit.

Since gecko would also trigger submission for untrusted submit event,
see
bug 1370630, we need to handle that case specially.

Differential Revision: https://phabricator.services.mozilla.com/D170941
 2023-05-12 23:11:28 +00:00
Emilio Cobos Álvarez
c1c1e7460b Bug 1829225 - Make BeforeSetAttr take the parsed nsAttrValue. r=smaug 
ParseAttribute ideally would be const (see bug 1829138), but the SVG and
SMIL code is rather messy. Still, now that BeforeSetAttr can't really
fail, swapping the order of ParseAttribute and BeforeSetAttr shouldn't
really change behavior.

Sorry for the extra `virtual` keyword removal and such. I had to do this
one by hand unlike the dependent bugs, and I went a bit drive-by, lmk if
you want me to split those changes.

Differential Revision: https://phabricator.services.mozilla.com/D176086
 2023-04-21 09:25:17 +00:00
Emilio Cobos Álvarez
c881eb2941 Bug 1829189 - Make BeforeSetAttr infallible. r=smaug 
rg BeforeSetAttr -l | xargs sed -i 's/nsresult BeforeSetAttr/void BeforeSetAttr/g'
  rg ::BeforeSetAttr -l | xargs sed -i 's/nsresult \(.*\)::BeforeSetAttr/void \1::BeforeSetAttr/g'

Plus trivial fixes, plus clang-format.

The only meaningful changes are in nsXULElement::BeforeSetAttr. Two
things could fail:

chromemargin: I removed it because we don't use the parsed attribute any
other place than here:

  https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/dom/xul/ChromeObserver.cpp#136

And that deals just fine with it not being parsed.

usercontextid: We have a debug assertion that we don't dynamically change it.
I kept it but I don't think it's worth failing to set the attribute on release for that

Differential Revision: https://phabricator.services.mozilla.com/D176069
 2023-04-21 08:56:27 +00:00
Jon Jensen
ceb72d47c4 Bug 1812696 - Implement FormData constructor submitter parameter r=webidl,smaug 
Also improve error messages for current submitter validations

Spec PR: https://github.com/whatwg/xhr/pull/366
WPT PR: https://github.com/web-platform-tests/wpt/pull/37895

Differential Revision: https://phabricator.services.mozilla.com/D167576
 2023-02-02 12:26:50 +00:00
Adam Vandolder
bf597b83c9 Bug 1509346 - Add support for <form rel>. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D166489
 2023-01-18 16:41:04 +00:00
Butkovits Atila
d84b895e9a Backed out changeset 704407d7ca31 (bug 1509346) for causing wpt failures at put-forwards.html. 2023-01-17 20:04:52 +02:00
Adam Vandolder
65a2df9059 Bug 1509346 - Add support for <form rel>. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D166489
 2023-01-17 16:11:06 +00:00
Sandor Molnar
d53ceaad55 Backed out changeset 5ad22146a015 (bug 1509346) for causing failures in docshell/base/nsDocShell.cpp 2023-01-17 03:16:20 +02:00
Adam Vandolder
4d4a650750 Bug 1509346 - Add support for <form rel>. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D166489
 2023-01-16 21:32:19 +00:00
Mark Banner
20f659895e Bug 1808115 - Remove the separate EmbedPrompter wrapper, use Prompter instead. r=Gijs,necko-reviewers,geckoview-reviewers,valentin,m_kato 
We no longer support the legacy add-ons, so this should not be necessary.

Differential Revision: https://phabricator.services.mozilla.com/D165764
 2023-01-03 17:19:48 +00:00
Edgar Chen
d9ba03546e Bug 1793075 - Part 2: Do not clear pending submission in HTMLFormElement.submit(); r=smaug 
So if the submit call doesn't trigger a submission, it won't clear the existing
pending submission.

Now we allow to override the unflushed pending submission, and add some assertion to
ensure form won't submit a submission if it is in defer state or there is an
unflushed pending submission.

Differential Revision: https://phabricator.services.mozilla.com/D121765
 2022-10-05 12:24:28 +00:00
Emilio Cobos Álvarez
1c58e2a928 Bug 1773070 - Unify Gecko and Servo EventState/ElementState bits. r=smaug 
Add a dom/base/rust crate called just "dom" where we can share these.

Most of the changes are automatic:

  s/mozilla::EventStates/mozilla::dom::ElementState/
  s/EventStates/ElementState/
  s/NS_EVENT_STATE_/ElementState::/
  s/NS_DOCUMENT_STATE_/DocumentState::/

And so on. This requires a new cbindgen version to avoid ugly casts for
large shifts.

Differential Revision: https://phabricator.services.mozilla.com/D148537
 2022-06-07 23:09:52 +00:00
Jan Varga
b93e399d5c Bug 1757575 - Fix non-unified-build bustage in dom/html/HTMLFormElement.cpp; r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D139947
 2022-03-01 17:39:18 +00:00
Kagami Sascha Rosylight
95253f2665 Bug 1743439 - Part 5: Mark callers in dom/events and dom/html as MOZ_CAN_RUN_SCRIPT_BOUNDARY r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D133364
 2021-12-09 19:56:09 +00:00
Alexandru Michis
b3616631ef Backed out 6 changesets (bug 1743439) for causing bustages in AnimationEventDispatcher.h 
CLOSED TREE

Backed out changeset 792c405d4afc (bug 1743439)
Backed out changeset 0376e73c7dce (bug 1743439)
Backed out changeset 23202094bc00 (bug 1743439)
Backed out changeset ba0fa3a8fa0e (bug 1743439)
Backed out changeset 7ad2746ec876 (bug 1743439)
Backed out changeset a919ef50cf33 (bug 1743439)
 2021-12-09 19:36:12 +02:00
Kagami Sascha Rosylight
1da93efca6 Bug 1743439 - Part 5: Mark callers in dom/events and dom/html as MOZ_CAN_RUN_SCRIPT_BOUNDARY r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D133364
 2021-12-09 17:16:50 +00:00
Edgar Chen
5fad53737d Bug 1742714 - Get rid of nsIFormSubmitObserver; r=geckoview-reviewers,agi,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D132091
 2021-12-06 12:23:08 +00:00
Edgar Chen
230d1b0afe Bug 1556367 - Part 2: Factor dispatching invalid event code into a common place; r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D130274
 2021-12-03 15:47:34 +00:00
Emilio Cobos Álvarez
1d054196f6 Bug 1740230 - Remove some prefs for pseudo-classes that we have shipped/unshipped successfully. r=dholbert 
And remove code for :-moz-submit-invalid completely.

Differential Revision: https://phabricator.services.mozilla.com/D130737
 2021-11-10 13:27:47 +00:00
Edgar Chen
635069f699 Bug 1556363 - Part 1: Check disabled state for submission in a common place; r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D129048
 2021-10-25 20:43:10 +00:00
Edgar Chen
4929cc1a94 Bug 1556351 - Part 5: Make nsGenericHTMLFormControlElement implement nsIFormControl; r=smaug 
nsGenericHTMLFormElement doesn't implement nsIFormControl now as HTMLElement would
inherit it to be able to be added into HTMLFormElement and HTMLFieldSetElement and
support some common form feature.

So some places that call the nsIFormControl method on nsGenericHTMLFormElement
directly would need to queryInterface it to nsIFormControl first, this should be
fine as those places are not in a hot path.

Differential Revision: https://phabricator.services.mozilla.com/D124788
 2021-10-04 20:51:27 +00:00
Edgar Chen
71042191bf Bug 1729008 - Part 2: Make HTMLFormElement::IsLastActiveElement take nsGenericHTMLFormElement as argument; r=smaug 
Depends on D124459

Differential Revision: https://phabricator.services.mozilla.com/D124462
 2021-09-03 17:21:44 +00:00
Edgar Chen
2f052986f8 Bug 1729008 - Part 1: Make HTMLFormElement::IsDefaultSubmitElement take nsGenericHTMLFormElement as argument; r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D124459
 2021-09-03 17:21:44 +00:00