Commit Graph

483 Commits

Author SHA1 Message Date
Gijs Kruitbosch
5b2838553e Bug 1595925 - QI to nsIWebNavigation before using docShell.document, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D53661
2019-11-18 17:59:36 +00:00
Kirk Steuber
99c74c9f2d Bug 1588142 - Prevent internal pages from flashing the URL on reload r=Gijs
Converting about:preferences's root from a xul:window to an html:html involves moving the Fluent-translated title attribute to a title tag, which starts empty and is populated by Fluent. The initially-empty title tag causes the title bar to flash "about:preferences" on reload.

This patch ignores empty title updates via DOMTitleChanged events to prevent this. This is only done for internal pages (i.e. pages with a system principal).

Differential Revision: https://phabricator.services.mozilla.com/D52289
2019-11-14 00:17:52 +00:00
Csoregi Natalia
5bbfe75ef4 Backed out 4 changesets (bug 1588142) for failures on browser_canvasframe_helper_02.js. CLOSED TREE
Backed out changeset 2284a535c8bc (bug 1588142)
Backed out changeset 939b6b3922c2 (bug 1588142)
Backed out changeset 1a5f2b044f82 (bug 1588142)
Backed out changeset 87336cc7f8a1 (bug 1588142)
2019-11-14 00:18:21 +02:00
Kirk Steuber
cd922b0857 Bug 1588142 - Prevent internal pages from flashing the URL on reload r=Gijs
Converting about:preferences's root from a xul:window to an html:html involves moving the Fluent-translated title attribute to a title tag, which starts empty and is populated by Fluent. The initially-empty title tag causes the title bar to flash "about:preferences" on reload.

This patch ignores empty title updates via DOMTitleChanged events to prevent this. This is only done for internal pages (i.e. pages with a system principal).

Differential Revision: https://phabricator.services.mozilla.com/D52289
2019-11-12 18:01:01 +00:00
Gijs Kruitbosch
b481878e9d Bug 1594457 - fix DOMTitleChanged handling for reloads, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D52022
2019-11-12 17:29:14 +00:00
Brendan Dahl
18265e3b1e Bug 1492582 - Support the <body> element being the default focus node in browser.xhtml r=Gijs
Previously we were returning the documentElement in order to match the old XUL behavior.
Now that we have a document.body we can just follow the normal HTML convention.

Differential Revision: https://phabricator.services.mozilla.com/D34021
2019-11-08 23:33:52 +00:00
Brendan Dahl
938e113e52 Bug 1492582 - Use document.title instead of writing the title attribute on the document element r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33561
2019-11-08 23:33:50 +00:00
Gijs Kruitbosch
ff3b38a74d Bug 1594472 - do less work for same-document navigations, r=MattN,mconley
Updating tab
- mute state
- audio playing indicator state
- find bar state
- tab titles
- icons

is not necessary when the navigation is same-document. Avoid doing the work.

Differential Revision: https://phabricator.services.mozilla.com/D52109
2019-11-07 21:02:26 +00:00
Noemi Erli
aa45dd3a98 Backed out 7 changesets (bug 1492582) for causing ss mochitest failures CLOSED TREE
Backed out changeset 1484255e5f4d (bug 1492582)
Backed out changeset bbf62ef50e52 (bug 1492582)
Backed out changeset 836724d3860e (bug 1492582)
Backed out changeset 5efddfd196b5 (bug 1492582)
Backed out changeset d4be1aa8cdb6 (bug 1492582)
Backed out changeset f05dfbeff17b (bug 1492582)
Backed out changeset e0e56a195659 (bug 1492582)
2019-11-07 21:51:46 +02:00
Brendan Dahl
0dddf0155e Bug 1492582 - Support the <body> element being the default focus node in browser.xhtml r=Gijs
Previously we were returning the documentElement in order to match the old XUL behavior.
Now that we have a document.body we can just follow the normal HTML convention.

Differential Revision: https://phabricator.services.mozilla.com/D34021
2019-11-07 16:21:09 +00:00
Brendan Dahl
7fe67e2699 Bug 1492582 - Use document.title instead of writing the title attribute on the document element r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33561
2019-11-07 16:21:02 +00:00
Gijs Kruitbosch
329935c405 Bug 1591183 - fix tabbrowser's expectations about state_start with documentchannel and add a test, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D51081
2019-10-30 19:10:21 +00:00
Gijs Kruitbosch
07ce706b62 Bug 1585732 - cache fission.rebuild_frameloaders_on_remoteness_change pref instead of refetching it, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D50956
2019-10-29 23:33:54 +00:00
Brian Grinstead
66142236d7 Bug 1592054 - Initialize tabbrowser-tab contents before appending it into the DOM r=dao
This prevents a brief flash of unstyled tab content that can be noticed especially
in debug builds.

What happens currently is that we first append child content into the tab
upon connection, then we do attribute inheritance which sets the relevant
styling properties.

With this change we first set up the child content and attributes _before_ appending
the tab into the DOM, so that it's ready to render after being appended.

Differential Revision: https://phabricator.services.mozilla.com/D50837
2019-10-29 17:23:29 +00:00
Dão Gottwald
12486e7adf Bug 1586351 - Cache retained results in the view temporarily to prevent results from flickering when MegaBar reopens. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48818
2019-10-15 16:05:05 +00:00
Matt Woodrow
d90755519d Bug 1578624 - P11: Add a flag to ask the parent to not actually load the URI when opening a window, since we'll do it ourselves anyway. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D47867
2019-10-11 01:56:35 +00:00
Brindusan Cristian
170d6fb93f Backed out 11 changesets (bug 1578624) for build bustages. CLOSED TREE
Backed out changeset b22733eb880f (bug 1578624)
Backed out changeset cb5e15489635 (bug 1578624)
Backed out changeset f1746b2f9dec (bug 1578624)
Backed out changeset d08a099a22ff (bug 1578624)
Backed out changeset 8ebd563c72a8 (bug 1578624)
Backed out changeset d8bfec2dc9b6 (bug 1578624)
Backed out changeset 591664928bce (bug 1578624)
Backed out changeset 63f5a619b9ef (bug 1578624)
Backed out changeset ff67cc13cdf3 (bug 1578624)
Backed out changeset 43556c937a09 (bug 1578624)
Backed out changeset 49065a55694d (bug 1578624)
2019-10-09 11:50:37 +03:00
Matt Woodrow
74519473ee Bug 1578624 - P11: Add a flag to ask the parent to not actually load the URI when opening a window, since we'll do it ourselves anyway. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D47867
2019-10-09 07:54:45 +00:00
Narcis Beleuzu
eab5ec4098 Backed out 11 changesets (bug 1578624) for bustages on WindowGlobalChild.h . CLOSED TREE
Backed out changeset 478897956ee0 (bug 1578624)
Backed out changeset ab9c09164df0 (bug 1578624)
Backed out changeset f461f10efa46 (bug 1578624)
Backed out changeset 9b958693a003 (bug 1578624)
Backed out changeset 3b8220a15051 (bug 1578624)
Backed out changeset 180407dc57a8 (bug 1578624)
Backed out changeset bb11892e2171 (bug 1578624)
Backed out changeset 4f5c28244290 (bug 1578624)
Backed out changeset 6c02bbe5c1c5 (bug 1578624)
Backed out changeset 1d762fdce921 (bug 1578624)
Backed out changeset 818bc6e20c7d (bug 1578624)
2019-10-09 08:52:25 +03:00
Matt Woodrow
35812a4c7a Bug 1578624 - P11: Add a flag to ask the parent to not actually load the URI when opening a window, since we'll do it ourselves anyway. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D47867
2019-10-03 23:15:19 +00:00
Nils Maier
b272722785 Bug 1296365 - Show extension name instead of URI in popup windows r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D45213
2019-09-26 04:13:27 +00:00
Neil Deakin
87ba7c3113 Bug 1553384, update findbar actors to inherit from JSWindowActor so that type ahead find works in out of process iframes, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D41226
2019-09-17 23:29:46 +00:00
Paul Zuehlcke
7f8797527c Bug 1577480 - Fixed hideTab webRTC sharing state check. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D45820
2019-09-17 15:00:49 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Kris Maglione
2a3f78dcc6 Bug 1542415: Part 4 - Always rebuild frameloaders on remoteness change in Fission windows. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D44738
2019-09-09 12:28:09 +00:00
Andreas Farre
bebc385f98 Bug 1563619 - Handle subframe crashes in BrowserParent::ActorDestroy. r=mconley,kmag,peterv
Differential Revision: https://phabricator.services.mozilla.com/D40937
2019-08-26 13:08:32 +00:00
Paul Zuehlcke
c271ff4da3 Bug 1574110 - Updated tabbrowser.js SitePermissions call to use principal. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D42321
2019-08-20 12:29:26 +00:00
Cameron McCormack
912c48931f Bug 1569060 - Add layout debugger command to dump process IDs. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D39437
2019-08-06 23:31:55 +00:00
Paul Zuehlcke
064380bb16 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428
2019-07-30 08:28:31 +00:00
Csoregi Natalia
16534798cd Backed out changeset 3855d35999dd (bug 630614) for causing failures on browser_ext_tabs_sharingState.js. CLOSED TREE 2019-07-29 14:32:05 +03:00
Paul Zuehlcke
2ba3aac2e1 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428
2019-07-29 08:37:55 +00:00
Abdoulaye Oumar Ly
273a130a29 Bug 1481055 - Improve the consistency of params of tab multiselection functions in gBrowser. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D36356
2019-07-22 17:16:40 +00:00
Narcis Beleuzu
e3abc25d8a Backed out changeset ff49c94ed1d2 (bug 1481055) for bc failures on browser_multiselect_tabs_using_keyboard.js . CLOSED TREE 2019-07-18 23:10:58 +03:00
Abdoulaye O. Ly
ecc6f87283 Bug 1481055 - Improve the consistency of params of tab multiselection functions in gBrowser. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D36356
2019-07-11 18:43:05 +00:00
James Teh
07affc570e Bug 1410757: Expose the info provided in the tool tip for the focused browser tab as the tab's accessible description. r=Gijs
The tool tip for a browser tab exposes information such as the process ids (on Nightly) and the container tab name.
It appears when a user mouses over the tab, but this isn't really accessible to screen reader users.
Ideally, we'd expose this information as the accessible description for all browser tabs.
However, doing this for all tabs and keeping it up to date is rather difficult and potentially expensive.
Instead, just expose this description for a tab when it gets focus; i.e. the user has to focus the tab bar to access it.

To enable this, XUL tab elements now fire an AriaFocus event on the ARIA focused tab when the ariaFocusedItem property is set.

Differential Revision: https://phabricator.services.mozilla.com/D38027
2019-07-15 11:21:15 +00:00
Dão Gottwald
d2894e5c84 Bug 1528605 - Remove UrlbarInput::closePopup in favor of UrlbarView::close. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D37550
2019-07-10 15:25:35 +00:00
Jonathan Kingston
32524b62e2 Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504
2019-07-08 16:37:45 +00:00
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
2019-07-05 09:48:57 +02:00
Andrew Swan
c124590602 Bug 1555060 Convert <tabs> to a custom element
The conversion for "regular" <tabs> elements is straightforward, most of
the work here is to support the tab strip (the <tabs> element with the id
"tabbrowser-tabs").  The markup needed for the tab strip moves directly
into browser.xhtml and the construction/teardown logic is now explicitly
driven from gBrowser.  There are many more little tweaks too numerous to
enumerate.

Differential Revision: https://phabricator.services.mozilla.com/D32855
2019-06-20 14:09:37 -07:00
Andrew Swan
a74f65b714 Bug 1555060 Stop using dom structure for <tabs>/<tab> relationships
A bunch of existing code assumes that <tab> elements are the immediate
and only children of a <tabs> element, and uses dom apis to traverse
relationships between these elements.  To simplify conversion of <tabs>
to a custom element (and hopefully improve readability a bit at the same
time!), introduce new apis:

On <tab>
this.parentNode -> this.container
this.nextElementSibling -> this.container.findNextTab(...)
this.previousElementSibiling -> this.container.findNextTab(...)

On <tabs>
this.children -> this.allTabs

Differential Revision: https://phabricator.services.mozilla.com/D34648
2019-06-11 14:49:46 -07:00
Ciure Andrei
360ee087a8 Backed out 3 changesets (bug 1555060) for causing test_tabbar.py to perma fail CLOSED TREE
Backed out changeset a5c6deeda8a9 (bug 1555060)
Backed out changeset f4e21e465f38 (bug 1555060)
Backed out changeset c71c45fe3e63 (bug 1555060)
2019-06-28 00:21:50 +03:00
Andrew Swan
c20b711ae1 Bug 1555060 Convert <tabs> to a custom element
The conversion for "regular" <tabs> elements is straightforward, most of
the work here is to support the tab strip (the <tabs> element with the id
"tabbrowser-tabs").  The markup needed for the tab strip moves directly
into browser.xhtml and the construction/teardown logic is now explicitly
driven from gBrowser.  There are many more little tweaks too numerous to
enumerate.

Differential Revision: https://phabricator.services.mozilla.com/D32855
2019-06-20 14:09:37 -07:00
Andrew Swan
795b5037d0 Bug 1555060 Stop using dom structure for <tabs>/<tab> relationships
A bunch of existing code assumes that <tab> elements are the immediate
and only children of a <tabs> element, and uses dom apis to traverse
relationships between these elements.  To simplify conversion of <tabs>
to a custom element (and hopefully improve readability a bit at the same
time!), introduce new apis:

On <tab>
this.parentNode -> this.container
this.nextElementSibling -> this.container.findNextTab(...)
this.previousElementSibiling -> this.container.findNextTab(...)

On <tabs>
this.children -> this.allTabs

Differential Revision: https://phabricator.services.mozilla.com/D34648
2019-06-11 14:49:46 -07:00
Geoff Lankow
902190d63a Bug 1529205 - Remove DateTimePickerParent's dependency on gBrowser; r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D35392
2019-06-26 18:15:28 +00:00
Nika Layzell
7920ede33c Bug 1559409 - Show subframe pids in tab hover text, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D35029
2019-06-14 15:42:39 +00:00
Dão Gottwald
db11d4d15e Bug 1559363 - Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D35280
2019-06-19 01:18:06 +00:00
Ehsan Akhgari
5f57b1b6e4 Bug 1557887 - Part 5: Pass a storage principal argument through the browser loadURI()/addTab() APIs; r=baku,mconley
Differential Revision: https://phabricator.services.mozilla.com/D34459
2019-06-12 23:05:36 +00:00
Gurzau Raul
ae3b8b1e09 Merge inbound to mozilla-central. a=merge 2019-06-12 00:34:32 +03:00
Neil Deakin
c1eb92539d Bug 1533948, change BrowserTabChild to inherit from JSWindowActor, r=mconley 2019-06-11 09:05:33 -04:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196
2019-06-11 15:51:51 +00:00