Emilio Cobos Álvarez
69199d50b9
Bug 1678881 - Avoid some allocations in selector serialization. r=xidorn
...
The allocations in display_to_css_identifier show up in the profiles of
bug 1675628https://phabricator.services.mozilla.com/D97856
2020-11-22 01:02:22 +00:00
Emilio Cobos Álvarez
0d6306d00d
Bug 1646811 - Remove some unused extern crate declarations now that style is in rust 2018.
...
This avoids some warnings.
Depends on D80247
Differential Revision: https://phabricator.services.mozilla.com/D80248
2020-06-18 18:14:24 +00:00
Emilio Cobos Álvarez
8d384d9cb8
Bug 1646811 - servo: Remove the dependency on font-kit from style.
...
No good reason to have this IMO, and helps remove some #[cfg] blocks.
Depends on D80246
Differential Revision: https://phabricator.services.mozilla.com/D80247
2020-06-18 18:14:21 +00:00
Utsav Oza
362c198a29
Bug 1646811 - servo: Enable textAlign, textBaseline and direction attributes for canvas.
...
Depends on D80238
Differential Revision: https://phabricator.services.mozilla.com/D80239
2020-06-18 18:12:56 +00:00
Simon Sapin
738eb8f46b
Bug 1633410 - Back out bug 1631721.
...
Rebased and squashed.
Differential Revision: https://phabricator.services.mozilla.com/D78174
2020-06-18 15:25:33 +00:00
Dorel Luca
0e71203f06
Backed out changeset bde27b38c9c5 (bug 1643201) for causing Valgrind failures and build bustages
2020-06-04 05:17:11 +03:00
Emilio Cobos Álvarez
54a9e01014
Bug 1643201 - Cherry-pick servo changes to use the matches macro from the standard library.
...
Depends on D78201
Differential Revision: https://phabricator.services.mozilla.com/D78202
2020-06-04 00:35:22 +00:00
Martin Robinson
8bf2322ba1
Bug 1643201 - servo: Start having animations conform to the HTML spec.
...
This is a small step toward fixing #19242 . The main idea is that the
clock for animations should advance as the event loop ticks. We
accomplish this by moving the clock from layout and naming it the
"animation timeline" which is the spec language. This should fix
flakiness with animations and transitions tests where a reflow could
move animations forward while script was running.
This change also starts to break out transition and animation events
into their own data structure, because it's quite likely that the next
step in fixing #19242 is to no longer send these events through a
channel.
Depends on D78188
Differential Revision: https://phabricator.services.mozilla.com/D78189
2020-06-04 00:34:18 +00:00
Martin Robinson
0a86ef369c
Bug 1643201 - servo: Add ElementAnimationState and PossibleElementAnimationState.
...
This refactor is preparation for implementing a specification
compliant transitions and animations processing model.
These data structures hold all the animation information about a single
node. Since adding, updating, and modifying animations for a single node
are all interdependent, it makes sense to start encapsulating animation
data and functionality into a single data structure. This also opens up
the possibility for easier concurrency in the future by more easily
allowing per-node mutexes.
Differential Revision: https://phabricator.services.mozilla.com/D78184
2020-06-04 00:34:02 +00:00
Boris Chiou
5d90d2861f
Bug 1635939 - Let aspect-ratio (css-sizing-4) support 'auto | <ratio>'. r=emilio
...
In order to test its parsing and serialization, we expose it but protect
it behind a pref.
Besides, I would like to drop layout.css.aspect-ratio-number.enabled in
the next patch because the spec has been updated. It seems we don't have
to keep this pref and we should always use Number.
Differential Revision: https://phabricator.services.mozilla.com/D74955
2020-05-21 06:45:10 +00:00
Simon Sapin
9a6ce7d347
Bug 1631721 - Use hashbrown instead of hashglobe r=manishearth
...
Differential Revision: https://phabricator.services.mozilla.com/D71741
2020-04-23 00:19:51 +00:00
Emilio Cobos Álvarez
15055d662f
Bug 1614394 - Remove now unused dependency from the style system.
...
Differential Revision: https://phabricator.services.mozilla.com/D62308
2020-02-10 17:32:35 +00:00
Emilio Cobos Álvarez
bdf0e6893c
Bug 1614394 - Rustfmt recent changes.
...
Differential Revision: https://phabricator.services.mozilla.com/D62307
2020-02-10 17:32:27 +00:00
Emilio Cobos Álvarez
48eb20de60
Bug 1611912 - Add a style flag for the root element style. r=heycam
...
This is needed to make the root element not a containing block in presence of
filters or what not.
Differential Revision: https://phabricator.services.mozilla.com/D61167
2020-01-31 14:51:06 +00:00
Emilio Cobos Álvarez
aab1464a8a
Bug 1605803 - Use cbindgen for content property. r=xidorn
...
This cleans up and also allows us to keep the distinction between content: none
and content: normal, which allows us to fix the computed style we return from
getComputedStyle().
Do this last bit from the resolved value instead of StyleAdjuster, because
otherwise we need to tweak every initial struct for ::before / ::after.
Differential Revision: https://phabricator.services.mozilla.com/D58276
2020-01-05 13:10:39 +00:00
Boris Chiou
2382837326
Bug 1429305 - Use serde to serialize LengthPercentage and StyleRayFunction. r=emilio
...
We need to pass these two types into the compositor, so we need a better
way to serialize these rust types. We use serde and bincode to
serialize/deserialize them, and use ByteBuf to pass the &[u8] data
through IPC. We define StyleVecU8 for FFI usage only.
Differential Revision: https://phabricator.services.mozilla.com/D50688
2019-10-31 21:35:05 +00:00
Emilio Cobos Álvarez
11632d1702
Bug 1574148 - Fix Servo build and unify display representation.
...
Differential Revision: https://phabricator.services.mozilla.com/D42130
2019-08-15 13:31:44 +00:00
Nicholas Nethercote
85e194318f
Bug 1563555 - Use static_prefs::pref! in Stylo. r=emilio
...
It's much nicer.
One nice thing about this is that the new code is subject to the existing
threadedness checking, which identified that several of these should be atomic
because they're accessed off the main thread.
Differential Revision: https://phabricator.services.mozilla.com/D40792
2019-08-07 22:58:55 +00:00
Cosmin Sabou
4a5cc732bb
Backed out 2 changesets (bug 1563555) for causing marionette failures on test_profile_management.py.
...
Backed out changeset 2559f5ddf8e0 (bug 1563555)
Backed out changeset e3c86ffa168c (bug 1563555)
2019-08-07 12:09:13 +03:00
Nicholas Nethercote
89e2a446f9
Bug 1563555 - Use static_prefs::pref! in Stylo. r=emilio
...
It's much nicer.
One nice thing about this is that the new code is subject to the existing
threadedness checking, which identified that several of these should be atomic
because they're accessed off the main thread.
Differential Revision: https://phabricator.services.mozilla.com/D40792
2019-08-07 04:17:08 +00:00
Emilio Cobos Álvarez
849ae38693
Bug 1550554 - Use ArcSlice for quotes. r=heycam
...
This saves the intermediate allocation.
Differential Revision: https://phabricator.services.mozilla.com/D30546
2019-05-16 23:04:31 +00:00
Ciure Andrei
0cdc899d9a
Backed out 17 changesets (bug 1550554, bug 1549593, bug 1551991, bug 1529002) for failing multiple Android tests and Windows 2012 bustages CLOSED TREE
...
Backed out changeset 3bb3fafa62e2 (bug 1551991)
Backed out changeset e12a979de502 (bug 1551991)
Backed out changeset d81e4aa6bf0c (bug 1551991)
Backed out changeset c354e61f2a34 (bug 1551991)
Backed out changeset 37fd602bebc2 (bug 1551991)
Backed out changeset 6c1f00cc30ca (bug 1551991)
Backed out changeset 8a7a0329bdc3 (bug 1551991)
Backed out changeset 86159475ddd3 (bug 1551991)
Backed out changeset 35f91a9ea82a (bug 15290021529002
2019-05-16 13:17:10 +03:00
Emilio Cobos Álvarez
ac28947f0c
Bug 1550554 - Use ArcSlice for quotes. r=heycam
...
This saves the intermediate allocation.
Differential Revision: https://phabricator.services.mozilla.com/D30546
2019-05-16 16:24:24 +02:00
Emilio Cobos Álvarez
b01a00c1e1
Bug 1549559 - Introduce ArcSlice, a small wrapper over ThinArc but without an explicit header. r=heycam
...
We could make the header PhantomData or something, but then we wouldn't be able
to bind to C++, since C++ doesn't have ZSTs. So add a canary instead to add a
runtime check of stuff being sane.
Differential Revision: https://phabricator.services.mozilla.com/D30133
2019-05-09 10:53:50 +00:00
Emilio Cobos Álvarez
8e122feb73
Bug 1549593 - Move OwnedSlice to style_traits. r=heycam
...
Differential Revision: https://phabricator.services.mozilla.com/D30126
2019-05-09 10:49:50 +00:00
Emilio Cobos Álvarez
39689c5d90
Bug 1548691 - Add an owned slice type which cbindgen can understand. r=heycam
...
Passing these by value won't be ok of course, but that's fine.
I plan to combine this with https://github.com/eqrion/cbindgen/pull/333 to
actually be able to share representation for ~all the things, this is just the
first bit.
Box<T>, Atom and Arc<T> will be much easier since cbindgen can understand them
without issues.
It's boxed slices the only ones I should need something like this. I could avoid
it if I rely on Rust's internal representation, which we can per [1], but then I
need to teach cbindgen all about slices, which is generally hard, I think.
[1]: https://github.com/rust-lang/unsafe-code-guidelines/blob/master/reference/src/layout/pointers.md
Differential Revision: https://phabricator.services.mozilla.com/D29768
2019-05-09 10:49:22 +00:00
Cameron McCormack
325131e833
Bug 1474793 - Part 10.8: Add derived ToShmem implementations. r=emilio
...
Depends on D17196
Differential Revision: https://phabricator.services.mozilla.com/D17197
2019-03-30 00:16:25 +00:00
Cameron McCormack
3b635a549f
Bug 1474793 - Part 10.1: Add simple ToShmem implementations. r=emilio
...
Depends on D17189
Differential Revision: https://phabricator.services.mozilla.com/D17190
2019-03-30 00:16:11 +00:00
Cameron McCormack
91b23f0f08
Bug 1474793 - Part 9: Add support for deriving ToShmem. r=emilio
...
Depends on D17188
Differential Revision: https://phabricator.services.mozilla.com/D17189
2019-03-30 00:16:08 +00:00
Cameron McCormack
705612e9ff
Bug 1474793 - Part 7: Add SharedMemoryBuilder type and ToShmem trait. r=emilio
...
Depends on D17186
Differential Revision: https://phabricator.services.mozilla.com/D17187
2019-03-30 00:15:59 +00:00
Emilio Cobos Álvarez
e9ee979cdf
Bug 1530847 - Add a Zero trait that doesn't require Add, and use it in place of num_traits and IsZeroLength. r=heycam
...
Use it to be consistent in InsetRect serialization and storage between Servo and
Gecko.
Differential Revision: https://phabricator.services.mozilla.com/D21493
2019-02-28 19:03:03 +00:00
Emilio Cobos Álvarez
3bf6c13ee8
No bug - rustfmt recent changes.
2019-01-29 03:22:06 +01:00
Bobby Holley
8f09d23567
Bug 1521187 - Derive more. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D17029
2019-01-22 12:19:22 -08:00
Shanavas M
905bede2e0
Bug 1519269 - Remove OrderedMap in favor of IndexMap. r=emilio
...
This cherry-picks https://github.com/servo/servo/pull/22656 .
2019-01-11 01:02:54 +01:00
Cameron McCormack
131392dcb7
Bug 1500362 - Use atom handles in favour of atom pointers in style system code r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D15078
2019-01-07 07:54:46 +00:00
Emilio Cobos Álvarez
72c583fe74
Bug 1518045 - Make Servo use a single thread-pool for layout-related tasks per-process. r=jdm
...
Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478 ), and to share more code with
Gecko, which is always nice.
This cherry-picks https://github.com/servo/servo/pull/22487 , with a few minor
fixes to the build that are landing as part of the sync associated to this bug,
and an lsan exception tweak to point to the right module since it's moving.
2019-01-07 00:53:04 +01:00
Bastien Orivel
1031c1524d
Bug 1511811 - Update crossbeam-channel to 0.3.
...
Cherry-picks https://github.com/servo/servo/pull/22142
2018-12-03 08:48:15 -05:00
Emilio Cobos Álvarez
dea05cdada
Bug 1511811 - Use https for the MPL license URL.
...
Cherry-picks https://github.com/servo/servo/pull/22198
2018-12-03 08:43:48 -05:00
shindli
3a4462fafb
Backed out 13 changesets (bug 1511811) for Btup bustages
...
Backed out changeset d71cde918f43 (bug 1511811)
Backed out changeset 0ae2634de8e1 (bug 1511811)
Backed out changeset 53d1f5ca4099 (bug 1511811)
Backed out changeset 5a08148928ef (bug 1511811)
Backed out changeset da7816ec50ef (bug 1511811)
Backed out changeset 5fe23889cccc (bug 1511811)
Backed out changeset 800bc60c75a7 (bug 1511811)
Backed out changeset 2392d8199cd0 (bug 1511811)
Backed out changeset 7bc486fbd195 (bug 1511811)
Backed out changeset d2c997426108 (bug 1511811)
Backed out changeset ddd573878432 (bug 1511811)
Backed out changeset 29c8ec1559a4 (bug 1511811)
Backed out changeset f5851346109d (bug 1511811)
2018-12-03 15:39:11 +02:00
Bastien Orivel
fdd2b560d3
Bug 1511811 - Update crossbeam-channel to 0.3.
...
Cherry-picks https://github.com/servo/servo/pull/22142
2018-12-03 08:15:26 -05:00
Emilio Cobos Álvarez
11a665046f
Bug 1511811 - Use https for the MPL license URL.
...
Cherry-picks https://github.com/servo/servo/pull/22198
2018-12-03 08:15:21 -05:00
Simon Sapin
4fde18b0de
Bug 1506391 - cargo fix --edition --features gecko. r=emilio
2018-11-11 02:40:24 +01:00
Simon Sapin
8796faa7aa
Bug 1506391 - cargo fix --edition. r=emilio
2018-11-11 02:40:21 +01:00
Brindusan Cristian
d311f835d2
Backed out 7 changesets (bug 1506391) for Btup bustages.
...
Backed out changeset b8216171101c (bug 1506391)
Backed out changeset 03d2309b737d (bug 1506391)
Backed out changeset 7b63f3149852 (bug 1506391)
Backed out changeset be88680421db (bug 1506391)
Backed out changeset 3840ce1ebfb0 (bug 1506391)
Backed out changeset 94517e21621c (bug 1506391)
Backed out changeset 32bde6f52a32 (bug 1506391)
2018-11-11 01:08:20 +02:00
Simon Sapin
bbea913aba
Bug 1506391 - cargo fix --edition --features gecko. r=emilio
2018-11-10 21:14:15 +01:00
Simon Sapin
daedee00db
Bug 1506391 - cargo fix --edition. r=emilio
2018-11-10 21:14:05 +01:00
Emilio Cobos Álvarez
bfdad1b339
Bug 1505565 - Split up push_applicable_declarations. r=heycam
...
Introduce RuleCollector, which contains all the state we need during the
cascade, and allows to reuse a bit of code.
Differential Revision: https://phabricator.services.mozilla.com/D11233
2018-11-08 23:07:40 +00:00
Emilio Cobos Álvarez
87231dd9d5
Bug 1505618 - Import formatting changes from servo/servo#22126 .
2018-11-08 00:50:12 +01:00
Simon Sapin
33af936975
Bug 1491577 - Replace mpsc with crossbeam/servo channel, update ipc-channel. r=emilio
...
This cherry-picks servo/servo#21325 .
Co-authored-by: Gregory Terzian <gterzian@users.noreply.github.com >
2018-09-15 19:24:23 +02:00
chansuke
135da1df90
Bug 1489862 - Format style component. r=emilio
...
This cherry-picks servo/servo#21652 .
2018-09-09 17:03:19 +02:00
